fix: destructuring with computed-property (#19530)

lib/javascript/JavascriptParser.js

@@ -2863,7 +2863,7 @@ class JavascriptParser extends Parser {
 				}
 			}
 			const key = property.key;
-			if (key.type === "Identifier") {
+			if (key.type === "Identifier" && !property.computed) {
 				props.add({
 					id: key.name,
 					range: key.range,

test/configCases/parsing/destructuring-computed-property/index.js

@@ -0,0 +1,18 @@
+import * as namespace from "../destructuring-namespace-import/module";
+
+it("should work with destructuring", function() {
+	const key = "fo" + "o";
+	const {
+		[key]: a = "foo",
+		["fo" + "o"]: a1 = "foo",
+		[PROPERTY]: a2 = "foo",
+		["unkn" + "own"]: unknown = "foo",
+		unknown1 = "foo",
+	} = namespace;
+
+	expect(a).toBe("bar");
+	expect(a1).toBe("bar");
+	expect(a2).toBe("bar");
+	expect(unknown).toBe("foo");
+	expect(unknown1).toBe("foo");
+});

test/configCases/parsing/destructuring-computed-property/module.js

@@ -0,0 +1 @@
+export const foo = 'bar';

test/configCases/parsing/destructuring-computed-property/webpack.config.js

@@ -0,0 +1,13 @@
+const webpack = require("../../../../");
+
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	optimization: {
+		concatenateModules: true
+	},
+	plugins: [
+		new webpack.DefinePlugin({
+			PROPERTY: JSON.stringify("foo")
+		})
+	]
+};

test/configCases/parsing/destructuring-rest/index.js

@@ -0,0 +1,8 @@
+import * as namespace from "../destructuring-namespace-import/module";
+
+it("should work with destructuring", function() {
+	const key = "fo" + "o";
+	const { ...rest } = namespace;
+
+	expect(rest[key]).toBe("bar");
+});

test/configCases/parsing/destructuring-rest/module.js

@@ -0,0 +1 @@
+export const foo = 'bar';

test/configCases/parsing/destructuring-rest/webpack.config.js

@@ -0,0 +1,6 @@
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	optimization: {
+		concatenateModules: true
+	}
+};