From 7cc9605ea3ffb4310ae58524550b0f387ab0fc98 Mon Sep 17 00:00:00 2001 From: Tobias Koppers Date: Tue, 15 May 2018 10:11:57 +0200 Subject: [PATCH] Improve pull request template and add automatic issue to docs --- .github/PULL_REQUEST_TEMPLATE.md | 19 ++++++------- open-bot.yaml | 47 ++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7af602ab9..998368de9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,9 @@ + + + + + **What kind of change does this PR introduce?** @@ -8,17 +13,11 @@ -**If relevant, link to documentation update:** - - - -**Summary** - - - - **Does this PR introduce a breaking change?** -**Other information** +**What need to be documented once your changes are merged?** + + + diff --git a/open-bot.yaml b/open-bot.yaml index 46f693cba..5721f82db 100644 --- a/open-bot.yaml +++ b/open-bot.yaml @@ -517,6 +517,53 @@ rules: If you think this is still a valid issue, please file a new issue with additional information. +# Add action actions box to each pull request +- filters: + pull_request: true + open: true + not: + comment: + matching: admin-actions + author: webpack-bot + actions: + comment: + identifier: admin-actions + message: |- + *For maintainers only:* + + * [x] This need to be documented (issue in webpack/webpack.js.org will be filed when merged) + + +# When a pull request need to be documented, create an issue in webpack/webpack.js.org when merged +- filters: + pull_request: + merged: true + comment: + author: webpack-bot + matching: "\\* \\[x\\] " + not: + comment_1: + author: webpack-bot + matching: admin-action-document-executed + actions: + new_issue: + target: webpack/webpack.js.org + title: "Document webpack change: {{{pull_request.title}}}" + body: |- + + + *A pull request by @{{pull_request.user.login}} was merged and maintainers requested a documentation change.* + + See pull request: {{{pull_request.html_url}}} + + --- + + {{{pull_request.body}}} + comment: + identifier: admin-action-document-executed + message: |- + I've created an issue to document this in webpack/webpack.js.org. +