root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4813 from JLHwung/perf/date-now 

Perf/use Date.now() instead of +new Date()/new Date().getTime()
This commit is contained in:
Tobias Koppers 2017-05-04 08:04:41 +02:00 committed by GitHub
parent c91ba49495 6afc397b99
commit 85dc98f17a
8 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/Compilation.js
View File

@ -201,7 +201,7 @@ class Compilation extends Tapable {
addModuleDependencies(module, dependencies, bail, cacheGroup, recursive, callback) { addModuleDependencies(module, dependencies, bail, cacheGroup, recursive, callback) {
let _this = this; let _this = this;
const start = _this.profile && +new Date(); const start = _this.profile && Date.now();
const factories = []; const factories = [];
for(let i = 0; i < dependencies.length; i++) { for(let i = 0; i < dependencies.length; i++) {
@ -270,7 +270,7 @@ class Compilation extends Tapable {
if(!dependentModule.profile) { if(!dependentModule.profile) {
dependentModule.profile = {}; dependentModule.profile = {};
} }
afterFactory = +new Date(); afterFactory = Date.now();
dependentModule.profile.factory = afterFactory - start; dependentModule.profile.factory = afterFactory - start;
} }
@ -290,7 +290,7 @@ class Compilation extends Tapable {
if(!module.profile) { if(!module.profile) {
module.profile = {}; module.profile = {};
} }
const time = +new Date() - start; const time = Date.now() - start;
if(!module.profile.dependencies || time > module.profile.dependencies) { if(!module.profile.dependencies || time > module.profile.dependencies) {
module.profile.dependencies = time; module.profile.dependencies = time;
} }
@ -311,7 +311,7 @@ class Compilation extends Tapable {
iterationDependencies(dependencies); iterationDependencies(dependencies);
if(_this.profile) { if(_this.profile) {
const afterBuilding = +new Date(); const afterBuilding = Date.now();
module.profile.building = afterBuilding - afterFactory; module.profile.building = afterBuilding - afterFactory;
} }
@ -332,7 +332,7 @@ class Compilation extends Tapable {
} }
if(_this.profile) { if(_this.profile) {
const afterBuilding = +new Date(); const afterBuilding = Date.now();
dependentModule.profile.building = afterBuilding - afterFactory; dependentModule.profile.building = afterBuilding - afterFactory;
} }
@ -360,7 +360,7 @@ class Compilation extends Tapable {
} }
_addModuleChain(context, dependency, onModule, callback) { _addModuleChain(context, dependency, onModule, callback) {
const start = this.profile && +new Date(); const start = this.profile && Date.now();
const errorAndCallback = this.bail ? function errorAndCallback(err) { const errorAndCallback = this.bail ? function errorAndCallback(err) {
callback(err); callback(err);
@ -397,7 +397,7 @@ class Compilation extends Tapable {
if(!module.profile) { if(!module.profile) {
module.profile = {}; module.profile = {};
} }
afterFactory = +new Date(); afterFactory = Date.now();
module.profile.factory = afterFactory - start; module.profile.factory = afterFactory - start;
} }
@ -408,7 +408,7 @@ class Compilation extends Tapable {
onModule(module); onModule(module);
if(this.profile) { if(this.profile) {
const afterBuilding = +new Date(); const afterBuilding = Date.now();
module.profile.building = afterBuilding - afterFactory; module.profile.building = afterBuilding - afterFactory;
} }
@ -436,7 +436,7 @@ class Compilation extends Tapable {
} }
if(this.profile) { if(this.profile) {
const afterBuilding = +new Date(); const afterBuilding = Date.now();
module.profile.building = afterBuilding - afterFactory; module.profile.building = afterBuilding - afterFactory;
} }

14
lib/Compiler.js
View File

@ -36,7 +36,7 @@ function Watching(compiler, watchOptions, handler) {
Watching.prototype._go = function() { Watching.prototype._go = function() {
var self = this; var self = this;
self.startTime = new Date().getTime(); self.startTime = Date.now();
self.running = true; self.running = true;
self.invalid = false; self.invalid = false;
self.compiler.applyPluginsAsync("watch-run", self, function(err) { self.compiler.applyPluginsAsync("watch-run", self, function(err) {
@ -61,7 +61,7 @@ Watching.prototype._go = function() {
var stats = new Stats(compilation); var stats = new Stats(compilation);
stats.startTime = self.startTime; stats.startTime = self.startTime;
stats.endTime = new Date().getTime(); stats.endTime = Date.now();
self.compiler.applyPlugins("done", stats); self.compiler.applyPlugins("done", stats);
self.compiler.applyPluginsAsync("additional-pass", function(err) { self.compiler.applyPluginsAsync("additional-pass", function(err) {
@ -80,7 +80,7 @@ Watching.prototype._go = function() {
Watching.prototype._getStats = function(compilation) { Watching.prototype._getStats = function(compilation) {
var stats = new Stats(compilation); var stats = new Stats(compilation);
stats.startTime = this.startTime; stats.startTime = this.startTime;
stats.endTime = new Date().getTime(); stats.endTime = Date.now();
return stats; return stats;
}; };
@ -222,7 +222,7 @@ Compiler.prototype.watch = function(watchOptions, handler) {
Compiler.prototype.run = function(callback) { Compiler.prototype.run = function(callback) {
var self = this; var self = this;
var startTime = new Date().getTime(); var startTime = Date.now();
self.applyPluginsAsync("before-run", self, function(err) { self.applyPluginsAsync("before-run", self, function(err) {
if(err) return callback(err); if(err) return callback(err);
@ -239,7 +239,7 @@ Compiler.prototype.run = function(callback) {
if(self.applyPluginsBailResult("should-emit", compilation) === false) { if(self.applyPluginsBailResult("should-emit", compilation) === false) {
var stats = new Stats(compilation); var stats = new Stats(compilation);
stats.startTime = startTime; stats.startTime = startTime;
stats.endTime = new Date().getTime(); stats.endTime = Date.now();
self.applyPlugins("done", stats); self.applyPlugins("done", stats);
return callback(null, stats); return callback(null, stats);
} }
@ -252,7 +252,7 @@ Compiler.prototype.run = function(callback) {
var stats = new Stats(compilation); var stats = new Stats(compilation);
stats.startTime = startTime; stats.startTime = startTime;
stats.endTime = new Date().getTime(); stats.endTime = Date.now();
self.applyPlugins("done", stats); self.applyPlugins("done", stats);
self.applyPluginsAsync("additional-pass", function(err) { self.applyPluginsAsync("additional-pass", function(err) {
@ -267,7 +267,7 @@ Compiler.prototype.run = function(callback) {
var stats = new Stats(compilation); var stats = new Stats(compilation);
stats.startTime = startTime; stats.startTime = startTime;
stats.endTime = new Date().getTime(); stats.endTime = Date.now();
self.applyPlugins("done", stats); self.applyPlugins("done", stats);
return callback(null, stats); return callback(null, stats);
}); });

2
lib/ContextModule.js
View File

@ -99,7 +99,7 @@ class ContextModule extends Module {
build(options, compilation, resolver, fs, callback) { build(options, compilation, resolver, fs, callback) {
this.built = true; this.built = true;
this.builtTime = new Date().getTime(); this.builtTime = Date.now();
this.resolveDependencies(fs, this.context, this.recursive, this.regExp, (err, dependencies) => { this.resolveDependencies(fs, this.context, this.recursive, this.regExp, (err, dependencies) => {
if(err) return callback(err); if(err) return callback(err);

2
lib/DelegatedModule.js
View File

@ -37,7 +37,7 @@ class DelegatedModule extends Module {
build(options, compilation, resolver, fs, callback) { build(options, compilation, resolver, fs, callback) {
this.built = true; this.built = true;
this.builtTime = new Date().getTime(); this.builtTime = Date.now();
this.usedExports = true; this.usedExports = true;
this.providedExports = this.delegateData.exports || true; this.providedExports = this.delegateData.exports || true;
this.dependencies.length = 0; this.dependencies.length = 0;

2
lib/ExternalModule.js
View File

@ -35,7 +35,7 @@ class ExternalModule extends Module {
} }
build(options, compilation, resolver, fs, callback) { build(options, compilation, resolver, fs, callback) {
this.builtTime = new Date().getTime(); this.builtTime = Date.now();
callback(); callback();
} }

2
lib/NormalModule.js
View File

@ -257,7 +257,7 @@ class NormalModule extends Module {
} }
build(options, compilation, resolver, fs, callback) { build(options, compilation, resolver, fs, callback) {
this.buildTimestamp = new Date().getTime(); this.buildTimestamp = Date.now();
this.built = true; this.built = true;
this._source = null; this._source = null;
this.error = null; this.error = null;

4
lib/ProgressPlugin.js
View File

@ -157,9 +157,9 @@ class ProgressPlugin {
state = state.replace(/^\d+\/\d+\s+/, ""); state = state.replace(/^\d+\/\d+\s+/, "");
if(percentage === 0) { if(percentage === 0) {
lastState = null; lastState = null;
lastStateTime = +new Date(); lastStateTime = Date.now();
} else if(state !== lastState || percentage === 1) { } else if(state !== lastState || percentage === 1) {
const now = +new Date(); const now = Date.now();
if(lastState) { if(lastState) {
const stateMsg = `${now - lastStateTime}ms ${lastState}`; const stateMsg = `${now - lastStateTime}ms ${lastState}`;
goToLineStart(stateMsg); goToLineStart(stateMsg);

2
lib/RawModule.js
View File

@ -36,7 +36,7 @@ module.exports = class RawModule extends Module {
} }
build(options, compilations, resolver, fs, callback) { build(options, compilations, resolver, fs, callback) {
this.builtTime = new Date().getTime(); this.builtTime = Date.now();
callback(); callback();
} }