From a63bb774c53c40a6e6f9a267a08b5e147bf3a542 Mon Sep 17 00:00:00 2001 From: Jevan Chan Date: Wed, 21 Feb 2018 12:42:36 +0800 Subject: [PATCH] upgrade micromatch, add sideEffects flag unit test cases --- package.json | 2 +- test/SideEffectsFlagPlugin.unittest.js | 1 + yarn.lock | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 00c8e8569..5a994bf67 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "loader-runner": "^2.3.0", "loader-utils": "^1.1.0", "memory-fs": "~0.4.1", - "micromatch": "^3.1.6", + "micromatch": "^3.1.8", "mkdirp": "~0.5.0", "neo-async": "^2.5.0", "node-libs-browser": "^2.0.0", diff --git a/test/SideEffectsFlagPlugin.unittest.js b/test/SideEffectsFlagPlugin.unittest.js index 33f5fb68f..be93f188c 100644 --- a/test/SideEffectsFlagPlugin.unittest.js +++ b/test/SideEffectsFlagPlugin.unittest.js @@ -27,6 +27,7 @@ describe("SideEffectsFlagPlugin", () => { SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/{x,y,z}.js").should.eql(true); SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/[x-z].js").should.eql(true); SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/[[:lower:]].js").should.eql(true); + SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "!*.js").should.eql(false); SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "!**/*.js").should.eql(false); }); diff --git a/yarn.lock b/yarn.lock index 132aedd15..91d7d93e3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2764,9 +2764,9 @@ micromatch@^2.1.5: parse-glob "^3.0.4" regex-cache "^0.4.2" -micromatch@^3.1.6: - version "3.1.6" - resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-3.1.6.tgz#8d7c043b48156f408ca07a4715182b79b99420bf" +micromatch@^3.1.8: + version "3.1.8" + resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-3.1.8.tgz#5c8caa008de588eebb395e8c0ad12c128f25fff1" dependencies: arr-diff "^4.0.0" array-unique "^0.3.2"