root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #8592 from hulkish/hoist-plugin-logic 

perf: hoist option logic, reduce code paths in handler
This commit is contained in:
Tobias Koppers 2019-01-07 21:26:40 +01:00 committed by GitHub
parent 9c01e81c7c b9f52dcb4d
commit b133ebeb25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/node/NodeTemplatePlugin.js
View File

@ -23,6 +23,10 @@ class NodeTemplatePlugin {
* @returns {void} * @returns {void}
*/ */
apply(compiler) { apply(compiler) {
const ChunkLoadingRuntimeModule = this.asyncChunkLoading
? ReadFileChunkLoadingRuntimeModule
: RequireChunkLoadingRuntimeModule;
compiler.hooks.thisCompilation.tap("NodeTemplatePlugin", compilation => { compiler.hooks.thisCompilation.tap("NodeTemplatePlugin", compilation => {
new NodeChunkTemplatePlugin(compilation).apply(compilation.chunkTemplate); new NodeChunkTemplatePlugin(compilation).apply(compilation.chunkTemplate);
@ -31,17 +35,10 @@ class NodeTemplatePlugin {
if (onceForChunkSet.has(chunk)) return; if (onceForChunkSet.has(chunk)) return;
onceForChunkSet.add(chunk); onceForChunkSet.add(chunk);
set.add(RuntimeGlobals.moduleFactories); set.add(RuntimeGlobals.moduleFactories);
if (this.asyncChunkLoading) { compilation.addRuntimeModule(
compilation.addRuntimeModule( chunk,
chunk, new ChunkLoadingRuntimeModule(chunk, set)
new ReadFileChunkLoadingRuntimeModule(chunk, set) );
);
} else {
compilation.addRuntimeModule(
chunk,
new RequireChunkLoadingRuntimeModule(chunk, set)
);
}
}; };
compilation.hooks.runtimeRequirementInTree compilation.hooks.runtimeRequirementInTree