root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fix infinite loop in inner graph optimization 

fixes #11678
This commit is contained in:
Tobias Koppers 2020-10-15 13:24:40 +02:00
parent 27796db6eb
commit b6bc2730b9
3 changed files with 3186 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/optimize/InnerGraph.js
View File

@ -116,6 +116,7 @@ exports.inferDependencyUsage = state => {
} }
const { innerGraph, usageCallbackMap } = innerGraphState; const { innerGraph, usageCallbackMap } = innerGraphState;
const processed = new Map();
// flatten graph to terminal nodes (string, undefined or true) // flatten graph to terminal nodes (string, undefined or true)
const nonTerminal = new Set(innerGraph.keys()); const nonTerminal = new Set(innerGraph.keys());
while (nonTerminal.size > 0) { while (nonTerminal.size > 0) {
@ -124,7 +125,15 @@ exports.inferDependencyUsage = state => {
let newSet = new Set(); let newSet = new Set();
let isTerminal = true; let isTerminal = true;
const value = innerGraph.get(key); const value = innerGraph.get(key);
let alreadyProcessed = processed.get(key);
if (alreadyProcessed === undefined) {
alreadyProcessed = new Set();
processed.set(key, alreadyProcessed);
}
if (value !== true && value !== undefined) { if (value !== true && value !== undefined) {
for (const item of value) {
alreadyProcessed.add(item);
}
for (const item of value) { for (const item of value) {
if (typeof item === "string") { if (typeof item === "string") {
newSet.add(item); newSet.add(item);
@ -137,7 +146,7 @@ exports.inferDependencyUsage = state => {
if (itemValue !== undefined) { if (itemValue !== undefined) {
for (const i of itemValue) { for (const i of itemValue) {
if (i === key) continue; if (i === key) continue;
if (value.has(i)) continue; if (alreadyProcessed.has(i)) continue;
newSet.add(i); newSet.add(i);
if (typeof i !== "string") { if (typeof i !== "string") {
isTerminal = false; isTerminal = false;

3105
test/configCases/inner-graph/issue-11678/module.js Normal file
View File

File diff suppressed because it is too large Load Diff

71
test/configCases/inner-graph/issue-11678/webpack.config.js Normal file
View File

@ -0,0 +1,71 @@
const createTestCases = require("../_helpers/createTestCases");
module.exports = createTestCases({
nothing: {
usedExports: [],
expect: {
"resize-observer": ["ResizeObserver"],
"Source_Data/employee": [],
"Source_Data/services": [],
"Source_Framework/splitview/page": [],
"Source_Framework/splitview/menu": [],
"Source_Framework/splitview/text": [],
"Source_Framework/uilistpicker/UiListPicker": [],
"Source_ODS/cookiestorage": [],
"Source_Framework/uirichtextedit": [],
"Source_Framework/uielement": [],
"Source_ODS/UiButton/icon": [],
"Source_ODS/UiButton/text": [],
"Source_Framework/pagelinks": [],
"Source_ODS/ods": [],
"Source_ODS/UiButton": [],
"Source_Framework/defaultButtons": [],
"Source_Framework/uiform": [],
"Source_Framework/breadcrumb": [],
"Source_ODS/lodash": [],
"Source_ODS/DomElement": [],
"Source_ODS/url": [],
"Source_ODS/tooltip": [],
"Source_ODS/ui": [],
"Source_ODS/types": [],
"Source_ODS/UiDialog": [],
"Source_Framework/common/moduleDispatcher": [],
"Source_Framework/common/employeeassignment": [],
"Source_Framework/common/pdf_preview": [],
"Source_Framework/common/taskprogress": [],
"Source_Framework/uitable": [],
"Source_Framework/backend/universalData": [],
"Source_Framework/common/columnsDialog": [],
"Source_Framework/backend/jsonData": [],
"Source_Framework/common/statuschange": [],
"Source_Framework/common/las_mod_jobselection": [],
"./text": [],
"./bec": [],
"./positionTypes": [],
"./settings": ["SETTINGS"],
"./preferences": [],
"./privileges": [],
"./buttons": [],
"./form": [],
"./formHelper": [],
"./table": [],
"./techText": [],
"./addPositionToSi": [],
"./ciPosFromJob": [],
"./shiftPosition": [],
"./autoSums": [],
"./defineLayout": [],
"./insertFromTemplate": [],
"./movePosition": [],
"./copy": [],
"./save": [],
"./createOrder": [],
"./orderPosFromJobPos": [],
"./nchInfoDialog": [],
"Source_Modules/las_mod_siheader/url": [],
"Source_Modules/las_mod_siheader/bec": [],
"Source_Modules/las_mod_ceheader/bec": [],
"Source_Modules/las_mod_order/bec": [],
"Source_Modules/las_mod_ciheader/bec": []
}
}
});