root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #6736 from mc-zone/improvment/performance-falsy-at-non-web-target 

Make the `performance` default to false while at non-web target. Close #6715
This commit is contained in:
Tobias Koppers 2018-03-14 11:52:34 +01:00 committed by GitHub
parent 12b3751604 2ecd323a38
commit c65fb74a26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 178 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/WebpackOptionsDefaulter.js
View File

@ -13,6 +13,10 @@ const isProductionLikeMode = options => {
return options.mode === "production" || !options.mode;
};
const isWebLikeTarget = options => {
return options.target === "web" || options.target === "webworker";
};
class WebpackOptionsDefaulter extends OptionsDefaulter {
constructor() {
super();
@ -166,17 +170,14 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
this.set("node.__filename", "mock");
this.set("node.__dirname", "mock");
this.set(
"performance",
"make",
options => (isProductionLikeMode(options) ? false : undefined)
);
this.set("performance", "call", value => {
if (typeof value === "boolean") {
return value;
} else {
return Object.assign({}, value);
}
this.set("performance", "call", (value, options) => {
if (value === false) return false;
if (
value === undefined &&
(!isProductionLikeMode(options) || !isWebLikeTarget(options))
)
return false;
return Object.assign({}, value);
});
this.set("performance.maxAssetSize", 250000);
this.set("performance.maxEntrypointSize", 250000);

102
test/statsCases/performance-different-mode-and-target/expected.txt Normal file
View File

@ -0,0 +1,102 @@
Hash: df3a0090d24670ebd17d7094466a296a7ae4ae823f59070ac8deb95011d223ef01d5f7db6f7b0912f47482563c8b6b9dc4955fdf2e3a0c7c308a998f9bab5b59aa119495c443
Child
Hash: df3a0090d24670ebd17d
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
warning.pro-web.js 296 KiB 0 [emitted] [big] main
Entrypoint main [big] = warning.pro-web.js
[0] ./index.js 293 KiB {0} [built]
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
warning.pro-web.js (296 KiB)
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
main (296 KiB)
warning.pro-web.js
WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/
Child
Hash: 7094466a296a7ae4ae82
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
warning.pro-webworker.js 296 KiB 0 [emitted] [big] main
Entrypoint main [big] = warning.pro-webworker.js
[0] ./index.js 293 KiB {0} [built]
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
warning.pro-webworker.js (296 KiB)
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
main (296 KiB)
warning.pro-webworker.js
WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/
Child
Hash: 3f59070ac8deb95011d2
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
no-warning.pro-node.js 296 KiB 0 [emitted] main
Entrypoint main = no-warning.pro-node.js
[0] ./index.js 293 KiB {0} [built]
Child
Hash: 23ef01d5f7db6f7b0912
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
no-warning.dev-web.js 1.72 MiB main [emitted] main
Entrypoint main = no-warning.dev-web.js
[./index.js] 293 KiB {main} [built]
Child
Hash: f47482563c8b6b9dc495
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
no-warning.dev-node.js 1.72 MiB main [emitted] main
Entrypoint main = no-warning.dev-node.js
[./index.js] 293 KiB {main} [built]
Child
Hash: 5fdf2e3a0c7c308a998f
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
no-warning.dev-web-with-limit-set.js 1.72 MiB main [emitted] [big] main
Entrypoint main [big] = no-warning.dev-web-with-limit-set.js
[./index.js] 293 KiB {main} [built]
Child
Hash: 9bab5b59aa119495c443
Time: Xms
Built at: Thu Jan 01 1970 00:00:00 GMT
Asset Size Chunks Chunk Names
warning.pro-node-with-hints-set.js 296 KiB 0 [emitted] [big] main
Entrypoint main [big] = warning.pro-node-with-hints-set.js
[0] ./index.js 293 KiB {0} [built]
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
warning.pro-node-with-hints-set.js (296 KiB)
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
main (296 KiB)
warning.pro-node-with-hints-set.js
WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

BIN
test/statsCases/performance-different-mode-and-target/index.js Normal file
View File

Binary file not shown.

64
test/statsCases/performance-different-mode-and-target/webpack.config.js Normal file
View File

@ -0,0 +1,64 @@
module.exports = [
{
entry: "./index",
mode: "production",
target: "web",
output: {
filename: "warning.pro-web.js"
}
},
{
entry: "./index",
mode: "production",
target: "webworker",
output: {
filename: "warning.pro-webworker.js"
}
},
{
entry: "./index",
mode: "production",
target: "node",
output: {
filename: "no-warning.pro-node.js"
}
},
{
entry: "./index",
mode: "development",
target: "web",
output: {
filename: "no-warning.dev-web.js"
}
},
{
entry: "./index",
mode: "development",
target: "node",
output: {
filename: "no-warning.dev-node.js"
}
},
{
entry: "./index",
mode: "development",
target: "web",
performance: {
maxAssetSize: 100
},
output: {
filename: "no-warning.dev-web-with-limit-set.js"
}
},
{
entry: "./index",
mode: "production",
target: "node",
performance: {
hints: "warning"
},
output: {
filename: "warning.pro-node-with-hints-set.js"
}
}
];