diff --git a/lib/container/ContainerPlugin.js b/lib/container/ContainerPlugin.js index f90f366e1..60a49a247 100644 --- a/lib/container/ContainerPlugin.js +++ b/lib/container/ContainerPlugin.js @@ -88,7 +88,7 @@ class ContainerPlugin { }, error => { if (error) return callback(error); - hooks.addContainerEntryModule.call(dep); + hooks.addContainerEntryDependency.call(dep); callback(); } ); diff --git a/lib/container/HoistContainerReferencesPlugin.js b/lib/container/HoistContainerReferencesPlugin.js index d48a2467b..1424b9a6e 100644 --- a/lib/container/HoistContainerReferencesPlugin.js +++ b/lib/container/HoistContainerReferencesPlugin.js @@ -22,10 +22,10 @@ class HoistContainerReferences { compiler.hooks.thisCompilation.tap(PLUGIN_NAME, compilation => { const hooks = ModuleFederationPlugin.getCompilationHooks(compilation); const containerEntryDependencies = new Set(); - hooks.addContainerEntryModule.tap(PLUGIN_NAME, dep => { + hooks.addContainerEntryDependency.tap(PLUGIN_NAME, dep => { containerEntryDependencies.add(dep); }); - hooks.addFederationRuntimeModule.tap(PLUGIN_NAME, dep => { + hooks.addFederationRuntimeDependency.tap(PLUGIN_NAME, dep => { containerEntryDependencies.add(dep); }); diff --git a/lib/container/ModuleFederationPlugin.js b/lib/container/ModuleFederationPlugin.js index 2178f7a59..ab62bbc18 100644 --- a/lib/container/ModuleFederationPlugin.js +++ b/lib/container/ModuleFederationPlugin.js @@ -20,8 +20,8 @@ const ContainerReferencePlugin = require("./ContainerReferencePlugin"); /** * @typedef {object} CompilationHooks - * @property {SyncHook} addContainerEntryModule - * @property {SyncHook} addFederationRuntimeModule + * @property {SyncHook} addContainerEntryDependency + * @property {SyncHook} addFederationRuntimeDependency */ const validate = createSchemaValidation( @@ -60,8 +60,8 @@ class ModuleFederationPlugin { let hooks = compilationHooksMap.get(compilation); if (!hooks) { hooks = { - addContainerEntryModule: new SyncHook(["dependency"]), - addFederationRuntimeModule: new SyncHook(["module"]) + addContainerEntryDependency: new SyncHook(["dependency"]), + addFederationRuntimeDependency: new SyncHook(["dependency"]) }; compilationHooksMap.set(compilation, hooks); } diff --git a/types.d.ts b/types.d.ts index 1d5a0d0fa..8275b70d8 100644 --- a/types.d.ts +++ b/types.d.ts @@ -2307,8 +2307,8 @@ declare interface CompilationHooksJavascriptModulesPlugin { useSourceMap: SyncBailHook<[Chunk, RenderContext], boolean>; } declare interface CompilationHooksModuleFederationPlugin { - addContainerEntryModule: SyncHook; - addFederationRuntimeModule: SyncHook; + addContainerEntryDependency: SyncHook; + addFederationRuntimeDependency: SyncHook; } declare interface CompilationHooksRealContentHashPlugin { updateHash: SyncBailHook<[Buffer[], string], string>;