mirror of https://github.com/webpack/webpack.git
feat: PoC of 17512
This commit is contained in:
parent
930785fb00
commit
d5b4b50c10
|
@ -1988,6 +1988,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
|
||||||
? /** @type {string} */ (originModule.nameForCondition())
|
? /** @type {string} */ (originModule.nameForCondition())
|
||||||
: "",
|
: "",
|
||||||
issuerLayer: originModule ? originModule.layer : null,
|
issuerLayer: originModule ? originModule.layer : null,
|
||||||
|
issuerDependency: originModule ? originModule.issuerDependencyType : null,
|
||||||
compiler: this.compiler.name,
|
compiler: this.compiler.name,
|
||||||
...contextInfo
|
...contextInfo
|
||||||
},
|
},
|
||||||
|
|
|
@ -341,6 +341,7 @@ class NormalModule extends Module {
|
||||||
constructor({
|
constructor({
|
||||||
layer,
|
layer,
|
||||||
type,
|
type,
|
||||||
|
issuerDependencyType,
|
||||||
request,
|
request,
|
||||||
userRequest,
|
userRequest,
|
||||||
rawRequest,
|
rawRequest,
|
||||||
|
@ -358,6 +359,7 @@ class NormalModule extends Module {
|
||||||
}) {
|
}) {
|
||||||
super(type, context || getContext(resource), layer);
|
super(type, context || getContext(resource), layer);
|
||||||
|
|
||||||
|
this.issuerDependencyType = issuerDependencyType;
|
||||||
// Info from Factory
|
// Info from Factory
|
||||||
/** @type {string} */
|
/** @type {string} */
|
||||||
this.request = request;
|
this.request = request;
|
||||||
|
|
|
@ -443,6 +443,7 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
context,
|
context,
|
||||||
dependencies,
|
dependencies,
|
||||||
dependencyType,
|
dependencyType,
|
||||||
|
issuerDependencyType,
|
||||||
request,
|
request,
|
||||||
assertions,
|
assertions,
|
||||||
resolveOptions,
|
resolveOptions,
|
||||||
|
@ -705,6 +706,7 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
Object.assign(data.createData, {
|
Object.assign(data.createData, {
|
||||||
layer:
|
layer:
|
||||||
layer === undefined ? contextInfo.issuerLayer || null : layer,
|
layer === undefined ? contextInfo.issuerLayer || null : layer,
|
||||||
|
issuerDependencyType: issuerDependencyType,
|
||||||
request: stringifyLoadersAndResource(
|
request: stringifyLoadersAndResource(
|
||||||
allLoaders,
|
allLoaders,
|
||||||
resourceData.resource
|
resourceData.resource
|
||||||
|
@ -793,7 +795,6 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
};
|
};
|
||||||
continueCallback();
|
continueCallback();
|
||||||
}
|
}
|
||||||
|
|
||||||
// resource without scheme and with path
|
// resource without scheme and with path
|
||||||
else {
|
else {
|
||||||
const normalResolver = this.getResolver(
|
const normalResolver = this.getResolver(
|
||||||
|
@ -804,6 +805,13 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
"dependencyType",
|
"dependencyType",
|
||||||
dependencyType
|
dependencyType
|
||||||
)
|
)
|
||||||
|
: resolveOptions,
|
||||||
|
issuerDependencyType
|
||||||
|
? cachedSetProperty(
|
||||||
|
resolveOptions || EMPTY_RESOLVE_OPTIONS,
|
||||||
|
"issuerDependency",
|
||||||
|
issuerDependencyType
|
||||||
|
)
|
||||||
: resolveOptions
|
: resolveOptions
|
||||||
);
|
);
|
||||||
this.resolveResource(
|
this.resolveResource(
|
||||||
|
@ -899,6 +907,7 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
const assertions = dependency.assertions;
|
const assertions = dependency.assertions;
|
||||||
const dependencyType = dependency.category || "";
|
const dependencyType = dependency.category || "";
|
||||||
const contextInfo = data.contextInfo;
|
const contextInfo = data.contextInfo;
|
||||||
|
const issuerDependencyType = dependency.issuerCategory || contextInfo.issuerDependency || null;
|
||||||
const fileDependencies = new LazySet();
|
const fileDependencies = new LazySet();
|
||||||
const missingDependencies = new LazySet();
|
const missingDependencies = new LazySet();
|
||||||
const contextDependencies = new LazySet();
|
const contextDependencies = new LazySet();
|
||||||
|
@ -911,6 +920,7 @@ class NormalModuleFactory extends ModuleFactory {
|
||||||
assertions,
|
assertions,
|
||||||
dependencies,
|
dependencies,
|
||||||
dependencyType,
|
dependencyType,
|
||||||
|
issuerDependencyType,
|
||||||
fileDependencies,
|
fileDependencies,
|
||||||
missingDependencies,
|
missingDependencies,
|
||||||
contextDependencies,
|
contextDependencies,
|
||||||
|
@ -1359,10 +1369,11 @@ If changing the source code is not an option there is also a resolve options cal
|
||||||
/**
|
/**
|
||||||
* @param {Parameters<ResolverFactory["get"]>[0]} type type of resolver
|
* @param {Parameters<ResolverFactory["get"]>[0]} type type of resolver
|
||||||
* @param {Parameters<ResolverFactory["get"]>[1]=} resolveOptions options
|
* @param {Parameters<ResolverFactory["get"]>[1]=} resolveOptions options
|
||||||
|
* @param {Parameters<ResolverFactory["get"]>[1]=} issuerResolveOptions options
|
||||||
* @returns {ReturnType<ResolverFactory["get"]>} the resolver
|
* @returns {ReturnType<ResolverFactory["get"]>} the resolver
|
||||||
*/
|
*/
|
||||||
getResolver(type, resolveOptions) {
|
getResolver(type, resolveOptions, issuerResolveOptions) {
|
||||||
return this.resolverFactory.get(type, resolveOptions);
|
return this.resolverFactory.get(type, resolveOptions, issuerResolveOptions);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -34,9 +34,13 @@ const EMPTY_RESOLVE_OPTIONS = {};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @param {ResolveOptionsWithDependencyType} resolveOptionsWithDepType enhanced options
|
* @param {ResolveOptionsWithDependencyType} resolveOptionsWithDepType enhanced options
|
||||||
|
* @param {ResolveOptionsWithDependencyType} issuerResolveOptions enhanced options
|
||||||
* @returns {ResolveOptions} merged options
|
* @returns {ResolveOptions} merged options
|
||||||
*/
|
*/
|
||||||
const convertToResolveOptions = (resolveOptionsWithDepType) => {
|
const convertToResolveOptions = (
|
||||||
|
resolveOptionsWithDepType,
|
||||||
|
issuerResolveOptions
|
||||||
|
) => {
|
||||||
const { dependencyType, plugins, ...remaining } = resolveOptionsWithDepType;
|
const { dependencyType, plugins, ...remaining } = resolveOptionsWithDepType;
|
||||||
|
|
||||||
// check type compat
|
// check type compat
|
||||||
|
@ -60,10 +64,24 @@ const convertToResolveOptions = (resolveOptionsWithDepType) => {
|
||||||
/** @type {Partial<ResolveOptionsWithDependencyType> & Pick<ResolveOptionsWithDependencyType, "fileSystem">} */ (
|
/** @type {Partial<ResolveOptionsWithDependencyType> & Pick<ResolveOptionsWithDependencyType, "fileSystem">} */ (
|
||||||
partialOptions
|
partialOptions
|
||||||
);
|
);
|
||||||
|
const { issuerDependency } = issuerResolveOptions;
|
||||||
|
|
||||||
|
const resolvedByDependency = resolveByProperty(
|
||||||
|
options,
|
||||||
|
"byDependency",
|
||||||
|
dependencyType
|
||||||
|
);
|
||||||
|
|
||||||
return /** @type {ResolveOptions} */ (
|
return /** @type {ResolveOptions} */ (
|
||||||
|
// byIssuerDependencyType
|
||||||
removeOperations(
|
removeOperations(
|
||||||
resolveByProperty(options, "byDependency", dependencyType),
|
issuerDependency
|
||||||
|
? resolveByProperty(
|
||||||
|
resolvedByDependency,
|
||||||
|
"byIssuerDependency",
|
||||||
|
issuerDependency
|
||||||
|
)
|
||||||
|
: resolvedByDependency,
|
||||||
// Keep the `unsafeCache` because it can be a `Proxy`
|
// Keep the `unsafeCache` because it can be a `Proxy`
|
||||||
["unsafeCache"]
|
["unsafeCache"]
|
||||||
)
|
)
|
||||||
|
@ -95,44 +113,55 @@ module.exports = class ResolverFactory {
|
||||||
/**
|
/**
|
||||||
* @param {string} type type of resolver
|
* @param {string} type type of resolver
|
||||||
* @param {ResolveOptionsWithDependencyType=} resolveOptions options
|
* @param {ResolveOptionsWithDependencyType=} resolveOptions options
|
||||||
|
* @param {ResolveOptionsWithDependencyType=} issuerResolveOptions options
|
||||||
* @returns {ResolverWithOptions} the resolver
|
* @returns {ResolverWithOptions} the resolver
|
||||||
*/
|
*/
|
||||||
get(type, resolveOptions = EMPTY_RESOLVE_OPTIONS) {
|
get(
|
||||||
let typedCaches = this.cache.get(type);
|
type,
|
||||||
if (!typedCaches) {
|
resolveOptions = EMPTY_RESOLVE_OPTIONS,
|
||||||
typedCaches = {
|
issuerResolveOptions = EMPTY_RESOLVE_OPTIONS
|
||||||
direct: new WeakMap(),
|
) {
|
||||||
stringified: new Map()
|
// let typedCaches = this.cache.get(type);
|
||||||
};
|
// if (!typedCaches) {
|
||||||
this.cache.set(type, typedCaches);
|
// typedCaches = {
|
||||||
}
|
// direct: new WeakMap(),
|
||||||
const cachedResolver = typedCaches.direct.get(resolveOptions);
|
// stringified: new Map()
|
||||||
if (cachedResolver) {
|
// };
|
||||||
return cachedResolver;
|
// this.cache.set(type, typedCaches);
|
||||||
}
|
// }
|
||||||
const ident = JSON.stringify(resolveOptions);
|
// const cachedResolver = typedCaches.direct.get(resolveOptions);
|
||||||
const resolver = typedCaches.stringified.get(ident);
|
// if (cachedResolver) {
|
||||||
if (resolver) {
|
// return cachedResolver;
|
||||||
typedCaches.direct.set(resolveOptions, resolver);
|
// }
|
||||||
return resolver;
|
// const ident = JSON.stringify(resolveOptions);
|
||||||
}
|
// const resolver = typedCaches.stringified.get(ident);
|
||||||
const newResolver = this._create(type, resolveOptions);
|
// if (resolver) {
|
||||||
typedCaches.direct.set(resolveOptions, newResolver);
|
// typedCaches.direct.set(resolveOptions, resolver);
|
||||||
typedCaches.stringified.set(ident, newResolver);
|
// return resolver;
|
||||||
|
// }
|
||||||
|
const newResolver = this._create(
|
||||||
|
type,
|
||||||
|
resolveOptions,
|
||||||
|
issuerResolveOptions
|
||||||
|
);
|
||||||
|
// typedCaches.direct.set(resolveOptions, newResolver);
|
||||||
|
// typedCaches.stringified.set(ident, newResolver);
|
||||||
return newResolver;
|
return newResolver;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @param {string} type type of resolver
|
* @param {string} type type of resolver
|
||||||
* @param {ResolveOptionsWithDependencyType} resolveOptionsWithDepType options
|
* @param {ResolveOptionsWithDependencyType} resolveOptionsWithDepType options
|
||||||
|
* @param {ResolveOptionsWithIssuerDependencyType} issuerResolveOptions options
|
||||||
* @returns {ResolverWithOptions} the resolver
|
* @returns {ResolverWithOptions} the resolver
|
||||||
*/
|
*/
|
||||||
_create(type, resolveOptionsWithDepType) {
|
_create(type, resolveOptionsWithDepType, issuerResolveOptions) {
|
||||||
/** @type {ResolveOptionsWithDependencyType} */
|
/** @type {ResolveOptionsWithDependencyType} */
|
||||||
const originalResolveOptions = { ...resolveOptionsWithDepType };
|
const originalResolveOptions = { ...resolveOptionsWithDepType };
|
||||||
|
|
||||||
const resolveOptions = convertToResolveOptions(
|
const resolveOptions = convertToResolveOptions(
|
||||||
this.hooks.resolveOptions.for(type).call(resolveOptionsWithDepType)
|
this.hooks.resolveOptions.for(type).call(resolveOptionsWithDepType),
|
||||||
|
issuerResolveOptions
|
||||||
);
|
);
|
||||||
const resolver = /** @type {ResolverWithOptions} */ (
|
const resolver = /** @type {ResolverWithOptions} */ (
|
||||||
Factory.createResolver(resolveOptions)
|
Factory.createResolver(resolveOptions)
|
||||||
|
|
|
@ -1787,12 +1787,17 @@ const getResolveDefaults = ({
|
||||||
conditionNames: ["require", "module", "..."],
|
conditionNames: ["require", "module", "..."],
|
||||||
extensions: [...jsExtensions]
|
extensions: [...jsExtensions]
|
||||||
});
|
});
|
||||||
/** @type {() => ResolveOptions} */
|
/** @type {(options?: { worker?: boolean }) => ResolveOptions} */
|
||||||
const esmDeps = () => ({
|
const esmDeps = ({ worker } = {}) => ({
|
||||||
aliasFields: browserField ? ["browser"] : [],
|
aliasFields: browserField ? ["browser"] : [],
|
||||||
mainFields: browserField ? ["browser", "module", "..."] : ["module", "..."],
|
mainFields: browserField ? ["browser", "module", "..."] : ["module", "..."],
|
||||||
conditionNames: ["import", "module", "..."],
|
conditionNames: [...(worker ? ["worker"] : []), "import", "module", "..."],
|
||||||
extensions: [...jsExtensions]
|
extensions: [...jsExtensions],
|
||||||
|
byIssuerDependency: {
|
||||||
|
worker: {
|
||||||
|
conditionNames: ["worker", "import", "module", "..."]
|
||||||
|
}
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
/** @type {ResolveOptions} */
|
/** @type {ResolveOptions} */
|
||||||
|
@ -1815,7 +1820,7 @@ const getResolveDefaults = ({
|
||||||
preferRelative: true
|
preferRelative: true
|
||||||
},
|
},
|
||||||
worker: {
|
worker: {
|
||||||
...esmDeps(),
|
...esmDeps({ worker: true }),
|
||||||
preferRelative: true
|
preferRelative: true
|
||||||
},
|
},
|
||||||
commonjs: cjsDeps(),
|
commonjs: cjsDeps(),
|
||||||
|
|
|
@ -59,6 +59,10 @@ class WorkerDependency extends ModuleDependency {
|
||||||
return "worker";
|
return "worker";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
get issuerCategory() {
|
||||||
|
return "worker";
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Update the hash
|
* Update the hash
|
||||||
* @param {Hash} hash hash to be updated
|
* @param {Hash} hash hash to be updated
|
||||||
|
|
Loading…
Reference in New Issue