root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

hoist comparators

This commit is contained in:
Tobias Koppers 2019-10-28 14:02:37 +01:00
parent 490329517d
commit dc06b66819
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Compilation.js
View File

@ -215,6 +215,17 @@ const byNameOrHash = concatComparators(
)
);
const byMessage = compareSelect(err => `${err.message}`, compareStringsNumeric);
const byModule = compareSelect(
err => (err.module && err.module.identifier()) || "",
compareStringsNumeric
);
const byLocation = compareSelect(err => err.loc, compareLocations);
const compareErrors = concatComparators(byModule, byLocation, byMessage);
/**
* @param {Source} a a source
* @param {Source} b another source
@ -1928,17 +1939,6 @@ class Compilation {
chunkGroup.sortItems();
}
const byMessage = compareSelect(
err => `${err.message}`,
compareStringsNumeric
);
const byModule = compareSelect(
err => (err.module && err.module.identifier()) || "",
compareStringsNumeric
);
const byLocation = compareSelect(err => err.loc, compareLocations);
const compareErrors = concatComparators(byModule, byLocation, byMessage);
this.errors.sort(compareErrors);
this.warnings.sort(compareErrors);
this.children.sort(byNameOrHash);