root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

docs: fix grammar

This commit is contained in:
Nitin Kumar 2020-07-14 17:00:37 +05:30
parent bff709f284
commit ee97ecd986
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -35,7 +35,7 @@ If you have created your own loader/plugin please include it on the relevant doc
## Submitting Changes ## Submitting Changes
After getting some feedbacks, push to your fork and submit a pull request. We After getting some feedback, push to your fork and submit a pull request. We
may suggest some changes or improvements or alternatives, but for small changes may suggest some changes or improvements or alternatives, but for small changes
your pull request should be accepted quickly. your pull request should be accepted quickly.
@ -46,7 +46,7 @@ Something that will increase the chance that your pull request is accepted:
- Write a [good commit message](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) - Write a [good commit message](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
- For a major fix/feature make sure your PR has an issue and if it doesn't, please create one. This would help discussion with the community, and polishing ideas in case of a new feature. - For a major fix/feature make sure your PR has an issue and if it doesn't, please create one. This would help discussion with the community, and polishing ideas in case of a new feature.
- Make sure your PR's description contains GitHub's special keyword references that automatically close the related issue when the PR is merged. ([More info](https://github.com/blog/1506-closing-issues-via-pull-requests)) - Make sure your PR's description contains GitHub's special keyword references that automatically close the related issue when the PR is merged. ([More info](https://github.com/blog/1506-closing-issues-via-pull-requests))
- When you have lot of commits in your PR, it's good practice to squash all your commits in one single commit. ([Learn how to squash here](https://davidwalsh.name/squash-commits-git)) - When you have a lot of commits in your PR, it's good practice to squash all your commits in one single commit. ([Learn how to squash here](https://davidwalsh.name/squash-commits-git))
## Documentation ## Documentation