root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #2016 from alexFaunt/master 

fix numberToIdentifer so it cant output duplicates
This commit is contained in:
Tobias Koppers 2016-02-08 18:01:00 +01:00
parent c501b5d5af 81ad5fd6a6
commit f7f4fcc9d0
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Template.js
View File

@ -22,13 +22,13 @@ Template.toIdentifier = function(str) {
var A_CODE = "a".charCodeAt(0);
var Z_CODE = "z".charCodeAt(0);
var AZ_COUNT = Z_CODE - A_CODE;
var AZ_COUNT = Z_CODE - A_CODE + 1;
var A2_CODE = "A".charCodeAt(0);
var Z2_CODE = "Z".charCodeAt(0);
var AZ2_COUNT = Z2_CODE - A2_CODE;
var AZ2_COUNT = Z2_CODE - A2_CODE + 1;
Template.numberToIdentifer = function numberToIdentifer(n) {
if(n < AZ_COUNT) return String.fromCharCode(A_CODE + n);
if(n < AZ_COUNT + AZ2_COUNT) return String.fromCharCode(A2_CODE + n + AZ_COUNT);
if(n < AZ_COUNT + AZ2_COUNT) return String.fromCharCode(A2_CODE + n - AZ_COUNT);
return "_" + (n - AZ_COUNT - AZ2_COUNT);
};

14
test/Template.test.js
View File

@ -7,4 +7,18 @@ describe("Template", function() {
it("should generate valid identifiers", function() {
template.toIdentifier("0abc-def9").should.equal("_abc_def9");
});
it("should generate valid number identifiers", function() {
var items = [];
var item;
for(var i = 0; i < 80; i += 1) {
item = template.numberToIdentifer(i);
if(item === '') {
throw new Error('empty number identifier');
} else if(items.indexOf(item) > -1) {
throw new Error('duplicate number identifier');
} else {
items.push(item);
}
}
});
});