root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor: logic suggestions from code review 

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
This commit is contained in:
Nitin Kumar 2020-11-20 18:03:05 +05:30 committed by GitHub
parent e827f4fc44
commit fa7686c0f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
bin/webpack.js
View File

@ -82,31 +82,17 @@ if (!cli.installed) {
console.error(notify); console.error(notify);
const isNpm = fs.existsSync(path.resolve(process.cwd(), "package-lock.json"));
let isYarn = false;
if (!isNpm) {
isYarn = fs.existsSync(path.resolve(process.cwd(), "yarn.lock"));
}
let isPnpm = false;
if (!isYarn) {
isPnpm = fs.existsSync(path.resolve(process.cwd(), "pnpm-lock.yaml"));
}
let packageManager; let packageManager;
if (isYarn) { if (fs.existsSync(path.resolve(process.cwd(), "yarn.lock"))) {
packageManager = "yarn"; packageManager = "yarn";
} else if (isPnpm) { } else if (fs.existsSync(path.resolve(process.cwd(), "pnpm-lock.yaml"))) {
packageManager = "pnpm"; packageManager = "pnpm";
} else { } else {
packageManager = "npm"; packageManager = "npm";
} }
const installOptions = [isYarn ? "add" : "install", "-D"]; const installOptions = [packageManager === "yarn" ? "add" : "install", "-D"];
console.error( console.error(
`We will use "${packageManager}" to install the CLI via "${packageManager} ${installOptions.join( `We will use "${packageManager}" to install the CLI via "${packageManager} ${installOptions.join(