root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix tests

This commit is contained in:
Zhibin Liu 2018-10-30 19:45:16 +08:00
parent 25af83f288
commit ff3bfa157d
2 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cases/parsing/issue-7778/index.js
View File

@ -34,7 +34,7 @@ it("should detect query strings in dynamic import as a static value 2", function
]);
});
it("should detect query strings in dynamic import as a static value 2", function() {
it("should detect query strings in dynamic import as a static value 3", function() {
var testFileName = "a";
return Promise.all([

31
test/configCases/parsing/issue-8293/index.js
View File

@ -8,12 +8,31 @@ const path = require("path");
path.join(__dirname, `bundle-${method}.js`),
"utf-8"
);
expect(source).toContain(`\`./\${foobar}/\${"suffix0"}\``);
// buggy for param.isConditional() cases, big work, resolve in later PRs
// expect(source).toContain(`\`./\${foobar}/\${"suffix1"}\``);
// expect(source).toContain(`\`./\${foobar}/\${"suffix2"}\``);
expect(source).toContain(`\`./\${foobar}/\${"suffix3"}\``);
expect(source).not.toContain(`\`./\${foobar}/\${"suffix4"}\``);
expect(source).toContain(`\`./\${foobar}/suffix0`);
expect(source).toContain(`\`./\${foobar}/suffix3`);
expect(source).not.toContain(`\`./\${foobar}/suffix4`);
});
}
);
["import", "commonjs"].forEach(method => {
it(`should be able to replace ${method} param in DefinePlugin for conditional expression`, function() {
const source = fs.readFileSync(
path.join(__dirname, `bundle-${method}.js`),
"utf-8"
);
expect(source).toContain(`\`./\${"prefix1"}/\${foobar}/\${"suffix1"}`);
expect(source).toContain(`\`./\${"prefix2"}/\${foobar}/\${"suffix2"}`);
});
});
["amd-require", "amd-define", "require.resolve"].forEach(method => {
it(`should be able to replace ${method} param in DefinePlugin for conditional expression`, function() {
const source = fs.readFileSync(
path.join(__dirname, `bundle-${method}.js`),
"utf-8"
);
expect(source).toContain(`\`./\${foobar}/suffix1`);
expect(source).toContain(`\`./\${foobar}/suffix2`);
});
});