Commit Graph

86 Commits

Author SHA1 Message Date
Whien f9d797fb93 fix: Compiler parser.apply bug
fix parser.apply.apply instead of parser.apply in lib/Compiler.js
2017-11-23 16:28:12 +08:00
EugeneHlushko f14c301dba Improvement: Ensure util.depracation use for deprecation warnings 2017-11-20 12:02:10 +02:00
EugeneHlushko 61d91f5b75 Improvement: Ensure respect for --no-deprecation flag when adding non util.depracation warnings to console output 2017-11-19 18:58:07 +02:00
Tobias Koppers 0975d13da7 assign correct cache to child compilation
fixes webpack-contrib/extract-text-webpack-plugin#612
2017-09-13 16:29:37 +02:00
Adam Thomann 15f4894ebe Convert bind(this) to arrow functions 2017-08-11 01:52:25 -04:00
Huang Chi-Han 6c0e4520ea Fix typo that causes "TypeError: this.compiler.compiler is not a function" since compiler is undefined. 2017-07-12 15:22:02 +08:00
Flavio Corpa 43f967cd11 Adjust style to es6 🎉 2017-07-12 08:03:22 +02:00
Flavio Corpa 8975d8ed09 Merge branch 'master' into master 2017-07-12 07:57:53 +02:00
Kyle Truong 79926b3eed - Edit PR to use normal functions again due to ‘arguments’ not working with arrow functions
- reverse timeout change back to normal in NodeWatchFileSystem.test.js
2017-07-07 10:52:07 -04:00
Kyle Truong 13bc80b1a4 - Put Watching as a property on Compiler rather than a static method 2017-07-07 09:11:15 -04:00
Kyle Truong 6dffccaa72 - Remove ‘self’ references from lib/Compiler and use more arrow functions instead 2017-07-07 09:11:15 -04:00
Kyle Truong 4378c92c60 - Add more tests 2017-07-07 09:11:15 -04:00
Kyle Truong f080ebe0ee - Add tests to Compiler and Watching 2017-07-07 09:11:15 -04:00
Kyle Truong 567868925d 4099 ES6 Refactor lib/Compiler.js 2017-07-07 09:11:15 -04:00
Tobias Koppers ee541d9ab3 Merge pull request #4704 from webpack/bugfix/child-records-cache
assign correct records and cache to child compilations
2017-05-16 14:35:03 +02:00
André Cruz b0c45da2fd Fix _done function not dealing with compilation being undefined 2017-05-06 00:35:39 +01:00
Tobias Koppers 101850c5a9 assign correct records and cache to child compilations
This is a breaking change because plugins or loader could rely on this incorrect behavior
When using child compilations plugins and loaders should use a unique compiler name or use a consistent order

fixes #2777
2017-05-04 13:05:03 +02:00
J Huang 6afc397b99 perf: use Date.now() instead of new Date().getTime()
new Date().getTime() is 2x slower than Date.now(), see https://jsperf.com/new-date-vs-date-now-vs-performance-now/6
2017-05-04 10:19:54 +08:00
Flavio Corpa 859e0ddab6 Replace 2 spaces with 1 tab 2017-05-03 14:54:50 +02:00
Flavio Corpa 2178f1ad50 Merge branch 'master' into master 2017-05-02 10:34:10 +02:00
Tobias Koppers 53bb15b1ed Merge pull request #3934 from timse/refactor-watching-in-compiler
Refactor _done of Watching in compiler
2017-04-23 12:10:20 +02:00
Flavio Corpa 4366ad81db Merge branch 'master' into master 2017-04-14 14:18:41 +02:00
kutyel af3422c5d6 Add callback to Watching.prototype.invalidate 2017-04-14 14:16:41 +02:00
e-cloud 07f6281185 fix: typos and variables/function misuse 2017-04-11 19:43:05 +08:00
Tim Sebastian ab30c6b1c0 pass stats to error handler again, to prevent breaking change 2017-04-08 09:13:38 +10:00
Tim Sebastian 2a1bcff9e6 refactor the _done method of Watching
- we can safely ignore the "else" cases of not having an error as _done() is only called without arguments if "this.invalid is true"
- if we get passed the point of `this.invalid` either `err` or `compilation` are !!always!! set. therefore later checks can again be ignored
- early return in error case
- ignore `this.error` if we make it passed the error as it will be unset at this point.
- remove the setting of `this.error` or `this.stats` as the only use is inside this method and only allow weird behaviour if someone set them from outside
2017-04-06 21:46:07 +10:00
Tim Sebastian 8165164d3e explicitly call `new Stats` with compilation
instead of having compilation.getStats returning a new instance of `Stats(this)`
2017-04-06 21:40:58 +10:00
Tobias Koppers 263c5c9f40 close watchers correctly when closing watching 2017-03-15 15:50:05 +01:00
James Newell 2dfdbad047 emit watch-close event when watcher closes 2017-03-06 14:32:34 +11:00
Tobias Koppers fbf84d51f2 allow to apply plugins to child compiler
allow to match on compiler name in rules

#4177
2017-02-22 11:49:49 +01:00
Sean Larkin 91c1f35e05 fix(node): rollback changes of Buffer.from to new Buffer() and bump down travis to 4.3 min node v 2017-01-16 23:57:27 -06:00
Tobias Koppers 8e69a80847 code linting 2017-01-11 12:29:01 +01:00
Sean Larkin 7327ee608a chore(eslint): added eslint-node-plugin (#3652) 2016-12-30 17:13:49 -06:00
Sean Larkin aa8d01bf8d refactor(eslint): Added no-unsed-vars, env specific .eslintrc's for buildin & hot (#3636)
* refactor(eslint): Added no-unsed-vars, env specific .eslintrc's for buildin & hot

* This change allows for buildin to now be part of the lint test by addition of an extra .eslintrc file which extends existing but sets es6 to false
* Turned on no-unused-vars for eslint, and then removed all warnings from turning that feature on
* Was getting notified of errors in "quote" property in eslintrc, so changed to correct value from error to 2.

* beautify

* swap invalid eslint config val
2016-12-30 09:43:49 -06:00
Joe Bateson a8bb6cdb1c refactor(es6): Replace object-assign polyfill with native method (#3608) 2016-12-28 13:07:28 -06:00
Tobias Koppers f4ab7fc7e2 more performance improvements 2016-12-14 16:22:54 +01:00
Tobias Koppers da29d21ae4 performance improvements
breaking change: Module has now a "unbuild" method that must work correctly
2016-12-14 16:22:16 +01:00
Raphael Mu 75caa169bc reduce fn.bind(this) usage by aliasing `this` to `self` (#3146) 2016-10-17 13:26:22 -05:00
Tobias Koppers 530fad43b4 allow to pass abs path to manifest property of DllReferencePlugin
manifest is loaded on compilation
2016-09-16 01:19:50 +02:00
Tobias Koppers ec262a4007 refactoring: moved parser instancation into NormalModuleFactory
breaking change: compiler.parser must no longer be used. Use this instead:

``` js
compiler.plugin("compilation", function(compilation, params) {
  params.normalModuleFactory.plugin("parser", function(parser, parserOptions) {
    parser.plugin(/* ... */);
  });
});
```

required for #2978
2016-09-15 00:22:10 +02:00
Tobias Koppers 2f618e733a refactoring and aggressive-splitting plugin 2016-07-13 11:03:14 +02:00
Tobias Koppers f5a5edd78d run purge before stats for cache #2003 2016-05-06 22:47:02 +02:00
Sharang Dashputre 8845a7dda7 Copy watchOptions properly in Compiler.js
Replace Object.create() with assign() from object-assign.
2016-04-22 01:11:37 +05:30
Daniel K 466d20890c Pass changed file into `invalid` plugin hook 2016-03-20 11:53:55 +01:00
Tobias Koppers 7cbd78c1da Merge branch 'master' into webpack-2
Conflicts:
	.travis.yml
	bin/config-optimist.js
	test/statsCases/define-plugin/expected.txt
2015-09-19 20:11:48 +02:00
Ahmet Katrancı 8ff6cb5fed Report constructor correctly when inheriting from Tapable 2015-08-18 12:35:57 +01:00
Tobias Koppers 431a4c791c Merge branch 'master' into webpack-2
Conflicts:
	hot/dev-server.js
	hot/only-dev-server.js
	hot/poll.js
	hot/signal.js
	lib/ChunkTemplate.js
	lib/HotModuleReplacement.runtime.js
	lib/HotModuleReplacementPlugin.js
	lib/JsonpMainTemplatePlugin.js
	lib/MainTemplate.js
	lib/NormalModule.js
	lib/Parser.js
	lib/RecordIdsPlugin.js
	lib/WebpackOptionsApply.js
	lib/dependencies/RequireEnsureDependency.js
	lib/node/OldNodeWatchFileSystem.js
	lib/optimize/OccurrenceOrderPlugin.js
	package.json
2015-07-17 09:30:37 +02:00
Tobias Koppers f7d799adb4 rebeautify without spacing after keyword 2015-07-16 00:19:23 +02:00
Avi Haiat 0a340f2b1a feat(app): Beautify all lib files 2015-07-13 01:20:09 +03:00
Tobias Koppers ff7848369a Merge branch 'master' into webpack-2
Conflicts:
	bin/webpack.js
	package.json
2015-05-10 20:41:04 +02:00