Commit Graph

60 Commits

Author SHA1 Message Date
Tobias Koppers 2bd2d2844c improve a few issues
from review by @Kovensky
2017-05-20 14:54:42 +02:00
Tobias Koppers e1bac32c19 Use a Set to store modules in a chunk 2017-05-16 11:50:50 +02:00
Ali BARIN a941499889 Update variable declarations according to ES6 2017-03-02 15:09:09 +01:00
Tim Sebastian f4d8c5f20f fix inner loop of "remove" method
as it is not guaranteed that the the chunk has parents the loop may not be run
this could lead to stale "this" still being a parent of one of its childs.
therefore we have to loop the chunks again.
2017-02-14 21:16:10 +11:00
Tim Sebastian 4438ac9880 remove "removeAndDo" and make usage inline and explicit 2017-02-14 21:16:10 +11:00
Tim Sebastian 9e60f2c302 fixup integratedSize to reflect original functionality 2017-02-14 21:16:10 +11:00
Tim Sebastian 7305593987 rename other to otherChunk 2017-02-14 21:16:10 +11:00
Tim Sebastian f062f49a70 make clearer what "parents" are 2017-02-14 21:16:10 +11:00
Tim Sebastian 3b4eb0f832 more readable variables 2017-02-14 21:16:09 +11:00
Tim Sebastian 63f0930161 simplify size calculation
add "moduleSize" calculator, add multiply and overhead helper
2017-02-14 21:16:09 +11:00
Tim Sebastian aaee63a500 make variables more readable 2017-02-14 21:16:09 +11:00
Tim Sebastian dd5eb39dd3 remove unnecessary passing of "this" argument - done via arrow functions 2017-02-14 21:16:09 +11:00
Tim Sebastian 2f58138516 remove unnecessary iteration if b.chunks is not set 2017-02-14 21:16:09 +11:00
Tim Sebastian 9f27e92d42 use replaceChunk and replaceParent in "integrate" method 2017-02-14 21:16:09 +11:00
Tim Sebastian 848b5aeb92 add two helper methods `replaceChunk` and `replaceParent`
they take an old item and a new item, remove the old item and add the new one
2017-02-14 21:16:09 +11:00
Tim Sebastian 5fa6caafd6 use method "moveModule" instead of duplicating it when integrating chunk 2017-02-14 21:16:09 +11:00
Tim Sebastian fc36ac366d use easier readable variable name in moveModule 2017-02-14 21:16:08 +11:00
Tim Sebastian 779c753baf transfer add logic for module, block, parent, chunk to prototype
bringing the "adder" logic to the prototype might be slighly better performance wise
reuse of logic for add module and block, though they now have one superfluous check (should be negligable though)
2017-02-14 21:16:08 +11:00
Tim Sebastian 071b504a84 merge iteration of parent and sub chunks
merge and document iteration over parent and subchunks in remove method
this will slightly increase performance for removing chunks as it only
iterates once over all chunks and parents'
2017-02-14 21:16:08 +11:00
Tim Sebastian f7e9d5805f use easier to read variable names 2017-02-14 21:16:08 +11:00
Tim Sebastian 14894f065f not needed as arrow functions keep "this" 2017-02-14 21:16:08 +11:00
Tim Sebastian e0da9a8c44 the point of the arrow function is to not need a context passed in 2017-02-14 21:16:08 +11:00
Tim Sebastian 4ea380ff68 no need to add removeAndDo to the context
no one else is using it on chunks and `_` indicates its private anyways
2017-02-14 21:16:08 +11:00
Tobias Koppers 8e69a80847 code linting 2017-01-11 12:29:01 +01:00
Will Mendes a1ffb615ab refactor(Chunk): upgrade to ES6 (#3694)
* refactor(Chunk): upgrade to ES6
* test(Chunk): adding unit test for Chunk class
2017-01-04 10:17:49 -06:00
Tobias Koppers f4ab7fc7e2 more performance improvements 2016-12-14 16:22:54 +01:00
Tobias Koppers 1296c689ac bug fix for agressive merging 2016-09-07 12:37:47 +02:00
Tobias Koppers 1675a5a5ca new way to handle new ids, reuse old ids
adjusted HMR to handle id reusing
2016-07-18 00:41:26 +02:00
Tobias Koppers 79eb404257 fixes webpack/extract-text-webpack-plugin#82
fixes webpack/extract-text-webpack-plugin#115
fixes webpack/extract-text-webpack-plugin#170
2016-07-15 21:59:24 +02:00
Tobias Koppers 2f618e733a refactoring and aggressive-splitting plugin 2016-07-13 11:03:14 +02:00
Tobias Koppers 1b459d91f5 move externals into chunk with entry
fixes #2314
maybe fixes #2066
fixes #2375
fixes #1673
2016-05-05 10:13:50 +02:00
Tobias Koppers 996b6c80ae cache parent checks, check faster array for contain 2016-04-10 23:55:37 +02:00
Tobias Koppers 5bbfbae551 Merge branch 'master' into webpack-2
Conflicts:
	package.json
	test/statsCases/chunks/expected.txt
2015-07-25 13:49:14 +02:00
Tobias Koppers ea7fd67ec1 fixed #1239 2015-07-22 22:34:25 +02:00
Tobias Koppers 431a4c791c Merge branch 'master' into webpack-2
Conflicts:
	hot/dev-server.js
	hot/only-dev-server.js
	hot/poll.js
	hot/signal.js
	lib/ChunkTemplate.js
	lib/HotModuleReplacement.runtime.js
	lib/HotModuleReplacementPlugin.js
	lib/JsonpMainTemplatePlugin.js
	lib/MainTemplate.js
	lib/NormalModule.js
	lib/Parser.js
	lib/RecordIdsPlugin.js
	lib/WebpackOptionsApply.js
	lib/dependencies/RequireEnsureDependency.js
	lib/node/OldNodeWatchFileSystem.js
	lib/optimize/OccurrenceOrderPlugin.js
	package.json
2015-07-17 09:30:37 +02:00
Tobias Koppers 5cd6e7d0b3 fixed a few linting issues 2015-07-16 00:39:56 +02:00
Tobias Koppers f7d799adb4 rebeautify without spacing after keyword 2015-07-16 00:19:23 +02:00
Avi Haiat 0a340f2b1a feat(app): Beautify all lib files 2015-07-13 01:20:09 +03:00
Tobias Koppers 8cfeb51c30 refactoring and bug fixes 2015-07-07 00:11:13 +02:00
Kenny Tran 7e0a98bb29 Refactor size method for Chunks 2015-05-31 20:02:07 -07:00
Kenny Tran 9352bb8806 Fix typo in Chunk.js 2015-05-20 14:57:10 -07:00
Tobias Koppers cebd3b9722 added linting 2015-04-23 23:55:50 +02:00
Tobias Koppers 18fe8e7b66 always create files array on Chunk 2015-01-30 00:44:58 +01:00
Tobias Koppers 544c368ea1 added support for an async commons chunk, tests and examples 2015-01-11 23:15:11 +01:00
Tobias Koppers de1ea9d15e allow multiple chunks for a dependency block #640 2015-01-01 21:58:27 +01:00
Tobias Koppers e12bc992af include [chunkhash] tests again
added support for [chunkhash] with target node
2014-11-02 12:48:15 +01:00
Tobias Koppers dd232012ca Merge pull request #427 from diurnalist/feature/templated-path-plugin-sq
Add TemplatedPathPlugin to generically handle asset paths w/ template vars
2014-09-11 19:09:17 +02:00
Jason Anderson f371945a29 Add TemplatedPathPlugin 2014-09-11 15:31:08 +02:00
Tobias Koppers e0f975eb9e fixes webpack/extract-text-webpack-plugin#14 2014-09-07 22:54:38 +02:00
Tobias Koppers d80cdcefac Code Quality 2014-06-24 18:53:32 +02:00