skratchdot
6705141ef6
prevent UnhandledPromiseRejectionWarning in node 6
...
Fixes #7654
2018-07-04 11:33:27 -04:00
Tobias Koppers
ad8f496745
arrow functions, remove or improve eslint-disable comments
2018-06-27 13:48:13 +02:00
Sam Saccone
735f99c01b
Fix race condition in profiling plugin.
...
Based on some digging in this git history for the profiling plugin it looks like this commit exacerbated the issue:
883088e
Note, we are calling end() and then writeStream right after we call flush on the trace object
64b514e9bd/lib/trace-event.ts (L123)
The trace object is only calling _push to the writable stream but in no way ensuring that all data that has been pushed has actually been written to the output stream sooo we find ourselves encounter 🐎 [race] conditions.
2018-06-23 11:27:18 -07:00
Mohsen Azimi
48a1e5166e
Update "chrome-trace-event" package and remove types
2018-06-05 20:38:48 -07:00
Tobias Koppers
f2ad440de8
More strict linting of jsdocs
...
Use TODO over any when type is possible
2018-05-08 14:53:33 +02:00
Tobias Koppers
5f0a99e93b
declare types for chrome-trace-event
2018-04-12 11:42:41 +02:00
Tobias Koppers
a4e8c07f09
fix jsdoc comments to make eslint happy
2018-04-12 11:42:40 +02:00
Mohsen Azimi
2adf5c2b0d
Better JSDocs for makeNewProfiledTapFn
2018-04-12 11:42:40 +02:00
Mohsen Azimi
2b66263b44
TS now understands module.exports assignments
...
https://github.com/Microsoft/TypeScript/pull/23228
2018-04-12 11:42:40 +02:00
Mohsen Azimi
2295c837d0
Add ts-ignore comments with link to issue
...
https://github.com/Microsoft/TypeScript/issues/15647
2018-04-12 11:42:39 +02:00
Mohsen Azimi
5b236e53da
More type fixes (these changes should be merged as separate PRs
2018-04-12 11:42:39 +02:00
Florent Cailhol
3983803d30
Destructure 'require' to improve readability
2018-03-22 12:05:58 +01:00
Tobias Koppers
d061aba750
fix ProfilingPlugin
2018-03-20 10:11:30 +01:00
Bazyli Brzóska
bd043f8e26
fix lint
2018-03-07 21:09:09 +01:00
Bazyli Brzóska
cdeffb39b0
fix(ProfilingPlugin): only expose the end method of fsStream
2018-03-07 20:28:14 +01:00
Bazyli Brzóska
883088e521
fix(ProfilingPlugin): complete after the writeStream had finished flushing the data to the filesystem
...
Fixes a race-condition where `events.json` might not yet be available immediately after compilation.
2018-03-05 22:49:32 +01:00
Josh Soref
0a4308f1da
spelling: ourself
2018-02-26 02:38:03 +00:00
Tobias Koppers
5238159d21
run prettier on existing code
2018-02-25 02:00:20 +01:00
EugeneHlushko
f33cf76608
Improvement: add schema for profiling plugin options, remove todo item: add docs, rename option
2018-02-14 10:29:29 +02:00
EugeneHlushko
97cd2dde70
Improvement: add schema for profiling plugin options, remove todo item: abs path to false
2018-02-14 09:49:15 +02:00
EugeneHlushko
fb4b275dc9
Improvement: add schema for profiling plugin options, remove todo item
2018-02-13 19:13:07 +02:00
Martin McKeaveney
1a2d9360b4
Update ProfilingPlugin.js
2018-01-30 22:06:23 +00:00
Martin McKeaveney
6225acefbe
fixed error with importing JSON with ProfilingPlugin
2018-01-30 21:40:24 +00:00
Sam Saccone
88cdf4b6af
Manually exclude internal tap of plugin.
...
This was forcing the timestamp of the last trace to be the last event
in the JSON trace, and thus breaking the CPU profile.
Instead manually exclude this plugin from being traced to avoid this
issue.
2018-01-29 16:03:46 -08:00
Sean Larkin
d235a61412
feat(profiling): add profiling plugin
2018-01-18 19:02:27 -08:00