Commit Graph

5 Commits

Author SHA1 Message Date
Jon Wong 4650dfef44 Fixing issue where DllPlugin + code-splits caused Webpack to end without emitting chunks.
When utilizing code-splitting via a statement like `require.ensure` in addition to the `DllPlugin`, the webpack process would emit the Dll manifest, but not the chunks corresponding to that manifest.

According to [async#forEach](https://github.com/caolan/async#eacharr-iterator-callback), the callback must be called at the completion of every iteration - when utilizing code-splitting, the shortcut branch here would never call the iterator callback, which in turn meant that the `emit` callback never got called, causing the chunks generated by the Dll to not get emitted.

Adding the completion callback results in the behavior we expect - the manifest and the chunks corresponding to that manifest both get emitted.
2015-12-16 10:45:48 -08:00
Tobias Koppers f7d799adb4 rebeautify without spacing after keyword 2015-07-16 00:19:23 +02:00
Avi Haiat 0a340f2b1a feat(app): Beautify all lib files 2015-07-13 01:20:09 +03:00
Tobias Koppers 4fdf62b919 added DllReferencePlugin 2015-05-17 11:06:35 +02:00
Tobias Koppers 817e678d9a added DllPlugin and dll example 2015-05-16 18:27:59 +02:00