Tim Sebastian
e1ea0a717c
implement review feedback
2017-02-22 21:32:31 +11:00
Tim Sebastian
018ca1ad2c
improve comments
2017-02-22 00:13:21 +11:00
Tim Sebastian
61ce0f79c1
apply review feedback
2017-02-22 00:13:21 +11:00
Tim Sebastian
cc1636f141
make variable and method names clearer
2017-02-22 00:13:20 +11:00
Tim Sebastian
efa8b52293
use children option instead of `selectedChunks === false`
2017-02-22 00:13:20 +11:00
Tim Sebastian
5838f56d0f
correct comment
2017-02-21 23:47:55 +11:00
Tim Sebastian
ec736bfe21
move actual apply method to the top, to easier find where things happen
2017-02-21 23:47:55 +11:00
Tim Sebastian
c97b3de912
add better validation for options, rename async to prevent future clash with reserved words
2017-02-21 23:47:54 +11:00
Tim Sebastian
10cea76e1e
fix wrong assignment of filenameTemplate in constructor
2017-02-21 23:47:54 +11:00
Tim Sebastian
9a7a6b93bd
add comments and clean up a bit
2017-02-21 23:47:54 +11:00
Tim Sebastian
bcc10e8aa6
extract the last step of reconnecting the chunks to own methods
2017-02-21 23:47:54 +11:00
Tim Sebastian
9f18ea9b15
split up and extract default linking between modules and chunks
2017-02-21 23:46:51 +11:00
Tim Sebastian
24b8aebb74
extract reallyUsedModules creation to own simplified methods
2017-02-21 23:46:51 +11:00
Tim Sebastian
15be539d24
fix up method call
2017-02-21 23:46:51 +11:00
Tim Sebastian
24ecaf56be
cleanup unused variables
2017-02-21 23:46:50 +11:00
Tim Sebastian
3dc08aec2a
extract creation of async chunk
2017-02-21 23:46:50 +11:00
Tim Sebastian
063c54f546
extract creation of usedChunks
2017-02-21 23:46:50 +11:00
Tim Sebastian
d53c882929
extract and simplify definition of the common chunk
2017-02-21 23:46:50 +11:00
Tim Sebastian
e9ac46dc26
normalize options for commons chunk plugin
2017-02-21 23:46:50 +11:00
Tim Sebastian
952f04d90f
node v4 fails to reassignes const in for-of loops properly
2017-02-19 13:18:01 +11:00
Tobias Koppers
d7384e2f6a
removed unnecessary context argument
2017-01-25 23:11:07 +01:00
Shubheksha Jalan
8d315b1630
cleaned up some functions
2017-01-24 16:39:46 +05:30
Shubheksha Jalan
4b06eb94e9
fix merge commits
2017-01-24 16:17:12 +05:30
Tobias Koppers
8e69a80847
code linting
2017-01-11 12:29:01 +01:00
Shubheksha Jalan
bc6a6ad324
cleaned up a few functions
2017-01-10 17:18:36 +05:30
Shubheksha Jalan
15d6a5e7ea
formatted the template string to remove extra whitespace and line breaks
2017-01-10 17:18:36 +05:30
Shubheksha Jalan
1f6431e4df
refactor(ES6): changed lengthy error message string to template literal
2017-01-10 17:18:36 +05:30
Shubheksha Jalan
29bf3e72f3
refactor(ES6): upgrade CommonsChunkPlugin to ES6
2017-01-10 17:18:36 +05:30
Shubheksha Jalan
9215b6affd
refactor(ES6): upgrade CommonsChunkPlugin to ES6
2017-01-10 17:18:36 +05:30
Tobias Koppers
d0beb306ee
check chunk condition before moving into commons chunk
2016-12-14 13:59:47 +01:00
inuscript
4bf2ba46af
revert this.async (avoid may breaking change)
2016-12-07 09:43:17 +09:00
inuscript
d03203d260
change async variable name
2016-12-07 08:54:10 +09:00
inuscript
dcff8c833f
Fill available params on Deprecation notice
2016-12-06 19:55:48 +09:00
Tobias Koppers
79eb404257
fixes webpack/extract-text-webpack-plugin#82
...
fixes webpack/extract-text-webpack-plugin#115
fixes webpack/extract-text-webpack-plugin#170
2016-07-15 21:59:24 +02:00
Tobias Koppers
2f618e733a
refactoring and aggressive-splitting plugin
2016-07-13 11:03:14 +02:00
Tobias Koppers
7fdfdbd43b
correct linting
2016-06-16 01:05:17 +02:00
Max Kostow
6cbd6997d3
skip commonModules if minChunks===Infinity
2016-04-06 13:51:21 -04:00
Ian Ker-Seymer
d0c6e98dee
Use better error message for when given multiple args for CommonChunksPlugin
2016-01-21 23:01:00 -05:00
Tobias Koppers
e5c11c721e
Merge branch 'webpack-1'
...
Conflicts:
lib/optimize/CommonsChunkPlugin.js
package.json
2015-11-20 21:35:37 +01:00
Tobias Koppers
181da3c004
fixed another bug with the CommonsChunkPlugin
...
when using multiple commons chunks
other optimization plugins doesn't optimize perfectly
2015-11-20 21:29:32 +01:00
Tobias Koppers
556872b38f
fixed bug in CommonsChunkPlugin
...
when passing passing mixed existing and not existing names
2015-11-20 20:24:06 +01:00
Tobias Koppers
5879483eb1
fixed formating
2015-10-31 15:31:10 +01:00
Tobias Koppers
0f0ede8a2c
removed deprecated parameters for plugins
2015-10-28 23:26:52 +01:00
Tobias Koppers
f7d799adb4
rebeautify without spacing after keyword
2015-07-16 00:19:23 +02:00
Avi Haiat
0a340f2b1a
feat(app): Beautify all lib files
2015-07-13 01:20:09 +03:00
Kenny Tran
7edffc381d
Small refactor for getting size
...
Currently, map is being called to extract sizes then reduce is called on that; so 2 iterations through the array. It is possible to solve this with only reduce: 1 iteration. reallyUsedModules probably won't ever be big enough for this to matter, so it comes down to readability.
I think doing a once-and-done reduce could be an improvement here. What do you guys think?
2015-05-21 12:39:08 -07:00
Tobias Koppers
1679218f80
fixed CommonsChunkPlugin
...
and added two explict vendor chunks example
2015-04-29 12:46:00 +02:00
Tobias Koppers
84b34151da
emit an error when using the CommonChunksPlugin wrongly
...
#946
2015-04-26 22:47:47 +02:00
Tobias Koppers
cebd3b9722
added linting
2015-04-23 23:55:50 +02:00
Tobias Koppers
feb7c7cc49
arguments bug fix
2015-01-18 00:50:05 +01:00