I was going to change the way changed used the column name
in the update_cache_counter code. (the purpose of this branch)
Decided to roll that change back, but this test still looks good
all but one reference are updating the ancestor_ids column
This is a moot point to be honest, behind the scenes, it is just
updating the ancestors field in the database, but this gives us
some indirection so we can change the ancestor encoding scheme
Previously creating children in an after_* callback would cause the
child's ancestry column to contain just the parent id and not the entire
ancestry path.
A workaround was to call self.reload in the after_* callback, but this
commit makes the process work automatically.
The main issue looked to be that the child_ancestry method was using the
ancestry path before the save (using _was) which for new records was
obviously blank.
This revision uses the current value of the parent's ancestry, and adds
a child_ancestry_was method to return the old behaviour (with a more
descriptive name).
The change to update_descendants_with_new_ancestry was due to it relying
on the old behaviour. The revised version explicitly replaces the old
parent ancestry snippet (using child_ancestry_was) with the new one
path.
REVISED for 2.1.x version of ancestry
This logic is currently a redirect to the class level condition methods
anyway. So removing the indirection and just calling the class
methods directly
The class methods are defined by the scheme (e.g.: materialized path)
unscoped is making descendant_conditions tricky to remove
`parent` used to hold the node's `parent`. so it was called `parent`.
But now it holds the parent id.
So this PR renames the variable to ... `parent_id`
This section of code is too complicated to add the extra cognitive load
and have a confusing variable name
thanks @nicklamuro
it gets rid of a constant
it moves all the validation to one spot.
I'm thinking different strategies will have different schemes
I liked having it defined in materialized path, but wanted to get rid
of the constant more
Keenan Brock
d-m-u
Maikel Linke
d-m-u
Michael Moll
Michael Yagudaev
Daniel Tamai
Jason Stirk
Denny Mueller