David Capello
681ee811ce
Fix several problems inserting/handling emojis with variation selector
...
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
Inserting an emoji with a variation at the end of a line was
introduced a lot of issues (saving the Widget text with the variation
in another place/line).
2025-10-09 12:01:15 -03:00
David Capello
9991566265
Avoid advancing the caret when a variant/hidden unicode char is pasted
...
This fixes some asserts failing in TextEdit where the caret might be
outside the valid range just because we advance the caret one glyph
when in reality the inserted unicode string is a hidden char/variant.
2025-10-09 09:30:57 -03:00
David Capello
66cb997abb
Don't depend on hard-coded ui::Style layers for TextEdit colors
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
2025-10-08 17:44:46 -03:00
David Capello
f6fbe6a8fb
Fix crash deleting w/backspace from the last (empty) line
2025-10-08 17:44:46 -03:00
David Capello
23e9e81922
Using Up/Down key in the first/last line goes to BOL/EOL
2025-10-08 17:44:46 -03:00
David Capello
c31381e875
Minor refactors
2025-10-08 17:44:46 -03:00
David Capello
5d89d84eaa
Fix caret position to ensure proper caret scrolling/IME position
2025-10-08 17:44:46 -03:00
David Capello
d1c87035af
Remove ASSERT() that can fail if we paste a RTL text
2025-10-08 17:44:46 -03:00
David Capello
63771afc7d
Match text caret size with Entry widget
2025-10-08 17:44:46 -03:00
David Capello
3759319971
Use gfx::RectF instead of gfx::Rect for text line bounds
2025-10-08 17:44:46 -03:00
David Capello
596099d67c
Fix TextEdit selection bounds for multiple lines
...
If we select from the beginning of a line to the previous line the
selection painting process was including the first character of the
line where we started, but it shouldn't be included (as the cursor
started in pos=0).
2025-10-08 17:44:46 -03:00
David Capello
5c92df05de
Fix TextEdit::caretFromPosition() when lines have different heights
2025-10-08 17:44:46 -03:00
David Capello
1fb4be5569
Invalidate all blobs after changing theme
...
We've moved the InitTheme code from the InitTheme.connect() signal to
the onInitTheme() member function.
2025-10-08 17:44:46 -03:00
David Capello
2beb1954e7
Implement "selection by words" after double-clicking
...
This is the same behavior as in ui::Entry widget.
2025-10-08 17:44:46 -03:00
David Capello
38ac7cd4d1
Improve caret/char selection with the mouse
2025-10-08 17:44:46 -03:00
David Capello
2426a1dcbe
Fix caret position when a line has multiple runs (e.g. there's an emoji present)
2025-10-08 17:44:46 -03:00
David Capello
c54cb332fe
Jump between words correctly with Ctrl+Left/Right
2025-10-08 17:44:46 -03:00
David Capello
cdbf7ec585
Change size_t to int for position/line numbers
2025-10-08 17:44:46 -03:00
David Capello
943b14b511
Fix End key to go to EOL and added Ctrl+Home/End to go to BOF/EOF
2025-10-08 17:44:46 -03:00
David Capello
5a6baf8663
Enter from the numeric keypad can be used for new lines too
2025-10-08 17:44:46 -03:00
David Capello
f96e0efd3c
We cannot bypass onSetText() as ui::Entry requires this
...
Without this fix, "Run Command" will crash.
2025-10-08 17:44:46 -03:00
Christian Kaiser
fb21298f83
User data with multiple lines of text (new TextEdit widget) ( #3130 , #3131 , #4743 , #4968 )
2025-10-08 17:44:46 -03:00
David Capello
2bd378fb7e
Merge branch 'main' into beta
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
2025-10-08 17:43:49 -03:00
David Capello
323242a0c4
[lint_commit] Increment to 100 columns for commit text to match clang-format
build-auto / build-auto (Debug, macos-latest) (push) Waiting to run
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Waiting to run
Details
build-auto / build-auto (Debug, windows-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Waiting to run
Details
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
2025-10-08 17:39:27 -03:00
David Capello
11158b8260
Fix crashes due buggy third-party IMEs or comctl32.dll bugs ( fix #4150 , fix #4412 )
2025-10-08 16:42:34 -03:00
Gaspar Capello
95d0dee4e0
Fix move tool with Auto Select Layer isn't working ( fix #4812 )
...
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
Prior to this fix, automatic layer selection for the Move Tool
did not work when the "Compose Groups Separately" option was active.
Related PRs: #5438 , #5439
2025-10-07 11:00:45 -03:00
David Capello
7ee486ebde
[clang-tidy] Avoid showing comments about boolean simplifications by DeMorgan's theorem
...
This is quite common for ASSERT(condition), which is a macro with !(condition)
2025-10-07 08:45:01 -03:00
David Capello
1b16cfbe71
Merge branch 'main' into beta
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
2025-10-07 08:06:10 -03:00
David Capello
d3ef5c61da
Update laf module
2025-10-07 08:05:18 -03:00
David Capello
107e846911
Remove direct TRACEARGS() calls
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
2025-10-01 16:53:07 -03:00
David Capello
6c7544a132
Merge branch 'main' into beta
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
2025-09-30 08:38:03 -03:00
David Capello
577caa4793
Reword action names when dropping files/images onto the timeline
build / build (Debug, macos-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, lua, cli) (push) Has been cancelled
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Has been cancelled
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Has been cancelled
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Has been cancelled
Details
2025-09-30 08:26:44 -03:00
David Capello
f3a372e78e
Fix div by zero crash dropping image ( fix #5447 )
2025-09-30 08:24:50 -03:00
David Capello
11df0bc877
Merge branch 'main' into beta
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
2025-09-29 19:04:14 -03:00
Joshua Lopez
41e5097c33
Fix mouse gestures not working after switching tabs (fix aseprite#4388)
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
2025-09-29 18:06:45 -03:00
Christian Kaiser
cf290b7679
Check mask validity before pasting ( fix #5361 )
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
2025-09-29 11:32:39 -03:00
David Capello
d7b2faca6d
Fix crash painting deleted cels while applying filter ( fix #4991 )
...
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
build-auto / build-auto (Debug, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (Debug, windows-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Has been cancelled
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Has been cancelled
Details
This could happen in the Editor::onPaint() or Timeline::onPaint().
2025-09-24 16:36:34 -03:00
David Capello
fa0b25fe87
Merge branch 'main' into beta
build-auto / build-auto (Debug, macos-latest) (push) Waiting to run
Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Waiting to run
Details
build-auto / build-auto (Debug, windows-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Waiting to run
Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Waiting to run
Details
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run
Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run
Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run
Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run
Details
2025-09-22 09:06:19 -03:00
David Capello
f26ce64208
[lua] Update scripting API version to 36
2025-09-22 09:04:57 -03:00
David Capello
e39dc90001
[lua] Enclose key names for plugin preferences with ["..."] when it's required ( #5412 )
2025-09-19 15:27:00 -03:00
Martín Capello
8f0dea0988
Avoid syntax errors reading extension preferences
...
Fix #5412 by using brackets and double quotes to enclose the name of
the preferences' properties and avoid issues when they contain unicode
chars
2025-09-19 14:58:35 -03:00
Christian Kaiser
6f1870cff3
Add Run Command
2025-09-18 21:25:13 -03:00
David Capello
e8f18087e5
Update laf module
2025-09-18 20:47:56 -03:00
David Capello
d8ac1a7a9e
Update laf and add new libxrandr dependency
2025-09-17 09:15:35 -03:00
Aiden J Erickson
5cfa75ab3f
[multimon] allow windows to open in non-default workareas ( #4560 , #5426 )
...
Fix issue below:
In multi-monitor setups, native windows, e.g. the preview window, will,
when re-opened, be moved/clamped to the monitor of the main aseprite
window even if the re-opened window was previously and explicitly moved
to a different monitor.
2025-09-16 20:42:21 -03:00
David Capello
94174509a4
Merge branch 'main' into beta
2025-09-16 17:35:06 -03:00
David Capello
c444b566e1
Fix painting UI theme colors as they are specified in sRGB color space
...
Fixes a regression found after merging #5414 :
https://github.com/aseprite/aseprite/pull/5414#issuecomment-3286339563
We always expected a sRGB color in ui::Graphics API and we can specify
a color in another color space using the ui::Paint version of its
member functions.
Several functions related to color spaces are now using a ui::Display
to receive the specific display where we're going to paint, instead of
using os::System::instance()->defaultWindow()->colorSpace().
2025-09-16 09:42:35 -03:00
David Capello
5d5f3ec234
Convert AppShortcut in a ui::Shortcut subclass
2025-09-12 15:48:38 -03:00
David Capello
71e680e05a
Refactor key context matching ( fix #5390 )
...
* Added AppShortcut::fitsBetterThan() to compare shortcuts and decide
which one is better depending on the current key context and the ones
where shortcuts are defined
* Added Key::fitsContext() to known if this key definition makes sense
for a given current key context, e.g. Normal context can be used in
SelectionTool context, and SelectionTool can be used in Transformation
* Added KeyboardShortcuts::findBestKeyFromMessage() to centralize the
keyboard shortcuts matching moving some code from
CustomizedGuiManager::processKey()
* Added more keyboard shortcuts tests (including some for #5390 )
2025-09-12 15:41:08 -03:00
David Capello
df5dcdc1d9
Add some KeyboardShortcuts basic tests
2025-09-12 15:07:26 -03:00