Nalin Dahyabhai
7aedebdccd
modernize: JSON doesn't do "omitempty" structs, so stop asking
...
Drop the "omitempty" tag from the "json" tag on struct members that are
themselves structs, since the JSON encoder doesn't actually do that, per
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-10 13:19:38 -04:00
Nalin Dahyabhai
802b069799
modernize: use maps.Copy() instead of iterating over a map to copy it
...
Use maps.Copy() instead of iterating over a map's keys and values to
copy the keys and values to a new map. Overdue from
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-10 13:19:34 -04:00
Nalin Dahyabhai
16680a4dfd
modernize: use strings.CutPrefix/SplitSeq/FieldsSeq
...
Use the CutPrefix(), SplitSeq(), and FieldsSeq() functions from the
strings package when chopping up or iterating over parts of strings, per
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-10 13:11:00 -04:00
Nalin Dahyabhai
ebc9b40491
Update expected/minimum version of Go to 1.24
...
Update the version of Go we suggest in go.mod to 1.24, and update the
one we use for the vendoring CI test to match.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-10 13:02:47 -04:00
openshift-merge-bot[bot]
f297289c72
Merge pull request #6357 from containers/renovate/go-github.com-ulikunitz-xz-vulnerability
...
Update module github.com/ulikunitz/xz to v0.5.15 [SECURITY]
2025-09-02 20:24:12 +00:00
renovate[bot]
95591dbc85
Update module github.com/ulikunitz/xz to v0.5.15 [SECURITY]
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-02 19:49:53 +00:00
openshift-merge-bot[bot]
6cfceff318
Merge pull request #6364 from containers/renovate/github.com-openshift-imagebuilder-1.x
...
Update module github.com/openshift/imagebuilder to v1
2025-09-02 19:47:57 +00:00
Nalin Dahyabhai
dd4f9fcd69
Update go.sum
...
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-02 15:15:12 -04:00
Nalin Dahyabhai
7c0c647d61
New VM images
...
Update the version of the VM image set that we use for running tests.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-09-02 14:54:37 -04:00
renovate[bot]
ac85735250
Update module github.com/openshift/imagebuilder to v1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-02 17:49:39 +00:00
openshift-merge-bot[bot]
7c85fac480
Merge pull request #6363 from containers/renovate/github.com-spf13-cobra-1.x
...
Update module github.com/spf13/cobra to v1.10.1
2025-09-02 17:34:09 +00:00
renovate[bot]
3acceccf63
Update module github.com/spf13/cobra to v1.10.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-01 23:47:50 +00:00
openshift-merge-bot[bot]
3367a9bc2c
Merge pull request #6356 from jankaluza/monorepo2
...
Switch common, storage and image to monorepo.
2025-08-29 13:53:44 +00:00
Jan Kaluza
a0a9ac6380
Switch common, storage and image to monorepo.
...
Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
2025-08-29 15:04:28 +02:00
openshift-merge-bot[bot]
50d9584c1e
Merge pull request #6353 from nalind/tags-and-digests
...
Handle tagged+digested references when processing --all-platforms
2025-08-27 17:34:12 +00:00
openshift-merge-bot[bot]
3acac6bf75
Merge pull request #6355 from containers/renovate/github.com-stretchr-testify-1.x
...
Update module github.com/stretchr/testify to v1.11.1
2025-08-27 16:03:28 +00:00
renovate[bot]
c448438efd
Update module github.com/stretchr/testify to v1.11.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-27 15:16:33 +00:00
openshift-merge-bot[bot]
fea4e4321a
Merge pull request #6347 from containers/renovate/go.etcd.io-bbolt-1.x
...
Update module go.etcd.io/bbolt to v1.4.3
2025-08-27 14:44:40 +00:00
renovate[bot]
57c9d52c64
Update module go.etcd.io/bbolt to v1.4.3
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-26 13:54:01 +00:00
openshift-merge-bot[bot]
264309dc10
Merge pull request #6350 from containers/renovate/github.com-stretchr-testify-1.x
...
Update module github.com/stretchr/testify to v1.11.0
2025-08-25 22:11:31 +00:00
Nalin Dahyabhai
c4cfbcda8d
Handle tagged+digested references when processing --all-platforms
...
When checking the platforms of the base images, if we encounter a
reference which includes both a tag and a digest, work around it like
the pull logic does: try it without the tag.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-25 15:18:53 -04:00
renovate[bot]
fc8d434820
Update module github.com/stretchr/testify to v1.11.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-24 18:04:01 +00:00
openshift-merge-bot[bot]
08775076a2
Merge pull request #6346 from nalind/add-transient-store
...
Add --transient-store global option
2025-08-20 18:56:43 +00:00
Nalin Dahyabhai
b436176d4a
Add --transient-store global option
...
Add another global storage configuration option.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-18 15:11:35 -04:00
openshift-merge-bot[bot]
b7de827961
Merge pull request #6341 from nalind/add-imagestore-flag
...
Support "--imagestore" global flags
2025-08-15 23:38:01 +00:00
openshift-merge-bot[bot]
33739efe61
Merge pull request #6328 from mtrmac/tls
...
Losen the dependency on go-connections/tlsconfig
2025-08-14 19:45:01 +00:00
openshift-merge-bot[bot]
e1bbbc2747
Merge pull request #6340 from nalind/mount-image-fails-with-imagestores
...
Mount image fails with imagestores
2025-08-14 15:02:31 +00:00
openshift-merge-bot[bot]
dc14545a80
Merge pull request #6339 from mohanboddu/community_manager
...
Adding mohanboddu as community manager to MAINTAINERS.md
2025-08-14 04:05:29 +00:00
Nalin Dahyabhai
fc748f85a4
Support "--imagestore" global flags
...
Add the global --imagestore flag to the buildah command and to the copy
and imgtype test helpers.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-13 21:25:19 -04:00
Nalin Dahyabhai
a20e25136f
Commit: don't depend on MountImage(), because .imagestore
...
Fall back to creating a new builder with it if MountImage() fails on the
base image, because when the store is configured with its "imagestore"
option, that can happen.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-13 21:22:23 -04:00
Mohan Boddu
13db28cdbd
Adding mohanboddu as community manager to MAINTAINERS.md
...
Since I am a community manager for podman. I would like to add myself to the community manager role, as per https://github.com/containers/podman/blob/main/GOVERNANCE.md#maintainers-file , specifically "The MAINTAINERS.md file in the main Podman repository is used for project-spanning roles, including Core Maintainer and Community Manager."
https://github.com/containers/podman/blob/main/MAINTAINERS.md
Signed-off-by: Mohan Boddu <mboddu@redhat.com>
2025-08-13 15:05:32 -04:00
openshift-merge-bot[bot]
3ca907f7e4
Merge pull request #6332 from nalind/exclude-pull-ups-take-three
...
Rework how we decide what to filter out of layer diffs
2025-08-13 15:44:31 +00:00
Nalin Dahyabhai
69a50588c5
Rework how we decide what to filter out of layer diffs
...
After narrowing down the list of parent directories which we might need
to exclude to those which are present in the base image, filter them out
of the layer diff as it is generated.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 15:49:28 -04:00
Nalin Dahyabhai
bf2cbe1645
Note that we have to build `true` first for the sake of its tests
...
Add a note that we need a test binary built for the sake of a few
conformance tests, for people who run the conformance tests directly
instead of using the top-level makefile target.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 15:49:28 -04:00
Nalin Dahyabhai
473656b9dd
copier.Stat(): return owner UID and GID if available
...
Return owner information for items that we've stat'ed.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 15:49:28 -04:00
Nalin Dahyabhai
738fa0d3c4
copier.Get(): ensure that directory entries end in "/"
...
Make sure that entries with Typeflag == TypeDir always end with a "/",
adding it as a suffix.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 14:10:16 -04:00
Nalin Dahyabhai
9461dd61d4
copier.Get(): strip user and group names from entries
...
When generating archives, clear user and group names to keep up with
recent changes to the storage library.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 14:10:16 -04:00
Nalin Dahyabhai
fd498cbf5d
imagebuildah.Executor/StageExecutor: check numeric --from= values
...
When we look up a stage that's referred to in a COPY --from argument,
treat the string as a stage number not only if it parses as one, as we
checked before, but now also require that the number correspond to one
of the stages that would be completed before the one into which the
content will be copied.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-11 14:10:16 -04:00
openshift-merge-bot[bot]
03da7d83c2
Merge pull request #6326 from containers/renovate/golang.org-x-crypto-0.x
...
fix(deps): update module golang.org/x/crypto to v0.41.0
2025-08-08 15:12:56 +00:00
Miloslav Trmač
fceb8d9edf
Losen the dependency on go-connections/tlsconfig
...
As of go-connections 0.6.0, there is no difference between
"server" and "client" configuration; so, take this opportunity
to switch from "server" defaults in client contexts, which were used
for an unknown reason.
Also, don't use the whole tlsconfig.ClientDefault(), to _slightly_
move into the direction of using the Go built-in defaults, and to
get a _bit_ closer to getting out of the business of managing TLS policy.
Should not change behavior (but the update from go-connections 0.5.0
to 0.6.0 did change the list of accepted TLS 1.2 cipher suites).
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-08-08 16:23:01 +02:00
renovate[bot]
e78c0ad5a8
fix(deps): update module golang.org/x/crypto to v0.41.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-07 19:22:54 +00:00
openshift-merge-bot[bot]
f5aed1996b
Merge pull request #6324 from containers/renovate/github.com-docker-go-connections-0.x
...
fix(deps): update module github.com/docker/go-connections to v0.6.0
2025-08-07 19:21:52 +00:00
openshift-merge-bot[bot]
3ed1f56608
Merge pull request #6325 from containers/renovate/golang.org-x-term-0.x
...
fix(deps): update module golang.org/x/term to v0.34.0
2025-08-07 18:58:02 +00:00
renovate[bot]
b49f0e2a57
fix(deps): update module golang.org/x/term to v0.34.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-07 16:46:18 +00:00
renovate[bot]
494fd9dfae
fix(deps): update module github.com/docker/go-connections to v0.6.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-07 15:12:35 +00:00
openshift-merge-bot[bot]
3ed8ff91a7
Merge pull request #6314 from nalind/no-more-instructions
...
imagebuildah.StageExecutor.Execute: commit more "no instructions" cases
2025-08-07 15:11:29 +00:00
openshift-merge-bot[bot]
f753f46ac4
Merge pull request #6307 from nalind/reap
...
Run: reap stray processes
2025-08-07 15:08:26 +00:00
openshift-merge-bot[bot]
d31fe58f41
Merge pull request #6310 from nalind/copy-dest-dot
...
copy: assume a destination with basename "." is a directory
2025-08-07 14:59:34 +00:00
openshift-merge-bot[bot]
e4097e80eb
Merge pull request #6323 from containers/renovate/golang.org-x-sys-0.x
...
fix(deps): update module golang.org/x/sys to v0.35.0
2025-08-07 13:44:50 +00:00
renovate[bot]
4912cf45d8
fix(deps): update module golang.org/x/sys to v0.35.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-07 12:42:08 +00:00