Commit Graph

1926 Commits

Author SHA1 Message Date
Kevin Ring 6ba15b9628 Fix test failure on ARM64 macOS.
The test was moving the camera in such a way that that the tile was no longer in the view frustum. The only reason it was passing on any platform was because the camera would still be just inside the tile, and so the rule that we don't cull tiles under the camera would apply. But on ARM64 macOS, the camera ends up being very very slightly outside the tile instead of very slightly inside, and so the test fails.

The change here is to keep the tile inside the frustum, as was intended in the first place.
2025-05-19 16:41:46 +10:00
Kevin Ring 7ec3d23632 Apply typo fixes. 2025-05-19 10:00:09 +10:00
Kevin Ring 4a433d46dd Require TileID to Tile constructors taking content.
This way the content reference count, which is only added when the tile
has an ID, can be correctly accounted for.
2025-05-16 14:55:01 +10:00
Janine Liu 3560039c0d Include Tile.h in header 2025-04-29 12:00:48 -04:00
Janine Liu 2dcabd69a8 Remove calls to ViewState::create 2025-04-29 10:24:44 -04:00
Janine Liu c0fd95bb68
Merge branch 'main' into multiple-views 2025-04-29 10:05:47 -04:00
Kevin Ring f7904505c8
Merge pull request #1135 from CesiumGS/orthographic
Orthographic
2025-04-29 14:10:52 +10:00
Janine Liu d861c19639
Merge branch 'main' into i3dm-empty-error 2025-04-28 13:54:13 -04:00
Tim Moore f8f6207324 Change incorrect comment 2025-04-28 17:59:14 +02:00
Janine Liu 70b97bb614 Fix failing unit test 2025-04-28 11:30:03 -04:00
Janine Liu fc83ace731
Merge branch 'main' into multiple-views 2025-04-28 10:06:54 -04:00
Janine Liu 0ca412f0be
Merge pull request #1148 from CesiumGS/bounding-volume-load-thread
Pass tile bounding volumes to `prepareInLoadThread`
2025-04-28 09:57:01 -04:00
Kevin Ring e5c0fa81d0 Merge remote-tracking branch 'origin/main' into orthographic 2025-04-28 16:05:51 +10:00
Kevin Ring cd5d4afe24 Merge remote-tracking branch 'origin/main' into multiple-views 2025-04-28 14:10:59 +10:00
Ashley Rogers bd1dc40616 Update doc comment 2025-04-25 12:00:58 -04:00
Ashley Rogers 14ced693a1 Merge from main 2025-04-25 11:52:54 -04:00
Tim Moore eed64b15c0 Remove unused include of CesiumGeospatial/Cartographic.h
Caught by clang-tidy
2025-04-25 12:16:11 +02:00
Tim Moore 099d8c14ca Add change log note and run format 2025-04-25 10:56:33 +02:00
Tim Moore 9eed8f6879 Add test case
Thanks to @javagl for the test case
2025-04-24 18:51:55 +02:00
Janine Liu ad575e3636
Merge pull request #1160 from CesiumGS/multiple-views-more
Multiple views: Some final improvements from review
2025-04-24 11:27:33 -04:00
Janine Liu 8a430741bc
Use hasReferencingContent in assert 2025-04-24 10:28:10 -04:00
Kevin Ring 0a939838cc Clear raster overlays attached to non-render content. 2025-04-24 20:47:13 +10:00
Kevin Ring d94e7d4865 Merge remote-tracking branch 'origin/multiple-views-one-reference-count' into multiple-views-more 2025-04-24 13:22:36 +10:00
Kevin Ring ce2c0b482b Address review comments. 2025-04-24 13:18:28 +10:00
Janine Liu bec1332b48
Update doc for correct method 2025-04-23 16:41:29 -04:00
Tim Moore 47546bc4b6 Deprecate ViewState::create functions in favor of constructors 2025-04-23 19:07:10 +02:00
Tim Moore 8852b81214 Merge branch 'main' into orthographic 2025-04-23 18:41:59 +02:00
Kevin Ring 87c9ae7465 Doc improvements. 2025-04-23 20:58:49 +10:00
Kevin Ring cc4e1a537c Deprecate updateView / updateViewOffline. 2025-04-23 20:48:40 +10:00
Kevin Ring 6107fecb19 Add updateViewGroupOffline method. 2025-04-23 17:44:35 +10:00
Kevin Ring 74b919d410 Merge remote-tracking branch 'origin/multiple-views' into multiple-views-one-reference-count 2025-04-23 15:47:06 +10:00
Kevin Ring c6c498eec1 Merge remote-tracking branch 'origin/main' into multiple-views 2025-04-23 15:46:32 +10:00
Kevin Ring 37cbd9c3bb clang-tidy. 2025-04-17 21:16:02 +10:00
Kevin Ring c19cbe1633 Clang-tidy 2025-04-17 19:46:04 +10:00
Kevin Ring 4d2241d3db Fix clang warnings. 2025-04-17 18:14:53 +10:00
Kevin Ring 4de9c081fb More cleanup. 2025-04-17 18:03:14 +10:00
Kevin Ring 463b91bdd3 Add some doc, simplify some logic. 2025-04-17 17:54:51 +10:00
Kevin Ring 6415b9a29f Remove unnecessary changes. 2025-04-17 17:46:41 +10:00
Kevin Ring ba8d790013 Fix assertion failure.
Caused by tiles that are not eligible for unloading still being loaded
when cleared.
2025-04-17 17:19:56 +10:00
Kevin Ring 00c575d1b5 More ref count cleanup, fix tests. 2025-04-17 15:40:10 +10:00
Kevin Ring a973df464b Keep TilesetContentManager alive while Tiles are alive. 2025-04-17 10:53:01 +10:00
Kevin Ring 9a4a3e3e78 Revert "Remove CESIUM_DEBUG_TILE_UNLOADING."
This reverts commit 6ee6210f78.
2025-04-16 15:53:44 +10:00
Kevin Ring 79bfe21186 Add some assertions. 2025-04-16 15:53:12 +10:00
Kevin Ring 0b0cb86831 clang-tidy 2025-04-15 18:32:30 +10:00
Kevin Ring 23fc5b27ab Comment tweak. 2025-04-15 17:52:41 +10:00
Kevin Ring 5fc9ed5dae Rename functions. 2025-04-15 17:49:14 +10:00
Kevin Ring 4f29c7b734 Assert that content isn't set twice. 2025-04-15 17:44:05 +10:00
Kevin Ring a2657e356b Remove rambling and redundant comment. 2025-04-15 17:30:14 +10:00
Kevin Ring 6ee6210f78 Remove CESIUM_DEBUG_TILE_UNLOADING.
Unfortunately there's no good way to support this sort of thing, now
that almost all of the reference counting is managed by
IntrusivePointer.
2025-04-15 17:25:42 +10:00
Kevin Ring 841344831b Hold IntrusivePointer during Tile loading. 2025-04-15 17:02:22 +10:00
Kevin Ring 41889dcfee Tile::Pointer and other cleanup. 2025-04-15 16:55:18 +10:00
Kevin Ring 818e4fccc3 More reference counting doc. 2025-04-15 16:12:54 +10:00
Kevin Ring 6e4b13f994 Fix clang-tidy warnings. 2025-04-14 19:33:37 +10:00
Kevin Ring c31e1da475 Fix broken link in doc. 2025-04-14 19:31:07 +10:00
Kevin Ring a6e9fde01d Only store one reference count on Tile. 2025-04-14 17:27:36 +10:00
Kevin Ring 3da6ea131b Improvements from review. 2025-04-11 18:35:46 +10:00
Kevin Ring 3dd746be7c Rename _tilesAlreadyLoading -> _tilesAlreadyLoadingOrUnloading. 2025-04-11 18:20:04 +10:00
Kevin Ring 1c184ccc1b Use member function pointers instead of templates / lambdas. 2025-04-11 18:07:32 +10:00
Kevin Ring 97dcc14d2d Doc improvements. 2025-04-11 18:05:21 +10:00
Kevin Ring abb8d3370c Don't enumerate root tile if it / descendants are not loaded. 2025-04-11 17:07:34 +10:00
Kevin Ring 05e6e12060 clang-tidy warnings. 2025-04-11 15:44:01 +10:00
Kevin Ring 300804cc3f Merge remote-tracking branch 'origin/main' into orthographic 2025-04-11 08:20:39 +10:00
Kevin Ring c3da20ed40 Formatting, add missing doc. 2025-04-11 08:08:23 +10:00
Tim Moore 1230be4aca ViewState constructor for orthographic projection 2025-04-10 17:36:11 +02:00
Kevin Ring a25233bb24 Changes from review. 2025-04-10 15:46:42 +10:00
Kevin Ring b1d845611a Better TileLoadTask ordering. 2025-04-08 18:29:13 +10:00
Kevin Ring f778da7019 Tileset cleanup. 2025-04-08 17:04:21 +10:00
Kevin Ring e4e8d62368 Tile initialization cleanup. 2025-04-08 16:31:42 +10:00
Kevin Ring 2720437e09 Simplify tile enumeration. 2025-04-08 16:18:08 +10:00
Kevin Ring 1f4d3b19fd Small cleanup, mostly doc. 2025-04-08 16:05:10 +10:00
Kevin Ring c09bd48d77 Add basic TilesetViewGroup test. 2025-04-08 13:46:45 +10:00
Kevin Ring bec5ae2f01 Remove frame number from Tileset.
It only makes sense on TilesetViewGroup.
2025-04-08 10:53:20 +10:00
Kevin Ring e7b0dedaea Start progress at 0 instead of 100. 2025-04-08 07:40:11 +10:00
Kevin Ring 9c0dc55bf0 Fix clang warning. 2025-04-07 14:25:00 +10:00
Kevin Ring 91090b87c0 Test cleanup. 2025-04-07 12:26:50 +10:00
Kevin Ring 499ef058fd Add TileLoadRequester tests. 2025-04-07 12:15:49 +10:00
Kevin Ring 398ae77a1d Doc tweaks. 2025-04-04 19:13:01 +11:00
Tim Moore 733a2872c2 Only use projection matrix method 2025-04-03 19:04:36 +02:00
Kevin Ring abd17bee59 More clang-tidy. 2025-04-03 21:38:59 +11:00
Kevin Ring d64469fe21 clang-tidy. 2025-04-03 21:20:27 +11:00
Kevin Ring cea2af7d12 Fix doc problems. 2025-04-03 19:14:06 +11:00
Kevin Ring f2975cf641 Formatting. 2025-04-03 18:41:29 +11:00
Kevin Ring 9a2b6c646e Re-add the rest of the credits. 2025-04-03 18:27:47 +11:00
Kevin Ring e623a7d7cd Better TilesetViewGroup credit tracking. 2025-04-03 18:01:01 +11:00
Kevin Ring 3499deec02 Start making TilesetViewGroups update credits. 2025-04-02 20:58:50 +11:00
Kevin Ring 4141a83b59 Merge remote-tracking branch 'origin/multiple-views' into multiple-views-credits 2025-04-02 17:24:49 +11:00
Kevin Ring 260e80357c Merge remote-tracking branch 'origin/main' into multiple-views 2025-04-02 17:22:47 +11:00
Ashley Rogers 6b1c311992 Pass bounding volumes to prepareInLoadThread 2025-04-01 14:03:03 -04:00
Tim Moore 225f885d94 Remove obsolete references to dependency header directories 2025-03-31 17:06:14 +02:00
Kevin Ring 58bbb1f159 Merge remote-tracking branch 'origin/main' into vcpkg-pkg 2025-03-31 11:10:31 +11:00
Ashley Rogers 9752291586 clang-tidy fixes 2025-03-28 09:54:00 -04:00
Ashley Rogers 0a723c48df More review comments. 2025-03-28 09:25:53 -04:00
Kevin Ring e9eb9e9e7f New retained mode CreditSystem.
Not hooked up to Tileset yet.
2025-03-28 18:32:35 +11:00
Kevin Ring 4bbb7e4910 clang-tidy warnings. 2025-03-28 08:05:09 +11:00
Kevin Ring 4ca1a1145c Fix clang warning. 2025-03-27 22:41:12 +11:00
Kevin Ring 2445c498b0 Add support for querying TilesetViewGroup load progress. 2025-03-27 22:26:17 +11:00
Ashley Rogers d22bc9c2c0 clang-tidy fixes 2025-03-26 15:43:36 -04:00
Ashley Rogers bcff1e4432 Fix Doxygen issues 2025-03-26 14:27:34 -04:00
Ashley Rogers 15e68cce28 Fix rest of review issues 2025-03-26 14:22:47 -04:00
Ashley Rogers 1220a74b45 Remove EndpointResource for ion tileset loader 2025-03-25 16:03:51 -04:00