This change recommends using a regular flush instead of synced-flush in
a rolling upgrade from 7.x to 8.0. We can perform noop recoveries with a
regular flush
The test "testRecoverFromHardDeletesIndex" failed because the
"min_retained_seqno" commit tag exists after we index using a
hard-deletes engine. A hard-deletes engine must not create this
commit tag; hence we need to remove it in the test.
Relates #50415
The InternalEngine always enables soft deletes in 8.0 regardless of the
setting. We need to wait for the global checkpoint and peer recovery
retention leases to be synced in these tests.
Relates #50415
PR #44238 changed several links related to the Elasticsearch search request body API. This updates several places still using outdated links or anchors.
This will ultimately let us remove some redirects related to those link changes.
Peer recoveries become faster and use less storage (i.e., no more extra
translog) with soft-deletes. Soft-deletes has been enabled by default
since 7.0. We should make it mandatory in 8.0, so we can simplify the
logic in the engine, recoveries, and other components.
With this change, InternalEngine will always use soft-deletes regardless
of the soft_deletes settings.
testCancelRecoveryDuringPhase1 uses a mock of IndexShard, which can't
create retention leases. We need to stub method createRetentionLease.
Relates #50351Closes#50424
The docs/reference/redirects.asciidoc file stores a list of relocated or
deleted pages for the Elasticsearch Reference documentation.
This prunes several older redirects that are no longer needed and
don't require work to fix broken links in other repositories.
Unreverts the commit that added the remote info api to HLRC (#49657).
The additional change to the original PR, is that `org.elasticsearch.client.cluster.RemoteConnectionInfo` now parses the initial_connect_timeout field as a string instead of a TimeValue instance.
The reason that this is needed is because that the initial_connect_timeout field in the remote connection api is serialized for human consumption, but not for parsing purposes.
Therefore the HLRC can't parse it correctly (which caused test failures in CI, but not in the PR CI
:( ). The way this field is serialized needs to be changed in the remote connection api, but that is a breaking change. We should wait making this change until rest api versioning is introduced.
Co-Authored-By: j-bean anton.shuvaev91@gmail.com
Percentile aggregations are non-deterministic. A percentile aggregation
can produce different results even when using the same data.
Based on [this discuss post][0], the non-deterministic property stems
from processes in Lucene that can affect the order in which docs are
provided to the aggregation.
This adds a warning stating that the aggregation is non-deterministic
and what that means.
[0]: https://discuss.elastic.co/t/different-results-for-same-query/111757
Both geo_bounding_box query and geo_bounds aggregation have
a very similar definition of a "bounding box". A lot of this
logic (serialization, xcontent-parsing, etc) can be centralized
instead of having separated efforts to do the same things
We are matching on the exact number of shards in this test, but may run into
snapshotting more than the single index created in it due to auto-created indices like
`.watcher`.
Fixed by making the test only take a snapshot of the single index used by this test.
Closes#50450
Some changes had to be made in order to make the test pass due to the removal or types.
Added some more assertions. The failure description in this comment [0] indicates that the rest handler couldn't be found. The test passes now.
I plan to merge this into master and see how CI reacts, if it handles this change well then I will also unmute this test in 7 dot x branch.
Relates to #41172
0: https://github.com/elastic/elasticsearch/issues/41172#issuecomment-496993976
File scripts were removed in 6.0 with #24627.
This removes an outdated file scripts reference from the conditional clauses section of the search templates docs.
* Make ILMHistoryStore.putAsync truly async
This moves the `putAsync` method in `ILMHistoryStore` never to block.
Previously due to the way that the `BulkProcessor` works, it was possible
for `BulkProcessor#add` to block executing a bulk request. This was bad
as we may be adding things to the history store in cluster state update
threads.
This also moves the index creation to be done prior to the bulk request
execution, rather than being checked every time an operation was added
to the queue. This lessens the chance of the index being created, then
deleted (by some external force), and then recreated via a bulk indexing
request.
Resolves#50353
The camel-case `nGram` and `edgeNGram` filter names were deprecated in 6. We
currently throw errors on new indices when they are used. However these errors
are currently only thrown for pre-configured filters, adding them as custom
filters doesn't trigger the warning and error. This change adds the appropriate
exceptions for `nGram` and `edgeNGram` respectively.
Closes#50360
This commit makes the TransportRolloverAction more resilient, by having it execute
only one cluster state update that creates the new (rollover index), rolls over
the alias from the source to the target index and set the RolloverInfo on the
source index. Before these 3 steps were represented as 3 chained cluster state
updates, which would've seen the user manually intervene if, say, the alias
rollover cluster state update (second in the chain) failed but the creation of
the rollover index (first in the chain) update succeeded
* Rename innerExecute to applyAliasActions
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit adapts the version checks of the InternalComposite
serialization after the backport of #50272.
Note that this pr disables bwc tests since #50272 is not merged yet.
Jake
Nhat Nguyen
Lisa Cawley
riverbuilding
James Rodewig
Martijn van Groningen
j-bean
Nik Everett
Orhan Toy
Tal Levy
Xiang Dai
Armin Braun
Mark Vieira
Benjamin Trent
Jack Conradson
Lee Hinman
Christoph Büscher
Andrei Dan
Przemysław Witek
Igor Motov
Florian Kelbert
Jim Ferenczi
Alexander Reelsen
Alpar Torok
Yannick Welsch