100a5e4bea
Add latest changes from gitlab-org/gitlab@master
2020-05-25 21:08:00 +00:00
374cf04cf2
Add latest changes from gitlab-org/gitlab@master
2020-05-20 12:07:52 +00:00
48650fe1bf
Add latest changes from gitlab-org/gitlab@master
2020-05-18 12:08:08 +00:00
927df95cc4
Add latest changes from gitlab-org/gitlab@master
2020-05-15 12:08:28 +00:00
87f286558d
Add latest changes from gitlab-org/gitlab@master
2020-05-14 15:08:14 +00:00
17c8111494
Add latest changes from gitlab-org/gitlab@master
2020-05-07 21:09:26 +00:00
5f0e3773e9
Add latest changes from gitlab-org/gitlab@master
2020-05-06 21:10:00 +00:00
5ba0ad3da6
Add latest changes from gitlab-org/gitlab@master
2020-05-04 09:09:36 +00:00
e33f87ac0f
Add latest changes from gitlab-org/gitlab@master
2020-04-21 15:21:10 +00:00
0d83264a7a
Add latest changes from gitlab-org/gitlab@master
2020-04-15 15:09:17 +00:00
ae93b28401
Add latest changes from gitlab-org/gitlab@master
2020-04-14 21:09:52 +00:00
eaea945e03
Add latest changes from gitlab-org/gitlab@master
2020-04-06 09:09:17 +00:00
6f2065c468
Add latest changes from gitlab-org/gitlab@master
2020-03-25 15:07:47 +00:00
967812838c
Add latest changes from gitlab-org/gitlab@master
2020-03-23 18:09:25 +00:00
4cb5e5011a
Add latest changes from gitlab-org/gitlab@master
2020-03-13 09:09:23 +00:00
a325f3a104
Add latest changes from gitlab-org/gitlab@master
2020-03-02 09:07:59 +00:00
c72e5ebe99
Add latest changes from gitlab-org/gitlab@master
2020-02-27 09:09:01 +00:00
0e9eea40b6
Add latest changes from gitlab-org/gitlab@master
2020-02-11 21:08:44 +00:00
0eb3d2f799
Add latest changes from gitlab-org/gitlab@master
2020-02-06 15:09:11 +00:00
ca05512007
Add latest changes from gitlab-org/gitlab@master
2020-02-04 18:08:50 +00:00
0434f38ef1
Add latest changes from gitlab-org/gitlab@master
2020-01-31 18:09:11 +00:00
30010b161d
Add latest changes from gitlab-org/gitlab@master
2020-01-08 03:08:05 +00:00
8dafc3b65a
Add latest changes from gitlab-org/gitlab@master
2020-01-07 18:07:34 +00:00
0ba52d8e77
Add latest changes from gitlab-org/gitlab@master
2019-12-28 09:08:05 +00:00
8f1f6b374b
Add latest changes from gitlab-org/gitlab@master
2019-11-25 12:06:13 +00:00
6026bddcd5
Add latest changes from gitlab-org/gitlab@master
2019-10-31 09:06:29 +00:00
3fe9588b1c
Add latest changes from gitlab-org/gitlab@master
2019-10-30 15:14:17 +00:00
77a7772c3b
Add latest changes from gitlab-org/gitlab@master
2019-10-08 09:06:09 +00:00
45482d5a27
Add latest changes from gitlab-org/gitlab@master
2019-09-27 12:06:07 +00:00
80f61b4035
Add latest changes from gitlab-org/gitlab@master
2019-09-18 14:02:45 +00:00
5939b09fd3
Add latest changes from gitlab-org/gitlab@master
2019-09-13 15:06:04 +00:00
a1852c6675
Fix broken link to the handbook
...
- Broken link to "How to work with the distribution team"
2019-09-09 17:33:20 -05:00
53275ad1a2
What to avoid in code review
2019-09-04 10:57:10 +10:00
fda560bdb4
Add Danger bot development documentation
...
This is overdue, and some of the suggestions are embarrassing, but
this is how we actually develop Danger today.
2019-09-03 00:23:52 +00:00
cd2a503db0
Add a section of examples
...
We have a fairly good guide to Code Reviews, but can be improved
by adding a few examples of what a good code review looks like
at GitLab, specifically ones where there is a bit of back and
forth, "nit-picking," etc. This would:
+ help set expectations of newly hired engineers around what our
process looks like when it is functioning what level of scrutiny
their code will be under
+ how we have technical conversations
+ show by example how after you're done crafting a solution, there
can still be extra work done either tidying up code and/or managing
the communication and conversations about your proposed MR
2019-07-25 14:02:10 +00:00
34a5f77e77
Document database review process
...
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
2019-07-19 17:33:48 +00:00
7da80b2d36
Update numbered lists for docs standards
...
Ensure that all numbered lists use only 1. and no other numbers.
Also ensure that numbered lists use proper spacing.
2019-07-19 02:20:32 +00:00
746f547877
Fix unordered list spacing
...
Correct the spacing of unordered markdown lists
in docs, to maintain standards of documentation.
2019-07-18 01:15:58 +00:00
24a5fe6b14
Rename "discussions" to "threads" in docs
2019-07-15 06:10:32 +00:00
00780264a7
Update the installation link
...
The installation link has changed from /installation/ to /install/. This
commit will update all the remaining links that are missing.
2019-07-08 17:24:54 -05:00
942b38d5af
Require database reviews for migrations
2019-06-24 16:53:16 +00:00
8ec7ecf0bc
Use relative URLs in development docs
...
This is part of https://gitlab.com/gitlab-org/gitlab-ce/issues/61945
2019-05-27 11:13:40 -04:00
c009e23a16
Give reviewer roulette its own header in the docs
2019-04-30 10:03:53 +01:00
95dbc34e29
Refer to guidelines on when to assign MRs close to the freeze
2019-04-16 18:44:39 +02:00
0477cd00dd
Rewrite "Review turnaround time" section
2019-04-16 18:22:34 +02:00
58d3d9ce9c
Add ssot link to security reviews documentation
2019-03-25 16:56:51 +00:00
cbeab67a27
Apply suggestion to doc/development/code_review.md
2019-02-21 16:43:53 +00:00
6349a18588
Update code review guidelines
2019-02-21 12:07:30 +00:00
4e42168b09
Merge branch 'docs/zj-reviewer-guidelines' into 'master'
...
Add a soft SLA for reviewers and maintainers
See merge request gitlab-org/gitlab-ce!25192
2019-02-18 10:31:04 +00:00
633cb37e28
Improve language
2019-02-18 07:14:16 +00:00
77b2ecd2b1
Reviewer roulette via Danger
...
Make danger pick reviewers and maintainers at random, for feontend,
backend, database, etc, changes, whenever files belonging to those
teams get changed.
2019-02-13 16:41:28 +00:00
341556816c
Add a soft SLA for reviewers and maintainers
...
By setting expectations both the contributor and reviewer have more
certainty on what gets reviewed when, and at what speed changes could be
merged.
2019-02-13 13:07:09 +01:00
ceb7631ca5
Fix links to sections that were moved
2018-12-11 20:09:05 +00:00
bc3e68d537
Fix Red/Orange data link markdown
2018-11-30 15:07:06 +00:00
86bf2dd349
Merge branch 'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master'
...
Add RED data security requirement to code review
See merge request gitlab-org/gitlab-ce!23426
2018-11-29 12:11:50 +00:00
f6e51e83a5
Merge branch 'mk/author-preparation-docs' into 'master'
...
Encourage MR author preparation in Code Review Guidelines documentation
See merge request gitlab-org/gitlab-ce!23360
2018-11-29 09:58:41 +00:00
62fd842c65
Add RED data security requirement to code review
...
closes #8608
2018-11-28 15:19:45 -05:00
59b4db7f2c
Encourage MR author preparation
2018-11-28 10:37:17 -08:00
cbfd6aced3
Left shift security in our workflow
2018-11-28 11:05:01 +00:00
367a0e8914
Clearer docs when it is OK for maintainer to squash
2018-11-27 11:55:01 +01:00
20146580a0
Resolve Markdown ordered lists not conforming to styleguide
2018-11-13 10:53:38 +10:00
a9b3f0811a
Includes the way approvals are handled to the documentation
2018-11-06 08:23:14 +00:00
2a631de547
Strongly recommend involving a domain expert, especially when in doubt.
2018-10-17 17:38:45 +00:00
a706b3735e
Merge branch 'master' into 'dm-document-role-maintainer'
...
# Conflicts:
# doc/development/code_review.md
2018-10-16 22:39:33 +00:00
90056ed25b
Clarify responsibilities of MR author and maintainer based on feedback.
2018-10-16 22:31:27 +00:00
5fa781ecf7
Fix "ready for review" link
...
Remove assignee_id=0 condition from search filters, we agreed
that just presence of "ready of review" label is sufficient
for filtering MRs, no need to unassign yourself.
2018-10-16 13:33:25 +02:00
189f366b9c
Add documentation how to assign a merge request for review
2018-10-15 13:16:46 +02:00
eb0ded1d90
Rewrite guidance on getting your merge request reviewed, approved, and merged
2018-10-10 10:48:14 +00:00
a1e267dc75
Document the role of the maintainer
2018-10-09 17:20:29 +00:00
88e3d76d16
Update code_review.md to include a recommendation for assigning maintainers from different teams
...
Improve recommended maintainer docs
2018-09-12 14:29:50 +01:00
b0be58a1b3
Resolve "CE documentation is not CommonMark compliant"
2018-09-06 16:52:18 +00:00
146279b53a
Fixed broken link to build team in documentation
2018-05-30 11:12:09 +00:00
07adee306e
Add Code Review documentation that maintainers also perform code review
2018-05-11 11:24:05 -05:00
8284118f36
Move footnote from CONTRIBUTING.md to doc/development/code_review.md
...
A section was moved in f644b8c8
2018-05-11 11:23:12 -05:00
9ba8685ea7
Merge branch 'master' into 'docs-specific-review-examples'
...
# Conflicts:
# doc/development/code_review.md
2017-08-01 18:23:36 +00:00
0430007ec8
Add code review guidelines related to Build [CI skip].
2017-08-01 14:01:48 +00:00
c4e7875d29
Add note about UX paradigm
2017-07-31 15:19:51 -05:00
fac3c91728
Add specific code review guidelines
2017-07-31 14:00:52 -05:00
e597fa613d
Add GitLab-specific concerns to code review guide
2017-07-24 14:12:39 +01:00
4b463dcb8d
Fix links in code review docs
2017-05-09 14:41:06 +01:00
38c29f8775
Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-04 09:02:39 +02:00
f644b8c80a
Improve the Code review guidelines documentation
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-03 18:25:20 +02:00
a084437b5c
Rename builds to jobs in docs
...
[ci skip]
2017-02-15 12:12:35 +01:00
e2585e642a
Rename endboss -> maintainer, miniboss -> reviewer
...
We want to describe these roles in a way that is more understandable to
people not familiar with GitLab.
2017-01-13 16:12:02 +00:00
0f90fd639c
Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master'
...
Rename MWBS service to Merge When Pipeline Succeeds
## What does this MR do?
This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675 .
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md ) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md )
- [x] All builds are passing
## What are the relevant issue numbers?
Closes #23354
See merge request !7135
2016-12-05 11:07:57 +00:00
ebef1a8441
Remove change to MWBS in code review guideline
...
[ci skip]
2016-12-02 08:55:53 +01:00
85c4aa4a67
Copy-edit text about right balance in code reviews
...
[ci skip]
2016-12-01 10:42:35 +01:00
5b052605b7
Extend code review docs with chapter about the right balance
2016-11-30 11:23:09 +01:00
c6a4f9fc5b
Update some docs to reflect MWPS name change
2016-11-21 11:27:28 +01:00
52ca9bf600
Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07 16:17:28 +02:00
2f7e28d1f7
Improve the contribution and MR review guide
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07 15:28:15 +02:00
0c6923e2d1
Re-add a note about sarcasm to the Code Review guide
...
[ci skip]
2016-04-10 22:54:44 -04:00
c7ec5929b1
First pass at a Code Review guide
...
Largely borrowed from thoughtbot's code review guide, so attribution is
included.
[ci skip]
2016-04-09 21:49:47 -04:00
GitLab Bot
David H. Wilkins
Marin Jankovski
Nick Thomas
Kerri Miller
Toon Claes
Marcel Amirault
Michel Engelen
Cindy Pallares
Andreas Brandl
Achilleas Pipinellis
Sean McGivern
Douwe Maan
James Ritchey
Marcia Ramos
Marcia Ramos
Zeger-Jan van de Weg
Michael Kozono
Philippe Lafoucrière
Rémy Coutable
Philippe Lafoucrière
Dylan Griffith
Evan Read
Dimitrie Hoekstra
Douwe Maan
Jan Provaznik
Jarka Kadlecová
Luke Bennett
Brett Walker
Eddie Stubbington
Robert Speicher
Clement Ho
Achilleas Pipinellis
Kamil Trzciński
Grzegorz Bizon