Commit Graph

293 Commits

Author SHA1 Message Date
Nick Thomas 77b2ecd2b1
Reviewer roulette via Danger
Make danger pick reviewers and maintainers at random, for feontend,
backend, database, etc, changes, whenever files belonging to those
teams get changed.
2019-02-13 16:41:28 +00:00
Zeger-Jan van de Weg 341556816c Add a soft SLA for reviewers and maintainers
By setting expectations both the contributor and reviewer have more
certainty on what gets reviewed when, and at what speed changes could be
merged.
2019-02-13 13:07:09 +01:00
Michael Kozono ceb7631ca5 Fix links to sections that were moved 2018-12-11 20:09:05 +00:00
Philippe Lafoucrière bc3e68d537 Fix Red/Orange data link markdown 2018-11-30 15:07:06 +00:00
Rémy Coutable 86bf2dd349 Merge branch 'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master'
Add RED data security requirement to code review

See merge request gitlab-org/gitlab-ce!23426
2018-11-29 12:11:50 +00:00
Marcia Ramos f6e51e83a5 Merge branch 'mk/author-preparation-docs' into 'master'
Encourage MR author preparation in Code Review Guidelines documentation

See merge request gitlab-org/gitlab-ce!23360
2018-11-29 09:58:41 +00:00
Philippe Lafoucrière 62fd842c65
Add RED data security requirement to code review
closes #8608
2018-11-28 15:19:45 -05:00
Michael Kozono 59b4db7f2c Encourage MR author preparation 2018-11-28 10:37:17 -08:00
Philippe Lafoucrière cbfd6aced3 Left shift security in our workflow 2018-11-28 11:05:01 +00:00
Dylan Griffith 367a0e8914 Clearer docs when it is OK for maintainer to squash 2018-11-27 11:55:01 +01:00
Evan Read 20146580a0 Resolve Markdown ordered lists not conforming to styleguide 2018-11-13 10:53:38 +10:00
Dimitrie Hoekstra a9b3f0811a Includes the way approvals are handled to the documentation 2018-11-06 08:23:14 +00:00
Douwe Maan 2a631de547 Strongly recommend involving a domain expert, especially when in doubt. 2018-10-17 17:38:45 +00:00
Douwe Maan a706b3735e Merge branch 'master' into 'dm-document-role-maintainer'
# Conflicts:
#   doc/development/code_review.md
2018-10-16 22:39:33 +00:00
Douwe Maan 90056ed25b Clarify responsibilities of MR author and maintainer based on feedback. 2018-10-16 22:31:27 +00:00
Jan Provaznik 5fa781ecf7 Fix "ready for review" link
Remove assignee_id=0 condition from search filters, we agreed
that just presence of "ready of review" label is sufficient
for filtering MRs, no need to unassign yourself.
2018-10-16 13:33:25 +02:00
Jarka Kadlecová 189f366b9c Add documentation how to assign a merge request for review 2018-10-15 13:16:46 +02:00
Douwe Maan eb0ded1d90 Rewrite guidance on getting your merge request reviewed, approved, and merged 2018-10-10 10:48:14 +00:00
Douwe Maan a1e267dc75 Document the role of the maintainer 2018-10-09 17:20:29 +00:00
Luke Bennett 88e3d76d16
Update code_review.md to include a recommendation for assigning maintainers from different teams
Improve recommended maintainer docs
2018-09-12 14:29:50 +01:00
Brett Walker b0be58a1b3 Resolve "CE documentation is not CommonMark compliant" 2018-09-06 16:52:18 +00:00
Eddie Stubbington 146279b53a Fixed broken link to build team in documentation 2018-05-30 11:12:09 +00:00
Robert Speicher 07adee306e Add Code Review documentation that maintainers also perform code review 2018-05-11 11:24:05 -05:00
Robert Speicher 8284118f36 Move footnote from CONTRIBUTING.md to doc/development/code_review.md
A section was moved in f644b8c8 but this got lost.
2018-05-11 11:23:12 -05:00
Clement Ho 9ba8685ea7 Merge branch 'master' into 'docs-specific-review-examples'
# Conflicts:
#   doc/development/code_review.md
2017-08-01 18:23:36 +00:00
Marin Jankovski 0430007ec8 Add code review guidelines related to Build [CI skip]. 2017-08-01 14:01:48 +00:00
Clement Ho c4e7875d29 Add note about UX paradigm 2017-07-31 15:19:51 -05:00
Clement Ho fac3c91728 Add specific code review guidelines 2017-07-31 14:00:52 -05:00
Sean McGivern e597fa613d Add GitLab-specific concerns to code review guide 2017-07-24 14:12:39 +01:00
Sean McGivern 4b463dcb8d Fix links in code review docs 2017-05-09 14:41:06 +01:00
Rémy Coutable 38c29f8775
Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-04 09:02:39 +02:00
Rémy Coutable f644b8c80a Improve the Code review guidelines documentation
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-03 18:25:20 +02:00
Achilleas Pipinellis a084437b5c Rename builds to jobs in docs
[ci skip]
2017-02-15 12:12:35 +01:00
Sean McGivern e2585e642a Rename endboss -> maintainer, miniboss -> reviewer
We want to describe these roles in a way that is more understandable to
people not familiar with GitLab.
2017-01-13 16:12:02 +00:00
Kamil Trzciński 0f90fd639c Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master'
Rename MWBS service to Merge When Pipeline Succeeds

## What does this MR do?

This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing

## What are the relevant issue numbers?

Closes #23354

See merge request !7135
2016-12-05 11:07:57 +00:00
Grzegorz Bizon ebef1a8441 Remove change to MWBS in code review guideline
[ci skip]
2016-12-02 08:55:53 +01:00
Grzegorz Bizon 85c4aa4a67 Copy-edit text about right balance in code reviews
[ci skip]
2016-12-01 10:42:35 +01:00
Grzegorz Bizon 5b052605b7 Extend code review docs with chapter about the right balance 2016-11-30 11:23:09 +01:00
Grzegorz Bizon c6a4f9fc5b Update some docs to reflect MWPS name change 2016-11-21 11:27:28 +01:00
Rémy Coutable 52ca9bf600
Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07 16:17:28 +02:00
Rémy Coutable 2f7e28d1f7
Improve the contribution and MR review guide
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-07 15:28:15 +02:00
Robert Speicher 0c6923e2d1 Re-add a note about sarcasm to the Code Review guide
[ci skip]
2016-04-10 22:54:44 -04:00
Robert Speicher c7ec5929b1 First pass at a Code Review guide
Largely borrowed from thoughtbot's code review guide, so attribution is
included.

[ci skip]
2016-04-09 21:49:47 -04:00