Commit Graph

69 Commits

Author SHA1 Message Date
GitLab Bot 7bb7a8d529 Add latest changes from gitlab-org/gitlab@master 2019-09-25 03:06:21 +00:00
Grzegorz Bizon 1068ec2e92 Merge branch '66741-remove-spec-rails_helper-rb' into 'master'
Remove spec/rails_helper.rb

Closes #66741

See merge request gitlab-org/gitlab-ce!32380
2019-09-03 13:48:17 +00:00
Markus Koller 1bccd36f04 Improve search result labels
- Use "results" instead of "blobs", "wiki blobs", "snippet blobs"
- Use "comments" instead of "notes"
- Use correct pluralization
- Don't add "1 - 10 of" if there's only one page
2019-08-30 09:49:14 +00:00
Ash McKenzie 19ff9d9899
Replace rails_helper.rb with spec_helper.rb
rails_helper.rb's only logic was to require
spec_helper.rb.
2019-08-30 12:26:18 +10:00
Heinrich Lee Yu 228833588a Fix flaky spec due to image lazy-loading 2019-08-05 11:16:25 +08:00
Sean McGivern 2b58b202e1 Remove snippet breadcrumb spec
We removed the breadcrumbs in 0def36777e.
2019-08-01 11:07:28 +01:00
Sean McGivern c4a8f45f7d Rename broken spec files
RSpec only executes files ending in _spec.rb.
2019-08-01 11:07:27 +01:00
Thong Kuah 73e848850c Add frozen_string_literal to spec/features
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-26 13:23:30 +12:00
Oswaldo Ferreira 44e1915d4f Persist tmp snippet uploads
It persist temporary personal snippets under
user/:id namespaces temporarily while creating
a upload record to track it. If an user gets removed
while it's still a tmp upload, it also gets removed.
If the tmp upload is sent, the upload gets moved to
personal_snippets/:id as before. The upload record
also gets updated to the new model type as well.
2019-06-17 11:25:40 -03:00
Thong Kuah 4ec16912b8 Autocorrect with RSpec/ExampleWording cop
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
2019-04-05 08:43:27 +00:00
Douwe Maan 63792707f9
Remove now-unnecessary md-preview class 2019-03-26 14:35:43 +01:00
Jan Provaznik 433bcf9b04 Add local markdown version
Cached markdown version is composed both from global and local
markdown version. This allows admins to bump version locally when
needed (e.g. when external URL is changed).
2019-02-06 19:46:59 +01:00
Jan Provaznik b2c70230b3 Remove Redcarpet markdown engine
This engine was replaced with CommonMarker in 11.4, it was deprecated
since then.
2019-02-04 12:48:35 +01:00
J.D. Bean fbb0fc5e87 Feature/new user snippets breadcrumbs 2018-09-24 13:36:37 +00:00
Dmitriy Zaporozhets 7f8a520f8a Unite green buttons under one css class
Rename btn-new, btn-create and btn-save to btn-success

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-09-19 13:55:48 +03:00
Brett Walker a963721f79 render using RedCarpet if legacy_render parameter is set 2018-09-05 09:19:16 -05:00
Bob Van Landuyt f1d3ea63cf Show the status of a user in interactions
The status is shown for
- The author of a commit when viewing a commit
- Notes on a commit (regular/diff)
- The user that triggered a pipeline when viewing a pipeline
- The author of a merge request when viewing a merge request
- The author of notes on a merge request (regular/diff)
- The author of an issue when viewing an issue
- The author of notes on an issue
- The author of a snippet when viewing a snippet
- The author of notes on a snippet
- A user's profile page
- The list of members of a group/user
2018-07-30 15:01:26 +02:00
Brett Walker 750af9fd32 Use proper markdown rendering for previews 2018-07-06 18:49:33 +00:00
Winnie Hellmann 3db2f32759 Enable Capybara/FeatureMethods cop 2018-07-05 06:32:05 +00:00
haseeb 99f278f6fd blank lines around expect removed 2018-03-27 14:01:21 +05:30
haseeb a0f585000f removed creating project 2018-03-19 19:26:18 +05:30
haseeb 9a304721d4 updated integration test 2018-03-19 19:00:53 +05:30
haseeb 520c93717a integration test added 2018-03-17 17:47:43 +05:30
Mike Greiling b5d5da7b6f
add InspectRequests helper automatically to :js tests 2017-11-02 10:27:15 -05:00
Mike Greiling 6c5e20c15a
update all status_code calls to use new inspect_requests helper 2017-10-26 18:48:29 +02:00
Mike Greiling 34f7e82563
add accept_confirm around "delete comment" button 2017-10-24 16:59:29 +03:00
Mike Greiling f783798825
Merge branch 'master' into sh-headless-chrome-support
* master: (113 commits)
  Introduce new hook data builders for Issue and MergeRequest
  Don't create todos for old issue assignees
  Start adding Gitlab::HookData::IssuableBuilder
  Include the changes in issuable webhook payloads
  Rename the `codeclimate` job to `codequality`
  Don't show an "Unsubscribe" link in snippet comment notifications
  Add QA::Scenario::Gitlab::Group::Create
  Removes CommitsList from global namespace
  Fix wiki empty page translation namespace not being removed
  Fixes mini graph in commit view
  Fix link to new i18n index page
  Update i18n docs
  Move i18n/introduction to i18n/index
  Resolve "Simple documentation update - backup to restore in restore section"
  Remove AjaxLoadingSpinner and CreateLabelDropdown from global namespace
  Move cycle analytics banner into a vue file
  Updated Icons + Fix for Collapsed Groups Angle
  Don't create fork networks for root projects that are deleted
  Remove executable permissions on images to make docs lint happy
  Sync up hard coded DN class in migration
  ...
2017-10-09 15:00:00 -05:00
Jacopo 0ce6785851 Replaces `tag: true` into `:tag` in the specs
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
2017-10-07 13:57:54 +02:00
Jose Ivan Vargas 5072ecc67b Replaced trigger click calls for click, also fixed ace_editor-input test 2017-09-27 13:13:07 -05:00
Jose Ivan Vargas 299213dd01 Replaced trigger calls for click, fixed click_on call 2017-09-26 10:30:26 -05:00
Stan Hu f045903541 Merge branch 'master' into sh-headless-chrome-support 2017-08-31 20:50:05 -07:00
Simon Knox bcd2135e08 fix transient test failures caused by wrong dropdown trigger 2017-08-28 16:38:26 +10:00
Stan Hu 541a082c9f Rename find('.ace_editor') -> find('.ace_text-input') to make Chrome happy 2017-08-16 02:20:39 -07:00
Stan Hu d3e8167382 Merge branch 'master' into sh-headless-chrome-support 2017-08-16 00:48:48 -07:00
Clement Ho cf55fb9b96 Merge branch '34527-make-edit-comment-button-always-available-outside-of-dropdown' into 'master'
Resolve "Make edit comment button always available outside of dropdown"

Closes #34527

See merge request !12931
2017-08-14 17:08:28 +00:00
Stan Hu b03fe23d53 Remove unsupported `network_traffic` in specs 2017-08-12 23:01:45 -07:00
Bob Van Landuyt 180de2d201 Make sure uploads for personal snippets are correctly rendered 2017-08-11 18:15:02 +02:00
Simon Knox 8858ddaf83 take edit note button out of dropdown 2017-08-10 09:37:25 +10:00
Keifer Furzland 7e113b6824 Remove superfluous type defs in specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Sean McGivern 88df076fae Merge branch '33359-pers-snippet-files-location' into 'security-9-3'
Use uploads/system directory for personal snippets

See merge request !2123
2017-07-19 22:28:27 -05:00
Robert Speicher eef068754a Merge branch 'master' into rs-sign_in 2017-07-06 12:43:51 -04:00
Rémy Coutable d9a5d92140 Merge branch '23036-replace-snippets-spinach' into 'master'
Replace 'snippets/snippets.feature' spinach with rspec

See merge request !12385
2017-07-05 15:04:05 +00:00
Alexander Randa 9651521ea7 Replace 'snippets/snippets.feature' spinach with rspec 2017-07-05 15:29:01 +03:00
Robert Speicher e939bf7be1 Change gitlab_sign_in to sign_in where possible 2017-06-29 12:18:23 -04:00
Luke "Jared" Bennett e2ea3e5c84 Resolve "Unable to access edit comment from dropdown menu in certain screen sizes" 2017-06-27 15:41:56 +00:00
Grzegorz Bizon 0430b76441 Enable Style/DotPosition Rubocop 👮 2017-06-21 13:48:12 +00:00
Robert Speicher 45fb1f9542 Change `login_as` uses to `gitlab_sign_in` 2017-06-19 18:59:01 -05:00
Eric Eastwood e51078ecfc Disable autocomplete on snippets comments
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/33594

Was supposedly fixed in MR for
https://gitlab.com/gitlab-org/gitlab-ce/issues/32086 but seeing this pop
up again
2017-06-19 13:42:12 -05:00
Luke "Jared" Bennett 32cac59727 Added more actions and report as abuse to all notes 2017-06-07 18:33:50 +00:00
Jarka Kadlecova 2e311d9d1a Support uploads for newly created personal snippets 2017-06-07 07:52:41 +02:00