Commit Graph

1981 Commits

Author SHA1 Message Date
Marcel Amirault 3af112a822 Adjust markdown linting guidelines
Move details of markdownlint mostly to the documentation
index for a SSoT, and link apropriately
2019-09-05 13:56:15 +00:00
Reuben Pereira 43d33ef824 Refactor new undo_* methods
- Move code for creating a new column from old into a function so that
it can be reused.
- Also add comments above the methods.
2019-09-05 12:15:16 +00:00
Marcel Amirault b86f8e7ec0 Change serveo link as it often goes down 2019-09-05 08:59:03 +00:00
Evan Read 38c30b3ed5 Provide guidance on how docs global navigation should be structured 2019-09-05 08:56:17 +00:00
Mark Lapierre 3ba3597501 Split tests across files for the sake of parallelization 2019-09-05 04:14:10 +00:00
Ash McKenzie 0fca70a40f Merge branch 'mj/code-review-avoid' into 'master'
What to avoid in code review

See merge request gitlab-org/gitlab-ce!32592
2019-09-05 02:28:19 +00:00
Mayra Cabrera b1fd8466eb Removes regular migrations from background ones
Specifies that background migrations should be scheduled as post
deployment migrations
2019-09-04 15:19:40 +00:00
Mayra Cabrera 6d0238a38c Updates the merge request author responsibility
Indicate it's the author's responsibility to prepare the merge request
for a database review
2019-09-04 03:09:05 +00:00
Marin Jankovski 53275ad1a2
What to avoid in code review 2019-09-04 10:57:10 +10:00
Thong Kuah 74effdcfcd Development docs: how to add Prometheus metrics
This documents the various knowledge needed to add new GitLab
self-monitoring Prometheus metrics.
2019-09-03 14:24:26 +00:00
Grzegorz Bizon 1068ec2e92 Merge branch '66741-remove-spec-rails_helper-rb' into 'master'
Remove spec/rails_helper.rb

Closes #66741

See merge request gitlab-org/gitlab-ce!32380
2019-09-03 13:48:17 +00:00
Rémy Coutable a8c4516321 Merge branch 'links-use-new-location' into 'master'
Use new location for helm charts repo

See merge request gitlab-org/gitlab-ce!32563
2019-09-03 09:24:23 +00:00
Balasankar "Balu" C 7d90f0f060
Use new location for helm charts repo
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2019-09-03 10:06:02 +05:30
Nick Thomas fda560bdb4 Add Danger bot development documentation
This is overdue, and some of the suggestions are embarrassing, but
this is how we actually develop Danger today.
2019-09-03 00:23:52 +00:00
Marcel Amirault a52f394bc5 Docs james gill contribution 2019-09-02 13:25:40 +00:00
Giorgenes Gelatti 2fb6c9f3c7 Adds basic overcommit support 2019-09-02 05:38:27 +00:00
Michael Kozono 88c6423e4a Merge branch 'remove-ignorable-column-concern' into 'master'
Remove dependency on IgnorableColumn concern

Closes #66746

See merge request gitlab-org/gitlab-ce!32427
2019-08-30 21:59:31 +00:00
Stan Hu d93b985df0 Use self.ignored_columns += instead of =
This is to accomodate prepended modules.
2019-08-30 13:15:34 -07:00
Shan e292e8e220 Fixed grammar and inconsistencies with capitalization 2019-08-30 05:56:51 +00:00
Marcel Amirault 03b152c5b9 Fix broken markdown in various docs 2019-08-30 03:29:45 +00:00
Ray Paik bfdb41be61 Merge branch 'patch-79' into 'master'
Fixed spelling

See merge request gitlab-org/gitlab-ce!32434
2019-08-30 03:19:28 +00:00
Ash McKenzie 19ff9d9899
Replace rails_helper.rb with spec_helper.rb
rails_helper.rb's only logic was to require
spec_helper.rb.
2019-08-30 12:26:18 +10:00
Evan Read 13627ca919 Merge branch 'fix-test-design-link' into 'master'
Broken Link to Test Design

See merge request gitlab-org/gitlab-ce!32279
2019-08-30 01:25:30 +00:00
Ray Paik ee18bf57f3 Merge branch 'patch-78' into 'master'
Fixed spelling

See merge request gitlab-org/gitlab-ce!32432
2019-08-29 22:41:53 +00:00
Shan be685251b0 Fixed spelling 2019-08-29 21:48:55 +00:00
Shan 9341406805 Fixed spelling 2019-08-29 21:41:42 +00:00
Shan 225fba83ca Fixed spelling 2019-08-29 21:34:41 +00:00
dineshpanda fa6f19d1f8 Remove dependency on IgnorableColumn concern 2019-08-30 02:09:13 +05:30
Mark Florian 05ec97d403 Apply review suggestions
- Reword relationship between Jest/Karma/Jasmine
- Prefer inline URLs, per the [docs]

[docs]: https://docs.gitlab.com/ee/development/documentation/styleguide.html#links
2019-08-29 06:43:25 +00:00
Marcel Amirault 27b0a870ec Update a few redirected links 2019-08-29 05:22:27 +00:00
Arun Kumar Mohan 7f15dacb55 Remove csslab 2019-08-28 05:01:15 -05:00
Achilleas Pipinellis a83f68baa7 Rename all filenames and occurrences to License Compliance
- New redirect doc/user/application_security/license_compliance/index.md
- Renaming of images.
- Some links that were pointing to the old location are fixed.
2019-08-28 06:48:58 +00:00
Evan Read 5c8545edf1 Merge branch 'docs/unlinking-emails' into 'master'
Remove a section for a now fixed bug

See merge request gitlab-org/gitlab-ce!32319
2019-08-28 06:36:58 +00:00
Achilleas Pipinellis 295b1b4d02
Remove a section for a now fixed bug
Those guidelines where based on
https://gitlab.com/gitlab-org/gitlab-docs/issues/311 which seems
to be fixed.
2019-08-28 08:10:00 +02:00
Marcel Amirault d7d218628f Fix markdown in various docs
Clean up issues that may cause the docs-lint
test to fail, such as trailing whitespace, no
EOF newline, blockquotes, etc
2019-08-28 06:06:34 +00:00
Achilleas Pipinellis 26054472e8 Merge branch 'docs-document-category-labels' into 'master'
Improve documentation of stage, group, category, feature labels

See merge request gitlab-org/gitlab-ce!32053
2019-08-27 17:04:50 +00:00
David H. Wilkins 30bc74f20d Broken Link to Test Design
- previous link
  engineering/quality/guidelines/test-engineering/test-design
  is missing and apparently should be
  engineering/quality/test-engineering/#test-heuristics
2019-08-27 08:15:18 -05:00
Evan Read 42e8bef3eb Removes trailing whitespace to fix linting 2019-08-27 11:31:43 +00:00
Rémy Coutable cc67829a07
Introduce facet labels
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27 12:24:25 +02:00
Rémy Coutable ae467503ce
Improve documentation of stage, group, category, feature labels
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-08-27 12:24:25 +02:00
Mayra Cabrera 9d5ea4203c Migrations guide: use atomic steps, when possible
Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.

But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.

To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:

- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,
2019-08-27 10:22:12 +00:00
Seth Berger 858daaff0d Update index of feature flags
Made it clear the pages are about feature flags,
and not documentation.
2019-08-27 08:51:02 +00:00
Marcel Amirault 9c87a3499c Update capitalization in /dev docs
Clean up capitalization in /development /gitlab-basics and
/install
2019-08-27 08:44:07 +00:00
Marcel Amirault 6f3fa06fd1 Change docs markdown linter
Change from ruby mdl to node markdownlint, add
config file to root of project, delete old config
file, update exceptions, and fix one doc that
was didn't meet standards
2019-08-26 20:31:04 +00:00
Zeger-Jan van de Weg a844a958ea
Remove the object pools feature flag
The flag defaulted to true, so there's no change unless users turned it
off. Given there's a lack of issues regarding object pools, this should
be OK.
2019-08-26 12:35:52 +02:00
Lucas Charles a5b1816978 Add changelog exclusion language for docs-only changes 2019-08-26 08:18:32 +00:00
Achilleas Pipinellis 6308a450c7 Fix link to issue template 2019-08-23 21:37:02 +00:00
Alessio Caiazza b86d3f2876 Document uploads development guidelines
Explain Workhorse acceleration features
2019-08-23 10:40:04 +00:00
Sean McGivern 842b4d4ab5 Merge branch 'feat/smime-signed-notification-emails' into 'master'
feat: smime signed notification emails

See merge request gitlab-org/gitlab-ce!30644
2019-08-22 12:16:00 +00:00
Mayra Cabrera bf5797d000 Adds new DB case study for namespaces statistics
Includes a new database case study about all the approaches taken to
store and update the namespace statistics in a performan manner
performant approach to store and update the namespaces statistics
2019-08-22 12:12:28 +00:00