Commit Graph

380 Commits

Author SHA1 Message Date
Grzegorz Bizon 1068ec2e92 Merge branch '66741-remove-spec-rails_helper-rb' into 'master'
Remove spec/rails_helper.rb

Closes #66741

See merge request gitlab-org/gitlab-ce!32380
2019-09-03 13:48:17 +00:00
Ash McKenzie 19ff9d9899
Replace rails_helper.rb with spec_helper.rb
rails_helper.rb's only logic was to require
spec_helper.rb.
2019-08-30 12:26:18 +10:00
Robert Speicher 7698d40550
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq 2019-08-29 17:17:37 -05:00
GitLab Release Tools Bot a5b2a37860 Merge branch 'security-59549-add-capcha-for-failed-logins' into 'master'
Require a captcha after unique failed logins from the same IP

See merge request gitlab/gitlabhq!3270
2019-08-29 21:34:12 +00:00
Payton Burdette 748b89ee94 Remove token field from runners edit form
Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry
2019-08-28 08:39:47 +00:00
Stan Hu 0324028a3f Rename githost.log -> git_json.log
The githost.log name was often confused with GitHost.io. Rename this to
git_json.log to make it clear it's coming from Git and that it's JSON
data.
2019-08-08 13:39:11 -07:00
George Koltsov e5e1c907c0 Add outbound requests setting for system hooks
This MR adds new application setting to network section
`allow_local_requests_from_system_hooks`. Prior to this change
system hooks were allowed to do local network requests by default
and we are adding an ability for admins to control it.
2019-08-02 15:39:18 +01:00
Małgorzata Ksionek dfcf4cf5f1 Add captcha if there are multiple failed login attempts
Add method to store session ids by ip

Add new specs for storing session ids

Add cleaning up records after login

Add retrieving anonymous sessions

Add login recaptcha setting

Add new setting to sessions controller

Add conditions for showing captcha

Add sessions controller specs

Add admin settings specs for login protection

Add new settings to api

Add stub to devise spec

Add new translation key

Add cr remarks

Rename class call

Add cr remarks

Change if-clause for consistency

Add cr remarks

Add code review remarks

Refactor AnonymousSession class

Add changelog entry

Move AnonymousSession class to lib

Move store unauthenticated sessions to sessions controller

Move link to recaptcha info

Regenerate text file

Improve copy on the spam page

Change action filter for storing anonymous sessions

Fix rubocop offences

Add code review remarks
2019-07-31 11:47:55 +02:00
Diego Louzán e20538088b Add support page link in help menu
Creates a new item in help dropdown to show configured support page link
2019-07-30 17:03:17 +00:00
Andreas Brandl 988dc80585
Further remove code branches by database type
We dropped MySQL support and a lot of mysql specific code has been
removed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29608.

This comes in from the other direction and removes any `if postgresql?`
branches.
2019-07-29 12:47:06 +02:00
Thong Kuah 73e848850c Add frozen_string_literal to spec/features
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-26 13:23:30 +12:00
Kamil Trzciński 3a4cb6d675 Bring backward compatibility for request profiles
It seems that we missed the backward compatibility support
for profiles in the existing folder.

This commit also fixes some specs to be idempotent
and work in a temporary directory which not always
seems to be the case.

This commit also brings the profile_spec.rb which seems
to be missing.
2019-07-23 09:30:00 +00:00
Sean McGivern e48851de62 Merge branch 'maintainers-can-create-subgroup' into 'master'
Add a group setting to allow Maintainers to create sub-groups

See merge request gitlab-org/gitlab-ce!29718
2019-07-22 15:17:23 +00:00
Zsolt Kovari 0f9fb07d5c Display group id on group admin page 2019-07-22 12:52:30 +00:00
Zsolt Kovari d8b11c2551 Display project id on project admin page 2019-07-22 12:50:46 +00:00
Fabio Papa c22e87121e Apply recomended changes from merge coach 2019-07-19 12:06:55 -07:00
Fabio Papa d4c53e1799 Apply changes recomended by merge request coach 2019-07-19 11:55:49 -07:00
Qingyu Zhao 10e51ac5f7 Add profile mode to extend request profiling
Extend the support for "X-Profile-Token: <token>" to have an additional
header that defines type of profile we are looking for, like:
  X-Profile-Mode: execution
  X-Profile-Mode: memory
2019-07-18 23:11:08 +10:00
Vladimir Shushlin 7b5936ebda Remove auto ssl feature flags
* remove feature flag for admin settings
* remove feature flag for domain settings
2019-07-12 16:53:44 +00:00
Nick Kipling 476f095548 Implemented frontend suggestions
Converted storage details into a small partial
Reworded the storage details summary as suggested
Updated pot file
2019-07-09 13:43:53 +00:00
Stan Hu 045ab84e0b Fix broken specs due to cached application settings
The /admin panel will now always return an uncached
application setting to ensure it always has the most
current info.
2019-07-01 22:23:01 -07:00
Mike Greiling c8c03f1d24 Merge branch '49814-display-in-admin-area-if-emails-are-verified-or-not' into 'master'
Resolve "Display in admin area if emails are verified or not"

Closes #49814

See merge request gitlab-org/gitlab-ce!29669
2019-06-21 20:53:22 +00:00
Brandon Labuschagne aebf867aee Add verification badge to users emails
This is being applied to the admin users view, when an admin
selects a user profile tp view.

It gives admins the ability to see an email verification status
without the need of impersonating a user.
2019-06-20 10:41:41 +02:00
Brett Walker 6b4f93c034 Update application settings using correct action
Updating multiple application settings panels through
a single action causes the incorrect action to be shown
when there are errors.  Instead, make each panel action
handle both updating and display.
2019-06-19 12:29:10 -05:00
Sean McGivern 51713627f6 Merge remote-tracking branch 'origin/master' into patch-56 2019-06-10 08:56:25 +01:00
Ben Bodenmiller 6a4aa3f9be Clarify that performance bar is not always on 2019-06-09 01:04:59 -07:00
Lin Jen-Shin 74399a9098
Show Test Automation Engineer for spec/feature as
reviewers.
2019-06-06 21:11:57 +08:00
Yorick Peterse 6cb750a2bb
Merge dev.gitlab.org master into GitLab.com master 2019-06-03 14:56:33 +02:00
Oswaldo Ferreira a1a0f8e6b0 Add DNS rebinding protection settings 2019-05-30 10:47:57 -03:00
Peter Marko 40490cc492 Add wiki size to project statistics 2019-05-29 16:08:25 +02:00
Tiger 26878c087a Add Kubernetes logs to monitoring UI 2019-05-27 09:52:51 -05:00
Rémy Coutable ec07641435
Fix an error in projects admin when statistics are missing
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-05-16 14:59:21 +02:00
Vladimir Shushlin db6989ddb0 Add Let's Encrypt application settings
Store Let's Encrypt account email in application settings
Also add explicit terms of service consent
2019-04-27 04:38:01 +00:00
Jason Goodman fe86890b9d Add deployment events to chat notification services
This enables sending a chat message to Slack or Mattermost
  upon a successful, failed, or canceled deployment
2019-04-26 21:08:41 +00:00
Rémy Coutable 98eb956cb0
Put some flaky specs in quarantine
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-04-24 19:02:02 +02:00
Rémy Coutable 5f36bb928b
Fix a few specs after updating capybara and selenium-webdriver
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-04-12 10:50:33 +02:00
Alexis Reigel 0fad7aa79c
add tag filter to admin runners page 2019-02-27 20:19:49 +01:00
Douwe Maan 28e1739a3f Port EE System Header And Footer feature to CE
remove EE specific code
remove EE licence checks
move migration from EE to CE folder structure
move specs from EE to CE folder structure
remove EE specific flag specs
2019-02-21 17:55:51 +02:00
Brandon Labuschagne d279cc9408 Add last activity to user administration
The columns 'Created on' and 'Last activity' have been
added to the admin -> users view.

Sorting options have also been added for last activity
and the search bar has been moved to match the issues
page.
2019-02-05 17:56:51 +02:00
Annabel Dunstone Gray fd1f61c02c Update UI of admin appearance settings
Updates the layout of the admin appearance settings to be consistent
with other settings pages across GitLab
2019-02-01 06:32:14 -06:00
Rémy Coutable 3a2abc1d50
Enable the Layout/ExtraSpacing cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
Mayra Cabrera 6eea09fd2e Fixes Auto DevOps Domain title on admin settings
Changes "Auto devops" to "Auto DevOps" on CI/CD admin settings
2019-01-08 18:38:29 -06:00
Stan Hu 29adade593 Fix and move specs into admin_disables_git_access_protocol_spec.rb 2018-12-24 00:12:36 -08:00
Robert Speicher fadcd224aa Merge branch 'replace-admin-sidebar-feature-spec-with-view-spec' into 'master'
Replace admin sidebar feature spec with view spec

See merge request gitlab-org/gitlab-ce!23551
2018-12-05 16:26:24 +00:00
Rémy Coutable 1209332a08
Replace admin sidebar feature spec with view spec
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-12-04 17:35:40 +01:00
Dmitriy Zaporozhets ad551e5e71
Keep sorting selection when search users on admin panel
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-12-04 14:10:59 +02:00
Dmitriy Zaporozhets 40c86cfede
Fix losing search query when sort users on admin users page
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-12-03 11:54:21 +02:00
Imre Farkas bd3a484032
Add config to disable impersonation
Adds gitlab.impersonation_enabled config option defaulting to true to
keep the current default behaviour.

Only the act of impersonation is modified, impersonation token
management is not affected.
2018-11-29 09:37:16 +01:00
Sean McGivern 07d10976d2 Merge branch '54093-the-default_value_for-gem-doesn-t-handle-actioncontroller-parameters-correctly' into 'master'
Replace the `default_value_for` gem with the `gitlab-default_value_with` gem which handles `ActionController::Parameters` correctly

Closes #54093

See merge request gitlab-org/gitlab-ce!23114
2018-11-19 10:02:21 +00:00
Roger Rüttimann 94d518f5d6
Add a test for the creation of an internal user by an admin
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-15 16:47:09 +01:00