Adds the ability to cherry pick a commit via the API. Right now it only supports to directly cherry pick a commit and not starting a MR from it. Shall we do that also for the API?
Closes#25450
See merge request !8047
For single line Git commit messages, the close quote should be on the same line as the open quote
_Originally opened at !7299 by @jzinn._
- - -
## What does this MR do?
Chomps merge commit messages so that there is not a dangling close quote.
A better solution would be not to use quotes at all, but to set off the message in a `<div>` with a background color.
## Screenshots (if relevant)
See merge request !7975
Allow all alphanumeric characters in file names
## What does this MR do?
Allow more characters in file names such as Chinese symbols.
## Why was this MR needed?
It is annoying that some files which can be uploaded using Git CLI cannot be created with the web editor.
## What are the relevant issue numbers?
fixes#20190
See merge request !8002
Replace static fixture for awards_handler_spec
## What does this MR do?
Use the already existing dynamic fixture `issues/open-issue.html` (!6059) in `awards_handler_spec.js` instead of the static fixture `awards_handler.html.haml`.
## What are the relevant issue numbers?
#24753
See merge request !7661
Fix Crontab typo for PruneOldEventsWorker to run 4x/day instead of 60x/hour
In c0a92cb8 the intended cron setting (per the comment) was to be "4 times a day", a * instead of a 0 means it runs 60x/hr 4x/day.
Closes#25571
See merge request !8051
break comment "edited at" block out of the note-text element to prevent issues w…
## What does this MR do?
Moves "edited" text below a note into its own element apart from rendered markdown to prevent issues when it is preceded by an inline text node.
## Are there points in the code the reviewer needs to double check?
to reproduce the bug, add text immediately following an image in a note's markdown like so:
```markdown
 test text here
```
then edit and save the note.
## Why was this MR needed?
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
- [ ] ~~Added for this feature/bug~~
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes#25155
See merge request !8048
hide new issue or MR button for not signed users for a group
## What does this MR do?
This MR prevents user creating issues or MR without signing in
## Are there points in the code the reviewer needs to double check?
NR
## Why was this MR needed?
This issue is needed to ensure an user to be logged in before creating an issue or MR
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
- [x] All builds are passing
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes#25106
See merge request !7902
`API::API` is autoloaded and shouldn't be required in non-autoloaded
code. Otherwise, we get the following dreaded error:
A copy of API::Helpers has been removed from the module tree but is
still active!
Signed-off-by: Rémy Coutable <remy@rymai.me>
Avoid escaping relative links in Markdown twice
## What does this MR do?
Avoid escaping relative links in Markdown twice.
## Why was this MR needed?
Relative links with special characters (e.g. spaces) were escaped twice.
## What are the relevant issue numbers?
closes#25191, #25318
See merge request !7940
Stop DDOSing ourselves
## What does this MR do?
Adds `hiddenInterval` to `SmartInterval` settings. This will be the interval used whilst the tab is inactive. If this setting is not set it will `cancel` as it would have done before.
Adds `immediateExecution` to `SmartInterval` settings. This boolean will dictate whether to execute the callback once before the first interval or not.
Uses `SmartInterval` with the new `hiddenInterval` settings to slow the polling for the MR widget on inactive tabs.
Fixes issue where `SmartInterval`s `visibilitychange` listeners are not getting called because jQuery doesn't support them.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
We're ddosing ourselves on the MR page.
## Screenshots (if relevant)
~30 seconds difference between the first 2 requests _(a couple requests had fired already so it's backed off already)_.
_-changed to different tab-_
~2 minutes difference between the middle 2 requests.
_-changed tab back to MR-_
~10 seconds difference between the last 2 requests.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes#24807
See merge request !7762
Rémy Coutable
Sean McGivern
jurre
Robert Schilling
Dmitriy Zaporozhets
Fatih Acet
Julian Zinn
Dimitrie Hoekstra
winniehell
Alfredo Sumaran
Stan Hu
Jon Bailey
Victor Wu
Mike Greiling
Felipe Artur
Gabriel Mazetto