722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
2025-11-25 21:34:50 +01:00
e824d94f74
Merge pull request #31557 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.1.0
...
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
2025-11-25 21:21:39 +01:00
4d54bea5ff
Merge pull request #31491 from benoittgt/31490-plugin-name-helper
...
feat: improve plugin name validation error messages and field name detection (v1)
2025-11-25 11:49:58 -05:00
00e12b8477
Merge pull request #31560 from mattfarina/fix-kube-client-logging
...
Fix kube client logging
2025-11-23 10:56:30 -08:00
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2025-11-22 10:13:05 +01:00
936cd328ac
Fix kube client logging
...
The kube client logging is based on the actionConfig logging. This
is setup to use slog.Default() before the logging flags are parsed
and logging is setup.
newRootCmdWithConfig changes the logging but it wasn't picked up
for actionConfig or the kube client. This change updates the logging
to include any changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-11-21 17:45:22 -05:00
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
2025-11-21 17:13:56 -05:00
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
2025-11-21 16:29:50 -05:00
cb35947ae6
chore(deps): bump golangci/golangci-lint-action from 9.0.0 to 9.1.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](0a35821d5c...e7fa5ac41e
2025-11-21 21:07:43 +00:00
bd9425c00b
Merge pull request #31550 from helm/dependabot/github_actions/main/actions/setup-go-6.1.0
...
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
2025-11-21 15:19:48 -05:00
2a614eeeab
Merge pull request #31551 from helm/dependabot/github_actions/main/actions/checkout-6.0.0
...
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
2025-11-21 15:18:22 -05:00
4fddc64678
chore(deps): bump actions/checkout from 5.0.1 to 6.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](93cb6efe18...1af3b93b68
2025-11-20 21:07:14 +00:00
b87f2da2f8
chore(deps): bump actions/setup-go from 5.5.0 to 6.1.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 5.5.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](d35c59abb0...4dc6199c7b
2025-11-20 21:07:06 +00:00
df6aafeeee
Merge pull request #31462 from mattfarina/load-archive
...
Adding a LoadArchive to common loader
2025-11-20 11:13:27 -05:00
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
2025-11-20 11:13:03 -05:00
eb3da36e2e
Merge pull request #31530 from shuv0id/improve-debug-logging
...
fix: add missing context to debug logs
2025-11-20 09:27:18 +01:00
47e940341f
Merge pull request #31527 from helm/dependabot/github_actions/main/actions/checkout-5.0.1
...
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
2025-11-20 09:25:18 +01:00
c185492188
Merge pull request #31540 from helm/dependabot/go_modules/main/github.com/cyphar/filepath-securejoin-0.6.1
...
chore(deps): bump github.com/cyphar/filepath-securejoin from 0.6.0 to 0.6.1
2025-11-20 09:18:43 +01:00
02000f4710
Merge pull request #31542 from helm/dependabot/go_modules/golang.org/x/crypto-0.45.0
...
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
2025-11-20 09:18:01 +01:00
c2405ce8c2
chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.44.0 to 0.45.0.
- [Commits](https://github.com/golang/crypto/compare/v0.44.0...v0.45.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.45.0
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-11-20 03:00:02 +00:00
28baa972c1
chore(deps): bump github.com/cyphar/filepath-securejoin
...
Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases )
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md )
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.6.0...v0.6.1 )
---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
dependency-version: 0.6.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-11-19 21:16:24 +00:00
63dcb5c74c
Merge pull request #31464 from benoittgt/fix-test
...
Properly test error messages on pull command's test
2025-11-19 10:52:28 -08:00
a7ba4fc80e
Merge pull request #31514 from yxxhero/fix-helm-plugin-cmd-args-env-issues
...
Refactor environment variable expansion in PrepareCommands and update tests
2025-11-19 10:36:20 -08:00
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-11-19 12:49:49 -05:00
2dc5864f44
fix: add missing context to debug logs
...
Adds chart name to dependency logs, namespace to resource waiting logs,
and confirmation message when all resources are ready.
Addresses #31520
Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com>
2025-11-18 22:25:34 +05:30
f6ceae9b74
chore(deps): bump actions/checkout from 5.0.0 to 5.0.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](08c6903cd8...93cb6efe18
2025-11-17 21:08:11 +00:00
f8a49f1852
fixup test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-17 08:31:56 -08:00
a9cdc78116
logs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-17 08:08:23 -08:00
b1a976073f
fix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-17 08:02:46 -08:00
a75fcc2948
Merge pull request #31478 from promalert/main
...
refactor: use strings.Builder to improve performance
2025-11-16 18:23:40 +01:00
71591ee63e
style: linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 12:21:45 +01:00
b296cbef6c
test: split tests between valid and invalid
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:49:08 +01:00
9b242dd9ed
test: convert tests to table drive tests
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:44:49 +01:00
c81a09b89a
test: refactor TestMetadataLegacyValidate to be more generic
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-16 11:37:18 +01:00
8c87024860
update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-11-16 10:05:27 +08:00
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-15 20:37:30 -05:00
ebd5f53fc3
Merge pull request #31421 from benoittgt/improve-doc-wait-strategy
...
Unify --wait strategy inputs, clarify defaults and docs; avoid SDK timeout footgun
2025-11-15 16:16:38 -05:00
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-11-15 08:37:54 -05:00
2d49f0cb4a
Refactor environment variable expansion in PrepareCommands and update tests
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-11-15 11:16:08 +08:00
3e06a8a440
Merge pull request #31512 from benoittgt/31508-client-go
...
fix: correct LDFLAGS path for default Kubernetes version
2025-11-14 21:31:26 -05:00
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
2025-11-14 15:26:10 -05:00
b6a8c65216
fix: correct LDFLAGS path for default Kubernetes version
...
The Makefile LDFLAGS were pointing to an incorrect package path
(helm.sh/helm/v4/pkg/chart/common/util) that doesn't exist, causing
the k8sVersionMajor and k8sVersionMinor variables to silently fail
to be set. This left the hardcoded defaults (1.20) in place.
After this fix, `helm template` now correctly defaults to Kubernetes
v1.34.0 (matching the bundled client-go version) instead of v1.20.0,
ensuring charts render with current stable API versions.
Testing scenario:
```sh
cat > /tmp/test-chart/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart
version: 1.0.0
kubeVersion: ">= 1.28.0-0"
EOF
./bin/helm template test-release /tmp/test-chart
cat > /tmp/test-chart-fail/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart-fail
version: 1.0.0
kubeVersion: ">= 1.35.0-0"
EOF
./bin/helm template test-release /tmp/test-chart-fail
Exit code 1
Error: chart requires kubeVersion: >= 1.35.0-0 which is incompatible with Kubernetes v1.34.0
```
Fixes #31508
Closes #31501
Closes #31502
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 21:18:37 +01:00
acf331a005
fix: improve plugin name validation err messages early via unmarshalling
...
- Add strict YAML unmarshalling for v1 plugins (d.KnownFields)
- Add comprehensive test coverage for validPluginName regex
- Maintain backwards compatibility for legacy plugins
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:21:37 +01:00
9e1e3d21c5
fix: Make invalid name error message more similar and move tests
...
Follow Scott comment\
https://github.com/helm/helm/pull/31491/files#r2524933784
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
cf077ceb27
fix: focus only on plugin name but give more info about what we get
...
And improve test
Follow Scott comment:
> here I would have a list of valid and invalid names based on pattern, with a check and intended outcome for each one so that we comprehensively cover the rules.
https://github.com/helm/helm/pull/31491/files#r2524820312
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
f4b139a82c
Make validation error similar and explicit for both metadatas
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
c04e18e452
fix: improve plugin name validation error messages
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-11-14 16:13:23 +01:00
51a9bc5157
Merge pull request #31473 from TerryHowe/fix-only-run-release-on-helm-helm
...
fix: do not run release workflow on forks
2025-11-14 13:11:01 +01:00
dd328fbd3b
Merge pull request #31503 from crenshaw-dev/patch-1
...
docs: Fix LFX Health Score badge URL in README.md
2025-11-14 13:09:51 +01:00
ecf1c0d886
Merge pull request #11739 from Fish-pro/fix/statement
...
docs: fix syntax errors in the document
2025-11-14 03:13:58 -05:00
Robert Sirchia
Scott Rigby
George Jenkins
Mads Jensen
Matt Farina
dependabot[bot]
shuv0id
Benoit Tigeot
yxxhero