root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 5 Packages Projects Releases Wiki Activity

MINOR: rename ConfigName.RENAME to ConfigName.RENAMES for replaceFiled (#17369) 

Reviewers: Andrew Schofield <aschofield@confluent.io>, TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
TaiJuWu 2024-10-05 05:50:48 +08:00 committed by GitHub
parent 529095ba34
commit 3bb408c4de
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java
View File

@ -412,7 +412,7 @@ public abstract class Cast<R extends ConnectRecord<R>> implements Transformation
for (String mapping : mappings) { for (String mapping : mappings) {
final String[] parts = mapping.split(":"); final String[] parts = mapping.split(":");
if (parts.length > 2) { if (parts.length > 2) {
throw new ConfigException(ReplaceField.ConfigName.RENAME, mappings, "Invalid rename mapping: " + mapping); throw new ConfigException(ReplaceField.ConfigName.RENAMES, mappings, "Invalid rename mapping: " + mapping);
} }
if (parts.length == 1) { if (parts.length == 1) {
Schema.Type targetType; Schema.Type targetType;

8
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java
View File

@ -51,7 +51,7 @@ public abstract class ReplaceField<R extends ConnectRecord<R>> implements Transf
String EXCLUDE = "exclude"; String EXCLUDE = "exclude";
String INCLUDE = "include"; String INCLUDE = "include";
String RENAME = "renames"; String RENAMES = "renames";
String REPLACE_NULL_WITH_DEFAULT_CONFIG = "replace.null.with.default"; String REPLACE_NULL_WITH_DEFAULT_CONFIG = "replace.null.with.default";
} }
@ -60,7 +60,7 @@ public abstract class ReplaceField<R extends ConnectRecord<R>> implements Transf
"Fields to exclude. This takes precedence over the fields to include.") "Fields to exclude. This takes precedence over the fields to include.")
.define(ConfigName.INCLUDE, ConfigDef.Type.LIST, Collections.emptyList(), ConfigDef.Importance.MEDIUM, .define(ConfigName.INCLUDE, ConfigDef.Type.LIST, Collections.emptyList(), ConfigDef.Importance.MEDIUM,
"Fields to include. If specified, only these fields will be used.") "Fields to include. If specified, only these fields will be used.")
.define(ConfigName.RENAME, ConfigDef.Type.LIST, Collections.emptyList(), .define(ConfigName.RENAMES, ConfigDef.Type.LIST, Collections.emptyList(),
ConfigDef.LambdaValidator.with( ConfigDef.LambdaValidator.with(
(name, value) -> { (name, value) -> {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@ -93,7 +93,7 @@ public abstract class ReplaceField<R extends ConnectRecord<R>> implements Transf
exclude = new HashSet<>(config.getList(ConfigName.EXCLUDE)); exclude = new HashSet<>(config.getList(ConfigName.EXCLUDE));
include = new HashSet<>(config.getList(ConfigName.INCLUDE)); include = new HashSet<>(config.getList(ConfigName.INCLUDE));
renames = parseRenameMappings(config.getList(ConfigName.RENAME)); renames = parseRenameMappings(config.getList(ConfigName.RENAMES));
reverseRenames = invert(renames); reverseRenames = invert(renames);
replaceNullWithDefault = config.getBoolean(ConfigName.REPLACE_NULL_WITH_DEFAULT_CONFIG); replaceNullWithDefault = config.getBoolean(ConfigName.REPLACE_NULL_WITH_DEFAULT_CONFIG);
@ -105,7 +105,7 @@ public abstract class ReplaceField<R extends ConnectRecord<R>> implements Transf
for (String mapping : mappings) { for (String mapping : mappings) {
final String[] parts = mapping.split(":"); final String[] parts = mapping.split(":");
if (parts.length != 2) { if (parts.length != 2) {
throw new ConfigException(ConfigName.RENAME, mappings, "Invalid rename mapping: " + mapping); throw new ConfigException(ConfigName.RENAMES, mappings, "Invalid rename mapping: " + mapping);
} }
m.put(parts[0], parts[1]); m.put(parts[0], parts[1]);
} }