root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Exclude jline, netty and findbugs annotations 

These dependencies are unnecessary and they are acquired
transitively via zkclient (jline, netty) and reflections (annotations).

Ewen did the hard work in figuring out why we have unexpected
additional dependencies since 0.9.x.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ewen Cheslack-Postava, Guozhang Wang, Gwen Shapira

Closes #1396 from ijuma/exclude-jline-netty-deps-in-streams and squashes the following commits:

3aa366f [Ismael Juma] Exclude findbugs annotations due to LGPL license
2d3d714 [Ismael Juma] Use local exclusion for `jline` and `netty`
482b6c0 [Ismael Juma] Exclude `jline` and `netty` dependencies in the `streams` project
This commit is contained in:
Ismael Juma 2016-05-17 19:18:33 -07:00 committed by Gwen Shapira
parent ab8fc86382
commit 9a44d938da
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
build.gradle
View File

@ -663,7 +663,11 @@ project(':streams') {
compile project(':connect:json') // this dependency should be removed after we unify data API
compile libs.slf4jlog4j
compile libs.rocksDBJni
compile libs.zkclient // this dependency should be removed after KIP-4
// this dependency should be removed after KIP-4
compile (libs.zkclient) {
exclude module: 'jline'
exclude module: 'netty'
}
compile libs.jacksonDatabind // this dependency should be removed after KIP-4
testCompile project(':clients').sourceSets.test.output
@ -829,7 +833,10 @@ project(':connect:runtime') {
compile libs.jettyServer
compile libs.jettyServlet
compile libs.jettyServlets
compile libs.reflections
compile(libs.reflections) {
// Exclude because of LGPL license
exclude group: 'com.google.code.findbugs', module: 'annotations'
}
testCompile project(':clients').sourceSets.test.output
testCompile libs.easymock