root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits (#19837)
CI / build (push) Waiting to run Details 

This PR fixes a typo in the `RocksDBStore` where it currently uses a
getter named `optimizeFiltersForHits`. However, to set the flag to true,
we have to use `setOptimizeFiltersForHits(true)` instead.

Reviewers: Matthias J. Sax <matthias@confluent.io>, Chia-Ping Tsai
 <chia7712@gmail.com>
This commit is contained in:
Chuckame 2025-06-15 18:18:29 +02:00 committed by GitHub
parent 081deaa1a9
commit a83bfda39b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
View File

@ -195,7 +195,7 @@ public class RocksDBStore implements KeyValueStore<Bytes, byte[]>, BatchWritingS
filter = new BloomFilter(); filter = new BloomFilter();
tableConfig.setFilterPolicy(filter); tableConfig.setFilterPolicy(filter);
userSpecifiedOptions.optimizeFiltersForHits(); userSpecifiedOptions.setOptimizeFiltersForHits(true);
userSpecifiedOptions.setTableFormatConfig(tableConfig); userSpecifiedOptions.setTableFormatConfig(tableConfig);
userSpecifiedOptions.setWriteBufferSize(WRITE_BUFFER_SIZE); userSpecifiedOptions.setWriteBufferSize(WRITE_BUFFER_SIZE);
userSpecifiedOptions.setCompressionType(COMPRESSION_TYPE); userSpecifiedOptions.setCompressionType(COMPRESSION_TYPE);

2
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
View File

@ -1256,7 +1256,7 @@ public class RocksDBStoreTest extends AbstractKeyValueStoreTest {
if (enableBloomFilters) { if (enableBloomFilters) {
filter = new BloomFilter(); filter = new BloomFilter();
tableConfig.setFilterPolicy(filter); tableConfig.setFilterPolicy(filter);
options.optimizeFiltersForHits(); options.setOptimizeFiltersForHits(true);
bloomFiltersSet = true; bloomFiltersSet = true;
} else { } else {
options.setOptimizeFiltersForHits(false); options.setOptimizeFiltersForHits(false);