root
/
kafka
mirror of https://github.com/apache/kafka.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MINOR: Cleanup `toString` methods in Storage Module (#20432) 

Getting rid of a bunch of `toString` functions in record classes in
Storage Module.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This commit is contained in:
Sanskar Jhajharia 2025-09-28 20:45:28 +05:30 committed by GitHub
parent 41611b4bd2
commit d2a699954d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
9 changed files with 0 additions and 86 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storage/src/main/java/org/apache/kafka/storage/internals/log/EpochEntry.java
View File

@ -18,12 +18,4 @@ package org.apache.kafka.storage.internals.log;
// Mapping of epoch to the first offset of the subsequent epoch
public record EpochEntry(int epoch, long startOffset) {
@Override
public String toString() {
return "EpochEntry(" +
"epoch=" + epoch +
", startOffset=" + startOffset +
')';
}
}

8
storage/src/main/java/org/apache/kafka/storage/internals/log/LastRecord.java
View File

@ -27,12 +27,4 @@ public record LastRecord(OptionalLong lastDataOffset, short producerEpoch) {
public LastRecord {
Objects.requireNonNull(lastDataOffset, "lastDataOffset must be non null");
}
@Override
public String toString() {
return "LastRecord(" +
"lastDataOffset=" + lastDataOffset +
", producerEpoch=" + producerEpoch +
')';
}
}

9
storage/src/main/java/org/apache/kafka/storage/internals/log/LoadedLogOffsets.java
View File

@ -26,13 +26,4 @@ public record LoadedLogOffsets(long logStartOffset, long recoveryPoint, LogOffse
this.recoveryPoint = recoveryPoint;
this.nextOffsetMetadata = Objects.requireNonNull(nextOffsetMetadata, "nextOffsetMetadata should not be null");
}
@Override
public String toString() {
return "LoadedLogOffsets(" +
"logStartOffset=" + logStartOffset +
", recoveryPoint=" + recoveryPoint +
", nextOffsetMetadata=" + nextOffsetMetadata +
')';
}
}

10
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java
View File

@ -23,14 +23,4 @@ package org.apache.kafka.storage.internals.log;
*/
public record LogOffsetSnapshot(long logStartOffset, LogOffsetMetadata logEndOffset, LogOffsetMetadata highWatermark,
LogOffsetMetadata lastStableOffset) {
@Override
public String toString() {
return "LogOffsetSnapshot(" +
"logStartOffset=" + logStartOffset +
", logEndOffset=" + logEndOffset +
", highWatermark=" + highWatermark +
", lastStableOffset=" + lastStableOffset +
')';
}
}

12
storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java
View File

@ -25,16 +25,4 @@ import java.util.Optional;
*/
public record LogReadInfo(FetchDataInfo fetchedData, Optional<FetchResponseData.EpochEndOffset> divergingEpoch,
long highWatermark, long logStartOffset, long logEndOffset, long lastStableOffset) {
@Override
public String toString() {
return "LogReadInfo(" +
"fetchedData=" + fetchedData +
", divergingEpoch=" + divergingEpoch +
", highWatermark=" + highWatermark +
", logStartOffset=" + logStartOffset +
", logEndOffset=" + logEndOffset +
", lastStableOffset=" + lastStableOffset +
')';
}
}

8
storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetPosition.java
View File

@ -32,12 +32,4 @@ public record OffsetPosition(long offset, int position) implements IndexEntry {
public long indexValue() {
return position;
}
@Override
public String toString() {
return "OffsetPosition(" +
"offset=" + offset +
", position=" + position +
')';
}
}

11
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageFetchInfo.java
View File

@ -22,15 +22,4 @@ import org.apache.kafka.server.storage.log.FetchIsolation;
public record RemoteStorageFetchInfo(int fetchMaxBytes, boolean minOneMessage, TopicIdPartition topicIdPartition,
FetchRequest.PartitionData fetchInfo, FetchIsolation fetchIsolation) {
@Override
public String toString() {
return "RemoteStorageFetchInfo{" +
"fetchMaxBytes=" + fetchMaxBytes +
", minOneMessage=" + minOneMessage +
", topicIdPartition=" + topicIdPartition +
", fetchInfo=" + fetchInfo +
", fetchIsolation=" + fetchIsolation +
'}';
}
}

13
storage/src/main/java/org/apache/kafka/storage/internals/log/RollParams.java
View File

@ -21,17 +21,4 @@ package org.apache.kafka.storage.internals.log;
*/
public record RollParams(long maxSegmentMs, int maxSegmentBytes, long maxTimestampInMessages, long maxOffsetInMessages,
int messagesSize, long now) {
@Override
public String toString() {
return "RollParams(" +
"maxSegmentMs=" + maxSegmentMs +
", maxSegmentBytes=" + maxSegmentBytes +
", maxTimestampInMessages=" + maxTimestampInMessages +
", maxOffsetInMessages=" + maxOffsetInMessages +
", messagesSize=" + messagesSize +
", now=" + now +
')';
}
}

7
storage/src/main/java/org/apache/kafka/storage/internals/log/TimestampOffset.java
View File

@ -36,11 +36,4 @@ public record TimestampOffset(long timestamp, long offset) implements IndexEntry
public long indexValue() {
return offset;
}
@Override
public String toString() {
return String.format("TimestampOffset(offset = %d, timestamp = %d)",
offset,
timestamp);
}
}