Commit Graph

1726 Commits

Author SHA1 Message Date
Jun Rao 17c6f33126 trivial fix to 0.9.0 docs 2015-11-17 19:05:53 -08:00
Jason Gustafson dbdec927b9 KAFKA-2841; safe group metadata cache loading/unloading
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jun Rao <junrao@gmail.com>

Closes #530 from hachikuji/KAFKA-2841
2015-11-17 18:34:51 -08:00
Ismael Juma 06d2c78164 MINOR: Introduce `producer.config` property to `ConsoleProducer`
This makes it easier to pass security properties in the same way
to `ConsoleConsumer` and `ConsoleProducer`.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Jun Rao <junrao@gmail.com>

Closes #544 from ijuma/producer-config-in-console-producer
2015-11-17 18:10:38 -08:00
Guozhang Wang 36b1c1dae2 MINOR: fix shutdownHook in ConsoleConsumer
Author: Confluent <confluent@Confluents-MacBook-Pro.local>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #548 from guozhangwang/HFConsoleConsumer
2015-11-17 18:00:09 -08:00
Parth Brahmbhatt dacd21ec4e KAFKA-2852; Updating the Authorizer CLI to use a consistent way to specify a list of values for a config options.
…ecify a list of values for a config options.

Author: Parth Brahmbhatt <brahmbhatt.parth@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #545 from Parth-Brahmbhatt/KAFKA-2852
2015-11-17 17:46:59 -08:00
Yasuhiro Matsuda 0158623480 MINOR: remove the group id from a restore consumer
guozhangwang
A restore consumer does not belong to a consumer group.

Author: Yasuhiro Matsuda <yasuhiro@confluent.io>

Reviewers: Guozhang Wang

Closes #543 from ymatsuda/no_group_for_restore_consumer
2015-11-17 17:39:21 -08:00
Yasuhiro Matsuda 1a36af80b7 MINOR: add KStream merge operator
guozhangwang

Added KStreamBuilder.merge(KStream...).

Author: Yasuhiro Matsuda <yasuhiro@confluent.io>

Reviewers: Guozhang Wang

Closes #536 from ymatsuda/kstream_merge_operator
2015-11-17 17:34:54 -08:00
Ashish Singh ffc0965d38 KAFKA-2746; Add support for using ConsumerGroupCommand on secure install
Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>, Jun Rao <junrao@gmail.com>

Closes #534 from SinghAsDev/KAFKA-2746
2015-11-17 12:00:16 -08:00
Ismael Juma 52d5e88393 KAFKA-2847; Remove principal builder class from client configs
Also mark `PrincipalBuilder` as `Unstable` and  tweak docs.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #542 from ijuma/kafka-2847-remove-principal-builder-class-from-client-configs
2015-11-17 08:36:43 -08:00
Ewen Cheslack-Postava f1169f1da8 KAFKA-2848; Use client SSL/SASL config utilities in Kafka Connect to avoid duplication of configs.
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #539 from ewencp/kafka-2848-reuse-ssl-sasl-client-configs
2015-11-16 22:00:34 -08:00
Jun Rao ae315264db trivial doc change for building customized user name 2015-11-16 17:57:59 -08:00
Dong Lin 6df9e7ff2c KAFKA-2721; Avoid handling duplicate LeaderAndISR requests
Author: Dong Lin <lindong28@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com?

Closes #436 from lindong28/KAFKA-2721
2015-11-16 15:50:46 -08:00
Grant Henke 6cbd97597c KAFKA-2809; Improve documentation linking
Often it is useful to link to a specific header within the documentation. Especially when referencing docs in the mailing lists.

This adds anchors and links for all headers in the docs.

Author: Grant Henke <granthenke@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #498 from granthenke/doc-links
2015-11-16 14:14:17 -08:00
Ismael Juma 5fc4546de7 KAFKA-2831; Do not use ZKUtils in `ConsumerGroupCommand` if `new-consumer` is used
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jason Gustafson <jason@confluent.io>, Ashish Singh <asingh@cloudera.com>, Jun Rao <junrao@gmail.com>

Closes #528 from ijuma/kafka-2831-consumer-group-command-zookeeper-new-consumer
2015-11-16 14:04:26 -08:00
Yasuhiro Matsuda 4a3d244a2c MINOR: do not create a StandbyTask if there is no state store in the task
guozhangwang
An optimization which may reduce unnecessary poll for standby tasks.

Author: Yasuhiro Matsuda <yasuhiro@confluent.io>

Reviewers: Guozhang Wang

Closes #535 from ymatsuda/remove_empty_standby_task
2015-11-16 14:09:27 -08:00
Yasuhiro Matsuda 45e7f71309 KAFKA-2811: add standby tasks
guozhangwang
* added a new config param "num.standby.replicas" (the default value is 0).
* added a new abstract class AbstractTask
* added StandbyTask as a subclass of AbstractTask
* modified StreamTask to a subclass of AbstractTask
* StreamThread
  * standby tasks are created by calling StreamThread.addStandbyTask() from onPartitionsAssigned()
  * standby tasks are destroyed by calling StreamThread.removeStandbyTasks() from onPartitionRevoked()
  * In addStandbyTasks(), change log partitions are assigned to restoreConsumer.
  * In removeStandByTasks(), change log partitions are removed from restoreConsumer.
  * StreamThread polls change log records using restoreConsumer in the runLoop with timeout=0.
  * If records are returned, StreamThread calls StandbyTask.update and pass records to each standby tasks.

Author: Yasuhiro Matsuda <yasuhiro@confluent.io>

Reviewers: Guozhang Wang

Closes #526 from ymatsuda/standby_task
2015-11-16 13:34:42 -08:00
Francois Visconte 356544caba KAFKA-2624; Change log message position
Log warning message before truncating log in order to
display right offset value for the truncated log.

Author: Francois Visconte <f.visconte@criteo.com>

Reviewers: Dong Lin <lindong28@gmail.com>, Jun Rao <junrao@gmail.com>

Closes #287 from dopuskh3/KAFKA-2624
2015-11-14 09:25:57 -08:00
Jun Rao f6d369b70d trivial 0.9.0 doc changes to fix links 2015-11-13 18:22:05 -08:00
Jun Rao 599a31c245 trivial 0.9.0 doc changes to AclCommand 2015-11-13 17:42:50 -08:00
Parth Brahmbhatt 8e6bae21c6 KAFKA-2838; Allow comma in super users, allow comma in CLI authz prop…
…erties.

Author: Parth Brahmbhatt <brahmbhatt.parth@gmail.com>

Reviewers: Sriharsha Chintalapani <harsha@hortonworks.com>, Jun Rao <junrao@gmail.com>

Closes #529 from Parth-Brahmbhatt/KAFKA-2838
2015-11-13 17:36:09 -08:00
Jun Rao 5d87eac856 additional trivial 0.9.0 doc changes 2015-11-13 14:18:02 -08:00
Guozhang Wang 43ef0150bd KAFKA-2833; print only group offset / metadata according to the formatter
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #527 from guozhangwang/K2833
2015-11-13 14:10:38 -08:00
Ashish Singh a26dbcdf3a KAFKA-2768: AdminClient ignore member list for non-stable groups
…stabilizing

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Ismael Juma, Jason Gustafson, Guozhang Wang

Closes #447 from SinghAsDev/KAFKA-2768
2015-11-13 12:56:15 -08:00
Jason Gustafson 002ec9c796 KAFKA-2821; fix deadlock in group metadata write callback
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jun Rao <junrao@gmail.com>

Closes #519 from hachikuji/KAFKA-2821
2015-11-13 11:11:56 -08:00
Ben Stopford 4efe4ac6d7 KAFKA-2791; removed deprecated properties
Removed support for BLOCK_ON_BUFFER_FULL_CONFIG (block.on.buffer.full)
Removed support for METADATA_FETCH_TIMEOUT_CONFIG
Removed support for TIMEOUT_CONFIG (aka timeout.ms)

Added support for MAX_BLOCK_MS_CONFIG
Added support for REQUEST_TIMEOUT_MS_CONFIG

Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #525 from benstopford/KAFKA-2791
2015-11-13 10:42:50 -08:00
Jun Rao 397306cdfe trivial doc changes 2015-11-13 10:34:15 -08:00
Sriharsha Chintalapani 4511aeebc3 Minor: Missing License
Author: Sriharsha Chintalapani <harsha@hortonworks.com>

Reviewers: Gwen Shapira

Closes #524 from harshach/missing-license
2015-11-13 10:25:00 -08:00
Ismael Juma da97330915 KAFKA-2830; Change default fix version to 0.9.1.0 in kafka-merge-pr.py
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Guozhang Wang

Closes #523 from ijuma/kafka-2830-fix-version-0.9.1.0
2015-11-13 10:03:47 -08:00
Ismael Juma 528c78fd30 KAFKA-2817; Check if socketChannel is connected in `SslTransportLayer.close`
This avoids spurious log warning messages. Also tweak log message
if wrapResult.getStatus != CLOSED.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Jun Rao <junrao@gmail.com>

Closes #511 from ijuma/kafka-2817-unconnected-ssl-transport-layer-close
2015-11-13 08:29:28 -08:00
Guozhang Wang 4170847f12 KAFKA-2819; catch NoSuchElementException in ConsoleConsumer
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #516 from guozhangwang/K2819
2015-11-12 21:23:28 -08:00
Ewen Cheslack-Postava 969d0cb0ae KAFKA-2826: Make Kafka Connect ducktape services easier to extend.
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Gwen Shapira

Closes #522 from ewencp/kafka-2826-extensible-connect-services
2015-11-12 18:54:20 -08:00
Geoff Anderson 2802bd081c MINOR: Tuned timeout parameter to reduce chance of transient failure
Increased timeout in downstream consumer doing validation step. This addresses a transient failure case in mirror maker tests with mirror maker failover.

Author: Geoff Anderson <geoff@confluent.io>

Reviewers: Gwen Shapira

Closes #521 from granders/minor-mm-transient-failure
2015-11-12 18:51:26 -08:00
Ewen Cheslack-Postava 2991c9865d KAFKA-2814: Make Kafka Connect system test REST requests use hostname that is compatible with running under AWS.
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Gwen Shapira

Closes #517 from ewencp/kafka-2814-connect-rest-on-aws
2015-11-12 13:19:12 -08:00
Ashish Singh 28d71ce5e0 KAFKA-2822: DescribeConsumerGroup now returns empty list for non-existent group.
…tent group, it used to throw IllegalArgumentException

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Jason Gustafson, Guozhang Wang

Closes #515 from SinghAsDev/KAFKA-2822
2015-11-12 12:28:08 -08:00
Ewen Cheslack-Postava 1408c670ea KAFKA-2807: Fix Kafka Connect packaging and move VerifiableSource/Sink into runtime jar.
Gradle does not handle subprojects with the same name (top-level tools vs
connect/tools) properly, making the dependency impossible to express correctly
since we need to move the ThroughputThrottler class into the top level tools
project. Moving the current set of tools into the runtime jar works fine since
they are only used for system tests at the moment.

Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Gwen Shapira

Closes #512 from ewencp/kafka-2807-redux
2015-11-12 11:11:56 -08:00
Jakub Nowak ab5ac264a7 KAFKA-2690: Hide passwords while logging the config.
Added PASSWORD_STRING in ConfigDef that returns "[hidden]" when method toString is invoked.

Author: Jakub Nowak <jakub.nowak94@interia.pl>

Reviewers: Ismael Juma, Gwen Shapira, Jun Rao

Closes #371 from Mszak/ssl-password-protection
2015-11-12 10:07:04 -08:00
Grant Henke 370ce2b4b7 KAFKA-2815: Fix KafkaStreamingPartitionAssignorTest.testSubscription
Fails when order of elements is incorrect

Author: Grant Henke <granthenke@gmail.com>

Reviewers: Yasuhiro Matsuda

Closes #510 from granthenke/streams-test
2015-11-12 09:59:47 -08:00
Jason Gustafson d9a455243e TRIVIAL: provide clearer error in describe group when group is inactive
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang

Closes #502 from hachikuji/trivial-consumer-groups-fix
2015-11-12 09:13:51 -08:00
Ismael Juma 2cf6218849 MINOR: Use Kafka artifact compiled with Scala 2.11 in quickstart.html
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #505 from ijuma/scala-2.11-in-quickstart
2015-11-12 07:21:45 -08:00
Ismael Juma d60e2ea581 MINOR: Fix logging message in `NetworkClient.poll` not to mention `producer`
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #507 from ijuma/fix-error-message-in-network-client-poll
2015-11-12 07:20:10 -08:00
Ismael Juma b5401f291a MINOR: Remove `InvalidReceiveException` catch in `SocketServer`
`Selector.poll` no longer throws it.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #506 from ijuma/poll-no-longer-throws-invalid-receive-exception
2015-11-12 07:19:02 -08:00
Jun Rao 3fd168d952 KAFKA-2813; selector doesn't close socket connection on non-IOExceptions
Patched Selector.poll() to close the connection on any exception.

Author: Jun Rao <junrao@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Gwen Shapira <cshapi@gmail.com>

Closes #501 from junrao/KAFKA-2813
2015-11-11 22:18:19 -08:00
Geoff Anderson df88d3be75 MINOR: Do not collect zk persistent data by default
In system tests zookeeper service, it is overkill and space-intensive to collect zookeeper data logs by default. This minor patch turns off default collection.

Author: Geoff Anderson <geoff@confluent.io>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #504 from granders/minor-zk-change-log-collect
2015-11-11 18:45:24 -08:00
Mayuresh Gharat 1cd22ed33f KAFKA2805; RecordAccumulator request timeout not enforced when all brokers are gone
Removed the check for expiring only those batches whose metadata is unavailable. Now the batches will be expired irrespective of whether the leader is available or not, as soon as it reaches the requestimeout threshold.

Author: Mayuresh Gharat <mgharat@mgharat-ld1.linkedin.biz>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #503 from MayureshGharat/kafka-2805
2015-11-11 18:41:45 -08:00
Yasuhiro Matsuda 124f73b174 KAFKA-2763: better stream task assignment
guozhangwang

When the rebalance happens each consumer reports the following information to the coordinator.
* Client UUID (a unique id assigned to an instance of KafkaStreaming)
* Task ids of previously running tasks
* Task ids of valid local states on the client's state directory

TaskAssignor does the following
* Assign a task to a client which was running it previously. If there is no such client, assign a task to a client which has its valid local state.
* Try to balance the load among stream threads.
  * A client may have more than one stream threads. The assignor tries to assign tasks to a client proportionally to the number of threads.

Author: Yasuhiro Matsuda <yasuhiro@confluent.io>

Reviewers: Guozhang Wang

Closes #497 from ymatsuda/task_assignment
2015-11-11 16:14:27 -08:00
Ewen Cheslack-Postava c6b8de4e68 KAFKA-2807: Move ThroughputThrottler back to tools jar to fix upgrade tests.
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Gwen Shapira

Closes #499 from ewencp/kafka-2807-relocate-throughput-throttler
2015-11-11 15:55:12 -08:00
Gwen Shapira a8ccdc6154 KAFKA-2790: doc improvements
Author: Gwen Shapira <cshapi@gmail.com>

Reviewers: Jun Rao, Guozhang Wang

Closes #491 from gwenshap/KAFKA-2790
2015-11-11 10:54:09 -08:00
Guozhang Wang e0098b4567 KAFKA-2770: Catch and ignore WakeupException for commit upon closing
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Gwen Shapira, Geoff Anderson, Jason Gustafson

Closes #470 from guozhangwang/K2770
2015-11-10 19:24:15 -08:00
Rajini Sivaram ea702c384f KAFKA-2801; Process any remaining data in SSL network read buffer after handshake
Process any remaining data in the network read buffer in `SslTransportLayer` when `read()` is invoked. On handshake completion, there could be application data ready to be processed that was read into `netReadBuffer` during handshake processing. `read()` is already invoked from `Selector` after handshake completion, but data already read into the `netReadBuffer` was not being processed. This PR adds a check for remaining data and continues with processing data if data is available.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #493 from rajinisivaram/KAFKA-2801
2015-11-10 16:37:16 -08:00
Grant Henke 04827e6e99 KAFKA-2752: Follow up to fix checkstlye
Author: Grant Henke <granthenke@gmail.com>

Reviewers: Ewen Cheslack-Postava

Closes #492 from granthenke/fix
2015-11-10 15:57:02 -08:00