Commit Graph

2285 Commits

Author SHA1 Message Date
Rajini Sivaram cea01af125 KAFKA-2693: Ducktape tests for SASL/PLAIN and multiple mechanisms
Run a sanity test with SASL/PLAIN and a couple of replication tests with SASL/PLAIN and multiple mechanisms.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1282 from rajinisivaram/KAFKA-2693
2016-04-29 09:41:12 -07:00
Matthias J. Sax 4ab4e4af81 KAFKA-3598: Improve JavaDoc of public API
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Michael G. Noll, Guozhang Wang

Closes #1250 from mjsax/JavaDoc-publicAPI
2016-04-29 08:49:16 -07:00
Michael G. Noll 68433dcfdc KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows
This PR includes the same code as https://github.com/apache/kafka/pull/1261 but is rebased on latest trunk.

Author: Michael G. Noll <michael@confluent.io>

Reviewers: Matthias J. Sax, Guozhang Wang

Closes #1277 from miguno/KAFKA-3613-v2
2016-04-29 07:44:03 -07:00
Ashish Singh 0ada3b1fc2 KAFKA-3382: Add system test for ReplicationVerificationTool
Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Geoff Anderson <geoff@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1160 from SinghAsDev/KAFKA-3382
2016-04-28 15:49:01 -07:00
Liquan Pei 346df72736 MINOR: Avoid compiler warnings when registering metrics in KafkaServer
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1280 from Ishiihara/minor-warning-fix
2016-04-28 14:46:47 -07:00
Jason Gustafson fdded2da6e KAFKA-3636; Change default max session timeout to 5 minutes
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Onur Karaman <okaraman@linkedin.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1284 from hachikuji/KAFKA-3636
2016-04-28 14:08:10 -07:00
Rajini Sivaram 3a496f480d KAFKA-3617; Unit tests for SASL authenticator
Unit tests for SASL authenticator, tests for SASL/PLAIN and multiple mechanisms, authorization test for SASL/PLAIN

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1273 from rajinisivaram/KAFKA-3617
2016-04-28 13:39:22 -07:00
Liquan Pei 316389d6ad KAFKA-3611: Remove warnings when using reflections
ewencp granders Can you take a look? Thanks!

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1259 from Ishiihara/fix-warning
2016-04-28 11:59:02 -07:00
Ashish Singh 57831a56a5 KAFKA-3621; Add tests for ApiVersionRequest/Response
Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1275 from SinghAsDev/KAFKA-3621
2016-04-27 17:31:31 -07:00
Grant Henke 669be7fadc KAFKA-3631; Fix Struct.toString for nullable arrayOf
Author: Grant Henke <granthenke@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1279 from granthenke/struct-fix
2016-04-27 17:15:37 -07:00
Eno Thereska 94aee2143e KAFKA-3612: Added structure for integration tests
Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ismael Juma, Damian Guy, Michael G. Noll, Guozhang Wang

Closes #1260 from enothereska/KAFKA-3612-integration-tests
2016-04-27 16:55:51 -07:00
Ashish Singh 8407dac6ee KAFKA-3307; Add ApiVersions Request/Response and server side handling.
The patch does the following.
1. Adds ApiVersionsRequest/Response.
2. Adds UNSUPPORTED_VERSION error and UnsupportedVersionException.
3. Adds broker side handling of ApiVersionsRequest.

Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Gwen Shapira, Ismael Juma, Magnus Edenhill

Closes #986 from SinghAsDev/KAFKA-3307
2016-04-27 11:28:32 -07:00
Damian Guy 4c76b5fa6a KAFKA-3629; KStreamImpl.to(...) throws NPE when the value SerDe is null
guozhangwang

Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Matthias J. Sax, Guozhang Wang

Closes #1272 from dguy/kstreamimpl-to-npe and squashes the following commits:

49d48fb [Damian Guy] actually commit the fix
07ce589 [Damian Guy] fix npe in KStreamImpl.to(..)
74d396d [Damian Guy] fix npe in KStreamImpl.to(..)
2016-04-27 10:50:20 -07:00
Manikumar reddy O 2885bc33da KAFKA-3580; Improve error logging in ReplicaFetchThread
Author: Manikumar reddy O <manikumar.reddy@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1237 from omkreddy/KAFKA-3580
2016-04-27 06:53:16 -07:00
Manikumar reddy O 77fa0b116f KAFKA-3406; Update CommonClientConfigs.RETRY_BACKOFF_MS_DOC doc string
Author: Manikumar reddy O <manikumar.reddy@gmail.com>

Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1230 from omkreddy/KAFKA-3406
2016-04-27 00:03:00 -07:00
Grant Henke 33d745e2dc KAFKA-3306: Change metadata response to include required additional fi…
…elds

- Adds boolean type to the protocol
- Allows protocol arrays to be null (optionally)
- Adds support to ask for no topics in the metadata request
- Adds new fields to the Metadata response protocol
- Adds server code to handle new fields
   - Support no-topic metadata requests
   - Track controller id in the metadata cache
   - Check if a topic is considered internal
   - Included rack information if present
   - Include all replicas and ISRs, even if node is down
- Adds test code to test new functionality independent of the client

Author: Grant Henke <granthenke@gmail.com>

Reviewers: Gwen Shapira, Ismael Juma, Ashish Singh

Closes #1095 from granthenke/metadata-changes
2016-04-26 17:03:18 -07:00
Rajini Sivaram 5b375d7bf9 KAFKA-3149; Extend SASL implementation to support more mechanisms
Code changes corresponding to KIP-43 to enable review of the KIP.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Jun Rao <junrao@apache.org>, Ismael Juma <ismael@juma.me.uk>

Closes #812 from rajinisivaram/KAFKA-3149
2016-04-26 16:56:42 -07:00
Ismael Juma cd427c9b90 MINOR: Upgrade to Gradle 2.13
There are a few improvements in 2.12 and 2.13. I am particularly interested in the performance improvements:
* 2.12: "This release brings support for compile only dependencies, improved build script compilation speed and even better IDE support."
* 2.13: "We've achieved performance improvements during Gradle's configuration and execution phase, where we have measured up to 25% improvements to build time in our performance tests. No changes to your build script are necessary to start taking advantage of these improvements."

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Gwen Shapira

Closes #1271 from ijuma/gradle-2.13
2016-04-26 15:14:33 -07:00
Rafael Winterhalter 2790d0cb1f MINOR: Changed port of bootstrap server to default
Kafka is typically running on port 9092. The example named a different port what makes it difficult to run a bootstrap example without any further configuration.

Author: Rafael Winterhalter <rafael.wth@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1074 from raphw/trunk
2016-04-26 11:52:33 -07:00
Stig fbac525c08 MINOR: Fix zk path in KafkaHealthCheck comment
Author: Stig <stig@linux-pr4q.suse>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1182 from srdo/comment-fix
2016-04-26 11:46:03 -07:00
Guozhang Wang 1a73629bb4 KAFKA-3607: Close KStreamTestDriver upon completing; follow-up fixes to be tracked in KAFKA-3623
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Eno Thereska, Michael G. Noll, Ismael Juma

Closes #1258 from guozhangwang/K3607
2016-04-26 11:39:49 -07:00
Dionysis Grigoropoulos f60a3fad38 MINOR: Typo fixes in ReplicaFetchMaxBytesDoc
Author: Dionysis Grigoropoulos <dgrig@erethon.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1228 from Erethon/trunk
2016-04-26 11:25:23 -07:00
Matthias J. Sax 9d37b9f4b6 KAKFA-3599: Move WindowStoreUtils to package "internals"
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Ismael Juma, Michael G. Noll, Guozhang Wang

Closes #1266 from mjsax/kafka-3599-minorCodeCleanup
2016-04-26 10:53:49 -07:00
Michael G. Noll 088ab3eaad KAFKA-3614: Consolidate duplicate code in KGroupedTableImpl
Feel free to review guozhangwang enothereska mjsax .

Author: Michael G. Noll <michael@confluent.io>

Reviewers: Matthias J. Sax, Michael G. Noll, Eno Thereska

Closes #1262 from miguno/KAFKA-3614
2016-04-26 09:59:37 -07:00
Jeff Klukas 18dd1986bd MINOR: Fix some copy-pasted Javadoc in StreamsConfig.java
This contribution is my original work and I license the work to the Kafka project under the project's open source license.

cc guozhangwang miguno ymatsuda

Author: Jeff Klukas <jeff@klukas.net>

Reviewers: Michael G. Noll <michael@confluent.io>, Guozhang Wang <wangguoz@gmail.com>

Closes #1270 from jklukas/streams-doc-fix
2016-04-26 09:11:40 -07:00
Guozhang Wang a02c8aaecf KAFKA-3499: prevent array typed keys in KeyValueStore
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Ismael Juma, Josh Gruenberg, Michael G. Noll, Ewen Cheslack-Postava

Closes #1229 from guozhangwang/K3499
2016-04-26 07:32:21 -07:00
Jason Gustafson e7d04c2515 KAFKA-3602; Rename RecordAccumulator dequeFor() and fix usage
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Grant Henke <granthenke@gmail.com>, Ashish Singh <asingh@cloudera.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1254 from hachikuji/KAFKA-3602
2016-04-26 06:37:08 -07:00
Ben Stopford b3847f76b5 KAFKA-3270; Added some Happy Path Tests for the Reassign Partitions Command
with help from enothereska  :)

Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Jun Rao <junrao@apache.org>, Eno Thereska <eno.thereska@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #956 from benstopford/KAFKA-3270-ReassignPartitionsCommand-Tests
2016-04-26 06:31:00 -07:00
Greg Fodor 996e29cfe8 KAFKA-3619: File handles are leaked on .lock files of ProcessorStateManager
Kafka Streams seems to hold file handles on the `.lock` files for the state dirs, resulting in an explosion of filehandles over time. Running `lsof` shows the number of open filehandles on the `.lock` file increasing rapidly over time. In a separate test project, I reproduced the issue and determined that in order for the filehandle to be relinquished the `FileChannel` instance must be properly closed. Applying this patch seems to resolve the issue in my job.

Author: Greg Fodor <gfodor@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1267 from gfodor/bug/state-lock-filehandle-leak
2016-04-25 13:45:51 -07:00
Damian Guy 1b764c5e83 MINOR: add unit test for KGroupedTable.count
Author: Damian Guy <damian.guy@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Michael G. Noll <michael@confluent.io>

Closes #1255 from dguy/kgroupedtable-count-test
2016-04-25 11:18:28 -07:00
Ewen Cheslack-Postava bc50515651 KAFKA-3605: Return error if connector config includes mismatching connector name.
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Jason Gustafson

Closes #1253 from ewencp/kafka-3605-connector-name-mismatch
2016-04-22 07:09:14 -07:00
Liquan Pei c7f9bd2a68 KAFKA-3606: Traverse CLASSPATH during herder start
ewencp Can you take a quick look?

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1252 from Ishiihara/pre-list-connectors
2016-04-21 17:59:23 -07:00
Manikumar reddy O 3274004497 KAFKA-3594; After calling MemoryRecords.close() method, hasRoomFor() method should return false
This exception is occurring when producer is trying to append a record to a Re-enqueued record batch in the accumulator. We should not allow to add a record to Re-enqueued record batch. This is due a bug in MemoryRecords.java/hasRoomFor() method. After calling MemoryRecords.close() method, hasRoomFor() method should return false.

Author: Manikumar reddy O <manikumar.reddy@gmail.com>

Reviewers: Ismael Juma, Grant Henke, Guozhang Wang

Closes #1249 from omkreddy/KAFKA-3594
2016-04-21 15:13:25 -07:00
Guozhang Wang 74e6dc8425 KAFKA-3589: set inner serializer for ChangedSerde upon initialization
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Eno Thereska <eno.thereska@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1246 from guozhangwang/K3589
2016-04-21 14:51:21 -07:00
Matthias J. Sax 5c547475d8 KAFKA-3337: Extract selector as a separate groupBy operator for KTable aggregations
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1231 from mjsax/kafka-3337-extact-key-selector-from-agg
2016-04-21 13:42:17 -07:00
Rajini Sivaram 9d71489ff0 KAFKA-3548: Use root locale for case transformation of constant strings
For enums and other constant strings, use locale independent case conversions to enable comparisons to work regardless of the default locale.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Manikumar Reddy, Ismael Juma, Guozhang Wang, Gwen Shapira

Closes #1220 from rajinisivaram/KAFKA-3548
2016-04-20 18:54:30 -07:00
Liquan Pei f213625fc5 MINOR: Fix comment in DistributedHerder
ewencp

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1243 from Ishiihara/docs
2016-04-20 17:50:00 -07:00
Jason Gustafson 8a863ecee7 KAFKA-3117: handle metadata updates during consumer rebalance
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1247 from hachikuji/KAFKA-3117
2016-04-20 17:08:00 -07:00
Jason Gustafson c9485b78a6 KAFKA-2370: kafka connect pause/resume API
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Liquan Pei <liquanpei@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1087 from hachikuji/KAFKA-2370
2016-04-20 14:09:59 -07:00
Ewen Cheslack-Postava 280efe7f78 MINOR: Remove RollingBounceTest since its functionality is covered by the ReplicationTest system test
RollingBounceTest is a system test that cannot be run reliably in unit tests and ReplicationTest is a superset of the
functionality: in addition to verifying that bouncing leaders eventually results in a new leader, ReplicationTest also
validates that data continues to be produced and consumed.

Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Gwen Shapira

Closes #1242 from ewencp/minor-remove-rolling-bounce-integration-test
2016-04-20 10:16:44 -07:00
Ishita Mandhan 0bf61039c8 MINOR: Fix typos in code comments
This patch fixes all occurances of two consecutive 'the's in the code comments.

Author: Ishita Mandhan (imandhaus.ibm.com)

Author: Ishita Mandhan <imandha@us.ibm.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1240 from imandhan/typofixes
2016-04-19 17:39:04 -07:00
Liquan Pei 501fa37222 KAFKA-3421: Update docs with new connector features
ewencp gwenshap Docs. I also tried to clean up some typos. However, it seems that the we don't have two words without space in between in the source yet they showed up as no space in between in the generated doc.

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1227 from Ishiihara/config-doc
2016-04-19 11:06:31 -07:00
Liquan Pei f89f5fb907 KAFKA-3582; Remove references to Copcyat from Kafka Connect property files
junrao

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #1236 from Ishiihara/minor-fix
2016-04-18 18:49:17 -07:00
Ismael Juma a5f1158c31 KAFKA-3558; Add compression_type parameter to benchmarks in benchmark_test.py
* Use a fixed `Random` seed in `EndToEndLatency.scala` for determinism
* Add `compression_type` to and remove `consumer_fetch_max_wait` from `end_to_end_latency.py`. The latter was never used.
* Tweak logging of `end_to_end_latency.py` to be similar to `consumer_performance.py`.
* Add `compression_type` to `benchmark_test.py` methods and add `snappy` to `matrix` annotation
* Use randomly generated bytes from a restricted range for `ProducerPerformance` payload. This is a simple fix for now. It can be improved in the PR for KAFKA-3554.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1225 from ijuma/kafka-3558-add-compression_type-benchmark_test.py
2016-04-18 14:23:46 -07:00
Grant Henke a81ad2582e KAFKA-3563: Maintain MessageAndMetadata constructor compatibility
Author: Grant Henke <granthenke@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Ashish Singh <asingh@cloudera.com>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1226 from granthenke/message_constructor
2016-04-18 14:10:26 -07:00
Jason Gustafson 03817d5a26 KAFKA-3529: Fix transient failure in testCommitAsync
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1234 from hachikuji/KAFKA-3529
2016-04-18 12:49:36 -07:00
Jason Gustafson 89c67727c2 KAFKA-3506: Kafka Connect restart APIs
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1189 from hachikuji/KAFKA-3506
2016-04-18 10:50:58 -07:00
Bill Bejeck b1691cf49e KAFKA-3430: Allow users to set key in KTable.toStream and in KStream.
… With KStream the method selectKey was added to enable getting a key from values before perfoming aggregation-by-key operations on original streams that have null keys.

Author: bbejeck <bbejeck@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1222 from bbejeck/KAFKA-3430_allow_users_to_set_key_KTable_toStream
2016-04-16 20:18:27 -07:00
Liquan Pei 5236bf60de KAFKA-3526: Return string instead of object in ConfigKeyInfo and ConfigValueInfo
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1200 from Ishiihara/config-string
2016-04-15 15:51:31 -07:00
Grant Henke 065ddf9019 KAFKA-3549: Close consumers instantiated in consumer tests
Author: Grant Henke <granthenke@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1217 from granthenke/close-consumers
2016-04-14 22:02:19 -07:00