Commit Graph

2327 Commits

Author SHA1 Message Date
Yuto Kawamura fec2d41bc2 KAFKA-3616: Make kafka producers/consumers injectable for KafkaStreams
Ticket: https://issues.apache.org/jira/browse/KAFKA-3616

Author: Yuto Kawamura <kawamuray.dadada@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1264 from kawamuray/kafka-3616-inject-clients
2016-05-06 08:49:44 -07:00
Dustin Cote 78de891ace KAFKA-3666; Update links for new consumer API
Pull request to update the consumer API links in the docs.

Author: Dustin Cote <dustin@dustins-mbp.attlocal.net>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1331 from cotedm/KAFKA-3666
2016-05-06 16:33:01 +01:00
Jason Gustafson 2ff955044a KAFKA-3627: consumer fails to execute delayed tasks in poll when records are available
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Liquan Pei <liquanpei@gmail.com>, Jiangjie Qin <becket.qin@gmail.com>, Guozhang Wang <wangguoz@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1295 from hachikuji/KAFKA-3627
2016-05-05 22:24:03 -07:00
Guozhang Wang 4a076a03be HOTFIX: follow-up on KAFKA-725 to remove the check and return empty response instead of throw exceptions
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Stig Døssing, Ismael Juma, Jun Rao

Closes #1327 from guozhangwang/K725r
2016-05-05 16:55:23 -07:00
Mayuresh Gharat 6856c5c214 KAFKA-3651; Remove the condition variable waiting on memory availability in Bufferpool when a TimeoutException is thrown
Whenever the BufferPool throws a "Failed to allocate memory within the configured max blocking time" exception, it should also remove the condition object from the waiters deque

Author: MayureshGharat <gharatmayuresh15@gmail.com>

Reviewers: Chen Zhu <amandazhu19620701@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1314 from MayureshGharat/kafka-3651
2016-05-05 23:31:46 +01:00
Onur Karaman 8429db937e KAFKA-3661; fix NPE in o.a.k.c.c.RoundRobinAssignor when topic metadata not found
AbstractPartitionAssignor.assign has an ambiguous line in its documentation:
> param partitionsPerTopic The number of partitions for each subscribed topic (may be empty for some topics)

Does empty mean the topic has an entry with value zero, or that the entry is excluded from the map altogether? The current implementation in AbstractPartitionAssignor excludes the entry from partitionsPerTopic if the topic isn't in the metadata.

RoundRobinAssignorTest.testOneConsumerNonexistentTopic interprets emptiness as providing the topic with a zero value.
RangeAssignor interprets emptiness as excluding the entry from the map.
RangeAssignorTest.testOneConsumerNonexistentTopic interprets emptiness as providing the topic with a zero value.

This implementation chooses to solve the NPE by deciding to exclude topics from partitionsPerTopic when the topic is not in the metadata.

Author: Onur Karaman <okaraman@linkedin.com>

Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #1326 from onurkaraman/KAFKA-3661
2016-05-05 23:25:03 +01:00
Eno Thereska 7f4e3ccde8 HOTFIX: Reverted timeouts to larger values
Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ismael Juma, Guozhang Wang

Closes #1324 from enothereska/hotfix-timeouts
2016-05-05 13:50:15 -07:00
Geoff Anderson b6cd0e2791 KAFKA-3581: add timeouts to joins in background thread services
This actually removes joins altogether, as well as references to self.worker_threads, which is best left as an implementation detail in BackgroundThreadService.

This makes use of hachikuji 's recent ducktape patch, and updates ducktape dependency to 0.5.0.

Author: Geoff Anderson <geoff@confluent.io>

Reviewers: Jason Gustafson <jason@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1297 from granders/KAFKA-3581-systest-add-join-timeout
2016-05-05 13:12:11 -07:00
Jason Gustafson 32bf83e5a7 KAFKA-3659: Handle coordinator disconnects more gracefully in client
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Grant Henke <granthenke@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1322 from hachikuji/KAFKA-3659
2016-05-05 12:03:28 -07:00
Roger Hoover 694303a3da MINOR: Fixes to AWS init script for testing
A path was wrong in the script and in the documentation.

Author: Roger Hoover <roger.hoover@gmail.com>

Reviewers: Geoff Anderson <geoff@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1309 from theduderog/fix_aws_init
2016-05-04 19:24:58 -07:00
Liquan Pei ad31650978 KAFKA-3527: Consumer commitAsync should not expose internal exceptions
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Grant Henke <granthenke@gmail.com>, Jason Gustafson <jason@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1300 from Ishiihara/kafka-3527
2016-05-04 19:20:54 -07:00
Rajini Sivaram 64451af9e0 KAFKA-3652; Return error response for unsupported version of ApiVersionsRequest
Handle unsupported version of ApiVersionsRequest during SASL auth as well as normal operation by returning an error response.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jun Rao <junrao@gmail.com>

Closes #1310 from rajinisivaram/KAFKA-3652
2016-05-04 18:16:08 -07:00
Guozhang Wang c8c6ac3f6d KAFKA-3639; Configure default serdes upon construction
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Michael G. Noll <michael@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #1311 from guozhangwang/K3639
2016-05-05 00:23:34 +01:00
Liquan Pei da7095f368 KAFKA 3656: Remove logging outstanding messages when producer flush fails
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1319 from Ishiihara/kafka-3656
2016-05-04 16:08:08 -07:00
William Thurston c46cc48021 KAFKA-2236; Offset request reply racing with segment rolling
Author: William Thurston <wthurston@linkedin.com>
Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Ismael Juma, Guozhang Wang

Closes #1318 from ijuma/KAFKA-2236-offset-request-reply-segment-rolling-race
2016-05-04 14:26:30 -07:00
Jason Gustafson 7a0821d653 KAFKA-3632; remove fetcher metrics on shutdown and leader migration
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1312 from hachikuji/KAFKA-3632
2016-05-04 20:10:41 +01:00
Guozhang Wang 768328689a MINOR: Modify checkstyle to allow import classes only used in javadoc
Author: Guozhang Wang <wangguoz@gmail.com>

Reviewers: Gwen Shapira, Ismael Juma

Closes #1317 from guozhangwang/KJavaDocImport
2016-05-04 11:25:26 -07:00
Ben Stopford b410ea37b0 KAFKA-2684; Add force option to topic / config command so they can be called programatically
Tiny change to add a force option to the topic and config commands so they can be called programatically without requiring user input.

Author: Ben Stopford <benstopford@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #351 from benstopford/CPKAFKA-61B
2016-05-04 14:26:41 +01:00
Ewen Cheslack-Postava 03a1f7d39c MINOR: Handle null values in validators
Author: Ewen Cheslack-Postava <me@ewencp.org>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1316 from ewencp/minor-handle-null-values-validators
2016-05-04 02:14:35 +01:00
Liquan Pei 50aacd660d KAFKA-3654: Config validation should validate both common and connector specific configurations
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1313 from Ishiihara/config-short-circuit
2016-05-03 18:05:04 -07:00
Chen Zhu 94e12a2e1f KAFKA-3648; maxTimeToBlock in BufferPool.allocate should be enforced
`maxTimeToBlock` needs to be updated in each loop iteration. Also record waitTime before throwing `TimeoutException`

Author: Chen Zhu <amandazhu19620701@gmail.com>

Reviewers: Dong Lin <lindong28@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1304 from zhuchen1018/KAFKA-3648
2016-05-03 23:59:12 +01:00
Liquan Pei af01378843 MINOR: Clean up of ConsumerCoordinator and PartitionAssignor
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #1306 from Ishiihara/minor-consumer-cleanup
2016-05-03 23:42:03 +01:00
Eno Thereska b3d2c0dabb MINOR: Added more integration tests
Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ismael Juma, Michael G. Noll, Guozhang Wang

Closes #1285 from enothereska/more-integration-tests
2016-05-03 13:26:22 -07:00
Som Sahu 88e5d5a9a1 KAFKA-3448; Support zone index in IPv6 regex
When an address is written textually, the zone index is appended to the address, separated by a percent sign (%). The actual syntax of zone indices depends on the operating system.

Author: Som Sahu <sosahu@microsoft.com>
Author: Soumyajit Sahu <soumyajit-sahu@users.noreply.github.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1305 from soumyajit-sahu/fixIPV6RegexPattern_trunk
2016-05-03 19:24:14 +01:00
Ismael Juma c7425be5be KAFKA-3128; Add metrics for ZooKeeper events zookeeper metrics
Also:
* Remove redundant `time.milliseconds` call in `Sensor.record`
* Clean-up a number of tests and remove a manual test that is no longer required

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Liquan Pei <liquanpei@gmail.com>, Jun Rao <junrao@gmail.com>

Closes #1265 from ijuma/kafka-3128-zookeeper-metrics
2016-05-03 10:55:54 -07:00
Yuto Kawamura 1f528815de KAFKA-3642: Fix NPE from ProcessorStateManager when the changelog topic not exists
Issue: https://issues.apache.org/jira/browse/KAFKA-3642

Author: Yuto Kawamura <kawamuray.dadada@gmail.com>

Reviewers: Guozhang Wang <wangguoz@gmail.com>

Closes #1289 from kawamuray/KAFKA-3642-streams-NPE
2016-05-03 10:47:23 -07:00
dan norwood 62253539d8 MINOR: add logfilename to error message when file missing
ewencp

Author: dan norwood <norwood@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1307 from norwood/log-filename-when-missing-file
2016-05-03 10:21:57 -07:00
Roger Hoover bf578f987b KAFKA-3650: Fix vagrant download URL
Author: Roger Hoover <roger.hoover@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1308 from theduderog/fix_vagrant_dl
2016-05-03 10:20:17 -07:00
Rajini Sivaram abac51dc0b KAFKA-3517; Add documentation for SASL/PLAIN
Documentation corresponding to KIP-43 - SASL/PLAIN and multiple mechanism support.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Magnus Edenhill <apache_m@edenhill.se>, Jun Rao <junrao@gmail.com>

Closes #1232 from rajinisivaram/KAFKA-3517
2016-05-03 09:49:23 -07:00
Geoff Anderson 5c47b9f80e MINOR: Add version check on enable-systest-events flag
Recent patch adding enable-systest-events flag without any version check breaks all uses of versioned console consumer. E.g. upgrade tests, compatibility tests etc.

Added a check to only apply the flag if running 0.10.0 or greater.

Author: Geoff Anderson <geoff@confluent.io>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1298 from granders/minor-systest-fix-versioned-console-consumer
2016-05-02 21:42:01 -07:00
Dana Powers 1e4dd66b19 HOTFIX: Fix main classpath libs glob for release (fixup KAFKA-3615 regression)
bin/kafka-run-class.sh does not correctly setup the CLASSPATH in release rc2.

Author: Dana Powers <dana.powers@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1302 from dpkp/KAFKA-3615-fix
2016-04-30 18:53:44 -07:00
Grant Henke 9eaf529ffb KAFKA-3644; Use Boolean protocol type for StopReplicaRequest delete_p…
…artitions

Author: Grant Henke <granthenke@gmail.com>

Reviewers: Gwen Shapira

Closes #1296 from granthenke/stop-boolean
2016-04-29 17:27:02 -07:00
Zack Dever 94d1878a9b MINOR: change initial value of Min stat to Double.MAX_VALUE (not MIN)
this is consistent with the Max stat implementation.

Author: Zack Dever <zdever@pandora.com>

Reviewers: Aditya Auradkar, Gwen Shapira

Closes #1143 from zackdever/min-stat-fix
2016-04-29 15:49:48 -07:00
Eno Thereska 60380e31d4 HOTFIX: Fix equality semantics of KeyValue
Fixes wrong KeyValue equals logic when keys not equal but values equal.

Original hotfix PR at https://github.com/apache/kafka/pull/1293 (/cc enothereska)

Please review: ewencp ijuma guozhangwang

Author: Eno Thereska <eno.thereska@gmail.com>
Author: Michael G. Noll <michael@confluent.io>

Reviewers: Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1294 from miguno/KeyValue-equality-hotfix
2016-04-29 15:14:36 -07:00
Liquan Pei d0dedc6314 KAFKA-3459: Returning zero task configurations from a connector does not properly clean up existing tasks
hachikuji ewencp Can you take a look when you have time?

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Jason Gustafson <jason@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1248 from Ishiihara/kafka-3459
2016-04-29 14:49:22 -07:00
Grant Henke 096b8b84e0 KAFKA-3641; Fix RecordMetadata constructor backward compatibility
Author: Grant Henke <granthenke@gmail.com>

Reviewers: Gwen Shapira, Ismael Juma

Closes #1292 from granthenke/recordmeta-compat
2016-04-29 14:48:25 -07:00
Matthias J. Sax 3414d56121 KAFKA-3440: Update streams javadocs
- add class doc for KTable, KStream, JoinWindows
- add missing return tags

Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Michael G. Noll <michael@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1287 from mjsax/kafka-3440-JavaDoc
2016-04-29 12:50:02 -07:00
Rajini Sivaram 69d9a669d7 KAFKA-3618; Handle ApiVersionsRequest before SASL authentication
Server-side implementation and tests for handling ApiVersionsRequest before SaslHandshakeRequest.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Gwen Shapira, Ismael Juma

Closes #1286 from rajinisivaram/KAFKA-3618
2016-04-29 11:15:20 -07:00
Liquan Pei e50327331d KAFKA-3578: Allow cross origin HTTP requests on all HTTP methods
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1288 from Ishiihara/kip-56
2016-04-29 10:52:42 -07:00
Anna Povzner e29eac4bbb KAFKA-3597; Query ConsoleConsumer and VerifiableProducer if they shutdown cleanly
Even if a test calls stop() on console_consumer or verifiable_producer, it is still possible that producer/consumer will not shutdown cleanly, and will be killed forcefully after a timeout. It will be useful for some tests to know whether a clean shutdown happened or not. This PR adds methods to console_consumer and verifiable_producer to query whether clean shutdown happened or not.

hachikuji and/or granders Please review.

Author: Anna Povzner <anna@confluent.io>

Reviewers: Jason Gustafson, Geoff Anderson, Gwen Shapira

Closes #1278 from apovzner/kafka-3597
2016-04-29 10:51:29 -07:00
Liquan Pei eb50d2f6ca KAFKA-3615: Exclude test jars in kafka-run-class.sh
granders hachikuji Can you take a look when you have time? Appreciate your time to review.

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Grant Henke <granthenke@gmail.com>, Geoff Anderson <geoff@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1263 from Ishiihara/classpath-no-test-jar
2016-04-29 10:29:00 -07:00
Jason Gustafson fe6c481b38 KAFKA-3418: add javadoc section describing consumer failure detection
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Ismael Juma <ismael@juma.me.uk>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1129 from hachikuji/KAFKA-3418
2016-04-29 10:26:01 -07:00
Rajini Sivaram cea01af125 KAFKA-2693: Ducktape tests for SASL/PLAIN and multiple mechanisms
Run a sanity test with SASL/PLAIN and a couple of replication tests with SASL/PLAIN and multiple mechanisms.

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1282 from rajinisivaram/KAFKA-2693
2016-04-29 09:41:12 -07:00
Matthias J. Sax 4ab4e4af81 KAFKA-3598: Improve JavaDoc of public API
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Michael G. Noll, Guozhang Wang

Closes #1250 from mjsax/JavaDoc-publicAPI
2016-04-29 08:49:16 -07:00
Michael G. Noll 68433dcfdc KAFKA-3613: Consolidate TumblingWindows and HoppingWindows into TimeWindows
This PR includes the same code as https://github.com/apache/kafka/pull/1261 but is rebased on latest trunk.

Author: Michael G. Noll <michael@confluent.io>

Reviewers: Matthias J. Sax, Guozhang Wang

Closes #1277 from miguno/KAFKA-3613-v2
2016-04-29 07:44:03 -07:00
Ashish Singh 0ada3b1fc2 KAFKA-3382: Add system test for ReplicationVerificationTool
Author: Ashish Singh <asingh@cloudera.com>

Reviewers: Geoff Anderson <geoff@confluent.io>, Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1160 from SinghAsDev/KAFKA-3382
2016-04-28 15:49:01 -07:00
Liquan Pei 346df72736 MINOR: Avoid compiler warnings when registering metrics in KafkaServer
Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1280 from Ishiihara/minor-warning-fix
2016-04-28 14:46:47 -07:00
Jason Gustafson fdded2da6e KAFKA-3636; Change default max session timeout to 5 minutes
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Onur Karaman <okaraman@linkedin.com>, Ismael Juma <ismael@juma.me.uk>

Closes #1284 from hachikuji/KAFKA-3636
2016-04-28 14:08:10 -07:00
Rajini Sivaram 3a496f480d KAFKA-3617; Unit tests for SASL authenticator
Unit tests for SASL authenticator, tests for SASL/PLAIN and multiple mechanisms, authorization test for SASL/PLAIN

Author: Rajini Sivaram <rajinisivaram@googlemail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #1273 from rajinisivaram/KAFKA-3617
2016-04-28 13:39:22 -07:00
Liquan Pei 316389d6ad KAFKA-3611: Remove warnings when using reflections
ewencp granders Can you take a look? Thanks!

Author: Liquan Pei <liquanpei@gmail.com>

Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>

Closes #1259 from Ishiihara/fix-warning
2016-04-28 11:59:02 -07:00