36200 Commits

All Branches

Search

Author	SHA1	Message	Date
Neil Horman	a4acf026ec	Remove _strlen31 ... This function is old and fairly broken. Code archeology in our git tree hasn't revealed why it was creted (though it may have possibly been to support older win32 systems that couldn't do 64 bit integers properly, like windows 95/98). There seems to be no good reason to keep it around, and given that it has potentially serious side effects, lets just remove it. Fixes #27761 Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27763) (cherry picked from commit b0d363a2cb)	2025-06-06 10:08:13 +02:00
Neil Horman	a564b793fe	Fix use of IO::Socket::IP on windows 2025 ... Apparently IO::Socket::IP has several odd behaviors on windows 2025, notably indicating that AF_INET6 isn't a supported family when it clearly is. Follow the pattern in determinig the haveIPV6 variable in Proxy.pm, and record if we determine IPv6 availablity with the IP class or the INET6 class and use the same method when testing port binding Fixes project/#1213 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Yang <kaishen.yy@antfin.com> (Merged from https://github.com/openssl/openssl/pull/27780) (cherry picked from commit ae404a9b3b)	2025-06-06 09:38:35 +02:00
Neil Horman	d171bc3e0d	Test randomly selected client port for availabilty in sslrecords test ... Encountered this error in a pr today: https://github.com/openssl/openssl/actions/runs/15418713146/job/43387767612 === Proxy started on port [::1]:56662 Engine "ossltest" set. Using default temp DH parameters ACCEPT [::1]:59189 Server responds on [::1]:59189 Engine "ossltest" set. C0774F02907F0000:error:80000062:system library:BIO_bind:Address already in use:crypto/bio/bio_sock2.c:240:calling bind() C0774F02907F0000:error:10000075:BIO routines:BIO_bind:unable to bind socket:crypto/bio/bio_sock2.c:242: connect:errno=98 === Its occuring because we randomly select a port to use for our client connection in the sslrecords test. Thats usually fine, but sometimes, we get unlucky and pick a port thats already in use. This presents as random failures in our CI on this test. So lets try harden ourselves against it. When creating the client connection, test the randomly selected port by trying to bind to it via a call to IO::Socket::IP->new(). If that fails, try a different port number, until we get one that works. If it works, use that port in the assignment for the clients local port value. Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27752) (cherry picked from commit f78f824c8e)	2025-06-05 10:30:31 -04:00
Dr. David von Oheimb	6fa1c78ecc	apps/x509.c: re-add ERR queue printing on errors ... Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27739) (cherry picked from commit ac85974bc3)	2025-06-04 17:42:04 +02:00
Viktor Dukhovni	2ac3267a86	Split arguments taking quotes into account ... CA.pl supports interpolating multiple arguments into the executed commands. Previously these were evaluated by a shell, which supported quoting of values that contain whitespace, backslashes, ... With a shell no longer used (avoid command injection), backwards compatibility requires some similar functionality. The code now handles double and single-quoted strings (shell-style word splitting), but not parameter expansion ($foo remains unexpanded) or command substitution (`cmd` and $(cmd) remain unexpanded). On Windows system(@LIST) does not correctly preserve argv, do our own quoting instead and use system(<$quoted_cmd>). Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27432) (cherry picked from commit 287bbb28b0)	2025-06-04 17:34:31 +02:00
Viktor Dukhovni	b25f51a5dc	Avoid shell commandline processing in CA.pl ... The CA.pl script used to build single-string string commandlines to pass to a shell via `system(command_string)`. That was fragile and not a best practice. This PR replaces `system(command_string)` with `system { executable } @argv`, which avoids the shell whenever possible (at least Unix-like systems and Windows). The only question mark is whether some sort of quoting is needed for VMS to preserve the case of commandline arguments even when processes are spawned directly, rather than via the shell. Unfortunately, given the way that some environment variables and command-line options are used to construct the commands to run, the result is still brittle. The CA.pl utility really should be replaced with something better. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27432) (cherry picked from commit 0b1bdef38e)	2025-06-04 17:34:29 +02:00
Matt Caswell	c638e92838	Add a CHANGES.md entry regarding no_renegotiation alert ... Highight the bug being fixed for DTLS users Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27591) (cherry picked from commit df5dff26ef)	2025-06-04 17:27:53 +02:00
Matt Caswell	b829cc5041	Update documentation regarding no_renegotiation handling ... Clarify what happens in the event that a no_renegotiation alert is received. Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27591) (cherry picked from commit 0db6a59ea7)	2025-06-04 17:26:44 +02:00
Matt Caswell	4548e4cb33	Test that a no_renegotiation alert is handled correctly ... If we receive a no_renegotiation alert we should abort the connection. We add a test for this. Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27591) (cherry picked from commit 7f6e66b048)	2025-06-04 17:26:39 +02:00
Matt Caswell	4c246610f0	Fix DTLS handling when receiving a no_renegotiation alert ... no_renegotiation is a warning alert sent from the server when it is not prepared to accept a renegotiation attempt. In TLS we abort the connection when we receive one of these - which is a reasonable response. However, in DTLS we incorrectly ignore this and keep trying to renegotiate. We bring the DTLS handling of a no_renegotiation alert into line with how TLS handles this. In versions prior to 3.2 handling of a warning alert in DTLS was mishandled resulting in a failure of the connection, which ends up being the right thing to do "by accident" in the case of "no_renegotiation". From 3.2 this mishandling was fixed, but exposed this latent bug. Fixes #27419 Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27591) (cherry picked from commit e5feca0659)	2025-06-04 17:24:17 +02:00
Dmitry Misharov	2762016a2b	ci: remove windows-2019 runner images ... According to https://github.com/actions/runner-images/issues/12045 The Windows 2019 Actions runner image will begin deprecation on 2025-06-01 and will be fully unsupported by 2025-06-30. Jobs using the windows-2019 YAML workflow label should be updated to windows-2022, windows-2025 or windows-latest. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27749) (cherry picked from commit 19dfc4672a)	2025-06-04 16:42:36 +02:00
Nicky Mouha	4987369bcb	Regression test for incorrect HMAC API usage ... Fixes #13210 Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from https://github.com/openssl/openssl/pull/27692) (cherry picked from commit a5d1eadde1)	2025-06-03 14:33:28 +02:00
Frederik Wedel-Heinen	2c7d954c23	Handle 0 return values from DH key computations as errors ... Returned 0 from ossl_dh_compute_key(), DH_compute_key_padded() and DH_compute_key() needs to be treated as an error. Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27673) (cherry picked from commit 1c1ce2a6ee)	2025-06-03 14:28:33 +02:00
Jai S	f42a2f251d	Use value barrier for constant_time_cond_swap_* ... Resolves #27497 Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27581) (cherry picked from commit 8a9e0d0f49)	2025-06-03 14:25:30 +02:00
Richard Levitte	1060ae3332	[design] Functions for explicitly fetched signature algorithms ... This design goes into more details what was outlined in the design for [fetching composite (PKEY) algorithms and using them]. It also changes what functionality will be used for this. The design for signature was originally to add modified initializers for DigestSign and DigestVerify, but recent OTC discussions redirected us to have a closer look at EVP_PKEY_sign() and EVP_PKEY_verify(). [fetching composite (PKEY) algorithms and using them]: ./fetching-composite-algorithms.md Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/22672) (cherry picked from commit 66454bf8ba)	2025-05-30 11:30:20 +02:00
Tomas Mraz	b2e1f8025a	Document that FIPS provider cannot be used by multiple libcryptos ... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/27702) (cherry picked from commit 08b2042a20)	2025-05-30 08:09:00 +10:00
JiashengJiang	9d4cbf0455	test/evp_test.c: Free fetched_digest on error to avoid memory leak ... Call EVP_MD_free() to release fetched_digest if OPENSSL_zalloc() fails, preventing a memory leak. Fixes: 2208ba56eb ("evp_test: Add the missing check after calling OPENSSL_malloc") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27648) (cherry picked from commit e8deb32af4)	2025-05-29 16:41:55 +02:00
JiashengJiang	1c9feebb44	crypto/property/property.c: Free impl->method to avoid memory leak ... After ossl_method_up_ref() succeeds, impl_free() should be called to free impl->method. Fixes: 860ecfd ("property: check return values from the property locking calls.") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27564) (cherry picked from commit 00c531a5e3)	2025-05-29 16:40:17 +02:00
AntonMoryakov	8e661b03a0	apps: lib: Prevent potential NULL dereference in init_client() ... apps: lib: Simplify ba_ret handling in init_client() Simplify logic around ba_ret assignment: - Fail early if ba_ret == NULL - Assign directly otherwise, without checking *ba_ret This avoids extra nesting and matches OpenSSL's conventions. CLA: trivial Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com> Co-authored-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26783) (cherry picked from commit 3161f460fa)	2025-05-29 16:38:23 +02:00
Viktor Dukhovni	40b7cbca10	Note finished state in cipher BIO EOF ... When the cipher BIO encounters a non-retriable EOF (or error), mark the state as "finished", else a subsequent BIO_flush() or attempted read may attempt to finalise the crypto state again, and fail, leading, for example, to users seeing erroneous apparent decryption failure. This is not a new problem, the fix should be backported to all supported releases. It was made more apparent by recent changes to the base64 BIO, which returns a non-retriable EOF when padding is seen at the end of the base64 data, even if the underlying next BIO is "retriable". Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27680) (cherry picked from commit 005fa3e00e)	2025-05-29 16:02:51 +02:00
Norbert Pocs	8ff81f95b8	Document EVP_CIPHER failure for missing provider function ... When writing a new CIPHER implementation the OSSL_FUNC_cipher_get_params must be present, otherwise the fetch fails. This behaviour is seen in function evp_cipher_cache_constants@crypto/evp/evp_lib.c. Resolves: #25801 Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27696) (cherry picked from commit 3423c30db3)	2025-05-28 10:35:51 +02:00
JiashengJiang	612f2b0fa4	apps/cmp.c: Free bio on error to avoid memory leak ... Call BIO_free() to release bio if ASN1_i2d_bio_of() fails, preventing a memory leak. Fixes: 6a3579e190 ("CMP: add support for requesting cert template using genm/genp") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27647) (cherry picked from commit e0ae801728)	2025-05-27 19:52:21 +02:00
JiashengJiang	0e9ca38e84	crypto/pkcs7/pk7_smime.c: Add BIO_free() to avoid memory leak ... Add BIO_free() to free tmpout if OPENSSL_malloc() fails to avoid memory leak. Fixes: 8e70485 ("RT3955: Reduce some stack usage") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27631) (cherry picked from commit 9882d389df)	2025-05-27 19:49:32 +02:00
JiashengJiang	b69f7e5d8c	apps/pkeyutl.c: Add OPENSSL_free() to avoid a memory leak ... If EVP_PKEY_CTX_ctrl_str() fails, the code jumps to 'end' label without freeing passwd, causing a memory leak. Fixes: 9d1bf5f7de ("Add option to read pkeyopts interactively") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27470) (cherry picked from commit 0dc6ea55a1)	2025-05-27 19:47:40 +02:00
widneve	4f1a815951	Fix memory leaks after failure of PKCS7_add_signed_attribute() ... If PKCS7_add_signed_attribute fails, seq never escapes out of the callee and will therefore result in a memory leak. This is similar to ed3d277127. CLA: trivial Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27670) (cherry picked from commit 6543f34dda)	2025-05-23 17:37:11 +02:00
klaus triendl	fd1a2ae037	Updated Windows notes on the use of “no-makedepend” for new builds ... Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27361) (cherry picked from commit afd32bcb54)	2025-05-22 16:08:47 +02:00
Dmitriy Denisov	d8c214d859	The condition that is never checked has been removed. ... If criterion == OSSL_STORE_SEARCH_BY_KEY_FINGERPRINT, the criterion !=0 condition will be triggered. Found by Linux Verification Center (linuxtesting.org) with SVACE. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27607) (cherry picked from commit 00480f1def)	2025-05-19 16:27:04 +02:00
JiashengJiang	d589d702c9	demos/bio/sconnect.c: Free ssl_bio on error to avoid memory leak ... Call BIO_free() to release ssl_bio if an error occurs before BIO_push(), preventing a memory leak. Fixes: 396e720965 ("Fix certificate validation for IPv6 literals in sconnect demo") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27639) (cherry picked from commit 55d8d85979)	2025-05-19 16:22:45 +02:00
JiashengJiang	251d2851ce	crypto/x509/v3_lib.c: Free tmpext if X509V3_EXT_add() fails to avoid memory leak ... Add OPENSSL_free to free tmpext if X509V3_EXT_add() fails to avoid memory leak. Fixes: 878dc8dd95 ("Join the x509 and x509v3 directories") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27566) (cherry picked from commit 5f661e4e96)	2025-05-19 16:18:55 +02:00
sashan	cdc4a1620a	Fix build failure on AIX ... Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27354) (cherry picked from commit e11fdd8293)	2025-05-19 08:42:59 +02:00
Benson Muite	ef6bb2e4c6	demos/guide/tls-client-block.c Spelling correction ... Fix spelling error in one word. CLA: trivial Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from https://github.com/openssl/openssl/pull/27611) (cherry picked from commit 10bd6fa8ca)	2025-05-16 12:17:23 +02:00
Norbert Pocs	b8c8b88a8e	s3_lib.c: Use illegal_parameter for failing encapsulation in ml_kem ... Signed-off-by: Norbert Pocs <norbertp@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27627) (cherry picked from commit e66097fc66)	2025-05-16 11:11:27 +02:00
Norbert Pocs	e669960727	s3_lib.c: Handle weak x keys as illegal_parameter alert ... Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27597) (cherry picked from commit 5da4ea10be)	2025-05-15 10:49:12 +02:00
JiashengJiang	6ab4e07c3e	test/testutil/testutil_init.c: Add OPENSSL_free() to avoid memory leak ... Free trace_data if error occurs to avoid memory leak. Fixes: d73458d17a ("Add tracing capability in test utilities") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27600) (cherry picked from commit 3818f7779e)	2025-05-13 14:18:05 +02:00
Matt Caswell	e26bb2d62d	Stop a TLSv1.3 server emitting an unsolicited PSK extension ... If we attempt to accept a connection on an SSL object, and the application has set an SSL_SESSION on that SSL object then we can mistakenly believe that we are resuming and emit an unsolicited PSK extension back to the client. This can especially happen when using SSL_clear() which leaves any SSL_SESSION associated with the SSL object. See https://github.com/openssl/openssl/discussions/27563#discussioncomment-13049352 and https://github.com/openssl/openssl/discussions/24567 Reviewed-by: Todd Short <todd.short@me.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27584) (cherry picked from commit aa8bca2e81)	2025-05-13 14:12:54 +02:00
Dr. David von Oheimb	e472530da5	APPS/cmp.c: fix char encoding of subject, issuer, sender, and recipient DN ... Fixes #27572 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27592) (cherry picked from commit 35e431ed6d)	2025-05-13 14:09:09 +02:00
Jakub Zelenka	6982df65ca	Check rand_meth_lock existence before trying to lock it ... There are situations during exit clean up where dependent libraries might be using TLS to finalize stuff but that might crash because the rand_meth_lock can get freed and there is still an attempt to get rand bytes. This change makes sure that things fail nicely. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27119) (cherry picked from commit 4eb3eea7a3)	2025-05-13 11:38:56 +02:00
Pauli	3d6b07f850	chacha_poly: fix settable ctx param list ... The settable list used the generic AEAD cipher list which included an extra parameter and omitted the IV length one. The set ctx param call was custom so the errant list didn't directly impact operation. The comment about ignoring OSSL_CIPHER_PARAM_AEAD_MAC_KEY is completely bogus. That parameter isn't accepted either here or by the shared AEAD cipher params. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from https://github.com/openssl/openssl/pull/27534) (cherry picked from commit 1c63382294)	2025-05-09 08:16:09 +10:00
Matt Caswell	af712a5933	Add a test for app data received too early ... Add a test for app data which was received prior to the Finished is read correctly, and that if we continue to read we get the expected result. Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> (Merged from https://github.com/openssl/openssl/pull/27543)	2025-05-08 14:14:14 -04:00
Matt Caswell	d459d00f97	Ensure we properly release DTLS buffered app data records ... If we read an app data record before we have read the Finished we buffer it. Once we've read it we need to make sure we've properly released it otherwise we will attempt to read it again (and this time there will be no data in it). Fixes #27316 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> (Merged from https://github.com/openssl/openssl/pull/27543)	2025-05-08 14:14:12 -04:00
JiashengJiang	2afa23acf9	test/bio_comp_test.c: Initialize pointer to avoid undefined behavior ... If the allocation for "original" fails, "result" may be freed without being properly initialized. Since result could hold a random value due to its assignment in do_bio_comp_test(), freeing it without initialization is unsafe and may lead to undefined behavior. Fixes: 12e96a2360 ("Add brotli compression support (RFC7924)") Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27569) (cherry picked from commit 4dca928a29)	2025-05-08 13:48:39 +02:00
Matt Caswell	cbc09444cb	Add a test for sending an empty app data record in DTLS ... DTLS should ignore this Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27541) (cherry picked from commit fe01b4d2f6)	2025-05-07 14:36:52 +02:00
Matt Caswell	3a7bb788ce	Drop empty app data records in DTLS ... App data records with 0 bytes of payload will confuse callers of SSL_read(). This will cause a successful read and return 0 bytes as read. Unfortunately a 0 return from SSL_read() is considered a failure response. A subsequent call to SSL_get_error() will then give the wrong result. Zero length app data records are actually allowed by the spec, but have never been handled correctly by OpenSSL. We already disallow creating such empty app data records. Since the SSL_read() API does not have a good way to handle this type of read, we simply ignore them. Partial fix for #27316 Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27541) (cherry picked from commit a23d5e20f1)	2025-05-07 14:36:51 +02:00
JiashengJiang	3607cb7e87	crypto/provider_conf.c: Fix possible memory leak ... Assign the return value of ossl_provider_info_add_to_store to added instead of setting it directly to 1, in order to avoid a memory leak caused by entry not being freed if ossl_provider_info_add_to_store() fails. Signed-off-by: JiashengJiang <jiasheng@purdue.edu> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27472) (cherry picked from commit 9884f1dc11)	2025-05-07 11:50:54 +02:00
Dr. David von Oheimb	0080dd66e0	Fix SSL_{set1,add1}_host() handling of host name/IP address and related documentation ... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27457) (cherry picked from commit 1eee02d3e7)	2025-05-06 15:11:56 +02:00
Dr. David von Oheimb	c1d13b7f8c	SSL_set1_host.pod: add recommendation to use SSL_{set1,add1}_host() and SSL_set_tlsext_host_name() ... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27457) (cherry picked from commit eb909d785f)	2025-05-06 15:11:55 +02:00
Richard Levitte	76fb0e2486	Drop "by store"'s by_store_subject_ex() ... It was used to pass libctx and propq, which would override the corresponding values passed to by_store_ctrl_ex(). This wasn't really reasonable to do either way, as it could potentially be a surprise to the user, who can reasonably expect that the URI is opened with the libctx and propq that was passed with the URI, and not with those passed later. Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27550)	2025-05-06 12:05:11 +02:00
Dr. David von Oheimb	2a50e24936	Add test_verify tests ... Originally from https://github.com/openssl/openssl/pull/27507, with some changes. Co-authored-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27550)	2025-05-06 12:04:59 +02:00
Richard Levitte	0f57419dad	Rework the "by store" X509_LOOKUP method to open the given URI early ... The cached X509_LOOKUP method data is no longer just the URI, but now includes the OSSL_STORE_CTX pointer, and required parameters to reopen the URI at any time. cache_objects() is modified to handle this, and only (re)open the URI when it wasn't previously opened, or when it was closed by an earlier call. This way, we can call OSSL_STORE_open_ex() in by_store_ctrl_ex(), and get to see possible errors when the URI is loaded. This assumes that if the URI could be opened once, it can be opened again. Fixes #27461 Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27550)	2025-05-06 12:04:34 +02:00
Tobias Brick	2417ddcc3d	Fix use after free bugs for public_keys and private_keys in evp_test ... Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27421) (cherry picked from commit 81e8b5a503)	2025-05-05 16:03:30 +02:00