b8d19543b8
ReduceResolution is currently called before validation during ingestion. This will cause a panic if there are not enough buckets in the histogram. If there are too many buckets, the spurious buckets are ignored, and therefore the error in the input histogram is masked. Furthermore, invalid negative offsets might cause problems, too. Therefore, we need to do some minimal validation in reduceResolution. Fortunately, it is easy and shouldn't slow things down. Sadly, it requires to return errors, which triggers a bunch of code changes. Even here is a bright side, we can get rud of a few panics. (Remember: Don't panic!) In different news, we haven't done a full validation of histograms read via remote-read. This is not so much a security concern (as you can throw off Prometheus easily by feeding it bogus data via remote-read) but more that remote-read sources might be makeshift and could accidentally create invalid histograms. We really don't want to panic in that case. So this commit does not only add a check of the spans and buckets as needed for resolution reduction but also a full validation during remote-read. Signed-off-by: beorn7 <beorn@grafana.com> |
||
|---|---|---|
| .. | ||
| testdata | ||
| README.md | ||
| benchmark_test.go | ||
| interface.go | ||
| interface_test.go | ||
| nhcbparse.go | ||
| nhcbparse_test.go | ||
| openmetricslex.l | ||
| openmetricslex.l.go | ||
| openmetricsparse.go | ||
| openmetricsparse_test.go | ||
| promlex.l | ||
| promlex.l.go | ||
| promparse.go | ||
| promparse_test.go | ||
| protobufparse.go | ||
| protobufparse_test.go | ||
README.md
Making changes to textparse lexers
In the rare case that you need to update the textparse lexers, edit promlex.l or openmetricslex.l and then run the following command:
golex -o=promlex.l.go promlex.l
Note that you need golex installed:
go get -u modernc.org/golex