2023-02-23 21:47:41 +08:00
|
|
|
load("@rules_erlang//:eunit2.bzl", "eunit")
|
2022-06-03 18:46:45 +08:00
|
|
|
load("@rules_erlang//:xref2.bzl", "xref")
|
2022-01-06 03:57:48 +08:00
|
|
|
load("@rules_erlang//:dialyze.bzl", "dialyze", "plt")
|
2021-05-10 23:38:03 +08:00
|
|
|
load("//:rabbitmq_home.bzl", "rabbitmq_home")
|
|
|
|
|
load("//:rabbitmq_run.bzl", "rabbitmq_run")
|
2021-03-29 17:01:43 +08:00
|
|
|
load(
|
|
|
|
|
"//:rabbitmq.bzl",
|
2021-06-01 16:19:10 +08:00
|
|
|
"RABBITMQ_DIALYZER_OPTS",
|
2021-07-12 21:55:56 +08:00
|
|
|
"assert_suites",
|
2022-01-06 03:57:48 +08:00
|
|
|
"rabbitmq_app",
|
2021-03-29 17:01:43 +08:00
|
|
|
"rabbitmq_integration_suite",
|
2021-05-11 16:44:28 +08:00
|
|
|
"rabbitmq_suite",
|
2023-02-07 00:57:10 +08:00
|
|
|
"without",
|
2021-03-29 17:01:43 +08:00
|
|
|
)
|
2023-02-23 21:47:41 +08:00
|
|
|
load(
|
|
|
|
|
":app.bzl",
|
|
|
|
|
"all_beam_files",
|
|
|
|
|
"all_srcs",
|
|
|
|
|
"all_test_beam_files",
|
|
|
|
|
"test_suite_beam_files",
|
|
|
|
|
)
|
2021-05-14 16:39:03 +08:00
|
|
|
load(":bats.bzl", "bats")
|
2021-03-29 17:01:43 +08:00
|
|
|
|
2022-08-16 17:43:02 +08:00
|
|
|
exports_files(glob([
|
|
|
|
|
"scripts/**",
|
|
|
|
|
]) + ["INSTALL"])
|
2021-03-29 17:01:43 +08:00
|
|
|
|
|
|
|
|
_APP_ENV = """[
|
2022-12-20 22:25:44 +08:00
|
|
|
%% See https://www.rabbitmq.com/consumers.html#acknowledgement-timeout
|
|
|
|
|
%% 30 minutes
|
|
|
|
|
{consumer_timeout, 1800000},
|
2021-03-29 17:01:43 +08:00
|
|
|
{tcp_listeners, [5672]},
|
|
|
|
|
{num_tcp_acceptors, 10},
|
|
|
|
|
{ssl_listeners, []},
|
|
|
|
|
{num_ssl_acceptors, 10},
|
|
|
|
|
{ssl_options, []},
|
|
|
|
|
{vm_memory_high_watermark, 0.4},
|
|
|
|
|
{vm_memory_high_watermark_paging_ratio, 0.5},
|
|
|
|
|
{vm_memory_calculation_strategy, rss},
|
|
|
|
|
{memory_monitor_interval, 2500},
|
|
|
|
|
{disk_free_limit, 50000000}, %% 50MB
|
|
|
|
|
{msg_store_index_module, rabbit_msg_store_ets_index},
|
|
|
|
|
{backing_queue_module, rabbit_variable_queue},
|
|
|
|
|
%% 0 ("no limit") would make a better default, but that
|
|
|
|
|
%% breaks the QPid Java client
|
|
|
|
|
{frame_max, 131072},
|
|
|
|
|
%% see rabbitmq-server#1593
|
|
|
|
|
{channel_max, 2047},
|
2023-03-29 08:07:57 +08:00
|
|
|
{ranch_connection_max, infinity},
|
2021-03-29 17:01:43 +08:00
|
|
|
{heartbeat, 60},
|
|
|
|
|
{msg_store_file_size_limit, 16777216},
|
|
|
|
|
{msg_store_shutdown_timeout, 600000},
|
|
|
|
|
{fhc_write_buffering, true},
|
|
|
|
|
{fhc_read_buffering, false},
|
|
|
|
|
{queue_index_max_journal_entries, 32768},
|
|
|
|
|
{queue_index_embed_msgs_below, 4096},
|
|
|
|
|
{default_user, <<"guest">>},
|
|
|
|
|
{default_pass, <<"guest">>},
|
|
|
|
|
{default_user_tags, [administrator]},
|
|
|
|
|
{default_vhost, <<"/">>},
|
|
|
|
|
{default_permissions, [<<".*">>, <<".*">>, <<".*">>]},
|
|
|
|
|
{loopback_users, [<<"guest">>]},
|
|
|
|
|
{password_hashing_module, rabbit_password_hashing_sha256},
|
|
|
|
|
{server_properties, []},
|
|
|
|
|
{collect_statistics, none},
|
|
|
|
|
{collect_statistics_interval, 5000},
|
|
|
|
|
{mnesia_table_loading_retry_timeout, 30000},
|
|
|
|
|
{mnesia_table_loading_retry_limit, 10},
|
|
|
|
|
{auth_mechanisms, ['PLAIN', 'AMQPLAIN']},
|
|
|
|
|
{auth_backends, [rabbit_auth_backend_internal]},
|
|
|
|
|
{delegate_count, 16},
|
|
|
|
|
{trace_vhosts, []},
|
|
|
|
|
{ssl_cert_login_from, distinguished_name},
|
|
|
|
|
{ssl_handshake_timeout, 5000},
|
|
|
|
|
{ssl_allow_poodle_attack, false},
|
|
|
|
|
{handshake_timeout, 10000},
|
|
|
|
|
{reverse_dns_lookups, false},
|
|
|
|
|
{cluster_partition_handling, ignore},
|
|
|
|
|
{cluster_keepalive_interval, 10000},
|
|
|
|
|
{autoheal_state_transition_timeout, 60000},
|
|
|
|
|
{tcp_listen_options, [{backlog, 128},
|
|
|
|
|
{nodelay, true},
|
|
|
|
|
{linger, {true, 0}},
|
|
|
|
|
{exit_on_close, false}
|
|
|
|
|
]},
|
|
|
|
|
{halt_on_upgrade_failure, true},
|
|
|
|
|
{ssl_apps, [asn1, crypto, public_key, ssl]},
|
2023-05-24 22:17:59 +08:00
|
|
|
%% classic queue storage implementation version
|
|
|
|
|
{classic_queue_default_version, 2},
|
2021-03-29 17:01:43 +08:00
|
|
|
%% see rabbitmq-server#114
|
|
|
|
|
{mirroring_flow_control, true},
|
|
|
|
|
{mirroring_sync_batch_size, 4096},
|
|
|
|
|
%% see rabbitmq-server#227 and related tickets.
|
|
|
|
|
%% msg_store_credit_disc_bound only takes effect when
|
|
|
|
|
%% messages are persisted to the message store. If messages
|
|
|
|
|
%% are embedded on the queue index, then modifying this
|
|
|
|
|
%% setting has no effect because credit_flow is not used when
|
|
|
|
|
%% writing to the queue index. See the setting
|
|
|
|
|
%% queue_index_embed_msgs_below above.
|
|
|
|
|
{msg_store_credit_disc_bound, {4000, 800}},
|
|
|
|
|
{msg_store_io_batch_size, 4096},
|
|
|
|
|
%% see rabbitmq-server#143,
|
|
|
|
|
%% rabbitmq-server#949, rabbitmq-server#1098
|
|
|
|
|
{credit_flow_default_credit, {400, 200}},
|
|
|
|
|
{quorum_commands_soft_limit, 32},
|
2021-03-30 16:44:55 +08:00
|
|
|
{quorum_cluster_size, 3},
|
2021-03-29 17:01:43 +08:00
|
|
|
%% see rabbitmq-server#248
|
|
|
|
|
%% and rabbitmq-server#667
|
|
|
|
|
{channel_operation_timeout, 15000},
|
|
|
|
|
|
|
|
|
|
%% see rabbitmq-server#486
|
|
|
|
|
{autocluster,
|
|
|
|
|
[{peer_discovery_backend, rabbit_peer_discovery_classic_config}]
|
|
|
|
|
},
|
|
|
|
|
%% used by rabbit_peer_discovery_classic_config
|
|
|
|
|
{cluster_nodes, {[], disc}},
|
|
|
|
|
|
|
|
|
|
{config_entry_decoder, [{passphrase, undefined}]},
|
|
|
|
|
|
|
|
|
|
%% rabbitmq-server#973
|
|
|
|
|
{queue_explicit_gc_run_operation_threshold, 1000},
|
|
|
|
|
{background_gc_enabled, false},
|
|
|
|
|
{background_gc_target_interval, 60000},
|
|
|
|
|
%% rabbitmq-server#589
|
|
|
|
|
{proxy_protocol, false},
|
|
|
|
|
{disk_monitor_failure_retries, 10},
|
|
|
|
|
{disk_monitor_failure_retry_interval, 120000},
|
|
|
|
|
%% either "stop_node" or "continue".
|
|
|
|
|
%% by default we choose to not terminate the entire node if one
|
|
|
|
|
%% vhost had to shut down, see server#1158 and server#1280
|
|
|
|
|
{vhost_restart_strategy, continue},
|
|
|
|
|
%% {global, prefetch count}
|
|
|
|
|
{default_consumer_prefetch, {false, 0}},
|
|
|
|
|
%% interval at which the channel can perform periodic actions
|
|
|
|
|
{channel_tick_interval, 60000},
|
|
|
|
|
%% Default max message size is 128 MB
|
|
|
|
|
{max_message_size, 134217728},
|
|
|
|
|
%% Socket writer will run GC every 1 GB of outgoing data
|
|
|
|
|
{writer_gc_threshold, 1000000000},
|
|
|
|
|
%% interval at which connection/channel tracking executes post operations
|
|
|
|
|
{tracking_execution_timeout, 15000},
|
|
|
|
|
{stream_messages_soft_limit, 256},
|
2022-01-15 00:11:38 +08:00
|
|
|
{track_auth_attempt_source, false},
|
2022-05-06 20:58:50 +08:00
|
|
|
{credentials_obfuscation_fallback_secret, <<"nocookie">>},
|
2022-01-24 22:24:38 +08:00
|
|
|
{dead_letter_worker_consumer_prefetch, 32},
|
2022-08-19 22:20:55 +08:00
|
|
|
{dead_letter_worker_publisher_confirm_timeout, 180000},
|
|
|
|
|
|
|
|
|
|
%% EOL date for the current release series, if known/announced
|
|
|
|
|
{release_series_eol_date, none}
|
2021-03-29 17:01:43 +08:00
|
|
|
]
|
|
|
|
|
"""
|
|
|
|
|
|
2021-05-19 16:54:56 +08:00
|
|
|
APP_MODULE = "rabbit"
|
|
|
|
|
|
2021-03-29 17:01:43 +08:00
|
|
|
APP_REGISTERED = [
|
|
|
|
|
"rabbit_amqqueue_sup",
|
|
|
|
|
"rabbit_direct_client_sup",
|
|
|
|
|
"rabbit_log",
|
|
|
|
|
"rabbit_node_monitor",
|
|
|
|
|
"rabbit_router",
|
|
|
|
|
]
|
|
|
|
|
|
2023-02-23 21:47:41 +08:00
|
|
|
all_beam_files(name = "all_beam_files")
|
|
|
|
|
|
|
|
|
|
all_test_beam_files(name = "all_test_beam_files")
|
|
|
|
|
|
|
|
|
|
all_srcs(name = "all_srcs")
|
|
|
|
|
|
|
|
|
|
test_suite_beam_files(name = "test_suite_beam_files")
|
|
|
|
|
|
|
|
|
|
# gazelle:erlang_apps_dirs apps
|
|
|
|
|
|
|
|
|
|
# gazelle:erlang_app_extra_app sasl
|
|
|
|
|
# gazelle:erlang_app_extra_app os_mon
|
|
|
|
|
# gazelle:erlang_app_extra_app inets
|
|
|
|
|
# gazelle:erlang_app_extra_app compiler
|
|
|
|
|
# gazelle:erlang_app_extra_app crypto
|
|
|
|
|
# gazelle:erlang_app_extra_app public_key
|
|
|
|
|
# gazelle:erlang_app_extra_app ssl
|
|
|
|
|
# gazelle:erlang_app_extra_app syntax_tools
|
|
|
|
|
# gazelle:erlang_app_extra_app xmerl
|
|
|
|
|
|
|
|
|
|
# gazelle:erlang_app_dep cuttlefish
|
|
|
|
|
# gazelle:erlang_app_dep syslog
|
|
|
|
|
# gazelle:erlang_app_dep observer_cli
|
|
|
|
|
# gazelle:erlang_app_dep redbug
|
|
|
|
|
# gazelle:erlang_app_dep sysmon_handler
|
|
|
|
|
# gazelle:erlang_app_dep systemd
|
2021-03-29 17:01:43 +08:00
|
|
|
|
2023-09-29 23:21:54 +08:00
|
|
|
# gazelle:erlang_app_dep_exclude looking_glass
|
|
|
|
|
|
2022-01-06 03:57:48 +08:00
|
|
|
rabbitmq_app(
|
2023-02-23 21:47:41 +08:00
|
|
|
name = "erlang_app",
|
|
|
|
|
srcs = [":all_srcs"],
|
|
|
|
|
hdrs = [":public_hdrs"],
|
2021-03-29 17:01:43 +08:00
|
|
|
app_description = "RabbitMQ",
|
|
|
|
|
app_env = _APP_ENV,
|
2021-05-19 16:54:56 +08:00
|
|
|
app_module = APP_MODULE,
|
2021-03-29 17:01:43 +08:00
|
|
|
app_name = "rabbit",
|
|
|
|
|
app_registered = APP_REGISTERED,
|
2023-02-23 21:47:41 +08:00
|
|
|
beam_files = [":beam_files"],
|
|
|
|
|
extra_apps = [
|
|
|
|
|
"compiler",
|
|
|
|
|
"inets",
|
|
|
|
|
"os_mon",
|
|
|
|
|
"public_key",
|
|
|
|
|
"sasl",
|
|
|
|
|
"ssl",
|
|
|
|
|
"syntax_tools",
|
|
|
|
|
"xmerl",
|
|
|
|
|
"crypto",
|
|
|
|
|
],
|
|
|
|
|
license_files = [":license_files"],
|
|
|
|
|
priv = [":priv"],
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/amqp10_common:erlang_app",
|
|
|
|
|
"//deps/rabbit/apps/rabbitmq_prelaunch:erlang_app",
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
"@cuttlefish//:erlang_app",
|
2023-09-14 12:03:54 +08:00
|
|
|
"@gen_batch_server//:erlang_app",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
"@khepri//:erlang_app",
|
|
|
|
|
"@khepri_mnesia_migration//:erlang_app",
|
2023-02-23 21:47:41 +08:00
|
|
|
"@observer_cli//:erlang_app",
|
|
|
|
|
"@osiris//:erlang_app",
|
|
|
|
|
"@ra//:erlang_app",
|
|
|
|
|
"@ranch//:erlang_app",
|
|
|
|
|
"@recon//:erlang_app",
|
|
|
|
|
"@redbug//:erlang_app",
|
|
|
|
|
"@seshat//:erlang_app",
|
|
|
|
|
"@stdout_formatter//:erlang_app",
|
|
|
|
|
"@syslog//:erlang_app",
|
|
|
|
|
"@sysmon_handler//:erlang_app",
|
|
|
|
|
"@systemd//:erlang_app",
|
|
|
|
|
],
|
2021-03-29 17:01:43 +08:00
|
|
|
)
|
|
|
|
|
|
2023-02-23 21:47:41 +08:00
|
|
|
xref(
|
|
|
|
|
name = "xref",
|
|
|
|
|
target = ":erlang_app",
|
|
|
|
|
)
|
2021-05-28 19:27:21 +08:00
|
|
|
|
|
|
|
|
plt(
|
2023-02-23 21:47:41 +08:00
|
|
|
name = "deps_plt",
|
|
|
|
|
apps = [
|
|
|
|
|
"mnesia", # keep
|
2023-05-25 23:23:35 +08:00
|
|
|
"runtime_tools", # keep
|
2023-02-23 21:47:41 +08:00
|
|
|
],
|
|
|
|
|
for_target = ":erlang_app",
|
2023-04-15 00:22:02 +08:00
|
|
|
ignore_warnings = True,
|
2023-02-23 21:47:41 +08:00
|
|
|
plt = "//:base_plt",
|
2023-05-25 23:23:35 +08:00
|
|
|
deps = [
|
|
|
|
|
"@looking_glass//:erlang_app", # keep
|
|
|
|
|
],
|
2021-05-28 19:27:21 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
dialyze(
|
2023-02-23 21:47:41 +08:00
|
|
|
name = "dialyze",
|
2023-05-25 23:23:35 +08:00
|
|
|
dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
|
2023-02-23 21:47:41 +08:00
|
|
|
plt = ":deps_plt",
|
|
|
|
|
target = ":erlang_app",
|
2021-05-28 19:27:21 +08:00
|
|
|
)
|
|
|
|
|
|
2021-05-14 16:39:03 +08:00
|
|
|
bats(
|
|
|
|
|
srcs = glob(["test/**/*.bats"]),
|
|
|
|
|
data = glob(
|
|
|
|
|
["scripts/*"],
|
|
|
|
|
exclude = ["scripts/*.bat"],
|
|
|
|
|
),
|
2022-01-06 03:57:48 +08:00
|
|
|
tags = ["bats"],
|
2021-05-14 16:39:03 +08:00
|
|
|
)
|
|
|
|
|
|
2021-05-10 23:38:03 +08:00
|
|
|
rabbitmq_home(
|
|
|
|
|
name = "broker-for-tests-home",
|
|
|
|
|
testonly = True,
|
|
|
|
|
plugins = [
|
2022-01-06 03:57:48 +08:00
|
|
|
":test_erlang_app",
|
|
|
|
|
"//deps/rabbitmq_ct_client_helpers:erlang_app",
|
2022-04-01 14:41:30 +08:00
|
|
|
"@inet_tcp_proxy_dist//:erlang_app",
|
2022-01-06 03:57:48 +08:00
|
|
|
"@meck//:erlang_app",
|
2021-05-10 23:38:03 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_run(
|
|
|
|
|
name = "rabbitmq-for-tests-run",
|
|
|
|
|
testonly = True,
|
|
|
|
|
home = ":broker-for-tests-home",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "amqqueue_backward_compatibility_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "backing_queue_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "channel_interceptor_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/dummy_interceptor.beam",
|
|
|
|
|
"test/failing_dummy_interceptor.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "channel_operation_timeout_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/channel_operation_timeout_test_queue.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "classic_queue_prop_SUITE",
|
|
|
|
|
size = "large",
|
2023-06-02 06:45:13 +08:00
|
|
|
shard_count = 6,
|
2022-11-24 22:46:08 +08:00
|
|
|
sharding_method = "case",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "cluster_rename_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
flaky = True,
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
shard_count = 3,
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "cluster_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2023-05-17 08:06:01 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "quorum_queue_member_reconciliation_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2023-05-17 08:06:01 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "clustering_management_SUITE",
|
|
|
|
|
size = "large",
|
2023-08-31 20:04:28 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
":test_clustering_utils_beam",
|
|
|
|
|
],
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
shard_count = 48,
|
2023-09-01 12:02:31 +08:00
|
|
|
sharding_method = "case",
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
2023-05-24 18:31:04 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "clustering_recovery_SUITE",
|
|
|
|
|
size = "medium",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
":test_clustering_utils_beam",
|
|
|
|
|
],
|
2023-09-29 23:13:20 +08:00
|
|
|
shard_count = 8,
|
|
|
|
|
sharding_method = "case",
|
2023-05-24 18:31:04 +08:00
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "config_schema_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
data = [
|
|
|
|
|
"test/definition_import_SUITE_data/case1.json",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "confirms_rejects_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "consumer_timeout_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "crashing_queues_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "dead_lettering_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
shard_count = 7,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "definition_import_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
Deprecated features: New module to manage deprecated features (!)
This introduces a way to declare deprecated features in the code, not
only in our communication. The new module allows to disallow the use of
a deprecated feature and/or warn the user when he relies on such a
feature.
[Why]
Currently, we only tell people about deprecated features through blog
posts and the mailing-list. This might be insufficiant for our users
that a feature they use will be removed in a future version:
* They may not read our blog or mailing-list
* They may not understand that they use such a deprecated feature
* They might wait for the big removal before they plan testing
* They might not take it seriously enough
The idea behind this patch is to increase the chance that users notice
that they are using something which is about to be dropped from
RabbitMQ. Anopther benefit is that they should be able to test how
RabbitMQ will behave in the future before the actual removal. This
should allow them to test and plan changes.
[How]
When a feature is deprecated in other large projects (such as FreeBSD
where I took the idea from), it goes through a lifecycle:
1. The feature is still available, but users get a warning somehow when
they use it. They can disable it to test.
2. The feature is still available, but disabled out-of-the-box. Users
can re-enable it (and get a warning).
3. The feature is disconnected from the build. Therefore, the code
behind it is still there, but users have to recompile the thing to be
able to use it.
4. The feature is removed from the source code. Users have to adapt or
they can't upgrade anymore.
The solution in this patch offers the same lifecycle. A deprecated
feature will be in one of these deprecation phases:
1. `permitted_by_default`: The feature is available. Users get a warning
if they use it. They can disable it from the configuration.
2. `denied_by_default`: The feature is available but disabled by
default. Users get an error if they use it and RabbitMQ behaves like
the feature is removed. They can re-enable is from the configuration
and get a warning.
3. `disconnected`: The feature is present in the source code, but is
disabled and can't be re-enabled without recompiling RabbitMQ. Users
get the same behavior as if the code was removed.
4. `removed`: The feature's code is gone.
The whole thing is based on the feature flags subsystem, but it has the
following differences with other feature flags:
* The semantic is reversed: the feature flag behind a deprecated feature
is disabled when the deprecated feature is permitted, or enabled when
the deprecated feature is denied.
* The feature flag behind a deprecated feature is enabled out-of-the-box
(meaning the deprecated feature is denied):
* if the deprecation phase is `permitted_by_default` and the
configuration denies the deprecated feature
* if the deprecation phase is `denied_by_default` and the
configuration doesn't permit the deprecated feature
* if the deprecation phase is `disconnected` or `removed`
* Feature flags behind deprecated feature don't appear in feature flags
listings.
Otherwise, deprecated features' feature flags are managed like other
feature flags, in particular inside clusters.
To declare a deprecated feature:
-rabbit_deprecated_feature(
{my_deprecated_feature,
#{deprecation_phase => permitted_by_default,
msgs => #{when_permitted => "This feature will be removed in RabbitMQ X.0"},
}}).
Then, to check the state of a deprecated feature in the code:
case rabbit_deprecated_features:is_permitted(my_deprecated_feature) of
true ->
%% The deprecated feature is still permitted.
ok;
false ->
%% The deprecated feature is gone or should be considered
%% unavailable.
error
end.
Warnings and errors are logged automatically. A message is generated
automatically, but it is possible to define a message in the deprecated
feature flag declaration like in the example above.
Here is an example of a logged warning that was generated automatically:
Feature `my_deprecated_feature` is deprecated.
By default, this feature can still be used for now.
Its use will not be permitted by default in a future minor RabbitMQ version and the feature will be removed from a future major RabbitMQ version; actual versions to be determined.
To continue using this feature when it is not permitted by default, set the following parameter in your configuration:
"deprecated_features.permit.my_deprecated_feature = true"
To test RabbitMQ as if the feature was removed, set this in your configuration:
"deprecated_features.permit.my_deprecated_feature = false"
To override the default state of `permitted_by_default` and
`denied_by_default` deprecation phases, users can set the following
configuration:
# In rabbitmq.conf:
deprecated_features.permit.my_deprecated_feature = true # or false
The actual behavior protected by a deprecated feature check is out of
scope for this subsystem. It is the repsonsibility of each deprecated
feature code to determine what to do when the deprecated feature is
denied.
V1: Deprecated feature states are initially computed during the
initialization of the registry, based on their deprecation phase and
possibly the configuration. They don't go through the `enable/1`
code at all.
V2: Manage deprecated feature states as any other non-required
feature flags. This allows to execute an `is_feature_used()`
callback to determine if a deprecated feature can be denied. This
also allows to prevent the RabbitMQ node from starting if it
continues to use a deprecated feature.
V3: Manage deprecated feature states from the registry initialization
again. This is required because we need to know very early if some
of them are denied, so that an upgrade to a version of RabbitMQ
where a deprecated feature is disconnected or removed can be
performed.
To still prevent the start of a RabbitMQ node when a denied
deprecated feature is actively used, we run the `is_feature_used()`
callback of all denied deprecated features as part of the
`sync_cluster()` task. This task is executed as part of a feature
flag refresh executed when RabbitMQ starts or when plugins are
enabled. So even though a deprecated feature is marked as denied in
the registry early in the boot process, we will still abort the
start of a RabbitMQ node if the feature is used.
V4: Support context-dependent warnings. It is now possible to set a
specific message when deprecated feature is permitted, when it is
denied and when it is removed. Generic per-context messages are
still generated.
V5: Improve default warning messages, thanks to @pstack2021.
V6: Rename the configuration variable from `permit_deprecated_features.*`
to `deprecated_features.permit.*`. As @michaelklishin said, we tend
to use shorter top-level names.
2023-02-23 00:26:52 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "deprecated_features_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
|
|
|
|
":feature_flags_v2_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "disconnect_detected_during_alarm_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "disk_monitor_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "dynamic_ha_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
flaky = True,
|
|
|
|
|
shard_count = 20,
|
|
|
|
|
sharding_method = "case",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "dynamic_qq_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "eager_sync_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
|
|
|
|
":sync_detection_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
flaky = True,
|
|
|
|
|
shard_count = 5,
|
|
|
|
|
sharding_method = "case",
|
|
|
|
|
tags = ["classic-queue"],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "feature_flags_SUITE",
|
|
|
|
|
size = "large",
|
2023-09-01 12:02:31 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
":test_clustering_utils_beam",
|
|
|
|
|
],
|
2022-11-24 22:46:08 +08:00
|
|
|
flaky = True,
|
|
|
|
|
shard_count = 5,
|
|
|
|
|
runtime_deps = [
|
|
|
|
|
"//deps/rabbit/test/feature_flags_SUITE_data/my_plugin:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "feature_flags_v2_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "feature_flags_with_unpriveleged_user_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
|
|
|
|
":feature_flags_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
flaky = True,
|
|
|
|
|
shard_count = 2,
|
|
|
|
|
# The enabling_* tests chmod files and then expect writes to be blocked.
|
|
|
|
|
# This probably doesn't work because we are root in the remote docker image.
|
2023-08-31 18:31:38 +08:00
|
|
|
tags = ["no-remote-exec"],
|
2022-11-24 22:46:08 +08:00
|
|
|
runtime_deps = [
|
|
|
|
|
"//deps/rabbit/test/feature_flags_SUITE_data/my_plugin:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "list_consumers_sanity_check_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "list_queues_online_and_offline_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "logging_SUITE",
|
|
|
|
|
runtime_deps = [
|
|
|
|
|
"@syslog//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "lqueue_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "maintenance_mode_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "many_node_ha_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_rabbit_ha_test_consumer_beam",
|
|
|
|
|
":test_rabbit_ha_test_producer_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
Move plugin rabbitmq-message-timestamp to the core
As reported in https://groups.google.com/g/rabbitmq-users/c/x8ACs4dBlkI/
plugins that implement rabbit_channel_interceptor break with
Native MQTT in 3.12 because Native MQTT does not use rabbit_channel anymore.
Specifically, these plugins don't work anymore in 3.12 when sending a message
from an MQTT publisher to an AMQP 0.9.1 consumer.
Two of these plugins are
https://github.com/rabbitmq/rabbitmq-message-timestamp
and
https://github.com/rabbitmq/rabbitmq-routing-node-stamp
This commit moves both plugins into rabbitmq-server.
Therefore, these plugins are deprecated starting in 3.12.
Instead of using these plugins, the user gets the same behaviour by
configuring rabbitmq.conf as follows:
```
incoming_message_interceptors.set_header_timestamp.overwrite = false
incoming_message_interceptors.set_header_routing_node.overwrite = false
```
While both plugins were incompatible to be used together, this commit
allows setting both headers.
We name the top level configuration key `incoming_message_interceptors`
because only incoming messages are intercepted.
Currently, only `set_header_timestamp` and `set_header_routing_node` are
supported. (We might support more in the future.)
Both can set `overwrite` to `false` or `true`.
The meaning of `overwrite` is the same as documented in
https://github.com/rabbitmq/rabbitmq-message-timestamp#always-overwrite-timestamps
i.e. whether headers should be overwritten if they are already present
in the message.
Both `set_header_timestamp` and `set_header_routing_node` behave exactly
to plugins `rabbitmq-message-timestamp` and `rabbitmq-routing-node-stamp`,
respectively.
Upon node boot, the configuration is put into persistent_term to not
cause any performance penalty in the default case where these settings
are disabled.
The channel and MQTT connection process will intercept incoming messages
and - if configured - add the desired AMQP 0.9.1 headers.
For now, this allows using Native MQTT in 3.12 with the old plugins
behaviour.
In the future, once "message containers" are implemented,
we can think about more generic message interceptors where plugins can be
written to modify arbitrary headers or message contents for various protocols.
Likewise, in the future, once MQTT 5.0 is implemented, we can think
about an MQTT connection interceptor which could function similar to a
`rabbit_channel_interceptor` allowing to modify any MQTT packet.
2023-05-12 22:12:50 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_message_interceptor_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "message_size_limit_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2023-03-29 08:07:57 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_node_limit_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
Message Containers (#5077)
This PR implements an approach for a "protocol (data format) agnostic core" where the format of the message isn't converted at point of reception.
Currently all non AMQP 0.9.1 originating messages are converted into a AMQP 0.9.1 flavoured basic_message record before sent to a queue. If the messages are then consumed by the originating protocol they are converted back from AMQP 0.9.1. For some protocols such as MQTT 3.1 this isn't too expensive as MQTT is mostly a fairly easily mapped subset of AMQP 0.9.1 but for others such as AMQP 1.0 the conversions are awkward and in some cases lossy even if consuming from the originating protocol.
This PR instead wraps all incoming messages in their originating form into a generic, extensible message container type (mc). The container module exposes an API to get common message details such as size and various properties (ttl, priority etc) directly from the source data type. Each protocol needs to implement the mc behaviour such that when a message originating form one protocol is consumed by another protocol we convert it to the target protocol at that point.
The message container also contains annotations, dead letter records and other meta data we need to record during the lifetime of a message. The original protocol message is never modified unless it is consumed.
This includes conversion modules to and from amqp, amqpl (AMQP 0.9.1) and mqtt.
COMMIT HISTORY:
* Refactor away from using the delivery{} record
In many places including exchange types. This should make it
easier to move towards using a message container type instead of
basic_message.
Add mc module and move direct replies outside of exchange
Lots of changes incl classic queues
Implement stream support incl amqp conversions
simplify mc state record
move mc.erl
mc dlx stuff
recent history exchange
Make tracking work
But doesn't take a protocol agnostic approach as we just convert
everything into AMQP legacy and back. Might be good enough for now.
Tracing as a whole may want a bit of a re-vamp at some point.
tidy
make quorum queue peek work by legacy conversion
dead lettering fixes
dead lettering fixes
CMQ fixes
rabbit_trace type fixes
fixes
fix
Fix classic queue props
test assertion fix
feature flag and backwards compat
Enable message_container feature flag in some SUITEs
Dialyzer fixes
fixes
fix
test fixes
Various
Manually update a gazelle generated file
until a gazelle enhancement can be made
https://github.com/rabbitmq/rules_erlang/issues/185
Add message_containers_SUITE to bazel
and regen bazel files with gazelle from rules_erlang@main
Simplify essential proprty access
Such as durable, ttl and priority by extracting them into annotations
at message container init time.
Move type
to remove dependenc on amqp10 stuff in mc.erl
mostly because I don't know how to make bazel do the right thing
add more stuff
Refine routing header stuff
wip
Cosmetics
Do not use "maybe" as type name as "maybe" is a keyword since OTP 25
which makes Erlang LS complain.
* Dedup death queue names
* Fix function clause crashes
Fix failing tests in the MQTT shared_SUITE:
A classic queue message ID can be undefined as set in
https://github.com/rabbitmq/rabbitmq-server/blob/fbe79ff47b4edbc0fd95457e623d6593161ad198/deps/rabbit/src/rabbit_classic_queue_index_v2.erl#L1048
Fix failing tests in the MQTT shared_SUITE-mixed:
When feature flag message_containers is disabled, the
message is not an #mc{} record, but a #basic_message{} record.
* Fix is_utf8_no_null crash
Prior to this commit, the function crashed if invalid UTF-8 was
provided, e.g.:
```
1> rabbit_misc:is_valid_shortstr(<<"😇"/utf16>>).
** exception error: no function clause matching rabbit_misc:is_utf8_no_null(<<216,61,222,7>>) (rabbit_misc.erl, line 1481)
```
* Implement mqtt mc behaviour
For now via amqp translation.
This is still work in progress, but the following SUITEs pass:
```
make -C deps/rabbitmq_mqtt ct-shared t=[mqtt,v5,cluster_size_1] FULL=1
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_1] FULL=1
```
* Shorten mc file names
Module name length matters because for each persistent message the #mc{}
record is persisted to disk.
```
1> iolist_size(term_to_iovec({mc, rabbit_mc_amqp_legacy})).
30
2> iolist_size(term_to_iovec({mc, mc_amqpl})).
17
```
This commit renames the mc modules:
```
ag -l rabbit_mc_amqp_legacy | xargs sed -i 's/rabbit_mc_amqp_legacy/mc_amqpl/g'
ag -l rabbit_mc_amqp | xargs sed -i 's/rabbit_mc_amqp/mc_amqp/g'
ag -l rabbit_mqtt_mc | xargs sed -i 's/rabbit_mqtt_mc/mc_mqtt/g'
```
* mc: make deaths an annotation + fixes
* Fix mc_mqtt protocol_state callback
* Fix test will_delay_node_restart
```
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_3]:will_delay_node_restart FULL=1
```
* Bazel run gazelle
* mix format rabbitmqctl.ex
* Ensure ttl annotation is refelected in amqp legacy protocol state
* Fix id access in message store
* Fix rabbit_message_interceptor_SUITE
* dializer fixes
* Fix rabbit:rabbit_message_interceptor_SUITE-mixed
set_annotation/3 should not result in duplicate keys
* Fix MQTT shared_SUITE-mixed
Up to 3.12 non-MQTT publishes were always QoS 1 regardless of delivery_mode.
https://github.com/rabbitmq/rabbitmq-server/blob/75a953ce286a10aca910c098805a4f545989af38/deps/rabbitmq_mqtt/src/rabbit_mqtt_processor.erl#L2075-L2076
From now on, non-MQTT publishes are QoS 1 if durable.
This makes more sense.
The MQTT plugin must send a #basic_message{} to an old node that does
not understand message containers.
* Field content of 'v1_0.data' can be binary
Fix
```
bazel test //deps/rabbitmq_mqtt:shared_SUITE-mixed \
--test_env FOCUS="-group [mqtt,v4,cluster_size_1] -case trace" \
-t- --test_sharding_strategy=disabled
```
* Remove route/2 and implement route/3 for all exchange types.
This removes the route/2 callback from rabbit_exchange_type and
makes route/3 mandatory instead. This is a breaking change and
will require all implementations of exchange types to update their
code, however this is necessary anyway for them to correctly handle
the mc type.
stream filtering fixes
* Translate directly from MQTT to AMQP 0.9.1
* handle undecoded properties in mc_compat
amqpl: put clause in right order
recover death deatails from amqp data
* Replace callback init_amqp with convert_from
* Fix return value of lists:keyfind/3
* Translate directly from AMQP 0.9.1 to MQTT
* Fix MQTT payload size
MQTT payload can be a list when converted from AMQP 0.9.1 for example
First conversions tests
Plus some other conversion related fixes.
bazel
bazel
translate amqp 1.0 null to undefined
mc: property/2 and correlation_id/message_id return type tagged values.
To ensure we can support a variety of types better.
The type type tags are AMQP 1.0 flavoured.
fix death recovery
mc_mqtt: impl new api
Add callbacks to allow protocols to compact data before storage
And make readable if needing to query things repeatedly.
bazel fix
* more decoding
* tracking mixed versions compat
* mc: flip default of `durable` annotation to save some data.
Assuming most messages are durable and that in memory messages suffer less
from persistence overhead it makes sense for a non existent `durable`
annotation to mean durable=true.
* mc conversion tests and tidy up
* mc make x_header unstrict again
* amqpl: death record fixes
* bazel
* amqp -> amqpl conversion test
* Fix crash in mc_amqp:size/1
Body can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0/ ct-system t=java
```
on branch native-amqp.
* Fix crash in lists:flatten/1
Data can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp.
* Fix crash in rabbit_writer
Running test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp resulted in the following crash:
```
crasher:
initial call: rabbit_writer:enter_mainloop/2
pid: <0.711.0>
registered_name: []
exception error: bad argument
in function size/1
called as size([<<0>>,<<"Sw">>,[<<160,2>>,<<"hi">>]])
*** argument 1: not tuple or binary
in call from rabbit_binary_generator:build_content_frames/7 (rabbit_binary_generator.erl, line 89)
in call from rabbit_binary_generator:build_simple_content_frames/4 (rabbit_binary_generator.erl, line 61)
in call from rabbit_writer:assemble_frames/5 (rabbit_writer.erl, line 334)
in call from rabbit_writer:internal_send_command_async/3 (rabbit_writer.erl, line 365)
in call from rabbit_writer:handle_message/2 (rabbit_writer.erl, line 265)
in call from rabbit_writer:handle_message/3 (rabbit_writer.erl, line 232)
in call from rabbit_writer:mainloop1/2 (rabbit_writer.erl, line 223)
```
because #content.payload_fragments_rev is currently supposed to
be a flat list of binaries instead of being an iolist.
This commit fixes this crash inefficiently by calling
iolist_to_binary/1. A better solution would be to allow AMQP legacy's #content.payload_fragments_rev
to be an iolist.
* Add accidentally deleted line back
* mc: optimise mc_amqp internal format
By removint the outer records for message and delivery annotations
as well as application properties and footers.
* mc: optimis mc_amqp map_add by using upsert
* mc: refactoring and bug fixes
* mc_SUITE routingheader assertions
* mc remove serialize/1 callback as only used by amqp
* mc_amqp: avoid returning a nested list from protocol_state
* test and bug fix
* move infer_type to mc_util
* mc fixes and additiona assertions
* Support headers exchange routing for MQTT messages
When a headers exchange is bound to the MQTT topic exchange, routing
will be performend based on both MQTT topic (by the topic exchange) and
MQTT User Property (by the headers exchange).
This combines the best worlds of both MQTT 5.0 and AMQP 0.9.1 and
enables powerful routing topologies.
When the User Property contains the same name multiple times, only the
last name (and value) will be considered by the headers exchange.
* Fix crash when sending from stream to amqpl
When publishing a message via the stream protocol and consuming it via
AMQP 0.9.1, the following crash occurred prior to this commit:
```
crasher:
initial call: rabbit_channel:init/1
pid: <0.818.0>
registered_name: []
exception exit: {{badmatch,undefined},
[{rabbit_channel,handle_deliver0,4,
[{file,"rabbit_channel.erl"},
{line,2728}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
{rabbit_channel,handle_cast,2,
[{file,"rabbit_channel.erl"},
{line,728}]},
{gen_server2,handle_msg,2,
[{file,"gen_server2.erl"},{line,1056}]},
{proc_lib,wake_up,3,
[{file,"proc_lib.erl"},{line,251}]}]}
```
This commit first gives `mc:init/3` the chance to set exchange and
routing_keys annotations.
If not set, `rabbit_stream_queue` will set these annotations assuming
the message was originally published via the stream protocol.
* Support consistent hash exchange routing for MQTT 5.0
When a consistent hash exchange is bound to the MQTT topic exchange,
MQTT 5.0 messages can be routed to queues consistently based on the
Correlation-Data in the PUBLISH packet.
* Convert MQTT 5.0 User Property
* to AMQP 0.9.1 headers
* from AMQP 0.9.1 headers
* to AMQP 1.0 application properties and message annotations
* from AMQP 1.0 application properties and message annotations
* Make use of Annotations in mc_mqtt:protocol_state/2
mc_mqtt:protocol_state/2 includes Annotations as parameter.
It's cleaner to make use of these Annotations when computing the
protocol state instead of relying on the caller (rabbitmq_mqtt_processor)
to compute the protocol state.
* Enforce AMQP 0.9.1 field name length limit
The AMQP 0.9.1 spec prohibits field names longer than 128 characters.
Therefore, when converting AMQP 1.0 message annotations, application
properties or MQTT 5.0 User Property to AMQP 0.9.1 headers, drop any
names longer than 128 characters.
* Fix type specs
Apply feedback from Michael Davis
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add mc_mqtt unit test suite
Implement mc_mqtt:x_header/2
* Translate indicator that payload is UTF-8 encoded
when converting between MQTT 5.0 and AMQP 1.0
* Translate single amqp-value section from AMQP 1.0 to MQTT
Convert to a text representation, if possible, and indicate to MQTT
client that the payload is UTF-8 encoded. This way, the MQTT client will
be able to parse the payload.
If conversion to text representation is not possible, encode the payload
using the AMQP 1.0 type system and indiate the encoding via Content-Type
message/vnd.rabbitmq.amqp.
This Content-Type is not registered.
Type "message" makes sense since it's a message.
Vendor tree "vnd.rabbitmq.amqp" makes sense since merely subtype "amqp" is not
registered.
* Fix payload conversion
* Translate Response Topic between MQTT and AMQP
Translate MQTT 5.0 Response Topic to AMQP 1.0 reply-to address and vice
versa.
The Response Topic must be a UTF-8 encoded string.
This commit re-uses the already defined RabbitMQ target addresses:
```
"/topic/" RK Publish to amq.topic with routing key RK
"/exchange/" X "/" RK Publish to exchange X with routing key RK
```
By default, the MQTT topic exchange is configure dto be amq.topic using
the 1st target address.
When an operator modifies the mqtt.exchange, the 2nd target address is
used.
* Apply PR feedback
and fix formatting
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* tidy up
* Add MQTT message_containers test
* consistent hash exchange: avoid amqp legacy conversion
When hashing on a header value.
* Avoid converting to amqp legacy when using exchange federation
* Fix test flake
* test and dialyzer fixes
* dialyzer fix
* Add MQTT protocol interoperability tests
Test receiving from and sending to MQTT 5.0 and
* AMQP 0.9.1
* AMQP 1.0
* STOMP
* Streams
* Regenerate portions of deps/rabbit/app.bzl with gazelle
I'm not exactly sure how this happened, but gazell seems to have been
run with an older version of the rules_erlang gazelle extension at
some point. This caused generation of a structure that is no longer
used. This commit updates the structure to the current pattern.
* mc: refactoring
* mc_amqpl: handle delivery annotations
Just in case they are included.
Also use iolist_to_iovec to create flat list of binaries when
converting from amqp with amqp encoded payload.
---------
Co-authored-by: David Ansari <david.ansari@gmx.de>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
2023-08-31 18:27:13 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "message_containers_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "metrics_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2023-01-16 20:35:17 +08:00
|
|
|
rabbitmq_integration_suite(
|
2022-11-24 22:46:08 +08:00
|
|
|
name = "mirrored_supervisor_SUITE",
|
|
|
|
|
size = "small",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/mirrored_supervisor_SUITE_gs.beam",
|
2023-02-07 00:57:10 +08:00
|
|
|
],
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "msg_store_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "peer_discovery_classic_config_SUITE",
|
2023-06-13 21:42:45 +08:00
|
|
|
size = "large",
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "peer_discovery_dns_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_user_connection_channel_limit_partitions_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_user_connection_channel_limit_SUITE",
|
|
|
|
|
size = "medium",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
shard_count = 7,
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_user_connection_channel_tracking_SUITE",
|
|
|
|
|
size = "medium",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
shard_count = 8,
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_user_connection_tracking_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_vhost_connection_limit_partitions_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_vhost_connection_limit_SUITE",
|
|
|
|
|
size = "medium",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
":cluster_rename_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
shard_count = 10,
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_vhost_msg_store_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
2021-03-29 17:01:43 +08:00
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "per_vhost_queue_limit_SUITE",
|
|
|
|
|
size = "medium",
|
2021-03-29 17:01:43 +08:00
|
|
|
)
|
2021-09-30 21:49:08 +08:00
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "policy_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "priority_queue_recovery_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "priority_queue_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "product_info_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "proxy_protocol_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "publisher_confirms_parallel_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "queue_length_limits_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "queue_master_location_SUITE",
|
|
|
|
|
size = "large",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
shard_count = 3,
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "queue_parallel_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
shard_count = 6,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "queue_type_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "quorum_queue_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2023-09-20 17:34:03 +08:00
|
|
|
":test_clustering_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
shard_count = 6,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_confirms_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_core_metrics_gc_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2023-02-23 21:47:41 +08:00
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_cuttlefish_SUITE",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_fifo_int_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
2022-11-24 22:46:08 +08:00
|
|
|
"@aten//:erlang_app",
|
|
|
|
|
"@gen_batch_server//:erlang_app",
|
|
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
"@ra//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_fifo_prop_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_test_util_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
"@proper//:erlang_app",
|
2023-02-23 21:47:41 +08:00
|
|
|
"@ra//:erlang_app",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_fifo_dlx_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_fifo_dlx_integration_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_test_util_beam",
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
":quorum_queue_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
2023-02-23 21:47:41 +08:00
|
|
|
"@ra//:erlang_app",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_fifo_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_test_util_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
":rabbit_fifo_v0_SUITE_beam_files",
|
|
|
|
|
],
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
2023-02-23 21:47:41 +08:00
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
"@ra//:erlang_app",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_fifo_v0_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_test_util_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
2023-02-23 21:47:41 +08:00
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
"@ra//:erlang_app",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_msg_record_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/amqp10_common:erlang_app",
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
Message Containers (#5077)
This PR implements an approach for a "protocol (data format) agnostic core" where the format of the message isn't converted at point of reception.
Currently all non AMQP 0.9.1 originating messages are converted into a AMQP 0.9.1 flavoured basic_message record before sent to a queue. If the messages are then consumed by the originating protocol they are converted back from AMQP 0.9.1. For some protocols such as MQTT 3.1 this isn't too expensive as MQTT is mostly a fairly easily mapped subset of AMQP 0.9.1 but for others such as AMQP 1.0 the conversions are awkward and in some cases lossy even if consuming from the originating protocol.
This PR instead wraps all incoming messages in their originating form into a generic, extensible message container type (mc). The container module exposes an API to get common message details such as size and various properties (ttl, priority etc) directly from the source data type. Each protocol needs to implement the mc behaviour such that when a message originating form one protocol is consumed by another protocol we convert it to the target protocol at that point.
The message container also contains annotations, dead letter records and other meta data we need to record during the lifetime of a message. The original protocol message is never modified unless it is consumed.
This includes conversion modules to and from amqp, amqpl (AMQP 0.9.1) and mqtt.
COMMIT HISTORY:
* Refactor away from using the delivery{} record
In many places including exchange types. This should make it
easier to move towards using a message container type instead of
basic_message.
Add mc module and move direct replies outside of exchange
Lots of changes incl classic queues
Implement stream support incl amqp conversions
simplify mc state record
move mc.erl
mc dlx stuff
recent history exchange
Make tracking work
But doesn't take a protocol agnostic approach as we just convert
everything into AMQP legacy and back. Might be good enough for now.
Tracing as a whole may want a bit of a re-vamp at some point.
tidy
make quorum queue peek work by legacy conversion
dead lettering fixes
dead lettering fixes
CMQ fixes
rabbit_trace type fixes
fixes
fix
Fix classic queue props
test assertion fix
feature flag and backwards compat
Enable message_container feature flag in some SUITEs
Dialyzer fixes
fixes
fix
test fixes
Various
Manually update a gazelle generated file
until a gazelle enhancement can be made
https://github.com/rabbitmq/rules_erlang/issues/185
Add message_containers_SUITE to bazel
and regen bazel files with gazelle from rules_erlang@main
Simplify essential proprty access
Such as durable, ttl and priority by extracting them into annotations
at message container init time.
Move type
to remove dependenc on amqp10 stuff in mc.erl
mostly because I don't know how to make bazel do the right thing
add more stuff
Refine routing header stuff
wip
Cosmetics
Do not use "maybe" as type name as "maybe" is a keyword since OTP 25
which makes Erlang LS complain.
* Dedup death queue names
* Fix function clause crashes
Fix failing tests in the MQTT shared_SUITE:
A classic queue message ID can be undefined as set in
https://github.com/rabbitmq/rabbitmq-server/blob/fbe79ff47b4edbc0fd95457e623d6593161ad198/deps/rabbit/src/rabbit_classic_queue_index_v2.erl#L1048
Fix failing tests in the MQTT shared_SUITE-mixed:
When feature flag message_containers is disabled, the
message is not an #mc{} record, but a #basic_message{} record.
* Fix is_utf8_no_null crash
Prior to this commit, the function crashed if invalid UTF-8 was
provided, e.g.:
```
1> rabbit_misc:is_valid_shortstr(<<"😇"/utf16>>).
** exception error: no function clause matching rabbit_misc:is_utf8_no_null(<<216,61,222,7>>) (rabbit_misc.erl, line 1481)
```
* Implement mqtt mc behaviour
For now via amqp translation.
This is still work in progress, but the following SUITEs pass:
```
make -C deps/rabbitmq_mqtt ct-shared t=[mqtt,v5,cluster_size_1] FULL=1
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_1] FULL=1
```
* Shorten mc file names
Module name length matters because for each persistent message the #mc{}
record is persisted to disk.
```
1> iolist_size(term_to_iovec({mc, rabbit_mc_amqp_legacy})).
30
2> iolist_size(term_to_iovec({mc, mc_amqpl})).
17
```
This commit renames the mc modules:
```
ag -l rabbit_mc_amqp_legacy | xargs sed -i 's/rabbit_mc_amqp_legacy/mc_amqpl/g'
ag -l rabbit_mc_amqp | xargs sed -i 's/rabbit_mc_amqp/mc_amqp/g'
ag -l rabbit_mqtt_mc | xargs sed -i 's/rabbit_mqtt_mc/mc_mqtt/g'
```
* mc: make deaths an annotation + fixes
* Fix mc_mqtt protocol_state callback
* Fix test will_delay_node_restart
```
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_3]:will_delay_node_restart FULL=1
```
* Bazel run gazelle
* mix format rabbitmqctl.ex
* Ensure ttl annotation is refelected in amqp legacy protocol state
* Fix id access in message store
* Fix rabbit_message_interceptor_SUITE
* dializer fixes
* Fix rabbit:rabbit_message_interceptor_SUITE-mixed
set_annotation/3 should not result in duplicate keys
* Fix MQTT shared_SUITE-mixed
Up to 3.12 non-MQTT publishes were always QoS 1 regardless of delivery_mode.
https://github.com/rabbitmq/rabbitmq-server/blob/75a953ce286a10aca910c098805a4f545989af38/deps/rabbitmq_mqtt/src/rabbit_mqtt_processor.erl#L2075-L2076
From now on, non-MQTT publishes are QoS 1 if durable.
This makes more sense.
The MQTT plugin must send a #basic_message{} to an old node that does
not understand message containers.
* Field content of 'v1_0.data' can be binary
Fix
```
bazel test //deps/rabbitmq_mqtt:shared_SUITE-mixed \
--test_env FOCUS="-group [mqtt,v4,cluster_size_1] -case trace" \
-t- --test_sharding_strategy=disabled
```
* Remove route/2 and implement route/3 for all exchange types.
This removes the route/2 callback from rabbit_exchange_type and
makes route/3 mandatory instead. This is a breaking change and
will require all implementations of exchange types to update their
code, however this is necessary anyway for them to correctly handle
the mc type.
stream filtering fixes
* Translate directly from MQTT to AMQP 0.9.1
* handle undecoded properties in mc_compat
amqpl: put clause in right order
recover death deatails from amqp data
* Replace callback init_amqp with convert_from
* Fix return value of lists:keyfind/3
* Translate directly from AMQP 0.9.1 to MQTT
* Fix MQTT payload size
MQTT payload can be a list when converted from AMQP 0.9.1 for example
First conversions tests
Plus some other conversion related fixes.
bazel
bazel
translate amqp 1.0 null to undefined
mc: property/2 and correlation_id/message_id return type tagged values.
To ensure we can support a variety of types better.
The type type tags are AMQP 1.0 flavoured.
fix death recovery
mc_mqtt: impl new api
Add callbacks to allow protocols to compact data before storage
And make readable if needing to query things repeatedly.
bazel fix
* more decoding
* tracking mixed versions compat
* mc: flip default of `durable` annotation to save some data.
Assuming most messages are durable and that in memory messages suffer less
from persistence overhead it makes sense for a non existent `durable`
annotation to mean durable=true.
* mc conversion tests and tidy up
* mc make x_header unstrict again
* amqpl: death record fixes
* bazel
* amqp -> amqpl conversion test
* Fix crash in mc_amqp:size/1
Body can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0/ ct-system t=java
```
on branch native-amqp.
* Fix crash in lists:flatten/1
Data can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp.
* Fix crash in rabbit_writer
Running test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp resulted in the following crash:
```
crasher:
initial call: rabbit_writer:enter_mainloop/2
pid: <0.711.0>
registered_name: []
exception error: bad argument
in function size/1
called as size([<<0>>,<<"Sw">>,[<<160,2>>,<<"hi">>]])
*** argument 1: not tuple or binary
in call from rabbit_binary_generator:build_content_frames/7 (rabbit_binary_generator.erl, line 89)
in call from rabbit_binary_generator:build_simple_content_frames/4 (rabbit_binary_generator.erl, line 61)
in call from rabbit_writer:assemble_frames/5 (rabbit_writer.erl, line 334)
in call from rabbit_writer:internal_send_command_async/3 (rabbit_writer.erl, line 365)
in call from rabbit_writer:handle_message/2 (rabbit_writer.erl, line 265)
in call from rabbit_writer:handle_message/3 (rabbit_writer.erl, line 232)
in call from rabbit_writer:mainloop1/2 (rabbit_writer.erl, line 223)
```
because #content.payload_fragments_rev is currently supposed to
be a flat list of binaries instead of being an iolist.
This commit fixes this crash inefficiently by calling
iolist_to_binary/1. A better solution would be to allow AMQP legacy's #content.payload_fragments_rev
to be an iolist.
* Add accidentally deleted line back
* mc: optimise mc_amqp internal format
By removint the outer records for message and delivery annotations
as well as application properties and footers.
* mc: optimis mc_amqp map_add by using upsert
* mc: refactoring and bug fixes
* mc_SUITE routingheader assertions
* mc remove serialize/1 callback as only used by amqp
* mc_amqp: avoid returning a nested list from protocol_state
* test and bug fix
* move infer_type to mc_util
* mc fixes and additiona assertions
* Support headers exchange routing for MQTT messages
When a headers exchange is bound to the MQTT topic exchange, routing
will be performend based on both MQTT topic (by the topic exchange) and
MQTT User Property (by the headers exchange).
This combines the best worlds of both MQTT 5.0 and AMQP 0.9.1 and
enables powerful routing topologies.
When the User Property contains the same name multiple times, only the
last name (and value) will be considered by the headers exchange.
* Fix crash when sending from stream to amqpl
When publishing a message via the stream protocol and consuming it via
AMQP 0.9.1, the following crash occurred prior to this commit:
```
crasher:
initial call: rabbit_channel:init/1
pid: <0.818.0>
registered_name: []
exception exit: {{badmatch,undefined},
[{rabbit_channel,handle_deliver0,4,
[{file,"rabbit_channel.erl"},
{line,2728}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
{rabbit_channel,handle_cast,2,
[{file,"rabbit_channel.erl"},
{line,728}]},
{gen_server2,handle_msg,2,
[{file,"gen_server2.erl"},{line,1056}]},
{proc_lib,wake_up,3,
[{file,"proc_lib.erl"},{line,251}]}]}
```
This commit first gives `mc:init/3` the chance to set exchange and
routing_keys annotations.
If not set, `rabbit_stream_queue` will set these annotations assuming
the message was originally published via the stream protocol.
* Support consistent hash exchange routing for MQTT 5.0
When a consistent hash exchange is bound to the MQTT topic exchange,
MQTT 5.0 messages can be routed to queues consistently based on the
Correlation-Data in the PUBLISH packet.
* Convert MQTT 5.0 User Property
* to AMQP 0.9.1 headers
* from AMQP 0.9.1 headers
* to AMQP 1.0 application properties and message annotations
* from AMQP 1.0 application properties and message annotations
* Make use of Annotations in mc_mqtt:protocol_state/2
mc_mqtt:protocol_state/2 includes Annotations as parameter.
It's cleaner to make use of these Annotations when computing the
protocol state instead of relying on the caller (rabbitmq_mqtt_processor)
to compute the protocol state.
* Enforce AMQP 0.9.1 field name length limit
The AMQP 0.9.1 spec prohibits field names longer than 128 characters.
Therefore, when converting AMQP 1.0 message annotations, application
properties or MQTT 5.0 User Property to AMQP 0.9.1 headers, drop any
names longer than 128 characters.
* Fix type specs
Apply feedback from Michael Davis
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add mc_mqtt unit test suite
Implement mc_mqtt:x_header/2
* Translate indicator that payload is UTF-8 encoded
when converting between MQTT 5.0 and AMQP 1.0
* Translate single amqp-value section from AMQP 1.0 to MQTT
Convert to a text representation, if possible, and indicate to MQTT
client that the payload is UTF-8 encoded. This way, the MQTT client will
be able to parse the payload.
If conversion to text representation is not possible, encode the payload
using the AMQP 1.0 type system and indiate the encoding via Content-Type
message/vnd.rabbitmq.amqp.
This Content-Type is not registered.
Type "message" makes sense since it's a message.
Vendor tree "vnd.rabbitmq.amqp" makes sense since merely subtype "amqp" is not
registered.
* Fix payload conversion
* Translate Response Topic between MQTT and AMQP
Translate MQTT 5.0 Response Topic to AMQP 1.0 reply-to address and vice
versa.
The Response Topic must be a UTF-8 encoded string.
This commit re-uses the already defined RabbitMQ target addresses:
```
"/topic/" RK Publish to amq.topic with routing key RK
"/exchange/" X "/" RK Publish to exchange X with routing key RK
```
By default, the MQTT topic exchange is configure dto be amq.topic using
the 1st target address.
When an operator modifies the mqtt.exchange, the 2nd target address is
used.
* Apply PR feedback
and fix formatting
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* tidy up
* Add MQTT message_containers test
* consistent hash exchange: avoid amqp legacy conversion
When hashing on a header value.
* Avoid converting to amqp legacy when using exchange federation
* Fix test flake
* test and dialyzer fixes
* dialyzer fix
* Add MQTT protocol interoperability tests
Test receiving from and sending to MQTT 5.0 and
* AMQP 0.9.1
* AMQP 1.0
* STOMP
* Streams
* Regenerate portions of deps/rabbit/app.bzl with gazelle
I'm not exactly sure how this happened, but gazell seems to have been
run with an older version of the rules_erlang gazelle extension at
some point. This caused generation of a structure that is no longer
used. This commit updates the structure to the current pattern.
* mc: refactoring
* mc_amqpl: handle delivery annotations
Just in case they are included.
Also use iolist_to_iovec to create flat list of binaries when
converting from amqp with amqp encoded payload.
---------
Co-authored-by: David Ansari <david.ansari@gmx.de>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
2023-08-31 18:27:13 +08:00
|
|
|
rabbitmq_suite(
|
2023-09-18 16:39:06 +08:00
|
|
|
name = "mc_unit_SUITE",
|
Message Containers (#5077)
This PR implements an approach for a "protocol (data format) agnostic core" where the format of the message isn't converted at point of reception.
Currently all non AMQP 0.9.1 originating messages are converted into a AMQP 0.9.1 flavoured basic_message record before sent to a queue. If the messages are then consumed by the originating protocol they are converted back from AMQP 0.9.1. For some protocols such as MQTT 3.1 this isn't too expensive as MQTT is mostly a fairly easily mapped subset of AMQP 0.9.1 but for others such as AMQP 1.0 the conversions are awkward and in some cases lossy even if consuming from the originating protocol.
This PR instead wraps all incoming messages in their originating form into a generic, extensible message container type (mc). The container module exposes an API to get common message details such as size and various properties (ttl, priority etc) directly from the source data type. Each protocol needs to implement the mc behaviour such that when a message originating form one protocol is consumed by another protocol we convert it to the target protocol at that point.
The message container also contains annotations, dead letter records and other meta data we need to record during the lifetime of a message. The original protocol message is never modified unless it is consumed.
This includes conversion modules to and from amqp, amqpl (AMQP 0.9.1) and mqtt.
COMMIT HISTORY:
* Refactor away from using the delivery{} record
In many places including exchange types. This should make it
easier to move towards using a message container type instead of
basic_message.
Add mc module and move direct replies outside of exchange
Lots of changes incl classic queues
Implement stream support incl amqp conversions
simplify mc state record
move mc.erl
mc dlx stuff
recent history exchange
Make tracking work
But doesn't take a protocol agnostic approach as we just convert
everything into AMQP legacy and back. Might be good enough for now.
Tracing as a whole may want a bit of a re-vamp at some point.
tidy
make quorum queue peek work by legacy conversion
dead lettering fixes
dead lettering fixes
CMQ fixes
rabbit_trace type fixes
fixes
fix
Fix classic queue props
test assertion fix
feature flag and backwards compat
Enable message_container feature flag in some SUITEs
Dialyzer fixes
fixes
fix
test fixes
Various
Manually update a gazelle generated file
until a gazelle enhancement can be made
https://github.com/rabbitmq/rules_erlang/issues/185
Add message_containers_SUITE to bazel
and regen bazel files with gazelle from rules_erlang@main
Simplify essential proprty access
Such as durable, ttl and priority by extracting them into annotations
at message container init time.
Move type
to remove dependenc on amqp10 stuff in mc.erl
mostly because I don't know how to make bazel do the right thing
add more stuff
Refine routing header stuff
wip
Cosmetics
Do not use "maybe" as type name as "maybe" is a keyword since OTP 25
which makes Erlang LS complain.
* Dedup death queue names
* Fix function clause crashes
Fix failing tests in the MQTT shared_SUITE:
A classic queue message ID can be undefined as set in
https://github.com/rabbitmq/rabbitmq-server/blob/fbe79ff47b4edbc0fd95457e623d6593161ad198/deps/rabbit/src/rabbit_classic_queue_index_v2.erl#L1048
Fix failing tests in the MQTT shared_SUITE-mixed:
When feature flag message_containers is disabled, the
message is not an #mc{} record, but a #basic_message{} record.
* Fix is_utf8_no_null crash
Prior to this commit, the function crashed if invalid UTF-8 was
provided, e.g.:
```
1> rabbit_misc:is_valid_shortstr(<<"😇"/utf16>>).
** exception error: no function clause matching rabbit_misc:is_utf8_no_null(<<216,61,222,7>>) (rabbit_misc.erl, line 1481)
```
* Implement mqtt mc behaviour
For now via amqp translation.
This is still work in progress, but the following SUITEs pass:
```
make -C deps/rabbitmq_mqtt ct-shared t=[mqtt,v5,cluster_size_1] FULL=1
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_1] FULL=1
```
* Shorten mc file names
Module name length matters because for each persistent message the #mc{}
record is persisted to disk.
```
1> iolist_size(term_to_iovec({mc, rabbit_mc_amqp_legacy})).
30
2> iolist_size(term_to_iovec({mc, mc_amqpl})).
17
```
This commit renames the mc modules:
```
ag -l rabbit_mc_amqp_legacy | xargs sed -i 's/rabbit_mc_amqp_legacy/mc_amqpl/g'
ag -l rabbit_mc_amqp | xargs sed -i 's/rabbit_mc_amqp/mc_amqp/g'
ag -l rabbit_mqtt_mc | xargs sed -i 's/rabbit_mqtt_mc/mc_mqtt/g'
```
* mc: make deaths an annotation + fixes
* Fix mc_mqtt protocol_state callback
* Fix test will_delay_node_restart
```
make -C deps/rabbitmq_mqtt ct-v5 t=[mqtt,cluster_size_3]:will_delay_node_restart FULL=1
```
* Bazel run gazelle
* mix format rabbitmqctl.ex
* Ensure ttl annotation is refelected in amqp legacy protocol state
* Fix id access in message store
* Fix rabbit_message_interceptor_SUITE
* dializer fixes
* Fix rabbit:rabbit_message_interceptor_SUITE-mixed
set_annotation/3 should not result in duplicate keys
* Fix MQTT shared_SUITE-mixed
Up to 3.12 non-MQTT publishes were always QoS 1 regardless of delivery_mode.
https://github.com/rabbitmq/rabbitmq-server/blob/75a953ce286a10aca910c098805a4f545989af38/deps/rabbitmq_mqtt/src/rabbit_mqtt_processor.erl#L2075-L2076
From now on, non-MQTT publishes are QoS 1 if durable.
This makes more sense.
The MQTT plugin must send a #basic_message{} to an old node that does
not understand message containers.
* Field content of 'v1_0.data' can be binary
Fix
```
bazel test //deps/rabbitmq_mqtt:shared_SUITE-mixed \
--test_env FOCUS="-group [mqtt,v4,cluster_size_1] -case trace" \
-t- --test_sharding_strategy=disabled
```
* Remove route/2 and implement route/3 for all exchange types.
This removes the route/2 callback from rabbit_exchange_type and
makes route/3 mandatory instead. This is a breaking change and
will require all implementations of exchange types to update their
code, however this is necessary anyway for them to correctly handle
the mc type.
stream filtering fixes
* Translate directly from MQTT to AMQP 0.9.1
* handle undecoded properties in mc_compat
amqpl: put clause in right order
recover death deatails from amqp data
* Replace callback init_amqp with convert_from
* Fix return value of lists:keyfind/3
* Translate directly from AMQP 0.9.1 to MQTT
* Fix MQTT payload size
MQTT payload can be a list when converted from AMQP 0.9.1 for example
First conversions tests
Plus some other conversion related fixes.
bazel
bazel
translate amqp 1.0 null to undefined
mc: property/2 and correlation_id/message_id return type tagged values.
To ensure we can support a variety of types better.
The type type tags are AMQP 1.0 flavoured.
fix death recovery
mc_mqtt: impl new api
Add callbacks to allow protocols to compact data before storage
And make readable if needing to query things repeatedly.
bazel fix
* more decoding
* tracking mixed versions compat
* mc: flip default of `durable` annotation to save some data.
Assuming most messages are durable and that in memory messages suffer less
from persistence overhead it makes sense for a non existent `durable`
annotation to mean durable=true.
* mc conversion tests and tidy up
* mc make x_header unstrict again
* amqpl: death record fixes
* bazel
* amqp -> amqpl conversion test
* Fix crash in mc_amqp:size/1
Body can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0/ ct-system t=java
```
on branch native-amqp.
* Fix crash in lists:flatten/1
Data can be a single amqp-value section (instead of
being a list) as shown by test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp.
* Fix crash in rabbit_writer
Running test
```
make -C deps/rabbitmq_amqp1_0 ct-system t=dotnet:roundtrip_to_amqp_091
```
on branch native-amqp resulted in the following crash:
```
crasher:
initial call: rabbit_writer:enter_mainloop/2
pid: <0.711.0>
registered_name: []
exception error: bad argument
in function size/1
called as size([<<0>>,<<"Sw">>,[<<160,2>>,<<"hi">>]])
*** argument 1: not tuple or binary
in call from rabbit_binary_generator:build_content_frames/7 (rabbit_binary_generator.erl, line 89)
in call from rabbit_binary_generator:build_simple_content_frames/4 (rabbit_binary_generator.erl, line 61)
in call from rabbit_writer:assemble_frames/5 (rabbit_writer.erl, line 334)
in call from rabbit_writer:internal_send_command_async/3 (rabbit_writer.erl, line 365)
in call from rabbit_writer:handle_message/2 (rabbit_writer.erl, line 265)
in call from rabbit_writer:handle_message/3 (rabbit_writer.erl, line 232)
in call from rabbit_writer:mainloop1/2 (rabbit_writer.erl, line 223)
```
because #content.payload_fragments_rev is currently supposed to
be a flat list of binaries instead of being an iolist.
This commit fixes this crash inefficiently by calling
iolist_to_binary/1. A better solution would be to allow AMQP legacy's #content.payload_fragments_rev
to be an iolist.
* Add accidentally deleted line back
* mc: optimise mc_amqp internal format
By removint the outer records for message and delivery annotations
as well as application properties and footers.
* mc: optimis mc_amqp map_add by using upsert
* mc: refactoring and bug fixes
* mc_SUITE routingheader assertions
* mc remove serialize/1 callback as only used by amqp
* mc_amqp: avoid returning a nested list from protocol_state
* test and bug fix
* move infer_type to mc_util
* mc fixes and additiona assertions
* Support headers exchange routing for MQTT messages
When a headers exchange is bound to the MQTT topic exchange, routing
will be performend based on both MQTT topic (by the topic exchange) and
MQTT User Property (by the headers exchange).
This combines the best worlds of both MQTT 5.0 and AMQP 0.9.1 and
enables powerful routing topologies.
When the User Property contains the same name multiple times, only the
last name (and value) will be considered by the headers exchange.
* Fix crash when sending from stream to amqpl
When publishing a message via the stream protocol and consuming it via
AMQP 0.9.1, the following crash occurred prior to this commit:
```
crasher:
initial call: rabbit_channel:init/1
pid: <0.818.0>
registered_name: []
exception exit: {{badmatch,undefined},
[{rabbit_channel,handle_deliver0,4,
[{file,"rabbit_channel.erl"},
{line,2728}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
{rabbit_channel,handle_cast,2,
[{file,"rabbit_channel.erl"},
{line,728}]},
{gen_server2,handle_msg,2,
[{file,"gen_server2.erl"},{line,1056}]},
{proc_lib,wake_up,3,
[{file,"proc_lib.erl"},{line,251}]}]}
```
This commit first gives `mc:init/3` the chance to set exchange and
routing_keys annotations.
If not set, `rabbit_stream_queue` will set these annotations assuming
the message was originally published via the stream protocol.
* Support consistent hash exchange routing for MQTT 5.0
When a consistent hash exchange is bound to the MQTT topic exchange,
MQTT 5.0 messages can be routed to queues consistently based on the
Correlation-Data in the PUBLISH packet.
* Convert MQTT 5.0 User Property
* to AMQP 0.9.1 headers
* from AMQP 0.9.1 headers
* to AMQP 1.0 application properties and message annotations
* from AMQP 1.0 application properties and message annotations
* Make use of Annotations in mc_mqtt:protocol_state/2
mc_mqtt:protocol_state/2 includes Annotations as parameter.
It's cleaner to make use of these Annotations when computing the
protocol state instead of relying on the caller (rabbitmq_mqtt_processor)
to compute the protocol state.
* Enforce AMQP 0.9.1 field name length limit
The AMQP 0.9.1 spec prohibits field names longer than 128 characters.
Therefore, when converting AMQP 1.0 message annotations, application
properties or MQTT 5.0 User Property to AMQP 0.9.1 headers, drop any
names longer than 128 characters.
* Fix type specs
Apply feedback from Michael Davis
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add mc_mqtt unit test suite
Implement mc_mqtt:x_header/2
* Translate indicator that payload is UTF-8 encoded
when converting between MQTT 5.0 and AMQP 1.0
* Translate single amqp-value section from AMQP 1.0 to MQTT
Convert to a text representation, if possible, and indicate to MQTT
client that the payload is UTF-8 encoded. This way, the MQTT client will
be able to parse the payload.
If conversion to text representation is not possible, encode the payload
using the AMQP 1.0 type system and indiate the encoding via Content-Type
message/vnd.rabbitmq.amqp.
This Content-Type is not registered.
Type "message" makes sense since it's a message.
Vendor tree "vnd.rabbitmq.amqp" makes sense since merely subtype "amqp" is not
registered.
* Fix payload conversion
* Translate Response Topic between MQTT and AMQP
Translate MQTT 5.0 Response Topic to AMQP 1.0 reply-to address and vice
versa.
The Response Topic must be a UTF-8 encoded string.
This commit re-uses the already defined RabbitMQ target addresses:
```
"/topic/" RK Publish to amq.topic with routing key RK
"/exchange/" X "/" RK Publish to exchange X with routing key RK
```
By default, the MQTT topic exchange is configure dto be amq.topic using
the 1st target address.
When an operator modifies the mqtt.exchange, the 2nd target address is
used.
* Apply PR feedback
and fix formatting
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* tidy up
* Add MQTT message_containers test
* consistent hash exchange: avoid amqp legacy conversion
When hashing on a header value.
* Avoid converting to amqp legacy when using exchange federation
* Fix test flake
* test and dialyzer fixes
* dialyzer fix
* Add MQTT protocol interoperability tests
Test receiving from and sending to MQTT 5.0 and
* AMQP 0.9.1
* AMQP 1.0
* STOMP
* Streams
* Regenerate portions of deps/rabbit/app.bzl with gazelle
I'm not exactly sure how this happened, but gazell seems to have been
run with an older version of the rules_erlang gazelle extension at
some point. This caused generation of a structure that is no longer
used. This commit updates the structure to the current pattern.
* mc: refactoring
* mc_amqpl: handle delivery annotations
Just in case they are included.
Also use iolist_to_iovec to create flat list of binaries when
converting from amqp with amqp encoded payload.
---------
Co-authored-by: David Ansari <david.ansari@gmx.de>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
2023-08-31 18:27:13 +08:00
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/amqp10_common:erlang_app",
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_stream_coordinator_SUITE",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "rabbit_stream_sac_coordinator_SUITE",
|
2023-03-31 16:16:06 +08:00
|
|
|
runtime_deps = [
|
|
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
],
|
2023-04-13 17:09:12 +08:00
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_stream_queue_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
2023-07-27 19:01:44 +08:00
|
|
|
shard_count = 21,
|
2022-11-24 22:46:08 +08:00
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2023-07-05 17:02:47 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbitmq_4_0_deprecations_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbitmq_queues_cli_integration_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbitmqctl_integration_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbitmqctl_shutdown_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "signal_handling_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "simple_ha_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
additional_beam = [
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_rabbit_ha_test_consumer_beam",
|
|
|
|
|
":test_rabbit_ha_test_producer_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
shard_count = 4,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "single_active_consumer_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "sync_detection_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "term_to_binary_compat_prop_SUITE",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "topic_permission_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2023-09-07 17:00:20 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "transactions_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_access_control_authn_authz_context_propagation_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/rabbit_auth_backend_context_propagation_mock.beam",
|
|
|
|
|
"test/rabbit_foo_protocol_connection_info.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_access_control_credential_validation_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_access_control_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/rabbit_dummy_protocol_connection_info.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_amqp091_content_framing_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_amqp091_server_properties_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2023-07-20 01:00:41 +08:00
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_quorum_queue_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_app_management_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_cluster_formation_locking_mocks_SUITE",
|
|
|
|
|
size = "small",
|
2023-02-23 21:47:41 +08:00
|
|
|
deps = [
|
2022-11-24 22:46:08 +08:00
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_collections_SUITE",
|
|
|
|
|
size = "small",
|
2023-02-23 21:47:41 +08:00
|
|
|
deps = [
|
2022-11-24 22:46:08 +08:00
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_config_value_encryption_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
deps = [
|
2022-11-24 22:46:08 +08:00
|
|
|
"//deps/rabbit/apps/rabbitmq_prelaunch:test_erlang_app",
|
|
|
|
|
"//deps/rabbit_common:test_erlang_app",
|
|
|
|
|
"@credentials_obfuscation//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_connection_tracking_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_credit_flow_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_disk_monitor_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_file_handle_cache_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_gen_server2_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_gm_SUITE",
|
|
|
|
|
size = "small",
|
2023-02-23 21:47:41 +08:00
|
|
|
deps = [
|
2022-11-24 22:46:08 +08:00
|
|
|
"//deps/rabbitmq_ct_helpers:erlang_app",
|
|
|
|
|
"@meck//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_log_management_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_operator_policy_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:test_erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_pg_local_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_plugin_directories_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:test_erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_plugin_versioning_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_policy_validators_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_priority_queue_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_queue_consumers_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_stats_and_metrics_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/dummy_event_receiver.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_supervisor2_SUITE",
|
|
|
|
|
size = "small",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/dummy_supervisor2.beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unit_vm_memory_monitor_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "upgrade_preparation_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "vhost_SUITE",
|
|
|
|
|
size = "medium",
|
2023-02-23 21:47:41 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/test_rabbit_event_handler.beam",
|
2023-02-14 03:38:25 +08:00
|
|
|
],
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_classic_mirrored_queue_sync_throttling_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_suite(
|
|
|
|
|
name = "unit_classic_mirrored_queue_throughput_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"//deps/rabbit_common:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "direct_exchange_routing_v2_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2022-11-24 22:46:08 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_direct_reply_to_prop_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2022-11-24 22:46:08 +08:00
|
|
|
deps = [
|
|
|
|
|
"@proper//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "unicode_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2022-11-24 22:46:08 +08:00
|
|
|
)
|
|
|
|
|
|
2023-01-09 17:46:18 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "exchanges_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
additional_beam = [
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2023-01-16 20:35:17 +08:00
|
|
|
],
|
2023-01-09 17:46:18 +08:00
|
|
|
)
|
|
|
|
|
|
2023-01-13 03:35:54 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "bindings_SUITE",
|
2023-02-16 04:04:14 +08:00
|
|
|
size = "medium",
|
2023-01-13 03:35:54 +08:00
|
|
|
)
|
2023-01-09 17:46:18 +08:00
|
|
|
|
2023-01-16 20:35:17 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_queue_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_maintenance_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_topic_exchange_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_exchange_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_binding_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_msup_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "rabbit_db_policy_SUITE",
|
2023-02-23 21:47:41 +08:00
|
|
|
size = "medium",
|
2023-01-16 20:35:17 +08:00
|
|
|
)
|
|
|
|
|
|
2023-04-18 07:29:12 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "runtime_parameters_SUITE",
|
|
|
|
|
size = "small",
|
2023-04-19 17:46:22 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
"test/dummy_runtime_parameters.beam",
|
2023-04-18 07:29:12 +08:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "metadata_store_clustering_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
shard_count = 18,
|
|
|
|
|
sharding_method = "case",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "metadata_store_phase1_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
deps = [
|
|
|
|
|
"@khepri//:erlang_app",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "metadata_store_migration_SUITE",
|
|
|
|
|
size = "small",
|
|
|
|
|
)
|
|
|
|
|
|
2023-09-01 16:36:17 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "routing_SUITE",
|
|
|
|
|
size = "large",
|
|
|
|
|
)
|
|
|
|
|
|
2023-09-15 18:56:59 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "cli_forget_cluster_node_SUITE",
|
|
|
|
|
size = "medium",
|
|
|
|
|
additional_beam = [
|
|
|
|
|
":test_clustering_utils_beam",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
rabbitmq_integration_suite(
|
|
|
|
|
name = "cluster_minority_SUITE",
|
2023-09-29 23:13:20 +08:00
|
|
|
size = "large",
|
Allow to use Khepri database to store metadata instead of Mnesia
[Why]
Mnesia is a very powerful and convenient tool for Erlang applications:
it is a persistent disc-based database, it handles replication accross
multiple Erlang nodes and it is available out-of-the-box from the
Erlang/OTP distribution. RabbitMQ relies on Mnesia to manage all its
metadata:
* virtual hosts' properties
* intenal users
* queue, exchange and binding declarations (not queues data)
* runtime parameters and policies
* ...
Unfortunately Mnesia makes it difficult to handle network partition and,
as a consequence, the merge conflicts between Erlang nodes once the
network partition is resolved. RabbitMQ provides several partition
handling strategies but they are not bullet-proof. Users still hit
situations where it is a pain to repair a cluster following a network
partition.
[How]
@kjnilsson created Ra [1], a Raft consensus library that RabbitMQ
already uses successfully to implement quorum queues and streams for
instance. Those queues do not suffer from network partitions.
We created Khepri [2], a new persistent and replicated database engine
based on Ra and we want to use it in place of Mnesia in RabbitMQ to
solve the problems with network partitions.
This patch integrates Khepri as an experimental feature. When enabled,
RabbitMQ will store all its metadata in Khepri instead of Mnesia.
This change comes with behavior changes. While Khepri remains disabled,
you should see no changes to the behavior of RabbitMQ. If there are
changes, it is a bug. After Khepri is enabled, there are significant
changes of behavior that you should be aware of.
Because it is based on the Raft consensus algorithm, when there is a
network partition, only the cluster members that are in the partition
with at least `(Number of nodes in the cluster ÷ 2) + 1` number of nodes
can "make progress". In other words, only those nodes may write to the
Khepri database and read from the database and expect a consistent
result.
For instance in a cluster of 5 RabbitMQ nodes:
* If there are two partitions, one with 3 nodes, one with 2 nodes, only
the group of 3 nodes will be able to write to the database.
* If there are three partitions, two with 2 nodes, one with 1 node, none
of the group can write to the database.
Because the Khepri database will be used for all kind of metadata, it
means that RabbitMQ nodes that can't write to the database will be
unable to perform some operations. A list of operations and what to
expect is documented in the associated pull request and the RabbitMQ
website.
This requirement from Raft also affects the startup of RabbitMQ nodes in
a cluster. Indeed, at least a quorum number of nodes must be started at
once to allow nodes to become ready.
To enable Khepri, you need to enable the `khepri_db` feature flag:
rabbitmqctl enable_feature_flag khepri_db
When the `khepri_db` feature flag is enabled, the migration code
performs the following two tasks:
1. It synchronizes the Khepri cluster membership from the Mnesia
cluster. It uses `mnesia_to_khepri:sync_cluster_membership/1` from
the `khepri_mnesia_migration` application [3].
2. It copies data from relevant Mnesia tables to Khepri, doing some
conversion if necessary on the way. Again, it uses
`mnesia_to_khepri:copy_tables/4` from `khepri_mnesia_migration` to do
it.
This can be performed on a running standalone RabbitMQ node or cluster.
Data will be migrated from Mnesia to Khepri without any service
interruption. Note that during the migration, the performance may
decrease and the memory footprint may go up.
Because this feature flag is considered experimental, it is not enabled
by default even on a brand new RabbitMQ deployment.
More about the implementation details below:
In the past months, all accesses to Mnesia were isolated in a collection
of `rabbit_db*` modules. This is where the integration of Khepri mostly
takes place: we use a function called `rabbit_khepri:handle_fallback/1`
which selects the database and perform the query or the transaction.
Here is an example from `rabbit_db_vhost`:
* Up until RabbitMQ 3.12.x:
get(VHostName) when is_binary(VHostName) ->
get_in_mnesia(VHostName).
* Starting with RabbitMQ 3.13.0:
get(VHostName) when is_binary(VHostName) ->
rabbit_khepri:handle_fallback(
#{mnesia => fun() -> get_in_mnesia(VHostName) end,
khepri => fun() -> get_in_khepri(VHostName) end}).
This `rabbit_khepri:handle_fallback/1` function relies on two things:
1. the fact that the `khepri_db` feature flag is enabled, in which case
it always executes the Khepri-based variant.
4. the ability or not to read and write to Mnesia tables otherwise.
Before the feature flag is enabled, or during the migration, the
function will try to execute the Mnesia-based variant. If it succeeds,
then it returns the result. If it fails because one or more Mnesia
tables can't be used, it restarts from scratch: it means the feature
flag is being enabled and depending on the outcome, either the
Mnesia-based variant will succeed (the feature flag couldn't be enabled)
or the feature flag will be marked as enabled and it will call the
Khepri-based variant. The meat of this function really lives in the
`khepri_mnesia_migration` application [3] and
`rabbit_khepri:handle_fallback/1` is a wrapper on top of it that knows
about the feature flag.
However, some calls to the database do not depend on the existence of
Mnesia tables, such as functions where we need to learn about the
members of a cluster. For those, we can't rely on exceptions from
Mnesia. Therefore, we just look at the state of the feature flag to
determine which database to use. There are two situations though:
* Sometimes, we need the feature flag state query to block because the
function interested in it can't return a valid answer during the
migration. Here is an example:
case rabbit_khepri:is_enabled(RemoteNode) of
true -> can_join_using_khepri(RemoteNode);
false -> can_join_using_mnesia(RemoteNode)
end
* Sometimes, we need the feature flag state query to NOT block (for
instance because it would cause a deadlock). Here is an example:
case rabbit_khepri:get_feature_state() of
enabled -> members_using_khepri();
_ -> members_using_mnesia()
end
Direct accesses to Mnesia still exists. They are limited to code that is
specific to Mnesia such as classic queue mirroring or network partitions
handling strategies.
Now, to discover the Mnesia tables to migrate and how to migrate them,
we use an Erlang module attribute called
`rabbit_mnesia_tables_to_khepri_db` which indicates a list of Mnesia
tables and an associated converter module. Here is an example in the
`rabbitmq_recent_history_exchange` plugin:
-rabbit_mnesia_tables_to_khepri_db(
[{?RH_TABLE, rabbit_db_rh_exchange_m2k_converter}]).
The converter module — `rabbit_db_rh_exchange_m2k_converter` in this
example — is is fact a "sub" converter module called but
`rabbit_db_m2k_converter`. See the documentation of a `mnesia_to_khepri`
converter module to learn more about these modules.
[1] https://github.com/rabbitmq/ra
[2] https://github.com/rabbitmq/khepri
[3] https://github.com/rabbitmq/khepri_mnesia_migration
See #7206.
Co-authored-by: Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com>
Co-authored-by: Diana Parra Corbacho <dparracorbac@vmware.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2023-01-05 20:57:50 +08:00
|
|
|
additional_beam = [
|
|
|
|
|
":test_clustering_utils_beam",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2022-11-24 22:46:08 +08:00
|
|
|
assert_suites()
|
|
|
|
|
|
2021-09-30 21:49:08 +08:00
|
|
|
filegroup(
|
|
|
|
|
name = "manpages",
|
|
|
|
|
srcs = glob([
|
|
|
|
|
"docs/*.1",
|
|
|
|
|
"docs/*.2",
|
|
|
|
|
"docs/*.3",
|
|
|
|
|
"docs/*.4",
|
|
|
|
|
"docs/*.5",
|
|
|
|
|
"docs/*.6",
|
|
|
|
|
"docs/*.7",
|
|
|
|
|
"docs/*.8",
|
|
|
|
|
"docs/*.9",
|
|
|
|
|
]),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
genrule(
|
|
|
|
|
name = "manpages-dir",
|
|
|
|
|
srcs = [":manpages"],
|
|
|
|
|
outs = ["manpages.tar"],
|
|
|
|
|
cmd = """set -euo pipefail
|
|
|
|
|
|
2023-05-01 16:32:59 +08:00
|
|
|
DESTDIR=share/man
|
2021-09-30 21:49:08 +08:00
|
|
|
mkdir -p $${DESTDIR}
|
|
|
|
|
for mp in $(SRCS); do
|
|
|
|
|
section=$${mp##*.}
|
|
|
|
|
mkdir -p $${DESTDIR}/man$$section
|
|
|
|
|
gzip < $$mp \\
|
|
|
|
|
> $${DESTDIR}/man$$section/$$(basename $$mp).gz
|
|
|
|
|
done
|
2023-05-01 16:32:59 +08:00
|
|
|
tar -cf $@ share
|
|
|
|
|
rm -dr share
|
2021-09-30 21:49:08 +08:00
|
|
|
""",
|
|
|
|
|
visibility = ["//visibility:public"],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
genrule(
|
|
|
|
|
name = "web-manpages",
|
|
|
|
|
srcs = [":manpages"],
|
|
|
|
|
outs = ["web-manpages.tar"],
|
|
|
|
|
cmd = """set -euo pipefail
|
|
|
|
|
|
|
|
|
|
mkdir web-manpages-tmp
|
|
|
|
|
for mp in $(SRCS); do
|
|
|
|
|
d=web-manpages-tmp/$$(basename $${mp}).html
|
|
|
|
|
echo "Converting $$mp to $$d..."
|
|
|
|
|
mandoc -T html -O 'fragment,man=%N.%S.html' "$$mp" | \\
|
|
|
|
|
awk '\\
|
|
|
|
|
/^<table class="head">$$/ { remove_table=1; next; } \\
|
|
|
|
|
/^<table class="foot">$$/ { remove_table=1; next; } \\
|
|
|
|
|
/^<\\/table>$$/ { if (remove_table) { remove_table=0; next; } } \\
|
|
|
|
|
{ if (!remove_table) { \\
|
|
|
|
|
line=$$0; \\
|
|
|
|
|
gsub(/<h2/, "<h3", line); \\
|
|
|
|
|
gsub(/<\\/h2>/, "</h3>", line); \\
|
|
|
|
|
gsub(/<h1/, "<h2", line); \\
|
|
|
|
|
gsub(/<\\/h1>/, "</h2>", line); \\
|
|
|
|
|
gsub(/class="D1"/, "class=\"D1 lang-bash\"", line); \\
|
|
|
|
|
gsub(/class="Bd Bd-indent"/, "class=\"Bd Bd-indent lang-bash\"", line); \\
|
|
|
|
|
gsub(/&#[xX]201[cCdD];/, "\\"", line); \\
|
|
|
|
|
print line; \\
|
|
|
|
|
} } \\
|
|
|
|
|
' > "$$d"
|
|
|
|
|
done
|
|
|
|
|
tar --strip-components 1 -cf $@ web-manpages-tmp/*
|
|
|
|
|
rm -dr web-manpages-tmp
|
|
|
|
|
""",
|
|
|
|
|
visibility = ["//visibility:public"],
|
|
|
|
|
)
|
2023-02-23 21:47:41 +08:00
|
|
|
|
|
|
|
|
alias(
|
|
|
|
|
name = "rabbit",
|
|
|
|
|
actual = ":erlang_app",
|
|
|
|
|
visibility = ["//visibility:public"],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
eunit(
|
|
|
|
|
name = "eunit",
|
|
|
|
|
compiled_suites = [
|
|
|
|
|
":test_channel_operation_timeout_test_queue_beam",
|
|
|
|
|
":test_dummy_event_receiver_beam",
|
|
|
|
|
":test_dummy_interceptor_beam",
|
|
|
|
|
":test_dummy_runtime_parameters_beam",
|
|
|
|
|
":test_dummy_supervisor2_beam",
|
|
|
|
|
":test_failing_dummy_interceptor_beam",
|
|
|
|
|
":test_mirrored_supervisor_SUITE_gs_beam",
|
2023-09-13 22:29:23 +08:00
|
|
|
":test_queue_utils_beam",
|
2023-02-23 21:47:41 +08:00
|
|
|
":test_rabbit_auth_backend_context_propagation_mock_beam",
|
|
|
|
|
":test_rabbit_dummy_protocol_connection_info_beam",
|
|
|
|
|
":test_rabbit_foo_protocol_connection_info_beam",
|
|
|
|
|
":test_rabbit_ha_test_consumer_beam",
|
|
|
|
|
":test_rabbit_ha_test_producer_beam",
|
|
|
|
|
":test_test_util_beam",
|
|
|
|
|
":test_test_rabbit_event_handler_beam",
|
2023-09-01 12:02:31 +08:00
|
|
|
":test_clustering_utils_beam",
|
2023-02-23 21:47:41 +08:00
|
|
|
],
|
|
|
|
|
target = ":test_erlang_app",
|
2023-10-16 21:14:56 +08:00
|
|
|
test_env = {
|
|
|
|
|
"COVERDATA_TO_LCOV_APPS_DIRS": "deps:deps/rabbit/apps",
|
|
|
|
|
},
|
2023-02-23 21:47:41 +08:00
|
|
|
)
|
