b157b6a7cf
Do not use defcmd macro.
2019-02-14 13:16:49 -05:00
1b4aaac477
Formatting of the help message
2019-02-14 13:11:23 -05:00
a56ee97d74
Make help sections and descriptions similar to man page.
2019-02-14 13:02:00 -05:00
82fa8f2e1d
Add rabbitmq-queues shrink command
...
That removes all quorum queue members for a given node.
[#162782789 ]
2019-02-14 17:04:55 +00:00
7edf3d87ca
Use elixir internal distance function instead of a library for command similarity comparison.
...
Elixir provides String.jaro_distance function, which is similar to
the levenstain distance.
This allows us to remove a dependency.
2019-02-12 15:22:02 -05:00
9fdeaef417
Clarify that list_connections command ony applies to AMQP 0.9.1
2019-02-12 14:49:16 -05:00
9231b21305
Follow-up to #298 : descriptions and aliases for TLS-enabled listeners
2019-02-12 14:14:54 +03:00
a5c34042de
Example of using defcmd to define constant command callbacks
2019-02-11 14:07:49 -05:00
680c8969ca
Add more command descriptions
2019-02-11 14:07:34 -05:00
5fabaeddb4
Cleanup help command. Support plugin sections in command list.
2019-02-11 14:06:16 -05:00
8bae6cd929
Add behaviour helpers.
...
Instead of calling function_exported? every time to access behaviour
functions, call CommandBehaviour.function.
Isolate all function defaults in the CommandBehaviour module.
Add a macro to define constant command functions.
2019-02-11 14:03:19 -05:00
a7d70f1448
More descriptions for commands
2019-02-11 09:35:12 -05:00
b17a998ed1
list_feature_flags_command.ex: Add `doc_url` to the columns list
...
[#160169569 ]
2019-02-11 11:01:18 +01:00
3d13da5797
More command descriptions.
2019-02-08 15:57:10 -05:00
d6789e60f2
A new way to display basic usage.
...
Do not show additional parameters info.
List commands as names and descriptions.
Group commands in sections.
New behaviour callbacks:
help_section/0 - atom name of a group to put command to. Default is :other
description/0 - single line description of the command. Printed in the commands list
Sections ans descriptions are WIP.
2019-02-08 15:33:17 -05:00
b452733d73
Improve error message produced by `rabbitmqctl shutdown`
...
References #309 .
2019-02-07 04:24:13 +03:00
f526663e9a
Cosmetics
2019-02-05 21:29:28 +03:00
41148d2f4d
Mention --longnames in the generic diagnostics message
...
Note that more specific errors are coming from
rabbit_nodes_common.
2019-02-05 21:11:00 +03:00
95e5b78af6
Output a friendly error if a long node name is used but --longnames not specified
2019-02-05 08:56:04 -08:00
962e0cf7c7
Ensure longnames option is passed to normalise_node
...
Fixes #311
2019-02-05 07:27:34 -08:00
97c048cf37
Add active consumer fields if necessary
...
When calling node is 3.8 and one of the nodes is < 3.8, active and
activity status fields need to be set with default values.
[#163298456 ]
2019-02-05 15:06:51 +01:00
aa93258f16
wait_command.ex: Fix function clause with validate/2
...
The function didn't have the success path, i.e. when one of `--pid` or a
pidfile is specified.
2019-02-04 12:07:53 +01:00
041a6c2bdf
Reuse existing modules more, rearrange functions
2019-02-04 02:22:21 +03:00
a392d8e432
This clause is no longer necessary
2019-02-03 22:01:29 +03:00
56ac8d1cf7
shutdown: correctly wrap badrpc responses in validate/2
2019-02-03 22:00:11 +03:00
7ad9176435
Further improvements to the shutdown command
...
Add --[no-]wait (enabled by default) for those who would prefer
to use it to shut down remote nodes even though it wouldn't wait for
a verified node termination.
Propagate --timeout to calls.
References #309 .
2019-02-03 20:40:01 +03:00
0786b13d4a
Move the node locality to a validator
2019-02-03 18:37:28 +03:00
29d01a44fb
Merge branch 'master' into shutdown_require_local_host
2019-02-03 18:15:17 +03:00
da514824c9
No more "error, operation completed successfully" jokes necessary
2019-02-03 06:20:35 +03:00
db72acf1a3
Squash a couple of warnings
2019-02-03 06:20:04 +03:00
2ad334c91f
Refactor
2019-02-03 04:55:37 +03:00
bf00712add
Make all list_* commands available to rabbitmq-diagnostics
2019-02-03 04:32:37 +03:00
e25fee769a
Set `feature_flags_file` app env for {forget,rename}_cluster_node
...
This is required when we try to impersonate a node: that node needs to
know about the actually enabled feature flags to act properly.
[#160169569 ]
2019-02-02 01:30:27 +01:00
8bf5e81926
Merge pull request #308 from rabbitmq/rabbitmqctl-cli-307
...
Support bare --help
2019-02-01 21:43:17 +04:00
627f3893bf
records.ex: The `#amqqueue{}` record is now private
...
No need to import it in the Elixir world.
[#159298729 ]
2019-02-01 17:51:24 +01:00
e22936b38c
New `pretty_table` formatter
...
Use it by specifying the following flag on the command line:
--formatter pretty_table
Tables are printed using ANSI line drawing (or ASCII characters) and
colors.
Example:
Listing queues for vhost / ...
┌──────┬──────────┬──────────────────┐
│ name │ messages │ pid │
├──────┼──────────┼──────────────────┤
│ b │ 0 │ #PID<9901.899.0> │
├──────┼──────────┼──────────────────┤
│ c │ 0 │ #PID<9901.914.0> │
├──────┼──────────┼──────────────────┤
│ a │ 0 │ #PID<9901.887.0> │
└──────┴──────────┴──────────────────┘
Internally, it uses the `rabbit_pretty_stdout` module from
rabbitmq-common.
2019-02-01 17:51:24 +01:00
9b01b1cf3c
Add `list_feature_flags` and `enable_feature_flag` commands
...
As their name suggests, they are used to manage the feature flags of
RabbitMQ and its plugins.
[#159298729 ]
2019-02-01 17:51:21 +01:00
7bc4bf9dfa
Make shutdown command require a node to be local.
...
Shutdown waits for the node to stop based on OS pid,
if the node is not local, it will be the wrong pid.
[#142699795 ]
2019-02-01 11:47:37 -05:00
0053f67485
Support bare --help
...
Note that there's a different between the case with no arguments
(exits with EX_USAGE) and --help (exits successfully).
Per discussion with the team.
Closes #307 .
2019-02-01 19:47:09 +03:00
345ce6d867
Cosmetic: move default switches and aliases to the top of the parser module
2019-01-31 11:38:46 -05:00
db2f6bc4e6
Help message copywriting
2019-01-31 01:39:12 +03:00
c79ac644b9
Mention --help in the global option section
2019-01-31 01:14:55 +03:00
5e5f4d461c
Make it possible to get command help by typing 'rabbitmqctl mycommand --help'
...
Add a new default switch `help`
Add an alias `?`
Make rabbitmqctl display command help if this option is true for known commands.
2019-01-30 16:47:18 -05:00
91bb84bc82
Move table_headers parameter definition to formatter.
...
Since #301 formatters support their own parameters
2019-01-30 16:02:11 -05:00
94b55d71fa
Format with `gmake format`
2019-01-30 22:20:29 +03:00
de3bca0658
memory_breakdown: correctly format for CSV
2019-01-30 21:47:07 +03:00
7db0d6ee01
Present correct name for `rabbitmq-diagnostics check_alarms`
2019-01-30 16:08:46 +03:00
724dbca331
Merge pull request #303 from rabbitmq/await_startup_with_a_timeout
...
New command: `rabbitmqctl await_startup`
2019-01-28 21:06:41 +03:00
5fad316390
New command: `rabbitmqctl await_startup`
...
Like `rabbitmqctl wait` but doesn't use a pid file path.
Pair: @gerhard.
References rabbitmq/rabbitmq-server#1848 .
2019-01-28 20:45:08 +03:00
606b72b5a6
Add active to default fields for list_consumers
...
[#163298456 ]
References rabbitmq/rabbitmq-server#1839
2019-01-24 18:26:39 +01:00
1732932f7b
Merge branch 'master' into rabbitmq-server-1838-active-field-for-consumers
2019-01-24 10:46:58 +01:00
7c44eeb0d9
Move get_formatter/2, get_printer/2 and friends to RabbitMQ.CLI.Core.Config
...
To avoid RabbitMQCtl being used as a library module and because
they both are effectively generic configurable settings.
2019-01-24 11:11:04 +03:00
d767b4520b
Merge branch 'master' into formatter_switches
2019-01-24 10:57:34 +03:00
a6cf0c5539
Correct protocol labels for STOMP and MQTT
2019-01-24 10:37:36 +03:00
e6530d6799
Make it possible for formatters to define arguments.
...
Add new callbacks to formatter_behavior: switches/0 and aliases/0
Merge them with command switches and aliases on parsing.
There is an example switch in the table formatter, enabling header padding.
2019-01-23 18:04:12 -05:00
e8729c5de0
Introduce 'rabbitmq-diagnostics check_port_connectivity'
2019-01-23 22:30:20 +03:00
ad23b37e3f
Introduce 'rabbitmq-diagnostics check_port_listener <port>'
...
Part of #292 .
2019-01-23 19:13:08 +03:00
bd618db9cd
Introduce 'rabbitmq-diagnostics check_protocol_listener'
...
Part of #292 .
2019-01-23 17:45:37 +03:00
3f9c982d44
Standardize on :not_enough_args
...
That's what most commands use and the execution pipeline
expects.
2019-01-23 15:20:24 +03:00
9a134415fc
More typos
2019-01-23 14:15:38 +03:00
fefc8047dc
One more typo
2019-01-23 14:15:26 +03:00
ad5902a5f8
Clarify
2019-01-23 14:14:50 +03:00
9df7048425
Correct a moduledoc typo
2019-01-23 14:14:20 +03:00
53f064b989
Remove an unused alias
2019-01-23 10:49:27 +03:00
5c4ed6b912
Format generic error triplets
2019-01-23 10:44:19 +03:00
94d5216e68
New check command: 'rabbitmq-diagnostics check_running'
...
Like is_running but will exit with a non-0 code if the app is
not running on the target node.
2019-01-23 10:43:12 +03:00
51d7490bd7
Use exit code of 69 (EX_UNAVAILABLE) by default
...
Per [1], which is still the best guide on the subject we could find,
EX_UNAVAILABLE makes more sense as a catch-all error compared to EX_SOFTWARE.
Per discussion with @gerhard.
1. https://www.freebsd.org/cgi/man.cgi?query=sysexits&apropos=0&sektion=0&manpath=FreeBSD+12.0-RELEASE&arch=default&format=html
2019-01-23 10:20:46 +03:00
58a66af140
Refactoring
2019-01-23 10:12:27 +03:00
18ff37665c
Change rabbitmq-diagnostics is_booting and is_running to be info commands
...
This means that even in the "negative" response they exit with a 0
status code. In other words, they just tell the user the state of things
without asserting on what constitutes a success or failure.
This is consistent with some recently introduced diagnostics commands:
some are "informational" (simply provide an insight into the state
of the node) and others are checks (optinionated, consider certain
conditions to be faulty and exit with a non-zero exit code).
References #292 .
2019-01-23 08:49:05 +03:00
b87678ee99
Follow command naming pattern in file names, too
2019-01-23 07:29:51 +03:00
dbbb475b16
Fix compiler warnings
2019-01-22 13:53:49 +03:00
cf226bb004
Tests and revisions for 'rabbitmq-diagnostics check[_local]_alarms'
...
References #292 .
2019-01-22 13:28:42 +03:00
4bc3e51461
Introduce rabbitmq-diagnostics check[_local]_alarms
...
References #292 .
2019-01-22 13:28:42 +03:00
aad1c3ae0e
Correct local vs. global alarm filtering
2019-01-22 13:27:52 +03:00
44e453fe25
Initial version of rabbitmq-diagnostics alarms
2019-01-22 13:27:51 +03:00
4d9c6462f1
Enquote listener interface for machine-readable formats, too
2019-01-22 12:26:28 +03:00
e938a6c1e1
Initial version of the 'rabbitmq-diagnostics listeners' command
...
Part of #292 .
2019-01-22 12:26:28 +03:00
1722a085d9
JSON formatter: flatten the stream before formatting
...
Otherwise JSON array items are enclosed in an array, which unlikely
was the intent.
(cherry picked from commit b66751490798d1b374a0ffde73307b84f510f420)
2019-01-22 11:49:27 +03:00
ca396e0ce5
Add active and activity status fields to list_consumers
...
[#163298456 ]
References rabbitmq/rabbitmq-management#1838
2019-01-21 14:36:53 +01:00
08fb2b77fb
Copy, list plugins that are not enabled
2019-01-21 13:36:58 +03:00
e54134baa5
Code style
2019-01-21 13:29:52 +03:00
a6338ba134
Use return code of 69 Unavailable here
2019-01-21 13:29:33 +03:00
84c1d51c92
Introducee rabbitmq-plugins is_enabled [plugin 1] [plugin 2] [...]
...
Part of #292 .
2019-01-21 11:02:10 +03:00
be2c1e7101
Introoduce rabbitmq-diagnostics is_running, is_booting
2019-01-20 07:33:40 +03:00
b6f4d75afc
Update (c) year
2019-01-20 06:10:59 +03:00
c6d4fcf19d
Add single active field to list_consumers command
...
[#163089472 ]
References rabbitmq/rabbitmq-management#649
2019-01-16 10:38:57 +01:00
9479a466f5
Revert "Pad info items in the table formatter to be at least as wide as header."
...
This reverts commit fc4264224a
2018-12-29 01:44:16 +03:00
fc4264224a
Pad info items in the table formatter to be at least as wide as header.
2018-12-28 17:42:21 +04:00
d0ea645ea3
New command: rabbitmq-diagnostics tls_versions
...
Like cipher_suites but for supported (available in the runtime)
TLS versions.
[#162832991 ]
2018-12-24 15:25:35 +03:00
f1b6283e9f
Format changed file with "mix format"
2018-12-19 16:14:43 -08:00
7629703ca4
Add chunks equal to number of nodes
...
Fixes #284
2018-12-19 14:44:53 -08:00
ac653965f4
Improve error message formatting for rabbitmq-plugins commands
...
There are two main types of errors that I see in practice:
* Insufficient enabled plugins file permission (or the file does not exist)
* Enabled plugins file used by CLI tools does not match that of
the target node
[#162757498 ]
2018-12-19 15:54:23 +03:00
e0e33f4b73
New diagnostics command: runtime_thread_stats
...
Uses Erlang's microstate accounting data to produce
high level thread state/activity breakdown.
Per discussion with @gerhard.
2018-12-07 18:43:48 +03:00
b523093c3e
Port Erlang/OTP node name code to Elixir
...
Follow-up to #278
Add another test case, fix bugs
Add another test
Start converting to new code
Node name related code is in NodeName module
Distribution not needed for Helpers tests
Add test for rabbit@localhost when longnames in use
No need to guess on domain in this spot
Fix behavior on OS X
2018-12-05 11:23:17 -08:00
5861d2da3b
Do not raise error as offline commands will crash
2018-11-30 15:02:22 -08:00
1d878c79e1
Fix merge defaults test, fix warnings
2018-11-30 14:48:47 -08:00
9cc61e594b
Add tests for normalising name with :longnames
2018-11-30 13:58:27 -08:00
ff6243bfd2
Fix test for @hostname case
2018-11-30 12:27:58 -08:00
35ffd53be1
Rename parse_node to normalise_node
2018-11-30 12:14:21 -08:00
c8e766dec7
Add function to normalise :node option after distribution started
...
Fixes #278
2018-11-30 07:00:18 -08:00
df5db4ec1b
Validate log level values, format unsupported level errors in a more human-friendly way
2018-11-29 00:20:41 +08:00
0e7608083b
Add command to set log level
...
Fixes #276
2018-11-27 15:49:11 -08:00
8ab22299a8
Document --no-table-headers
...
Fixes #274
Switch no_table_headers to table_headers
update tests
Integrate --silent
2018-11-19 15:25:36 -08:00
a3658df971
Merge pull request #272 from rabbitmq/idempotent-stop
...
Make stop idempotent using --idempotent flag
2018-11-01 23:47:07 +03:00
6416d745ed
Update tests
...
[#161309687 ]
2018-11-01 23:46:32 +03:00
2f16936e36
Merge pull request #271 from rabbitmq/rabbitmq-cli-270
...
Ensure cli name ends with correct hostname
2018-11-01 09:31:43 -07:00
b8ab5f9b01
Rename ignore-stopped flag to idempotent
...
[#161309687 ]
2018-11-01 16:18:38 +00:00
68d901bc3a
Make stop idempotent using --ignore-stopped flag
...
[#161309687 ]
2018-11-01 14:22:13 +00:00
915004de25
Make CSV formatter return a string from format_output
...
By default CSV.encode returns a stream. Plain-value output does not
support streams.
2018-11-01 10:22:56 +00:00
933f4476f5
Improve scenario where inet:get_rc/0 does not return domain info
2018-10-31 19:33:10 -07:00
585bdacba2
Ensure cli name ends with correct hostname
...
If longnames are in use, this also ensures that the domain (if known) is appended to the CLI node name
CLI node names will be based on RabbitMQ host names
Fixes #270
2018-10-31 13:33:54 -07:00
36ad6dfdb5
Merge pull request #269 from rabbitmq/rabbitmq-cli-267
...
rabbitmq-diagnostics: make cipher_suites default to --openssl-format
2018-10-30 07:06:57 +03:00
7a4e7c403f
Use a custom formatter for cipher_suites
...
There are effectively two separate formatters used:
* The String one for --openssl-format
* Command-joined Inspect for --erlang-format
This implementation is more involved than using :io_lib:format/2
on a collection but it fits the run/output/print framework every
command uses.
References #267 .
2018-10-30 06:58:07 +03:00
3c3ae2afeb
Output in erlang term format that can be pasted into a config file
2018-10-29 16:43:54 -07:00
582fa06686
More warnings
2018-10-30 00:51:35 +03:00
152395c30b
Squash a warning
2018-10-30 00:33:15 +03:00
875c7827f6
rabbitmq-diagnostics: make cipher_suites default to --openssl-format
...
And introduce --erlang-format. They are mutually exclusive.
Closes #267 .
[#161435591 ]
2018-10-28 23:31:39 +03:00
19a58551b3
Improve error reporting for quorum queues commands.
...
Validate that the rabbit app is runninig.
Format error when trying to access a classic queue.
Minor refactorings.
2018-10-26 15:20:34 +01:00
c9d9dc58a8
Delete quorum member command
...
[#157481599 ]
2018-10-26 14:50:36 +01:00
357cd5c1b6
Add quorum queue member command
...
[#157481599 ]
2018-10-26 14:50:36 +01:00
6bda3873d6
Add quorum status command to report local ra state
...
[#157146500 ]
2018-10-26 14:50:36 +01:00
5e54354fdf
Make it possible to suppress table headers for list_* commands
...
Using --no-table-headers, per discussion with @dumbbell.
2018-10-24 16:43:58 +03:00
f7d307dd30
Merge pull request #266 from rabbitmq/rabbitmq-server-1712
...
Output cipher suites one by one
2018-10-24 02:15:26 +03:00
1296e6824e
Output cipher suites one by one
...
This is more useful to the users of the new config format.
References rabbitmq/rabbitmq-server#1712.
[#160792113 ]
2018-10-24 01:44:24 +03:00
222e486ca7
Add headers to the table formatter.
...
There were headers in 3.6 CLI which were not implemented when moving
to the new one.
Fixes #264
[#161326468 ]
2018-10-22 10:55:16 +01:00
312b6f57c4
Use the correct key name for plugin archive directory
...
[#160792758 ]
2018-10-03 17:05:07 +03:00
5ec71c18f3
Retrieve plugin directory and file information via Config
...
[#160792758 ]
2018-10-03 16:43:42 +03:00
a85908aa30
Simplify clauses, make --offline more robust
...
[#160792758 ]
2018-10-02 15:34:20 +03:00
0defc87c20
Wording
2018-10-02 14:23:39 +03:00
3a30b45c5d
Wording
2018-10-02 14:22:42 +03:00
1b56fc5957
New command: rabbitmq-plugins directories
...
Closes rabbitmq/rabbitmq-cli#261.
[#160792758 ]
2018-10-02 03:16:25 +03:00
ad184bac68
Add global parameters to rabbbitmqctl report
...
Follow-up to #256
2018-08-27 14:38:26 -07:00
4f3b2d39bd
RabbitMQ.CLI.Core.Parser: Set `allow_nonexistent_atoms` in OptionParser
...
There is a change of behavior in OptionParser between Elixir 1.6.x and
1.7.x. It's probably the deprecation documented in Elixir 1.7.0 release
notes:
[OptionParser] Deprecate dynamic option parser mode that depended on
atoms to be previously loaded and therefore behaved inconsistently
Setting the `allow_nonexistent_atoms` to true allows to restore the
behavior from Elixir 1.6.x, thus giving a consistent parsing with both
versions of Elixir.
[#159500280 ]
2018-08-03 13:17:09 +02:00
c88cfd940d
Reduce code footprint on aliases
2018-07-23 06:06:18 +01:00
4ee275cbcd
Include policies and parameters in report command
2018-07-16 16:36:47 +01:00
40b40a6d42
Make the ping command available in rabbitmq-diagnostics as well
...
References #253 .
[#158291890 ]
2018-06-13 00:38:02 +03:00
158dc0eb7e
Wording
2018-06-13 00:37:17 +03:00
b20418cb83
Pass current node as is_auth "argument"
...
To be closer to what net_adm:ping/1 does. The argument
is then ignored by net_kernel, though.
[#158291890 ]
2018-06-12 23:18:48 +03:00
ee2b185db9
Introduce rabbitmqctl ping
...
See #253 for background.
[#158291890 ]
2018-06-12 16:47:54 +03:00
09e86fb73d
New command: await_online_nodes <count> [--timeout <timeout>]
...
Closes #235 .
[#156729133 ]
2018-05-29 16:01:03 +03:00
1ea1edf865
Explain why --timeout is on the global flag list
2018-03-09 20:32:02 +03:00
56991de0f3
Accept -t/--timeout before command name [again]
...
There are existing users (including RabbitMQ core tests) that
use that sequence because it was previously in the docs.
This relaxes command validation so that if a command-specific
flag overrides a global, we accept it as long as their types match.
Per discussion with @hairyhum.
2018-03-09 20:28:26 +03:00
e99bc16428
Whitespace changes
...
See #236
2018-03-08 14:13:32 -08:00
d96d0f6e22
Axe some [now] dead code
2018-03-08 18:25:33 +03:00
aef04bef84
Show timeout in help messages only for commands supporting timeout.
...
Removed timeout from default parsing options. Now every command
has to specify timeout in it's own switches.
If a command has timeout in switches - there will be help displayed
for this option in usage output.
2018-03-07 18:28:21 +00:00
0c83c05ec1
Do not show timeout option for rabbitmq-plugins tool.
...
The rabbitmq-plugins tool does not respect timeout option.
2018-03-07 15:51:54 +00:00
8b33c646ed
Command to delete a queue.
2018-03-07 15:20:18 +00:00
ee1a651f6d
Squash a warning
2018-02-22 23:59:06 +03:00
e4505bb9a6
Ensure another string case is taken care of
...
If a user happens to set the following in rabbitmq-env-conf.bat, it will be matched:
set USE_LONGNAME="true"
Fixes rabbitmq/rabbitmq-server#1508
2018-02-20 15:05:28 -08:00
fa5763e6c2
Format "plugins not found" errors better
...
References #241 .
(cherry picked from commit 018c829e1e
2018-02-13 21:49:57 +03:00
08c3100897
Add function clause for set: case
...
Fixes #241
2018-02-13 09:08:59 -08:00
97b1f21803
Optimise some commands by not starting erlang distribution
...
(cherry picked from commit cf23e45cf9
2018-01-16 20:05:51 +03:00
97846fcf79
Add a callback to control erlang distribution.
...
The callback cab be used to disable distribution (offline commands)
or to have command-specific node name and distribution parameters.
(cherry picked from commit b5de2236ce
2018-01-16 20:05:41 +03:00
3435bc66a5
Wording
2017-12-08 17:56:07 -08:00
81862adcab
Fixing SetParameterCommand and tests
...
Fix code to fix test suite
2017-12-08 11:49:20 -08:00
747f953d76
Remove an unused variable
2017-11-28 20:12:48 +03:00
404f55ecc9
Pick the max of totals, just like HTTP API reporter does
2017-11-28 19:47:51 +03:00
5cbb4039a6
Cosmetics
2017-11-28 19:28:34 +03:00
a404c0b8c5
Adapt rabbitmq-diagnostics memory_breakdown to server master
...
Specifically to https://github.com/rabbitmq/rabbitmq-server/pull/1404 .
Closes #228 .
[#153217000 ]
2017-11-28 19:12:14 +03:00
82d5fcd804
Merge pull request #227 from rabbitmq/rabbitmq-cli-226
...
Fix rabbitmq-plugins enable/disable/set behavior for --online flag.
2017-11-28 00:04:18 +03:00
e5fd1ccc5a
Cosmetics
2017-11-27 23:39:14 +03:00
32cf46e5c8
Fix rabbitmq-plugins enable/disable/set behavior for --online flag.
...
If flag is set to `--online` the commands should fail if node is not
running.
If flag is not set, they should fallback to offline mode if the
node is not running.
This corresponds to the rabbitmq-plugins.8 manpage.
Made validation aware of online flag.
Define best_effort mode to fallback if node is not running.
Requires rabbitmq/rabbitmq-server#1433
Fixes #226
[#153184802 ]
2017-11-27 18:49:08 +00:00
9cbfbc21a0
Correctly format the list of missing plugins
...
Closes #224 .
[#153141065 ]
2017-11-27 18:32:53 +03:00
1103c82a87
Don't require RabbitMQ node to be running for `rabbitmq-plugins list'
...
This extra validation wasn't intentional and turns out to be inconvenient
for provisioning and automation projects such as BOSH releases and Docker images.
2017-09-05 13:45:17 -07:00
32bd206ff9
Remove -l alias from help_command. It iss conflicting with default alias
2017-08-18 16:13:20 +01:00
206a5fb93c
Squash a warning
2017-08-15 12:53:31 +03:00
8bc0b68f4e
Change validation for the force_boot command
2017-08-14 19:20:32 +01:00
7b2de34620
Error message if a command has duplicate global switches
2017-08-14 17:14:41 +01:00
141e845fab
Remove duplicate global switches.
2017-08-14 17:14:41 +01:00
e34bfe2297
Merge branch 'master' into rabbitmq-cli-214-take-two
2017-08-14 14:40:35 +01:00
568874033d
Run dialyzer tests. Fix warnings.
...
Some types were named wrongly (list(), map())
MapSet cannot be matched to be empty. `%MapSet{}` only matches the type.
2017-08-14 14:36:38 +01:00
3e30b8a4f3
Enable rabbit app validation for list_parameters and clear_permissions. Disable the validation for shutdown
2017-08-14 11:59:35 +01:00
cb65a340d5
Add single quotes around commands given in output
2017-08-11 17:00:20 -07:00
006ff6a259
Remove extra whitespace
2017-08-11 14:57:18 -07:00
b00e648b9c
Extend execution environment validation to more commands
...
This also re-formats a bunch of commands to follow the same
order for the following functions:
* merge_defaults/2
* validate/2
* validate_execution_environment/2
* run/2
2017-08-11 18:06:30 +03:00
ea1078fc5f
Update command type specs
2017-08-11 18:06:16 +03:00
6b007ab1cf
Make sure we format errors here
2017-08-11 18:04:00 +03:00
fa0515911f
These commands don't really require the rabbit app to be running
2017-08-11 14:37:02 +03:00
586a557096
Add a type spec for validate_execution_environment/2
2017-08-11 14:15:36 +03:00
8cee00231b
Introduce RabbitMQ.CLI.Core.RequiresRabbitApp{Running,Stopped}
...
and apply them to a subset of commands.
2017-08-11 02:23:53 +03:00
efe8725f3c
Merge branch 'master' into rabbitmq-cli-214-take-two
2017-08-10 14:21:42 +03:00
e8c73d9bea
Merge branch 'master' into rabbitmq-cli-207
2017-08-09 14:36:07 +01:00
de10e4f5a7
Different list of info items for unresponsive queues
2017-08-09 14:34:01 +01:00
035e7305ac
Merge pull request #218 from rabbitmq/timeout_list_queues
...
Set a timeout on list_queues and a warning if unresponsive ones are found
2017-08-09 17:24:40 +04:00
2eda5ea31c
Make sure *validation_error_output/2 functions are used correctly
2017-08-09 15:52:04 +03:00
0031c4fdf6
Make validate/2 and validate_execution_environment/2 use the same tuple tag
...
Per discussion with @hairyhum.
2017-08-09 01:11:14 +03:00
afa605b3e9
Merge branch 'master' into rabbitmq-cli-214-take-two
...
Conflicts:
lib/rabbitmq/cli/plugins/commands/enable_command.ex
2017-08-08 19:14:07 +03:00
82ebcfafeb
Assume this match is exhaustive
2017-08-08 19:12:19 +03:00
c227843e32
Make validate_execution_environment/2 use a different tuple tag for failures
...
Per discussion with @hairyhum.
2017-08-08 18:29:04 +03:00
738f667716
Override timeout
2017-08-08 10:01:32 +02:00
6c70863dcf
rabbitmq-plugins: refactor to validate_execution_environment/2 and R.C.C.Validators.chain/2
2017-08-08 03:21:07 +03:00
9d6dfddb3e
Set a timeout on list_queues and a warning if unresponsive ones are found
...
Related to rabbitmq-cli#207
2017-08-07 17:38:24 +02:00
15565ec1d7
rabbitmq-plugins set: switch to validate_execution_environment/2
2017-08-07 16:44:19 +03:00
829a918c5a
Use info items to list unresponsive queues
...
rabbitmq-cli#207
[#149059849 ]
2017-08-07 15:08:33 +02:00
2e64c90913
rabbitmq-plugins enable: switch to validate_execution_environment/2
2017-08-07 16:04:30 +03:00
770258ea65
rabbitmq-plugins disable: switch to validate_execution_environment/2
2017-08-07 14:47:17 +03:00
4b6978f26d
Squash a couple more warnings
2017-08-04 22:41:12 +03:00
e9fa801d6f
Update restart_vhost usage
2017-08-04 21:45:22 +03:00
6da66de40a
forget_cluster_node: switch to validate_execution_environment/2
2017-08-04 19:15:53 +03:00
8e9b114eac
Fold execution environment validation into a single optional fn
...
While at it, move Ctl.Validators => Core.Validators.
If the function is not defined we skip validation. Note that
individual commands need to be revisited and refactored to use
this mechanism; this is yet to come.
Per discussion with @hairyhum and @lukebakken.
2017-08-04 18:40:17 +03:00
d92b78b49e
Simplify, explain
2017-08-04 15:20:57 +03:00
032482cec6
Factor in rabbit app state and execution env validation
...
This introduces two other "validation steps" that have little or nothing
to do with CLI argument validation.
Per discussion with @hairyhum.
2017-08-04 15:08:37 +03:00
9919700303
Inline validate_and_run_command/3 for greater flexibility
...
This way we can inject more "validation steps" between validate/2
return and command execution, such as checking whether the rabbit app
is running (or not running) on the remote node.
While at it, group functions that are used in a chain.
2017-08-04 14:09:37 +03:00
10bb587d61
The command to restart a vhost.
...
The command will attempt to restart a vhost.
If restarted successfully, return exit code 0
If the vhost is already started, return exit code 0 and notify that it's already started.
If there is an error restarting, return exit code 70 and the error
Part of rabbitmq/rabbitmq-server#1321
[#149484305 ]
2017-08-04 11:32:40 +01:00
a7bd5811d0
Change state in vhost info to cluster_state
2017-08-01 14:56:21 +01:00
59c1a54cad
Do not format errors using to_string. Let rabbitmqctl core do the formatting
2017-07-31 15:57:10 +01:00
3c6a59079c
Command to report unresponsive queues
...
rabbitmq-cli#207
[#149059849 ]
2017-07-27 17:50:52 +02:00
d4e701bb3d
Merge pull request #211 from rabbitmq/rabbitmq-management-446
...
Report vhost status on list_vhosts command
2017-07-25 18:38:15 +01:00
05469e4bad
Report vhost status on list_vhosts command
...
rabbitmq-management#446
[#149398495 ]
2017-07-25 11:47:07 +01:00
bd96454992
Merge pull request #210 from rabbitmq/rabbitmq-server-1296
...
Do not crash command loading if unable to read enabled plugins file.
2017-07-24 22:10:43 +03:00
540b5bd170
Copy
2017-07-24 22:07:46 +03:00
306b7574e4
Do not crash command loading if unable to read enabled plugins file.
...
Some distributions set no permissions to read the enabled plugins
file location. This can cause a crash when running not as root or
rabbitmq user.
It was decided that plugins commands can be skipped when printing
the help message if the user have no access to the enabled plugins
file.
The warning message will be displayed in that case.
Addresses https://github.com/rabbitmq/rabbitmq-server/issues/1296
[#149079123 ]
2017-07-24 17:28:12 +01:00
6926a3a9a8
Recompile pid_regex at runtime, too
2017-07-20 17:51:30 +03:00
54f417b93f
Recompile regexes at runtime.
...
Because the regex engine may change between OTP versions it is necessary
to recompile any compiled regexes at runtime in case the engine is not
compatible.
[#149227527 ]
2017-07-20 14:08:43 +01:00
a33b26105c
Supress banners for machine readable format
...
Namely JSON and CSV.
Fixes #205 .
2017-07-14 18:08:17 +03:00
4383c3e280
Tests, refactoring
2017-07-14 03:33:46 +03:00
d4bf287a90
output formatter now can rely on command defaults
2017-07-13 15:53:18 +03:00
3f21e0fac1
Make sure that command-provided defaults are available to output formatting fns
2017-07-13 15:46:31 +03:00
f5ddac1f22
Merge branch 'master' into memory_breakdown_command
2017-07-13 03:50:03 +03:00
330d8a4eda
rabbitmq-diagnostics memory_breakdown: WIP
2017-07-13 03:45:01 +03:00
df726906a2
Make arguments in this fn head easier to identify
2017-07-12 13:08:20 +03:00
7361c7d54a
Merge branch 'master' into rabbitmq-cli-202
2017-07-12 13:04:07 +03:00
8745bdf5df
Squash a warning
2017-07-12 13:03:30 +03:00
1be262d496
Avoid streaming if no nodes are available
...
rabbitmq-cli-202
[#148733373 ]
2017-07-12 10:35:32 +01:00
de41a1081a
Introduce rabbitmq-diagnostics erlang_version
2017-07-11 15:28:12 +03:00
c26a7a5909
Introduce rabbitmq-diagnostics server_version
2017-07-11 13:26:05 +03:00
310ffe159e
Wording
2017-07-04 22:41:32 +03:00
ca20f8a0d6
Make CLI tools diagnostics message more detailed
...
Our current message is informative enough but it ends with a "nodedown".
Emperical evidence suggests that once a user sees it, they stop reading.
Providing a hint that there will be diagnostics output below is step 1.
Step 2 is improving the diagnostics section. It now
* Calls out three most common groups of issues explicitly
* Suggests what documentation guides can contain helpful information
There are rabbitmq-server and rabbitmq-common commits that make
similar improvements to the server-supplied part of the diagnostics
message.
Per discussion with the team.
2017-07-04 22:34:39 +03:00
65346cde82
Use rabbit_nodes_common here
2017-07-04 22:24:19 +03:00
a9bd603352
Squash a warning
2017-07-04 22:24:00 +03:00
09eee9fd53
Improve error messages
2017-07-03 16:39:04 +03:00
5774bc64e5
Merge branch 'master' into rabbitmq-cli-encode-commands
2017-07-03 15:52:07 +03:00
58304ffc95
Split encode command tests to separate commands
2017-07-03 12:11:34 +01:00
88629421d1
Whitespace
2017-06-30 14:44:35 +03:00
b7b5223a39
list_vhost_limits: handle errors before serialising results
...
Also update tests and format no_such_vhost errors in a more sensible
way.
2017-06-30 14:43:09 +03:00
c40368fe02
Split encode command to encode, decode, list_ciphers and list_hashes commands
...
[#147861659 ]
2017-06-28 17:19:42 +01:00
a4b452545b
Improve formatting for list_vhost_limits command.
...
Format limits as JSON.
Make sure vhost field printed before limits.
2017-06-27 17:28:37 +01:00
66a7ee4cab
distribution.ex: ensure_epmd() was moved to rabbit_nodes_common
...
[#147436507 ]
2017-06-26 19:28:52 +02:00
ee8c2f133c
Support Elixir-1.5.0-rc.0
2017-06-26 11:59:46 +01:00
2ac997fd89
Merge pull request #200 from rabbitmq/rabbitmq-cli-199
...
Handle error in `rabbit_mnesia:cluster_nodes/1` on cluster_status command
2017-06-16 19:48:43 +03:00
6410ba0272
Fix compiler warnings that hinted at a typo in atom name
...
First spotted by @lbakken.
2017-06-16 19:43:09 +03:00
a1e07c72f1
Merge pull request #198 from rabbitmq/rabbitmq-cli-197
...
Use the output of multirpc to report the down or timed out nodes
2017-06-16 19:40:38 +03:00
beacfe998a
Handle error in `rabbit_mnesia:cluster_nodes/1` on cluster_status command
...
If the error is ignored, an Enum exception is triggered which is not
meaningful for the final user. Notifying that something is wrong accessing
to Mnesia files provides a hint. Can be eventually reproduced while
the node is restarting.
rabbitmq-cli#199
2017-06-16 16:51:57 +01:00
31822baf8c
Revert "Revert "Compile""
...
This reverts commit 7908b17f01ec695461ab
2017-06-16 17:55:31 +03:00
7908b17f01
Revert "Compile"
...
This reverts commit ec695461ab
2017-06-16 17:35:57 +03:00
ec695461ab
Compile
2017-06-16 17:34:29 +03:00
cb2b3bc667
Fix timed out message
2017-06-16 14:54:33 +01:00
dfa9827135
Use the output of multirpc to report the down or timed out nodes
...
Most commands do rpc's only to the target node, but join_cluster
triggers an rpc between nodes. If the rpc to the remote down returns
down/timeout, we must use that value to run the diagnostics.
Using the node from command options in diagnostics will report as down
the wrong node.
rabbitmq-cli#197
2017-06-16 12:41:11 +01:00
81c1f9461f
Add an output formatter for report command
...
Report command executes other commands, so it's formatter
cannot be changed using command line argument.
Report formatter will format each command output with this command
default formatter.
2017-06-15 16:32:39 +01:00
3693daf693
Add functions to get info keys to list_* commands
2017-06-15 16:31:32 +01:00
c31989de08
Change banner for list_queues and list_exchanges to show vhost
2017-06-15 16:03:38 +01:00
5409c37f3e
Merge pull request #194 from rabbitmq/rabbitmq-cli-193
...
Check `rabbit_mnesia:status` return value
2017-06-15 16:38:22 +03:00
a84c4b3405
Merge pull request #195 from rabbitmq/naming
...
Rename <user> to <username> to standarise all rabbitmqctl commands
2017-06-15 16:37:55 +03:00
5bdfcc575d
Display --local option in list_queues help
2017-06-15 12:42:02 +01:00
d6686e40f6
Rename <user> to <username> to standarise all rabbitmqctl commands
...
Most commands use <username> in the help description
2017-06-15 12:06:32 +01:00
68698d34d2
Check `rabbit_mnesia:status` return value
...
Ensures the error is returned and not used later on.
rabbitmq-cli#193
2017-06-14 17:00:18 +01:00
93b42d5e31
Log enabled and disabled plugins in offline mode.
...
This ensures that the enabled/disabled plugins are logged
in offline mode.
[#146384227 ]
2017-06-13 10:01:32 +01:00
858b79d603
Use plugins formatter as default formatter for plugins list command
2017-06-09 12:24:38 +01:00
a3776bf9b8
Return :ok in validation.
2017-06-08 18:29:51 +01:00
1641ecbc11
Improve wait command.
...
Do not call await_startup on rabbitmq node, instead do it on
rabbitmqctl node, so even if net_ticktime is low, it won't fail
with nodedown.
2017-06-08 18:15:21 +01:00
b802fcdf87
Do not try to connect to the RabbitMQ node before executing command
...
Commands are supposed to return bardpc errors, which are handled by output,
so there is no need to connect to the node before calling the run function.
2017-06-07 16:21:53 +01:00
b8d6042046
Quiet mode for wait command will suppress log messages
2017-06-07 14:22:59 +01:00
cd377eeb0f
Merge branch 'rabbitmq-cli-wait-stages'
2017-06-07 13:42:36 +02:00
6b1fbb482c
Change cluster node type to selected type
2017-06-06 18:43:38 +01:00
a759eea11a
Make wait take the actual function execution time to account
2017-06-06 18:11:25 +01:00
61eeab17c1
Callback for exec_command function to process output
2017-06-06 12:07:34 +01:00
27fc29914c
Test exec command
2017-06-06 12:07:00 +01:00
5c98699a29
Add new test to check argument processing typical to multiple commands.
...
Check that merge_defaults does not fail on badmatch with arbitrary args.
Check that info keys can be a comma-separated list
2017-06-06 12:06:17 +01:00
975be0ccfb
join_cluster_command: Format the `already_member` return value
2017-06-06 11:50:20 +02:00
b4a8789ed1
Wait in stages.
...
Make wait command work in stages with timeouts.
First wait for a pid file to appear (times out)
Then wait for erlang distribution to start on the node (times out)
Then wait for application to be running in the node (does not time out)
Default timeout is set to 10 seconds, which should be enough to
write a pid file and start distribution.
2017-06-02 16:48:34 +01:00
6cf003ed03
Typo in info message
2017-06-02 14:35:52 +01:00
8ea044dd80
Do not match arguments in merge_defaults.
...
merge_defaults gets called before validate, so it should allow
any argument number.
2017-06-02 10:17:28 +01:00
51de5e0fea
Less strict help arguments
...
Print command help even if there are more than 1 argument.
For example:
rabbitmqctl help <command> <other args>
2017-06-02 10:17:28 +01:00
7fb2a1d797
Print result in trace_on/off commands
2017-06-02 10:17:28 +01:00
14cb785966
Unused clause
2017-06-02 10:17:28 +01:00
4c06bee5fe
Unfold stream subcommand output in report command.
2017-06-02 10:17:28 +01:00
be7ffd911d
Do not stramify keyword lists (proplists)
2017-06-02 10:17:28 +01:00
d1040ca11f
Helper function to parse info_keys arguments
2017-06-02 10:17:28 +01:00
9b0ec73a0d
Set default formatter for environment command to erlang
2017-06-02 10:17:28 +01:00
6c2cb2336f
Explain
2017-05-31 23:24:58 +03:00
ad3d016e4d
Avoid formatting message of no peers discovered.
...
{:error, exit_ok(), message} is a trick to print a string
without formatting it first.
2017-05-31 17:17:07 +01:00
769fe8e712
Better error management with stream outputs from list_ commands.
...
Fixed incorrect tuple matching.
Added support for error codes and messages for timeout with value.
2017-05-24 13:28:51 +01:00
60deb8514d
Improve error reporting.
...
badrpc errors are handled in Rabbitmqctl module.
Report errors from node discovery
Add helpers to skip errors in formatters.
2017-05-24 12:08:03 +01:00
719b75269c
Fixing erlang and string formatters.
...
Erlang formatter had issues when formatting erlang strings, because
they were interpreted as streams. Now all streams are being converted
to lists and printed as is.
String formatter does not try to format with io_lib, instead it tries
to format using Elixir to_string.
2017-05-22 17:14:26 +01:00
a10ecbdb7a
This command belongs to diagnostics, not ctl
2017-04-30 01:27:44 +02:00
48f79daa09
Don't output backend information; declare a formatter instead of delegating to it
2017-04-30 01:25:27 +02:00
5b8cdf37a1
Rename list_discover_peers with discover_peers
2017-04-28 18:47:35 +02:00
4fa68912a4
Format result
...
Add Backend type
Add simple unit test
2017-04-28 18:12:04 +02:00
34e791851c
Add case
2017-04-27 22:59:20 +02:00
a875fe52ef
Add list_discovery_peers command.
...
Command to report: :rabbit_peer_discovery, :discover_cluster_nodes
2017-04-27 12:16:10 +02:00
1805012f77
Merge branch 'master' into rabbitmq-cli-shutdown
2017-04-07 22:31:54 +02:00
987526d70f
(c) year
2017-04-05 15:44:16 +03:00
ac8b32f61a
Merge branch 'master' into rabbitmq-cli-180
...
Conflicts:
lib/rabbitmq/cli/core/distribution.ex
2017-04-05 15:03:52 +03:00
8ef4c404ab
Do not import modules. Import only protocols and records.
...
Aliases is a convinient enough to reference elixir modules.
Imported functions can be confusing, especially mixed with aliases.
2017-04-05 11:59:54 +01:00
819d512038
Implement shutdown command
2017-04-04 19:23:50 +01:00
62a44ac641
Optimize rabbitmqctl startup.
...
Plugins dirs are added to ERL_LIBS by shell scripts, we try to load
enabled plugins first and scan plugins dir only if some of them
are not found.
When discovering plugins, we can load applications only for enabled ones.
EPMD can be started only after initial `net_kernel:start` call failed.
We don't need to discover all commands every time, only if a command is not
in the `rabbitmqctl` application modules.
[finishes #143025009 ]
2017-04-04 14:06:53 +01:00
61c3d0e9d0
Naming; make sure ensure_cookie/1 always returns :ok
...
erlang:set_cookie/2 returns true, not ok.
2017-04-04 15:11:41 +03:00
1e1cb92a44
Make it possible to specify erlang cookie from command line
...
Add new flag `--erlang-cookie` and environment variable `RABBITMQ_ERLANG_COOKIE`
to configure a cookie for CLI to connect to RabbitMQ node.
2017-04-03 14:46:26 +01:00
00a298961a
Print diagnostics on nodedown error
...
[finishes #142492945 ]
2017-03-31 11:28:41 +01:00
05a2a18f52
Handle `eacces` errors in addition to `eperm` in `hipe_compile` command
...
`hipe_compile` command validation checks that directory can be created and
have permissions to write .beam files. System can return `eperm` or `eacces`
errors in different conditions, but the meaning of those errors is same.
2017-03-14 17:18:18 +00:00
2dc56b3737
hipe_compile: reject blank, non-existent paths and those with insufficient permissions
...
References #178 .
2017-03-14 01:49:04 +03:00
95ea549472
rabbit app is loaded during validation; handle "already compiled" cases
...
References #178 .
2017-03-13 21:21:15 +03:00
f2f0c26e44
Finish hipe_compile command
...
This correctly handles the case where the rabbit app is
already loaded.
References #178 .
2017-03-10 21:25:00 +03:00
34262f2161
ctl hipe_compile WIP
...
This command needs access to RabbitMQ modules and currently
propagation doesn't work as expected.
2017-03-10 15:30:50 +03:00
ef98536ab4
rabbitmqctl hipe_compile WIP
2017-03-10 01:01:03 +03:00
89e12a1ac7
lib/rabbitmq/cli/plugins/plugins_helpers.ex: Remove dead code
...
The same function call is made the line after.
2017-02-28 16:16:27 +01:00
12c34a78c4
lib/rabbitmq/cli/plugins/plugins_helpers.ex: Use `deps` to filter plugins
...
... in validate_plugins(). This variable was computed but not used. The
initial `plugins` variable was used but it lacked dependencies.
2017-02-28 16:15:08 +01:00
1f68c5a89d
Mark unused variables with '_'
...
Obviously, this fixes sevearl "unused variable" warnings.
2017-02-28 16:12:34 +01:00
3dd4ff27c6
lib/rabbitmq/cli/core/parser.ex: Remove dead code
...
OptionParser is already called inside parse_global_head() and the return
values are overwritten anyway. This fixes warnings about unused
variables.
2017-02-28 16:11:32 +01:00
74ffe46fb3
Rename function
2017-02-27 16:23:57 +00:00
87331bb95e
Exclude applications that are not RabbitMQ plugins from the list of plugins
2017-02-27 14:52:40 +00:00
1aeedbe98e
RABBITMQCTL_ALIASES => RABBITMQ_CLI_ALIASES_FILE
...
Per discussion with @hairyhum.
2017-02-21 17:51:17 +03:00
95fe5c96fd
Document aliases. Improve eval command to accept bound arguments
2017-02-16 12:41:26 +00:00
2b4012127e
Support aliases
...
Fixes #10
Loads aliases in "name = command_name [arguments and options]" format from --aliases-file
2017-02-15 18:03:45 +00:00
8efb8a32ab
Do not use Mix in production code.
...
Fixes #174
Mix is not bundled into the escript file, so sould not
be used in the code.
2017-02-15 10:46:08 +00:00
c4dab95dce
Copy
2017-02-06 00:39:16 +03:00
696adc923d
Copy
2017-02-06 00:35:20 +03:00
39f17b53ee
Naming, Elixir code style
2017-02-06 00:02:30 +03:00
62cdd4d7fc
Merge branch 'master' into rabbitmq-server-1085
2017-01-31 17:20:52 +01:00
2a9c24af2c
Merge branch 'master' into rabbitmq-server-release-12
2017-01-27 18:33:19 +03:00
61d8bb836e
Merge pull request #171 from rabbitmq/rabbitmq-cli-170
...
Validate enabled plugins version requirements
2017-01-27 16:29:04 +01:00
0e13568ec3
Move plugin validation from `validate` to `run`
2017-01-27 14:55:09 +00:00
77860364bb
Merge branch 'master' into rabbitmq-server-release-12
2017-01-27 10:42:58 +00:00
8038f583e0
Validate all plugins if `all` flag is present
2017-01-26 16:21:44 +00:00
df95a411c7
Format user_already_exists error
2017-01-26 12:33:56 +00:00
52ad0d2a39
Validate enabled plugins version requirements
2017-01-26 12:21:20 +00:00
04c1c2e2f9
Do not print "Command '' not found" for empty command
2017-01-25 15:24:47 +00:00
a5857e13d8
Handle auto-completion line as argv, not a single argument
...
It's easier to detect a script name if passed as argv list.
Arguments can be parsed with quoted spaces (e.g. in directory path)
2017-01-24 14:40:31 +00:00
3871c4ccde
Support autocompletion with different script names
2017-01-24 12:30:12 +00:00
6288d75472
Cleanup compiler warnings
2017-01-24 09:59:00 +00:00
2174446ff9
Auto complete command called with full path
2017-01-24 09:47:30 +00:00
6c4302d7f8
Revert "Fix --auto-complete clauses"
...
This reverts commit cbab77e34ccbab77e34c
2017-01-23 13:28:31 +03:00
57f2eff218
Add read to topic permissions
...
Part of rabbitmq/rabbitmq-server#1085
2017-01-23 10:12:03 +01:00
cbab77e34c
Fix --auto-complete clauses
...
According to the completion script in rabbitmq/rabbitmq-server-release#14 , the correct
way to invoke auto-completion is
/path/to/rabbitmqctl --auto-complete [command prefix]
However, the above arguments were not matched by the existing
main heads.
2017-01-21 23:33:35 +03:00
6faff961c1
Fix a few compiler warnings
2017-01-21 23:18:58 +03:00
ed68f0e957
Merge pull request #166 from rabbitmq/rabbitmq-event-exchange-10
...
Provide cli user as user who performs action for event notifications
2017-01-21 02:05:19 +03:00
b7fb43fb48
Fix auto complete module to support new parser API
2017-01-18 15:38:33 +00:00
ee34fac5bd
Merge branch 'master' into rabbitmq-event-exchange-10
2017-01-17 20:28:03 +03:00
bb57a213c0
List vhost limits command
2017-01-17 13:02:09 +00:00
fd6ba841cd
Provide cli user as user who performs action for event notifications
2017-01-17 09:01:14 +00:00
5e15f5c2d2
Merge branch 'master' into rabbitmq-server-505
2017-01-12 12:58:27 +03:00
5905f1c40a
Update copyright line to year 2017
2017-01-10 15:42:40 +01:00
6c5c35e4b1
Wording
2017-01-07 05:13:57 +08:00
088fa90faf
Cosmetics
2017-01-07 04:54:31 +08:00
b2b804eda9
Limit number of connections to close
2017-01-06 15:15:31 +01:00
da8e333209
Test close all connections command
2017-01-06 13:54:48 +01:00
c4bf5ee0fa
Close all connections command with vhost, global and delay options
2017-01-06 08:25:21 +01:00
530a9c7d83
{disable,enable}_command.ex: Support --all to enable/disable all plugins
...
[#136769947 ]
2016-12-29 11:47:48 +01:00
77a23a9a72
Move plugin_names() from list_command.ex to plugins_helpers.ex
...
[#136769947 ]
2016-12-29 11:46:17 +01:00
6160bdd57e
Merge branch 'master' into rabbitmq-server-505
2016-12-27 16:43:57 +01:00
41a67e6c4f
Actually, don't log anything
...
Those CT log entries would look really weird to the user
and we already log CLI failures in rabbitmq_ct_helpers.
2016-12-27 13:57:23 +03:00
ce909f8d3a
Explain; log something more meaningful with CT
2016-12-27 13:55:13 +03:00
30b41ba267
Support start from common_test tests
2016-12-23 12:12:33 +00:00
93e9d9301e
Merge branch 'master' into rabbitmq-server-505
2016-12-22 17:50:18 +01:00
7d41df5d8d
Fix sorting and plugin name access for plugin management commands
2016-12-22 16:19:17 +00:00
c7a11fad38
Merge branch 'master' into rabbitmq-server-505
2016-12-22 17:09:06 +01:00
1dcc44d5f7
Add topic authorisation commands
...
References rabbitmq/rabbitmq-server#505
2016-12-22 16:50:59 +01:00
7b689ae633
Detailed error message in memory threshold validation
2016-12-22 12:13:46 +01:00
93ca16c5ff
Add global parameters commands
...
Part of rabbitmq/rabbitmq-mqtt#73
2016-12-16 16:41:29 +01:00
240c7c0862
Merge pull request #156 from rabbitmq/rabbitmq-cli-153
...
Load .ez plugins without version
2016-12-14 17:00:40 +00:00
4d46936749
Be more specific about what is being stopped on `stop_app`
...
rabbitmq/rabbitmq-server#1043
2016-12-14 12:04:54 +00:00
eaaea172ae
Squash a couple of compiler warnings
2016-12-14 14:55:03 +03:00
c647314d79
Merge branch 'master' into rabbitmq-cli-153
2016-12-14 14:50:06 +03:00
067f0cee14
Load .ez plugins without version
2016-12-13 13:06:16 +01:00
ad094d74a9
Correct delegation here
2016-12-12 16:27:34 +03:00
1f7404ce4c
Don't include double quotes in cookie hash output
...
It is easier to parse, in particular when -q is passed.
2016-12-12 15:51:29 +03:00
6e29559910
Add tests for Erlang cookie hash command
2016-12-12 12:59:41 +01:00
065c06dfab
Erlang cookie hash command
2016-12-12 11:38:45 +01:00
8735851da4
Sort commands when printing help
2016-12-07 16:21:10 +00:00
adef01fcbc
Merge pull request #150 from rabbitmq/rabbitmq-cli-144
...
Introduce `rabbitmq-diagnostics maybe_stuck`
2016-12-07 16:10:22 +01:00
6f5d3c6bb0
Introduce `rabbitmq-diagnostics maybe_stuck`
...
Fixes #144 .
[Finished ##135678977]
2016-12-07 17:10:17 +03:00
f7a741ece8
Merge branch 'master' into rabbitmq-cli-134
2016-12-07 14:05:59 +00:00
216810d205
Drive by change: simplify
2016-12-07 15:47:28 +03:00
5a5e00a48e
Use Erlang terms formatter to be compatible with eval 'ssl:cipher_suites().' output
2016-12-07 15:43:41 +03:00
d6202f761c
Make the Erlang term formatter concatenate stream elements with commas
...
Fixes #149 , references #141 .
2016-12-07 15:42:48 +03:00
7d730e739d
Introduce `rabbitmq-diagnostics cipher_suites [--openssl-format]`
...
Fixes #141 .
[##135616437]
2016-12-07 01:43:41 +03:00
967cc07c16
Do not streamify plain maps
2016-12-06 17:14:59 +00:00
6846cfa258
Remove useless output
2016-12-06 16:18:54 +00:00
28d8259450
Real time output in enable/disable/set commands
2016-12-06 15:12:47 +00:00
7b809bd7a5
Wording
2016-12-06 17:00:50 +03:00
fc0ca12a91
Test commands suggestions
2016-12-06 12:19:25 +00:00
80dc953ee5
Suggest commands by Levenshtein distance
2016-12-05 18:59:58 +00:00
cb41fe932d
Unbreak with_distribution/1
2016-12-05 19:23:20 +03:00
3deb0df90f
Merge branch 'handle-distribution-errors' of https://github.com/binarin/rabbitmq-cli into binarin-handle-distribution-errors
2016-12-05 18:42:27 +03:00
2d11e45625
Handle errors from distribution start attempts
...
Otherwise broken or misconfigured distribution is reported as an
unavailable broker node.
2016-12-05 17:51:22 +03:00
511a898a8f
Wording
2016-12-05 17:39:38 +03:00
e17c809530
Switch to a documented inet* function
...
References #137 .
2016-12-05 17:38:16 +03:00
fcd23a6ca3
Fix longname-mode on hosts without detectable FQDN
...
Re-implement https://github.com/rabbitmq/rabbitmq-server/issues/890
CLI tools fail in longnames-mode if erlang is not able to determine host
FQDN (with at least one dot in it). E.g. this happens on docker.
And it was not possible to alleviate this situation using any options
from http://erlang.org/doc/apps/erts/inet_cfg.html
2016-12-05 16:06:52 +03:00
ba0efb56b0
Merge pull request #133 from rabbitmq/rabbitmq-cli-129
...
Load command specific options from a single command
2016-12-03 11:32:44 +03:00
f788060718
Extract function
2016-12-03 11:20:02 +03:00
c62d48380a
Load command specific options from a single command
2016-11-30 16:51:59 +00:00
409f8e3b00
Use 1 RPC call to get running plugins
2016-11-30 17:19:13 +01:00
fd07c8b70b
Support several versions of plugins in directories
...
References #131
2016-11-29 17:33:41 +01:00
304ab703f4
Support multiple plugins directories
...
References #131
2016-11-29 15:26:57 +01:00
95d7d055f2
Merge pull request #130 from rabbitmq/rabbitmq-cli-123
...
Make `rabbitmqctl stop` support an optional pid file argument
2016-11-23 21:19:15 +03:00
94c21f4a40
Make `rabbitmqctl stop` support an optional pid file argument
...
While at it, move test/helpers_test.exs under test/core.
This slightly changes command output (mentions what file path is used
or what its contents are when we cannot parse it). We try hard
to not introduce any breaking changes compared to the 3.6.x CLI
tools but in this case it's an improvement.
Also, no one should depend on `rabbitmqctl stop` output, only UNIX
exit code, which did not change.
2016-11-23 21:11:01 +03:00
fcd7b66299
Add banner to encode command
...
Fixes #118
2016-11-23 10:18:20 +01:00
fc08e50e88
Merge branch 'master' into rabbitmq-cli-118
2016-11-23 09:21:56 +01:00
e3289ed454
Remove empty switches and aliases
2016-11-22 18:32:12 +00:00
887a09644b
Merge branch 'master' into rabbitmq-cli-118
2016-11-22 16:51:27 +01:00
266a4f664e
Make StopCommand#validate/2 accept a pidfile path
2016-11-22 17:23:19 +03:00
c59b6c029f
Make switches/0 and aliases/0 optional command callbacks
...
Fixes #120 . Same as #124 but doesn't include any unrelated changes
and thus suffer from #126 .
2016-11-22 16:11:25 +03:00
e92022da11
Revert "Merge pull request #124 from rabbitmq/rabbitmq-cli-120"
...
This reverts commit c087a635c059225a551dhttps://github.com/rabbitmq/rabbitmq-cli/issues/126 , which exposed
a serious flaw in the option parser split which was introduced
as part of #124 .
Reopens #120 .
2016-11-22 14:07:58 +03:00
5607b92e32
Remove empty switches/0 and aliases/0 callbacks
2016-11-21 11:26:40 +00:00
cc87a49f93
Make switches as aliases callbacks optional
2016-11-18 17:21:27 +00:00
59225a551d
Remove `flags/0` callback. Remove command modules helpers from helpers to command_modules
2016-11-18 14:12:53 +00:00
5e16943fe4
Add encode command
...
Catching up with rabbitmq/rabbitmq-server#979.
Fixes #118
2016-11-18 14:52:29 +01:00
0aa7bf6f9b
Merge branch 'master' into rabbitmq-server-1030
2016-11-17 21:36:23 +03:00
a664f83b9f
Fix stream output for csv formatter
2016-11-17 16:09:18 +00:00
e4ebdaabde
Make rabbit node resolve from environment variable by default
2016-11-17 14:16:00 +00:00
061dc48e96
Use binaries for policy RPC call
...
Part of rabbitmq/rabbitmq-server#1030
2016-11-17 09:54:11 +01:00
77e17ddf13
Printer behaviour
2016-11-16 13:46:36 +00:00
0d61a2b0d0
Use Erlang term formatter by default for status
...
Fixes #106 .
2016-11-16 00:15:44 +03:00
1cf7b70bc1
Merge pull request #116 from rabbitmq/rabbitmq-cli-115
...
CSV formatter
2016-11-15 22:05:48 +03:00
36ac65d56a
Remove dependencies
2016-11-15 16:14:22 +00:00
82026a0ec8
More global switches to control environment
2016-11-15 16:14:10 +00:00
f160f0536a
New exec command to execute elixir code locally in command context.
2016-11-15 16:12:41 +00:00
4c05e343d7
Format CSV info items with helpers
2016-11-15 11:31:59 +00:00
cb52a66d70
CSV formatter
2016-11-15 11:14:44 +00:00
ccb6bf116c
Namespace refactoring
2016-11-14 17:52:08 +00:00
6795aec784
Improve code consistency
...
* Fix some code consistency issues, mostly spaces around parenthesis, brackets and operators.
* Write large number with underscores (example: 70_000 instead of 70000)
* Write variable names in snake_case
* Remove trailing white spaces
2016-11-13 00:29:17 -06:00
31848069e2
Use RABBITMQ_NODENAME as default node
2016-11-11 11:12:09 +00:00
1dc8e90a70
Make tests happy
2016-11-10 17:40:43 +00:00
6c98c51a7d
Call rabbit:alarms instead of rabbit:status to get alarms
2016-11-10 16:01:41 +00:00
3c8e6d1ef7
Use seconds in timeout parameter. Better timeout error report
2016-11-10 14:53:59 +00:00
63382a3b18
Force non infinity timeout for node health check. Node health check output
2016-11-10 13:51:01 +00:00
8f601a4bbe
Erlang terms formatter name
2016-11-10 13:01:49 +00:00
7dd74a3232
Erlang terms formatter
2016-11-10 12:19:47 +00:00
ca69dff530
Handle non-list format_output in table formatter
2016-11-10 12:12:17 +00:00
58af1261b1
Flatten list_consumers output in table formatter
2016-11-09 18:18:32 +00:00
0d88314c50
It's not a map, it's a keyword list
2016-11-09 17:11:51 +00:00
b984a423bf
Support --local argument in list_queues
2016-11-09 17:02:05 +00:00
b436f52797
Proper error handling
2016-11-09 17:02:05 +00:00
dae427bbf9
Handle non-error outputs in wait command
2016-11-09 13:03:35 +00:00
9ebf876c9a
Do not require ENABLED_PLUGINS_FILE to run ctl, still print an error
2016-11-08 14:45:59 +00:00
4d0f9b1fb5
Load commands from plugins
2016-11-08 14:25:14 +00:00
b0f59ead31
Fix tests
2016-11-08 14:23:09 +00:00
ad90e60121
script name is overridable via argument
2016-11-08 14:21:31 +00:00
60fdcecdb4
Format disabled plugins
2016-11-08 14:19:11 +00:00
3e3d8f3f0b
Fix tests for plugins commands
2016-11-08 14:19:11 +00:00
b8c7360b14
Plugins enable/disable command formatter
2016-11-08 14:19:11 +00:00
b98470288d
List plugins formatter
2016-11-08 14:19:11 +00:00
4733765759
Better generic formatting. No tests for format_error
2016-11-08 10:11:07 +00:00
db194fb013
Merge branch 'master' into rabbitmq-cli-105
...
Conflicts:
test/forget_cluster_node_command_test.exs
test/rename_cluster_node_command_test.exs
2016-11-07 22:37:24 +03:00
837226430b
Coordinate environment with config module
2016-11-07 22:03:09 +03:00
e423453159
Add a missing clause
2016-11-07 09:45:43 -08:00
08e263ab2a
Vhost limits commands
2016-11-07 14:08:26 +00:00
85d6868763
Make table formatter look like in the old CLI
2016-11-04 12:38:35 +00:00
603dfd4cf0
Add optional callbacks to the command behaviour
2016-11-04 11:29:14 +00:00
aaabab1fe9
Enable table formatter for each list_ command
2016-11-04 11:17:02 +00:00
Daniil Fedotov
kjnilsson
Michael Klishin
Jean-Sébastien Pédron
Luke Bakken
Arnaud Cogoluègnes
Michael Klishin
Michael Klishin
Luke Bakken
Diana Corbacho
Jean-Sébastien Pédron
Ayanda Dube
Daniil Fedotov
Karl Nilsson
Gabriele Santomaggio
Daniil Fedotov
Gerhard Lazu
Gerhard Lazu
Alexey Lebedeff
Milton Mazzarri