Using xargs(1) is not always possible because it has a default limit on
the number of bytes it reads on stdin which can be too low for our need.
When we reach this limit, it breaks in a non-obvious way: the created
archive contains half of the expected files.
Now, we go through an intermediate file: the list is created once with
find(1) and sort(1) and consumed from tar(1) and zip(1).
Otherwise erl.diff cannot be applied:
patch -o rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl.src < erl.diff
patch: **** Can't create file rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl : Permission denied
The default mode of `$prefix/lib/erlang/bin/erl` is 0755.
Because we compile Erlang from sources as part of a release build, there
is no issue. Debian and FreeBSD packages follow the official mode too,
so when testing on those, it still works. However, Homebrew changes the
mode to 0555, which breaks our `Makefile` expectation.
Otherwise erl.diff cannot be applied:
patch -o rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl.src < erl.diff
patch: **** Can't create file rabbitmq_server-3.7.0.milestone8/release/rabbitmq_server-3.7.0.milestone8/erts-8.2/bin/erl : Permission denied
The default mode of `$prefix/lib/erlang/bin/erl` is 0755.
Because we compile Erlang from sources as part of a release build, there
is no issue. Debian and FreeBSD packages follow the official mode too,
so when testing on those, it still works. However, Homebrew changes the
mode to 0555, which breaks our `Makefile` expectation.
We override the default $(PLUGINS) with the one specified from the
command line, or with the same value if nothing was specified.
This makes sure that the source archive doesn't try to fetch plugins
which were not listed when it was created.
[#131643765]
This only replaces an existing but empty `broker_version_requirements`
so it's fine in the 3.6.x branch where the parameter is never set. And
even if it is present, it would not be used by the broker so it is
harmless.
[#130992027]
This is the variable expected and used by Erlang.mk
When working from Git, the variable can be specified on the command
line. This is particularily useful when using `make run-broker` or `make
source-dist`.
When working from the source archive created by `make source-dist`, the
version is taken from `git-revisions.txt`, a file created during the
creation of the source archive. If the variable is specified on the
command line as well, it takes precedence over the one in
`git-revisions.txt`, like any Makefile variables.
[#130992027]
We cannot remove it in 3.6.x but it's really time for it to go.
It has been effectively unmaintained (and very much unused)
since at least 2012. In fact, it has always been experimental
and it wasn't a very good idea to include it into the distribution
in the first place.
We cannot continue carrying this dead weight forever.
Per discussion with other team members.
Add a matrix of two test cases:
* Smoke test: just a check if rabbit cluster assembles.
* Jepsen test: allowed to fail, it's main value is to
verify cluster auto-healing after consequent network
partitions and to provide numbers for
duplicated/lost/recovered/unexpected messages as well.
* Pin the cluster installer repo to the 1.2.0.
Backport from master branch
Make the gate always passing if there is no changes found
to the RabbitMQ OCF RA script in the patch under test.
Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
Add a matrix of two test cases:
* Smoke test: just a check if rabbit cluster assembles.
* Jepsen test: allowed to fail, it's main value is to
verify cluster auto-healing after consequent network
partitions and to provide numbers for
duplicated/lost/recovered/unexpected messages as well.
Make the gate always passing if there is no changes found
to the RabbitMQ OCF RA script in the patch under test.
Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>