Commit Graph

466 Commits

Author SHA1 Message Date
Michael Klishin 93dbbf342e Rework how command-specific options are displayed in help
Per recommendation from @dumbbell.
usage_addition/0 return format per discussion
with @dcorbacho, @hairyhum, @lukebakken.
2019-03-26 01:21:22 +03:00
Michael Klishin 187d6cd79a Cosmetics 2019-03-21 19:06:27 +03:00
Spring Operator 0a2541afd3 URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# HTTP URLs that Could Not Be Fixed
These URLs were unable to be fixed. Please review them to see if they can be manually resolved.

* http://blog.listincomprehension.com/search/label/procket (200) with 1 occurrences could not be migrated:
   ([https](https://blog.listincomprehension.com/search/label/procket) result ClosedChannelException).
* http://dozzie.jarowit.net/trac/wiki/TOML (200) with 1 occurrences could not be migrated:
   ([https](https://dozzie.jarowit.net/trac/wiki/TOML) result SSLHandshakeException).
* http://dozzie.jarowit.net/trac/wiki/subproc (200) with 1 occurrences could not be migrated:
   ([https](https://dozzie.jarowit.net/trac/wiki/subproc) result SSLHandshakeException).
* http://e2project.org (200) with 1 occurrences could not be migrated:
   ([https](https://e2project.org) result AnnotatedConnectException).
* http://erlang.org/doc/reference_manual/distributed.html (200) with 1 occurrences could not be migrated:
   ([https](https://erlang.org/doc/reference_manual/distributed.html) result ConnectTimeoutException).
* http://nitrogenproject.com/ (200) with 2 occurrences could not be migrated:
   ([https](https://nitrogenproject.com/) result ConnectTimeoutException).
* http://proper.softlab.ntua.gr (200) with 1 occurrences could not be migrated:
   ([https](https://proper.softlab.ntua.gr) result SSLHandshakeException).
* http://yaws.hyber.org (200) with 1 occurrences could not be migrated:
   ([https](https://yaws.hyber.org) result AnnotatedConnectException).
* http://choven.ca (503) with 1 occurrences could not be migrated:
   ([https](https://choven.ca) result ConnectTimeoutException).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* http://fixprotocol.org/ (301) with 1 occurrences migrated to:
  https://fixtrading.org ([https](https://fixprotocol.org/) result SSLHandshakeException).
* http://erldb.org (UnknownHostException) with 1 occurrences migrated to:
  https://erldb.org ([https](https://erldb.org) result UnknownHostException).
* http://elixir-lang.org/docs/stable/elixir/OptionParser.html (301) with 1 occurrences migrated to:
  https://elixir-lang.org/docs/stable/elixir/OptionParser.html ([https](https://elixir-lang.org/docs/stable/elixir/OptionParser.html) result 404).
* http://elixir-lang.org/docs/stable/elixir/Stream.html (301) with 1 occurrences migrated to:
  https://elixir-lang.org/docs/stable/elixir/Stream.html ([https](https://elixir-lang.org/docs/stable/elixir/Stream.html) result 404).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* http://cloudi.org/ with 27 occurrences migrated to:
  https://cloudi.org/ ([https](https://cloudi.org/) result 200).
* http://elixir-lang.org with 1 occurrences migrated to:
  https://elixir-lang.org ([https](https://elixir-lang.org) result 200).
* http://elixir-lang.org/ with 2 occurrences migrated to:
  https://elixir-lang.org/ ([https](https://elixir-lang.org/) result 200).
* http://elixir-lang.org/getting-started/typespecs-and-behaviours.html with 1 occurrences migrated to:
  https://elixir-lang.org/getting-started/typespecs-and-behaviours.html ([https](https://elixir-lang.org/getting-started/typespecs-and-behaviours.html) result 200).
* http://elixir-lang.org/install.html with 1 occurrences migrated to:
  https://elixir-lang.org/install.html ([https](https://elixir-lang.org/install.html) result 200).
* http://erlware.org/ with 1 occurrences migrated to:
  https://erlware.org/ ([https](https://erlware.org/) result 200).
* http://inaka.github.io/cowboy-trails/ with 1 occurrences migrated to:
  https://inaka.github.io/cowboy-trails/ ([https](https://inaka.github.io/cowboy-trails/) result 200).
* http://ninenines.eu with 6 occurrences migrated to:
  https://ninenines.eu ([https](https://ninenines.eu) result 200).
* http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 1 occurrences migrated to:
  https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200).
* http://www.actordb.com/ with 2 occurrences migrated to:
  https://www.actordb.com/ ([https](https://www.actordb.com/) result 200).
* http://www.cs.kent.ac.uk/projects/wrangler/Home.html with 1 occurrences migrated to:
  https://www.cs.kent.ac.uk/projects/wrangler/Home.html ([https](https://www.cs.kent.ac.uk/projects/wrangler/Home.html) result 200).
* http://www.rebar3.org with 1 occurrences migrated to:
  https://www.rebar3.org ([https](https://www.rebar3.org) result 200).
* http://contributor-covenant.org with 1 occurrences migrated to:
  https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301).
* http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301).
* http://inaka.github.com/apns4erl with 1 occurrences migrated to:
  https://inaka.github.com/apns4erl ([https](https://inaka.github.com/apns4erl) result 301).
* http://inaka.github.com/edis/ with 1 occurrences migrated to:
  https://inaka.github.com/edis/ ([https](https://inaka.github.com/edis/) result 301).
* http://lasp-lang.org/ with 1 occurrences migrated to:
  https://lasp-lang.org/ ([https](https://lasp-lang.org/) result 301).
* http://rabbitmq.com/documentation.html with 1 occurrences migrated to:
  https://rabbitmq.com/documentation.html ([https](https://rabbitmq.com/documentation.html) result 301).
* http://saleyn.github.com/erlexec with 1 occurrences migrated to:
  https://saleyn.github.com/erlexec ([https](https://saleyn.github.com/erlexec) result 301).
* http://www.mozilla.org/MPL/ with 290 occurrences migrated to:
  https://www.mozilla.org/MPL/ ([https](https://www.mozilla.org/MPL/) result 301).
* http://zhongwencool.github.io/observer_cli with 1 occurrences migrated to:
  https://zhongwencool.github.io/observer_cli ([https](https://zhongwencool.github.io/observer_cli) result 301).
2019-03-20 03:13:07 -05:00
Michael Klishin 4c1b377330 Reduce generic options section per discussion in #333
The section on node names has been moved to https://www.rabbitmq.com/cli.html#node-names
(not yet live).
2019-03-19 22:23:42 +03:00
Michael Klishin c72b0928f7 Reduce general options section
* Only keep [--timeout <n>] but not a separate section for
   commands that support timeouts.
 * Replace a separate virtual host section with a general option.
   This option doesn't really need a detailed explanation.
 * Replace a separate --quiet/--silent section with a general option.
   This option doesn't really need a detailed explanation.

Per discussion with @gerhard and @acogoluegnes.
2019-03-18 14:36:22 +03:00
Michael Klishin 8c60489719 Replace [-p vhost] in help messages with [--vhost vhost] 2019-03-18 13:53:54 +03:00
Michael Klishin cb3fa1048e Rename <*infoitem> in help messages to <column>
Clearer, easier to read and uniform.
2019-03-18 13:47:46 +03:00
Michael Klishin 1e996b1128 Sort info items in command help
Per suggestion from @gerhard.
2019-03-18 13:42:06 +03:00
Michael Klishin 9bc4b148f1 Document more command-specific arguments and switches 2019-03-18 08:56:17 +03:00
Michael Klishin 7d2b5c4730 Document more command-specific arguments and switches 2019-03-18 07:47:46 +03:00
Michael Klishin 1ce3cb00f6 delete_queue: document switches in --help 2019-03-18 07:47:45 +03:00
Michael Klishin 97960bde37 Cosmetics 2019-03-18 07:47:45 +03:00
Michael Klishin af2b343784 list_channels: @info_keys are meant to be atoms
Even though the implementation now supports
string values as well.
2019-03-18 07:47:44 +03:00
Michael Klishin b47ec93f97 Merge pull request #331 from rabbitmq/list-queue-type
Add queue type to list queues command
2019-03-18 05:53:07 +03:00
Michael Klishin 50f702d63b Global options: mention --formatter=pretty_table 2019-03-17 14:18:33 +03:00
Michael Klishin e1df5c0a87 ctl close_all_connections: additional usage docs 2019-03-17 14:13:13 +03:00
Michael Klishin d54f979ed8 Do not indent lines in usage_additional
We eliminated indentation in other sections
because it is too painful to get aligned
for command author.
2019-03-17 14:12:50 +03:00
Michael Klishin 2f5472e03f Cosmetics 2019-03-17 14:05:42 +03:00
Michael Klishin b5d39b2a2f Handle info keys that are strings
Some commands define them as atoms, others
as strings.
2019-03-17 14:01:04 +03:00
Michael Klishin bea9cf4486 Rework command-specific help
* Display command-specific options first instead of
  generic at the top
* Include one line command synopsis from --list-commands
  in the command-specific message
* List timeout in a separate section. It doesn't
  integrate very well with either command-specific
  or general section
* Format section headings as H2s in Markdown, this makes them stand out
* Assorted small formatting changes
* Update tests to be less fragile to copywriting changes
2019-03-17 13:54:18 +03:00
Michael Klishin c5b5df1282 Help command descriptions, cosmetics 2019-03-17 06:55:22 +03:00
Michael Klishin c48a1fae65 Correctly format management_agent and other multi-segment plugin names
Without this management_agent failed to be formatted
causing an ugly looking exception in --help.
2019-03-16 21:18:22 +03:00
Michael Klishin 10be5d4dec Cosmetics
Rearrange functions to follow a more common
command interface order.
2019-03-16 21:17:12 +03:00
Michael Klishin 30b6069293 restart_vhost belongs to the Virtual Hosts section 2019-03-16 21:16:33 +03:00
Diana Corbacho b56b69f9fa Add queue type to list queues command
[#163984879]
2019-03-15 17:07:11 +00:00
Michael Klishin 7f6ef260da ctl shutdown: consider @localhost nodes to be local
Without this -n has to be used when it previously wasn't required.

Follow-up to #328, references #327, #309.

Per discussion with @lukebakken.
2019-03-07 01:29:23 +03:00
Michael Klishin c339b6a10c ctl shutdown: infer hostnames from node names
inet_db is not a very reliable source as it doesn't take
node name CLI arguments and ERL_INETRC file settings.
That can lead to false positives in environments where
inet_db returns the same value (e.g. `localhost`) for
every cluster member.

Per discussion with @gerhard.

Closes #327.
References #309.
2019-03-06 20:19:52 +03:00
Michael Klishin e589a2b985 ctl forget_cluster_node: improve error formatting 2019-02-26 14:04:41 +03:00
Josh Soref 2dcfd4a34b spelling: parameterised 2019-02-24 02:02:34 -05:00
Michael Klishin 6a368e24dc New command group: replication 2019-02-21 20:45:49 +03:00
Michael Klishin 8ac5f2ec7b Improve formatting of protocol plugin help sections 2019-02-21 19:53:45 +03:00
Michael Klishin 3f32c237dc Squash a couple of compiler warnings 2019-02-21 19:17:52 +03:00
Michael Klishin aceab7c592 Wording, typos 2019-02-21 19:14:50 +03:00
Michael Klishin ea6294be41 New command: `rabbitmqctl force_gc`
Developed as part of a live coding training session but can be
useful in practice, so let's keep it.

Per discussion with @hairyhum.
2019-02-21 19:11:30 +03:00
Michael Klishin 62b2fdf80c Combine virtual host management, limits, tracing into a single group 2019-02-21 17:54:16 +03:00
Michael Klishin 866ce75fe4 More/slightly improved command descriptions 2019-02-21 17:03:34 +03:00
Michael Klishin cbaf74d269 Help sections for rabbitmq-diagnostics commands 2019-02-21 16:35:41 +03:00
Michael Klishin 4932c339c7 Command groups: naming, rearranging 2019-02-21 15:52:51 +03:00
Michael Klishin 80993dc921 Merge branch 'master' into help-wip 2019-02-21 13:18:59 +03:00
Daniil Fedotov 993d4a928a Support custom help sections. 2019-02-14 13:19:46 -05:00
Daniil Fedotov b157b6a7cf Do not use defcmd macro. 2019-02-14 13:16:49 -05:00
Daniil Fedotov 1b4aaac477 Formatting of the help message 2019-02-14 13:11:23 -05:00
Daniil Fedotov a56ee97d74 Make help sections and descriptions similar to man page. 2019-02-14 13:02:00 -05:00
Michael Klishin c7e8ab9b56 New command: version, closes #314 2019-02-14 15:10:22 +03:00
Daniil Fedotov 9fdeaef417 Clarify that list_connections command ony applies to AMQP 0.9.1 2019-02-12 14:49:16 -05:00
Daniil Fedotov a5c34042de Example of using defcmd to define constant command callbacks 2019-02-11 14:07:49 -05:00
Daniil Fedotov 680c8969ca Add more command descriptions 2019-02-11 14:07:34 -05:00
Daniil Fedotov 5fabaeddb4 Cleanup help command. Support plugin sections in command list. 2019-02-11 14:06:16 -05:00
Daniil Fedotov a7d70f1448 More descriptions for commands 2019-02-11 09:35:12 -05:00
Jean-Sébastien Pédron b17a998ed1 list_feature_flags_command.ex: Add `doc_url` to the columns list
[#160169569]
2019-02-11 11:01:18 +01:00
Daniil Fedotov 3d13da5797 More command descriptions. 2019-02-08 15:57:10 -05:00
Daniil Fedotov d6789e60f2 A new way to display basic usage.
Do not show additional parameters info.
List commands as names and descriptions.
Group commands in sections.

New behaviour callbacks:
help_section/0 - atom name of a group to put command to. Default is :other
description/0 - single line description of the command. Printed in the commands list

Sections ans descriptions are WIP.
2019-02-08 15:33:17 -05:00
Michael Klishin b452733d73 Improve error message produced by `rabbitmqctl shutdown`
References #309.
2019-02-07 04:24:13 +03:00
Michael Klishin f526663e9a Cosmetics 2019-02-05 21:29:28 +03:00
Luke Bakken 962e0cf7c7 Ensure longnames option is passed to normalise_node
Fixes #311
2019-02-05 07:27:34 -08:00
Arnaud Cogoluègnes 97c048cf37 Add active consumer fields if necessary
When calling node is 3.8 and one of the nodes is < 3.8, active and
activity status fields need to be set with default values.

[#163298456]
2019-02-05 15:06:51 +01:00
Jean-Sébastien Pédron aa93258f16 wait_command.ex: Fix function clause with validate/2
The function didn't have the success path, i.e. when one of `--pid` or a
pidfile is specified.
2019-02-04 12:07:53 +01:00
Michael Klishin 041a6c2bdf Reuse existing modules more, rearrange functions 2019-02-04 02:22:21 +03:00
Michael Klishin 56ac8d1cf7 shutdown: correctly wrap badrpc responses in validate/2 2019-02-03 22:00:11 +03:00
Michael Klishin 7ad9176435 Further improvements to the shutdown command
Add --[no-]wait (enabled by default) for those who would prefer
to use it to shut down remote nodes even though it wouldn't wait for
a verified node termination.

Propagate --timeout to calls.

References #309.
2019-02-03 20:40:01 +03:00
Michael Klishin 0786b13d4a Move the node locality to a validator 2019-02-03 18:37:28 +03:00
Michael Klishin 29d01a44fb Merge branch 'master' into shutdown_require_local_host 2019-02-03 18:15:17 +03:00
Michael Klishin db72acf1a3 Squash a couple of warnings 2019-02-03 06:20:04 +03:00
Michael Klishin 2ad334c91f Refactor 2019-02-03 04:55:37 +03:00
Michael Klishin bf00712add Make all list_* commands available to rabbitmq-diagnostics 2019-02-03 04:32:37 +03:00
Jean-Sébastien Pédron e25fee769a Set `feature_flags_file` app env for {forget,rename}_cluster_node
This is required when we try to impersonate a node: that node needs to
know about the actually enabled feature flags to act properly.

[#160169569]
2019-02-02 01:30:27 +01:00
Luke Bakken 9b01b1cf3c Add `list_feature_flags` and `enable_feature_flag` commands
As their name suggests, they are used to manage the feature flags of
RabbitMQ and its plugins.

[#159298729]
2019-02-01 17:51:21 +01:00
Daniil Fedotov 7bc4bf9dfa Make shutdown command require a node to be local.
Shutdown waits for the node to stop based on OS pid,
if the node is not local, it will be the wrong pid.

[#142699795]
2019-02-01 11:47:37 -05:00
Michael Klishin db2f6bc4e6 Help message copywriting 2019-01-31 01:39:12 +03:00
Michael Klishin c79ac644b9 Mention --help in the global option section 2019-01-31 01:14:55 +03:00
Daniil Fedotov 5e5f4d461c Make it possible to get command help by typing 'rabbitmqctl mycommand --help'
Add a new default switch `help`
Add an alias `?`

Make rabbitmqctl display command help if this option is true for known commands.
2019-01-30 16:47:18 -05:00
Daniil Fedotov 91bb84bc82 Move table_headers parameter definition to formatter.
Since #301 formatters support their own parameters
2019-01-30 16:02:11 -05:00
Michael Klishin 94b55d71fa Format with `gmake format` 2019-01-30 22:20:29 +03:00
Michael Klishin 724dbca331 Merge pull request #303 from rabbitmq/await_startup_with_a_timeout
New command: `rabbitmqctl await_startup`
2019-01-28 21:06:41 +03:00
Michael Klishin 5fad316390 New command: `rabbitmqctl await_startup`
Like `rabbitmqctl wait` but doesn't use a pid file path.

Pair: @gerhard.

References rabbitmq/rabbitmq-server#1848.
2019-01-28 20:45:08 +03:00
Arnaud Cogoluègnes 606b72b5a6 Add active to default fields for list_consumers
[#163298456]

References rabbitmq/rabbitmq-server#1839
2019-01-24 18:26:39 +01:00
Arnaud Cogoluègnes 1732932f7b Merge branch 'master' into rabbitmq-server-1838-active-field-for-consumers 2019-01-24 10:46:58 +01:00
Michael Klishin ad23b37e3f Introduce 'rabbitmq-diagnostics check_port_listener <port>'
Part of #292.
2019-01-23 19:13:08 +03:00
Michael Klishin 58a66af140 Refactoring 2019-01-23 10:12:27 +03:00
Arnaud Cogoluègnes ca396e0ce5 Add active and activity status fields to list_consumers
[#163298456]

References rabbitmq/rabbitmq-management#1838
2019-01-21 14:36:53 +01:00
Michael Klishin b6f4d75afc Update (c) year 2019-01-20 06:10:59 +03:00
Arnaud Cogoluègnes c6d4fcf19d Add single active field to list_consumers command
[#163089472]

References rabbitmq/rabbitmq-management#649
2019-01-16 10:38:57 +01:00
Luke Bakken f1b6283e9f Format changed file with "mix format" 2018-12-19 16:14:43 -08:00
Luke Bakken 7629703ca4 Add chunks equal to number of nodes
Fixes #284
2018-12-19 14:44:53 -08:00
Luke Bakken 9cc61e594b Add tests for normalising name with :longnames 2018-11-30 13:58:27 -08:00
Luke Bakken 35ffd53be1 Rename parse_node to normalise_node 2018-11-30 12:14:21 -08:00
Michael Klishin df5db4ec1b Validate log level values, format unsupported level errors in a more human-friendly way 2018-11-29 00:20:41 +08:00
Luke Bakken 0e7608083b Add command to set log level
Fixes #276
2018-11-27 15:49:11 -08:00
Luke Bakken 8ab22299a8 Document --no-table-headers
Fixes #274

Switch no_table_headers to table_headers

update tests

Integrate --silent
2018-11-19 15:25:36 -08:00
Michael Klishin 6416d745ed Update tests
[#161309687]
2018-11-01 23:46:32 +03:00
Diana Corbacho b8ab5f9b01 Rename ignore-stopped flag to idempotent
[#161309687]
2018-11-01 16:18:38 +00:00
Diana Corbacho 68d901bc3a Make stop idempotent using --ignore-stopped flag
[#161309687]
2018-11-01 14:22:13 +00:00
Michael Klishin 582fa06686 More warnings 2018-10-30 00:51:35 +03:00
Daniil Fedotov 19a58551b3 Improve error reporting for quorum queues commands.
Validate that the rabbit app is runninig.
Format error when trying to access a classic queue.
Minor refactorings.
2018-10-26 15:20:34 +01:00
Diana Corbacho 6bda3873d6 Add quorum status command to report local ra state
[#157146500]
2018-10-26 14:50:36 +01:00
Michael Klishin 5e54354fdf Make it possible to suppress table headers for list_* commands
Using --no-table-headers, per discussion with @dumbbell.
2018-10-24 16:43:58 +03:00
Luke Bakken ad184bac68 Add global parameters to rabbbitmqctl report
Follow-up to #256
2018-08-27 14:38:26 -07:00
Ayanda Dube c88cfd940d Reduce code footprint on aliases 2018-07-23 06:06:18 +01:00
Ayanda Dube 4ee275cbcd Include policies and parameters in report command 2018-07-16 16:36:47 +01:00
Michael Klishin 40b40a6d42 Make the ping command available in rabbitmq-diagnostics as well
References #253.

[#158291890]
2018-06-13 00:38:02 +03:00
Michael Klishin 158dc0eb7e Wording 2018-06-13 00:37:17 +03:00
Michael Klishin b20418cb83 Pass current node as is_auth "argument"
To be closer to what net_adm:ping/1 does. The argument
is then ignored by net_kernel, though.

[#158291890]
2018-06-12 23:18:48 +03:00
Michael Klishin ee2b185db9 Introduce rabbitmqctl ping
See #253 for background.

[#158291890]
2018-06-12 16:47:54 +03:00
Michael Klishin 09e86fb73d New command: await_online_nodes <count> [--timeout <timeout>]
Closes #235.

[#156729133]
2018-05-29 16:01:03 +03:00
Luke Bakken e99bc16428 Whitespace changes
See #236
2018-03-08 14:13:32 -08:00
Daniil Fedotov aef04bef84 Show timeout in help messages only for commands supporting timeout.
Removed timeout from default parsing options. Now every command
has to specify timeout in it's own switches.
If a command has timeout in switches - there will be help displayed
for this option in usage output.
2018-03-07 18:28:21 +00:00
Daniil Fedotov 0c83c05ec1 Do not show timeout option for rabbitmq-plugins tool.
The rabbitmq-plugins tool does not respect timeout option.
2018-03-07 15:51:54 +00:00
Daniil Fedotov 8b33c646ed Command to delete a queue. 2018-03-07 15:20:18 +00:00
Michael Klishin aff9d9aa11 Merge branch 'rabbitmq-cli-command-distribution' 2018-01-16 19:35:34 +03:00
Michael Klishin f99245c5b6 Wording 2017-12-08 17:55:50 -08:00
Luke Bakken 81862adcab Fixing SetParameterCommand and tests
Fix code to fix test suite
2017-12-08 11:49:20 -08:00
Daniil Fedotov cf23e45cf9 Optimise some commands by not starting erlang distribution 2017-12-07 11:06:34 +00:00
Daniil Fedotov b5de2236ce Add a callback to control erlang distribution.
The callback cab be used to disable distribution (offline commands)
or to have command-specific node name and distribution parameters.
2017-12-06 18:10:11 +00:00
Daniil Fedotov 32bd206ff9 Remove -l alias from help_command. It iss conflicting with default alias 2017-08-18 16:13:20 +01:00
Michael Klishin 206a5fb93c Squash a warning 2017-08-15 12:53:31 +03:00
Daniil Fedotov 8bc0b68f4e Change validation for the force_boot command 2017-08-14 19:20:32 +01:00
Daniil Fedotov 141e845fab Remove duplicate global switches. 2017-08-14 17:14:41 +01:00
Daniil Fedotov 3e30b8a4f3 Enable rabbit app validation for list_parameters and clear_permissions. Disable the validation for shutdown 2017-08-14 11:59:35 +01:00
Luke Bakken 006ff6a259 Remove extra whitespace 2017-08-11 14:57:18 -07:00
Michael Klishin b00e648b9c Extend execution environment validation to more commands
This also re-formats a bunch of commands to follow the same
order for the following functions:

 * merge_defaults/2
 * validate/2
 * validate_execution_environment/2
 * run/2
2017-08-11 18:06:30 +03:00
Michael Klishin fa0515911f These commands don't really require the rabbit app to be running 2017-08-11 14:37:02 +03:00
Michael Klishin 8cee00231b Introduce RabbitMQ.CLI.Core.RequiresRabbitApp{Running,Stopped}
and apply them to a subset of commands.
2017-08-11 02:23:53 +03:00
Michael Klishin efe8725f3c Merge branch 'master' into rabbitmq-cli-214-take-two 2017-08-10 14:21:42 +03:00
Daniil Fedotov e8c73d9bea Merge branch 'master' into rabbitmq-cli-207 2017-08-09 14:36:07 +01:00
Daniil Fedotov de10e4f5a7 Different list of info items for unresponsive queues 2017-08-09 14:34:01 +01:00
Daniil Fedotov 035e7305ac Merge pull request #218 from rabbitmq/timeout_list_queues
Set a timeout on list_queues and a warning if unresponsive ones are found
2017-08-09 17:24:40 +04:00
Michael Klishin afa605b3e9 Merge branch 'master' into rabbitmq-cli-214-take-two
Conflicts:
	lib/rabbitmq/cli/plugins/commands/enable_command.ex
2017-08-08 19:14:07 +03:00
Diana Corbacho 738f667716 Override timeout 2017-08-08 10:01:32 +02:00
Diana Corbacho 9d6dfddb3e Set a timeout on list_queues and a warning if unresponsive ones are found
Related to rabbitmq-cli#207
2017-08-07 17:38:24 +02:00
Diana Corbacho 829a918c5a Use info items to list unresponsive queues
rabbitmq-cli#207
[#149059849]
2017-08-07 15:08:33 +02:00
Michael Klishin e9fa801d6f Update restart_vhost usage 2017-08-04 21:45:22 +03:00
Michael Klishin 6da66de40a forget_cluster_node: switch to validate_execution_environment/2 2017-08-04 19:15:53 +03:00
Michael Klishin 8e9b114eac Fold execution environment validation into a single optional fn
While at it, move Ctl.Validators => Core.Validators.

If the function is not defined we skip validation. Note that
individual commands need to be revisited and refactored to use
this mechanism; this is yet to come.

Per discussion with @hairyhum and @lukebakken.
2017-08-04 18:40:17 +03:00
Daniil Fedotov 10bb587d61 The command to restart a vhost.
The command will attempt to restart a vhost.
If restarted successfully, return exit code 0
If the vhost is already started, return exit code 0 and notify that it's already started.
If there is an error restarting, return exit code 70 and the error
Part of rabbitmq/rabbitmq-server#1321
[#149484305]
2017-08-04 11:32:40 +01:00
Daniil Fedotov a7bd5811d0 Change state in vhost info to cluster_state 2017-08-01 14:56:21 +01:00
Diana Corbacho 3c6a59079c Command to report unresponsive queues
rabbitmq-cli#207
[#149059849]
2017-07-27 17:50:52 +02:00
Diana Corbacho 05469e4bad Report vhost status on list_vhosts command
rabbitmq-management#446
[#149398495]
2017-07-25 11:47:07 +01:00
Michael Klishin df726906a2 Make arguments in this fn head easier to identify 2017-07-12 13:08:20 +03:00
Diana Corbacho 1be262d496 Avoid streaming if no nodes are available
rabbitmq-cli-202
[#148733373]
2017-07-12 10:35:32 +01:00
Michael Klishin a9bd603352 Squash a warning 2017-07-04 22:24:00 +03:00
Michael Klishin 09eee9fd53 Improve error messages 2017-07-03 16:39:04 +03:00
Michael Klishin 5774bc64e5 Merge branch 'master' into rabbitmq-cli-encode-commands 2017-07-03 15:52:07 +03:00
Daniil Fedotov 58304ffc95 Split encode command tests to separate commands 2017-07-03 12:11:34 +01:00
Michael Klishin b7b5223a39 list_vhost_limits: handle errors before serialising results
Also update tests and format no_such_vhost errors in a more sensible
way.
2017-06-30 14:43:09 +03:00
Daniil Fedotov c40368fe02 Split encode command to encode, decode, list_ciphers and list_hashes commands
[#147861659]
2017-06-28 17:19:42 +01:00
Daniil Fedotov a4b452545b Improve formatting for list_vhost_limits command.
Format limits as JSON.
Make sure vhost field printed before limits.
2017-06-27 17:28:37 +01:00
Daniil Fedotov ee8c2f133c Support Elixir-1.5.0-rc.0 2017-06-26 11:59:46 +01:00
Michael Klishin 6410ba0272 Fix compiler warnings that hinted at a typo in atom name
First spotted by @lbakken.
2017-06-16 19:43:09 +03:00
Diana Corbacho beacfe998a Handle error in `rabbit_mnesia:cluster_nodes/1` on cluster_status command
If the error is ignored, an Enum exception is triggered which is not
meaningful for the final user. Notifying that something is wrong accessing
to Mnesia files provides a hint. Can be eventually reproduced while
the node is restarting.

rabbitmq-cli#199
2017-06-16 16:51:57 +01:00
Daniil Fedotov 81c1f9461f Add an output formatter for report command
Report command executes other commands, so it's formatter
cannot be changed using command line argument.
Report formatter will format each command output with this command
default formatter.
2017-06-15 16:32:39 +01:00
Daniil Fedotov 3693daf693 Add functions to get info keys to list_* commands 2017-06-15 16:31:32 +01:00
Daniil Fedotov c31989de08 Change banner for list_queues and list_exchanges to show vhost 2017-06-15 16:03:38 +01:00
Michael Klishin 5409c37f3e Merge pull request #194 from rabbitmq/rabbitmq-cli-193
Check `rabbit_mnesia:status` return value
2017-06-15 16:38:22 +03:00
Michael Klishin a84c4b3405 Merge pull request #195 from rabbitmq/naming
Rename <user> to <username> to standarise all rabbitmqctl commands
2017-06-15 16:37:55 +03:00
Diana Corbacho 5bdfcc575d Display --local option in list_queues help 2017-06-15 12:42:02 +01:00
Diana Corbacho d6686e40f6 Rename <user> to <username> to standarise all rabbitmqctl commands
Most commands use <username> in the help description
2017-06-15 12:06:32 +01:00
Diana Corbacho 68698d34d2 Check `rabbit_mnesia:status` return value
Ensures the error is returned and not used later on.

rabbitmq-cli#193
2017-06-14 17:00:18 +01:00
Daniil Fedotov a3776bf9b8 Return :ok in validation. 2017-06-08 18:29:51 +01:00
Daniil Fedotov 1641ecbc11 Improve wait command.
Do not call await_startup on rabbitmq node, instead do it on
rabbitmqctl node, so even if net_ticktime is low, it won't fail
with nodedown.
2017-06-08 18:15:21 +01:00
Daniil Fedotov b8d6042046 Quiet mode for wait command will suppress log messages 2017-06-07 14:22:59 +01:00
Jean-Sébastien Pédron cd377eeb0f Merge branch 'rabbitmq-cli-wait-stages' 2017-06-07 13:42:36 +02:00
Daniil Fedotov 6b1fbb482c Change cluster node type to selected type 2017-06-06 18:43:38 +01:00
Daniil Fedotov a759eea11a Make wait take the actual function execution time to account 2017-06-06 18:11:25 +01:00
Daniil Fedotov 27fc29914c Test exec command 2017-06-06 12:07:00 +01:00
Daniil Fedotov 5c98699a29 Add new test to check argument processing typical to multiple commands.
Check that merge_defaults does not fail on badmatch with arbitrary args.
Check that info keys can be a comma-separated list
2017-06-06 12:06:17 +01:00
Jean-Sébastien Pédron 975be0ccfb join_cluster_command: Format the `already_member` return value 2017-06-06 11:50:20 +02:00
Daniil Fedotov b4a8789ed1 Wait in stages.
Make wait command work in stages with timeouts.
First wait for a pid file to appear (times out)
Then wait for erlang distribution to start on the node (times out)
Then wait for application to be running in the node (does not time out)

Default timeout is set to 10 seconds, which should be enough to
write a pid file and start distribution.
2017-06-02 16:48:34 +01:00
Daniil Fedotov 6cf003ed03 Typo in info message 2017-06-02 14:35:52 +01:00
Daniil Fedotov 8ea044dd80 Do not match arguments in merge_defaults.
merge_defaults gets called before validate, so it should allow
any argument number.
2017-06-02 10:17:28 +01:00
Daniil Fedotov 51de5e0fea Less strict help arguments
Print command help even if there are more than 1 argument.
For example:
  rabbitmqctl help <command> <other args>
2017-06-02 10:17:28 +01:00
Daniil Fedotov 7fb2a1d797 Print result in trace_on/off commands 2017-06-02 10:17:28 +01:00
Daniil Fedotov 4c06bee5fe Unfold stream subcommand output in report command. 2017-06-02 10:17:28 +01:00
Daniil Fedotov d1040ca11f Helper function to parse info_keys arguments 2017-06-02 10:17:28 +01:00
Daniil Fedotov 9b0ec73a0d Set default formatter for environment command to erlang 2017-06-02 10:17:28 +01:00
Daniil Fedotov 769fe8e712 Better error management with stream outputs from list_ commands.
Fixed incorrect tuple matching.
Added support for error codes and messages for timeout with value.
2017-05-24 13:28:51 +01:00
Daniil Fedotov 60deb8514d Improve error reporting.
badrpc errors are handled in Rabbitmqctl module.
Report errors from node discovery
Add helpers to skip errors in formatters.
2017-05-24 12:08:03 +01:00
Daniil Fedotov 719b75269c Fixing erlang and string formatters.
Erlang formatter had issues when formatting erlang strings, because
they were interpreted as streams. Now all streams are being converted
to lists and printed as is.
String formatter does not try to format with io_lib, instead it tries
to format using Elixir to_string.
2017-05-22 17:14:26 +01:00
Michael Klishin 1805012f77 Merge branch 'master' into rabbitmq-cli-shutdown 2017-04-07 22:31:54 +02:00
Michael Klishin 987526d70f (c) year 2017-04-05 15:44:16 +03:00
Daniil Fedotov 8ef4c404ab Do not import modules. Import only protocols and records.
Aliases is a convinient enough to reference elixir modules.
Imported functions can be confusing, especially mixed with aliases.
2017-04-05 11:59:54 +01:00
Daniil Fedotov 819d512038 Implement shutdown command 2017-04-04 19:23:50 +01:00
Daniil Fedotov 62a44ac641 Optimize rabbitmqctl startup.
Plugins dirs are added to ERL_LIBS by shell scripts, we try to load
enabled plugins first and scan plugins dir only if some of them
are not found.
When discovering plugins, we can load applications only for enabled ones.
EPMD can be started only after initial `net_kernel:start` call failed.
We don't need to discover all commands every time, only if a command is not
in the `rabbitmqctl` application modules.
[finishes #143025009]
2017-04-04 14:06:53 +01:00
Daniil Fedotov 05a2a18f52 Handle `eacces` errors in addition to `eperm` in `hipe_compile` command
`hipe_compile` command validation checks that directory can be created and
have permissions to write .beam files. System can return `eperm` or `eacces`
errors in different conditions, but the meaning of those errors is same.
2017-03-14 17:18:18 +00:00
Michael Klishin 2dc56b3737 hipe_compile: reject blank, non-existent paths and those with insufficient permissions
References #178.
2017-03-14 01:49:04 +03:00
Michael Klishin 95ea549472 rabbit app is loaded during validation; handle "already compiled" cases
References #178.
2017-03-13 21:21:15 +03:00
Michael Klishin f2f0c26e44 Finish hipe_compile command
This correctly handles the case where the rabbit app is
already loaded.

References #178.
2017-03-10 21:25:00 +03:00
Michael Klishin 34262f2161 ctl hipe_compile WIP
This command needs access to RabbitMQ modules and currently
propagation doesn't work as expected.
2017-03-10 15:30:50 +03:00
Michael Klishin ef98536ab4 rabbitmqctl hipe_compile WIP 2017-03-10 01:01:03 +03:00
Daniil Fedotov 95fe5c96fd Document aliases. Improve eval command to accept bound arguments 2017-02-16 12:41:26 +00:00
Michael Klishin c4dab95dce Copy 2017-02-06 00:39:16 +03:00
Michael Klishin 696adc923d Copy 2017-02-06 00:35:20 +03:00
Michael Klishin 39f17b53ee Naming, Elixir code style 2017-02-06 00:02:30 +03:00
Arnaud Cogoluègnes 62cdd4d7fc Merge branch 'master' into rabbitmq-server-1085 2017-01-31 17:20:52 +01:00
Daniil Fedotov 77860364bb Merge branch 'master' into rabbitmq-server-release-12 2017-01-27 10:42:58 +00:00
Daniil Fedotov df95a411c7 Format user_already_exists error 2017-01-26 12:33:56 +00:00
Daniil Fedotov 6288d75472 Cleanup compiler warnings 2017-01-24 09:59:00 +00:00
Arnaud Cogoluègnes 57f2eff218 Add read to topic permissions
Part of rabbitmq/rabbitmq-server#1085
2017-01-23 10:12:03 +01:00
Michael Klishin 6faff961c1 Fix a few compiler warnings 2017-01-21 23:18:58 +03:00
Michael Klishin ee34fac5bd Merge branch 'master' into rabbitmq-event-exchange-10 2017-01-17 20:28:03 +03:00
Daniil Fedotov bb57a213c0 List vhost limits command 2017-01-17 13:02:09 +00:00