Commit Graph

1123 Commits

Author SHA1 Message Date
Robert Haines 2f993221c0 Fix Style/Next cop. 2020-02-15 16:26:32 +00:00
Robert Haines 7978abb85e Configure Naming/MemoizedInstanceVariableName cop. 2020-02-15 16:26:32 +00:00
Robert Haines 835843d992 Fix Naming/HeredocDelimiterCase cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2dc9b49568 Fix Style/EvalWithLocation cop. 2020-02-15 16:26:32 +00:00
Robert Haines d42c66ce2c Fix Style/MultilineWhenThen cop. 2020-02-15 16:26:32 +00:00
Robert Haines 172ab4b567 Fix Style/FloatDivision cop. 2020-02-15 16:26:32 +00:00
Robert Haines 5e32204ec4 Configure Style/MultilineBlockChain cop. 2020-02-15 16:26:32 +00:00
Robert Haines 41f2359c4b Configure Style/RegexpLiteral cop.
Allow inner slashes when using // for regex literals. Allow the
Guardfile to use a syntax that is more consistent with its own style.
2020-02-15 16:26:32 +00:00
Robert Haines 2dfe092728 Fix Style/UnpackFirst cop. 2020-02-15 16:26:32 +00:00
Robert Haines 4e1b679c73 Fix Style/TrailingCommaInArrayLiteral cop. 2020-02-15 16:26:32 +00:00
Robert Haines cc0e372351 Configure Style/SymbolArray cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2e11a88fd2 Fix Style/StringLiterals cop. 2020-02-15 16:26:32 +00:00
Robert Haines 45f4c2dc29 Fix Style/GuardClause cop. 2020-02-15 16:26:32 +00:00
Robert Haines bce841639e Fix Style/MixinUsage cop. 2020-02-15 16:26:32 +00:00
Robert Haines 1b8f1a6f3c Fix Naming/RescuedExceptionsVariableName cop. 2020-02-15 16:26:32 +00:00
Robert Haines 3121ad066f Fix Style/Alias cop. 2020-02-15 16:26:32 +00:00
Robert Haines 468a80ce02 Fix Style/IfInsideElse cop. 2020-02-15 16:26:32 +00:00
Robert Haines b3f241353a Fix Style/CommentedKeyword cop. 2020-02-15 16:26:32 +00:00
Robert Haines b3c4c37882 Fix Style/NonNilCheck cop.
Use the `refute_nil` method for most of these.
2020-02-15 16:26:32 +00:00
Robert Haines 5a1baf46ab Fix Style/RedundantReturn cop. 2020-02-15 16:26:32 +00:00
Robert Haines 19aa7e834c Fix Style/RescueStandardError cop. 2020-02-15 16:26:32 +00:00
Robert Haines 6544563dd0 Configure Style/ZeroLengthPredicate so it doesn't misfire. 2020-02-15 16:26:32 +00:00
Robert Haines 70d036b3ad Fix Style/ExpandPathArguments cop. 2020-02-15 16:26:32 +00:00
Robert Haines 68259ed7b0 Fix Style/Encoding cop. 2020-02-15 16:26:32 +00:00
Robert Haines 61c83b2a1a Configure Layout/HashAlignment cop. 2020-02-15 16:26:32 +00:00
Robert Haines cfe4972e71 Fix Layout/EmptyLineAfterGuardClause cop. 2020-02-15 16:26:32 +00:00
Robert Haines fff2c41d68 Configure Lint/SuppressedException cop.
In the tests we can say "anything goes", but in the main body of the
code we should at least comment if we're not handling an exception
fully.
2020-02-15 16:26:32 +00:00
Robert Haines 0d49421711 Fix Lint/UselessAccessModifier cop. 2020-02-15 16:26:32 +00:00
Robert Haines 23ba1af4fb Fix Lint/RescueException cop. 2020-02-15 16:26:32 +00:00
Robert Haines e361a47c8e Configure Lint/UselessComparison cop.
Allow this in entry_test.rb so we can test <=>.
2020-02-15 16:26:32 +00:00
Robert Haines cd065d0186 Fix Lint/UnusedBlockArgument cop. 2020-02-15 16:26:32 +00:00
Robert Haines b528cae084 Fix Lint/LiteralAsCondition cop.
This fixes Style/InfiniteLoop as a side-effect.
2020-02-15 16:26:32 +00:00
Robert Haines 20743a53b2 Fix Lint/AmbiguousBlockAssociation cop. 2020-02-15 16:26:32 +00:00
Robert Haines 98c6969c18 Fix Layout/SpaceAroundOperators cop. 2020-02-15 16:26:32 +00:00
Robert Haines e7275dad93 Fix Style/BlockDelimiters cop errors. 2020-02-15 16:26:32 +00:00
Robert Haines 3a3ac6feb7 Fix Style/Semicolon cop. 2020-02-15 16:26:32 +00:00
Robert Haines f1154c2eca Fix Style/OrAssignment cop. 2020-02-15 15:56:17 +00:00
Robert Haines 73e405acef Fix Security/Open cop errors. 2020-02-15 15:56:17 +00:00
Robert Haines aa40035525 Fix Gemspec/OrderedDependencies cop. 2020-02-15 15:56:17 +00:00
Robert Haines a3245ac241 Add Rubocop tasks to the Rakefile. 2020-02-15 15:56:17 +00:00
Robert Haines c8bfd14764 Update rubocop version and the config files.
Also rename .rubocop_rubyzip.yml to be consistent with Rubocop default
setup.
2020-02-15 15:56:17 +00:00
John Lees-Miller 5da87ef1d6
Merge pull request #420 from hainesr/console
Quickly fire up a console with 'zip' pre-loaded.
2020-02-15 11:48:12 +00:00
Robert Haines 862892c0ac Quickly fire up a console with 'zip' pre-loaded. 2020-02-15 09:43:53 +00:00
John Lees-Miller 247fd43290 Update changelog for #431 2020-02-09 08:24:30 +00:00
John Lees-Miller 393cd9749c
Merge pull request #431 from taichi-ishitani/fix_frozen_error
Fix frozen error caused by frozen string literal
2020-02-09 08:19:54 +00:00
taichi 976dbd3408 reverted the change according to comment below:
https://github.com/rubyzip/rubyzip/pull/431#discussion_r376698387
2020-02-08 19:54:45 +09:00
taichi b326d17438 use @+ operator instead of #dup to get unfrozen string 2020-02-05 11:40:56 +09:00
taichi 3bc85ccdec fixed frozen error caseud by frozen string literal 2020-02-05 11:30:30 +09:00
taichi 609c12d1c4 added Ruby 2.7 to CI regression 2020-02-05 11:11:46 +09:00
John Lees-Miller ecd641e459
Merge pull request #429 from rubyzip/v2-2-0
Bump version to 2.2.0
2020-02-01 15:22:01 +00:00