Commit Graph

1160 Commits

Author SHA1 Message Date
Robert Haines f37e679e7c Add a rubocop job to the Travis config. 2020-03-14 17:42:36 +00:00
John Lees-Miller 3bc55a5d98
Merge pull request #443 from rubyzip/v2-3-0
Bump version to 2.3.0
2020-03-14 12:00:50 +00:00
John Lees-Miller 69186f65cd Bump version to 2.3.0 2020-03-14 11:31:39 +00:00
John Lees-Miller 516941bec5 Update changelog for #439 and #440 2020-03-14 11:28:02 +00:00
John Lees-Miller a64a14767d Bump rake version (development dependency) 2020-03-14 11:09:33 +00:00
John Lees-Miller 4c789c2821 Remove unused constant from #439 2020-03-14 11:00:39 +00:00
John Lees-Miller fabacf1633
Merge pull request #440 from hainesr/rubocop-names
Rubocop name cops
2020-03-14 10:58:54 +00:00
John Lees-Miller b231b28998
Merge pull request #439 from henkeinfo/binary-outstream-buffer
Set OutputStream.write_buffer's default buffer to binmode
2020-03-14 10:32:28 +00:00
Sebastian Henke 66324a711c Remove duplicate binmode call 2020-03-02 11:06:50 +01:00
Sebastian Henke e33c07a6e7
Use existing constant for ASCII_8BIT
Co-Authored-By: John Lees-Miller <jdleesmiller@gmail.com>
2020-03-02 11:00:39 +01:00
Robert Haines ce17c57e2d Fix Naming/AccessorMethodName in the tests.
This was kind of a misfire of this cop, but no bother to change.
2020-02-29 18:11:52 +00:00
Robert Haines c30d9dfb26 Configure Naming/MemoizedInstanceVariableName in source.
Rather than turn it off for a whole file, it's better to mark these
exceptions in comments.
2020-02-29 18:11:52 +00:00
Robert Haines f9b161eb32 Fix Naming/VariableName cop in the library code. 2020-02-29 18:11:52 +00:00
Robert Haines e6f414f539 Fix Naming/VariableName cop in the tests. 2020-02-29 18:11:52 +00:00
Robert Haines 7626423994 Fix Naming/VariableName cop in the samples. 2020-02-29 18:11:52 +00:00
Robert Haines aa6ea05d45 Fix Naming/MethodParameterName cop in the library code. 2020-02-29 18:11:52 +00:00
Robert Haines b09f05d8d3 Fix Naming/MethodParameterName cop in the tests. 2020-02-29 18:11:52 +00:00
Robert Haines fcadea61e2 Fix Naming/MethodParameterName cop in the samples. 2020-02-29 17:12:45 +00:00
Sebastian Henke b0ee2683b0 Set buffers to binmode by default 2020-02-19 18:48:13 +01:00
Robert Haines 846e704048 Fix Naming/BlockParameterName cop. 2020-02-17 22:35:08 +00:00
John Lees-Miller 8d91d001fd Update changelog for #420 and #437 2020-02-16 08:14:43 +00:00
John Lees-Miller 10685a74e0
Merge pull request #437 from hainesr/rubocop-0.79
Rubocop 0.79
2020-02-16 08:10:56 +00:00
Robert Haines 87a63e0cc3 Set TargetRubyVersion to match that in the gemspec.
Currently 2.4 is the earliest supported ruby version.
2020-02-15 16:26:32 +00:00
Robert Haines c31ab81cf6 Fix Style/NumericLiterals cop. 2020-02-15 16:26:32 +00:00
Robert Haines 989a565340 Fix Style/TrailingCommaInHashLiteral cop. 2020-02-15 16:26:32 +00:00
Robert Haines d07b36b2e6 Fix Style/TernaryParentheses cop. 2020-02-15 16:26:32 +00:00
Robert Haines fae95e3c29 Fix Style/NumericLiteralPrefix cop. 2020-02-15 16:26:32 +00:00
Robert Haines 4b8f74042a Fix Layout/EmptyLinesAroundClassBody cop. 2020-02-15 16:26:32 +00:00
Robert Haines a187ec0c38 Configure Metrics/MethodLength and turn off for the tests. 2020-02-15 16:26:32 +00:00
Robert Haines a9adfa26d6 Configure Metrics/ClassLength and turn off for the tests. 2020-02-15 16:26:32 +00:00
Robert Haines 5ce4e13ddd Configure and fix Style/ClassCheck cop. 2020-02-15 16:26:32 +00:00
Robert Haines c97d560b69 Configure Metrics/AbcSize and turn off for the tests. 2020-02-15 16:26:32 +00:00
Robert Haines 0e25e63d38 Turn off Metrics/BlockLength for the tests. 2020-02-15 16:26:32 +00:00
Robert Haines 6cab5922bc Configure and fix Metrics/LineLength cop.
Set a workable line length for now, and fix a couple of particularly bad
examples.

Also, turn off for the tests.
2020-02-15 16:26:32 +00:00
Robert Haines 0df6cb3059 Fix Style/SymbolProc cop. 2020-02-15 16:26:32 +00:00
Robert Haines bb3b4474fa Fix Style/SpecialGlobalVars cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2cbdbf110b Fix Style/SignalException cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2f993221c0 Fix Style/Next cop. 2020-02-15 16:26:32 +00:00
Robert Haines 7978abb85e Configure Naming/MemoizedInstanceVariableName cop. 2020-02-15 16:26:32 +00:00
Robert Haines 835843d992 Fix Naming/HeredocDelimiterCase cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2dc9b49568 Fix Style/EvalWithLocation cop. 2020-02-15 16:26:32 +00:00
Robert Haines d42c66ce2c Fix Style/MultilineWhenThen cop. 2020-02-15 16:26:32 +00:00
Robert Haines 172ab4b567 Fix Style/FloatDivision cop. 2020-02-15 16:26:32 +00:00
Robert Haines 5e32204ec4 Configure Style/MultilineBlockChain cop. 2020-02-15 16:26:32 +00:00
Robert Haines 41f2359c4b Configure Style/RegexpLiteral cop.
Allow inner slashes when using // for regex literals. Allow the
Guardfile to use a syntax that is more consistent with its own style.
2020-02-15 16:26:32 +00:00
Robert Haines 2dfe092728 Fix Style/UnpackFirst cop. 2020-02-15 16:26:32 +00:00
Robert Haines 4e1b679c73 Fix Style/TrailingCommaInArrayLiteral cop. 2020-02-15 16:26:32 +00:00
Robert Haines cc0e372351 Configure Style/SymbolArray cop. 2020-02-15 16:26:32 +00:00
Robert Haines 2e11a88fd2 Fix Style/StringLiterals cop. 2020-02-15 16:26:32 +00:00
Robert Haines 45f4c2dc29 Fix Style/GuardClause cop. 2020-02-15 16:26:32 +00:00